Replace SDL_strdup() by strdup()

The functions SDL_malloc(), SDL_free() and SDL_strdup() were used only
because strdup() was not available everywhere.

Now that it is available, use the native version of these functions.

app/meson.build

@@ -11,7 +11,6 @@ src = [
     'src/event_converter.c',
     'src/file_handler.c',
     'src/fps_counter.c',
-    'src/frame_texture.c',
     'src/input_manager.c',
     'src/opengl.c',
     'src/receiver.c',
@@ -24,8 +23,7 @@ src = [
     'src/video_buffer.c',
     'src/util/net.c',
     'src/util/process.c',
-    'src/util/str_util.c',
-    'src/util/thread.c',
+    'src/util/str_util.c'
 ]
 
 if host_machine.system() == 'windows'
@@ -47,7 +45,6 @@ if not get_option('crossbuild_windows')
         dependency('libavformat'),
         dependency('libavcodec'),
         dependency('libavutil'),
-        dependency('libswscale'),
         dependency('sdl2'),
     ]
 

app/scrcpy.1

@@ -167,13 +167,6 @@ Set the initial display rotation. Possibles values are 0, 1, 2 and 3. Each incre
 .BI "\-s, \-\-serial " number
 The device serial number. Mandatory only if several devices are connected to adb.
 
-.TP
-.BI "\-\-scale\-filter filter
-Supported filters are "none" and "trilinear".
-
-Trilinear filtering is only available if the renderer is OpenGL 3.0+ or OpenGL
-ES 2.0+.
-
 .TP
 .BI "\-\-shortcut\-mod " key[+...]][,...]
 Specify the modifiers to use for scrcpy shortcuts. Possible keys are "lctrl", "rctrl", "lalt", "ralt", "lsuper" and "rsuper".

app/src/cli.c

@@ -103,6 +103,11 @@ scrcpy_print_usage(const char *arg0) {
         "    --no-key-repeat\n"
         "        Do not forward repeated key events when a key is held down.\n"
         "\n"
+        "    --no-mipmaps\n"
+        "        If the renderer is OpenGL 3.0+ or OpenGL ES 2.0+, then\n"
+        "        mipmaps are automatically generated to improve downscaling\n"
+        "        quality. This option disables the generation of mipmaps.\n"
+        "\n"
         "    -p, --port port[:port]\n"
         "        Set the TCP port (range) used by the client to listen.\n"
         "        Default is %d:%d.\n"
@@ -149,11 +154,6 @@ scrcpy_print_usage(const char *arg0) {
         "        The device serial number. Mandatory only if several devices\n"
         "        are connected to adb.\n"
         "\n"
-        "    --scale-filter filter\n"
-        "        Supported filters are \"none\" and \"trilinear\".\n"
-        "        Trilinear filtering is only available if the renderer is\n"
-        "        OpenGL 3.0+ or OpenGL ES 2.0+.\n"
-        "\n"
         "    --shortcut-mod key[+...]][,...]\n"
         "        Specify the modifiers to use for scrcpy shortcuts.\n"
         "        Possible keys are \"lctrl\", \"rctrl\", \"lalt\", \"ralt\",\n"
@@ -641,62 +641,6 @@ guess_record_format(const char *filename) {
     return 0;
 }
 
-static bool
-parse_scale_filter(const char *optarg, enum sc_scale_filter *filter) {
-    // TODO store in a map and loop over the entries instead
-    if (!strcmp(optarg, "none")) {
-        *filter = SC_SCALE_FILTER_NONE;
-        return true;
-    }
-    if (!strcmp(optarg, "trilinear")) {
-        *filter = SC_SCALE_FILTER_TRILINEAR;
-        return true;
-    }
-    if (!strcmp(optarg, "bilinear")) {
-        *filter = SC_SCALE_FILTER_BILINEAR;
-        return true;
-    }
-    if (!strcmp(optarg, "bicubic")) {
-        *filter = SC_SCALE_FILTER_BICUBIC;
-        return true;
-    }
-    if (!strcmp(optarg, "x")) {
-        *filter = SC_SCALE_FILTER_X;
-        return true;
-    }
-    if (!strcmp(optarg, "point")) {
-        *filter = SC_SCALE_FILTER_POINT;
-        return true;
-    }
-    if (!strcmp(optarg, "area")) {
-        *filter = SC_SCALE_FILTER_AREA;
-        return true;
-    }
-    if (!strcmp(optarg, "bicublin")) {
-        *filter = SC_SCALE_FILTER_BICUBLIN;
-        return true;
-    }
-    if (!strcmp(optarg, "gauss")) {
-        *filter = SC_SCALE_FILTER_GAUSS;
-        return true;
-    }
-    if (!strcmp(optarg, "sinc")) {
-        *filter = SC_SCALE_FILTER_SINC;
-        return true;
-    }
-    if (!strcmp(optarg, "lanczos")) {
-        *filter = SC_SCALE_FILTER_LANCZOS;
-        return true;
-    }
-    if (!strcmp(optarg, "spline")) {
-        *filter = SC_SCALE_FILTER_SPLINE;
-        return true;
-    }
-    LOGE("Unsupported scale filter: %s "
-         "(expected one of [TODO])", optarg);
-    return false;
-}
-
 #define OPT_RENDER_EXPIRED_FRAMES  1000
 #define OPT_WINDOW_TITLE           1001
 #define OPT_PUSH_TARGET            1002
@@ -723,7 +667,6 @@ parse_scale_filter(const char *optarg, enum sc_scale_filter *filter) {
 #define OPT_FORWARD_ALL_CLICKS     1023
 #define OPT_LEGACY_PASTE           1024
 #define OPT_ENCODER_NAME           1025
-#define OPT_SCALE_FILTER           1026
 
 bool
 scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) {
@@ -760,7 +703,6 @@ scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) {
         {"render-expired-frames",  no_argument,       NULL,
                                                   OPT_RENDER_EXPIRED_FRAMES},
         {"rotation",               required_argument, NULL, OPT_ROTATION},
-        {"scale-filter",           required_argument, NULL, OPT_SCALE_FILTER},
         {"serial",                 required_argument, NULL, 's'},
         {"shortcut-mod",           required_argument, NULL, OPT_SHORTCUT_MOD},
         {"show-touches",           no_argument,       NULL, 't'},
@@ -915,9 +857,7 @@ scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) {
                 opts->render_driver = optarg;
                 break;
             case OPT_NO_MIPMAPS:
-                LOGW("Deprecated option --no-mipmaps. "
-                     "Use --scale-filter=none instead.");
-                opts->scale_filter = SC_SCALE_FILTER_NONE;
+                opts->mipmaps = false;
                 break;
             case OPT_NO_KEY_REPEAT:
                 opts->forward_key_repeat = false;
@@ -945,11 +885,6 @@ scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) {
             case OPT_LEGACY_PASTE:
                 opts->legacy_paste = true;
                 break;
-            case OPT_SCALE_FILTER:
-                if (!parse_scale_filter(optarg, &opts->scale_filter)) {
-                    return false;
-                }
-                break;
             default:
                 // getopt prints the error message on stderr
                 return false;

app/src/controller.c

@@ -2,27 +2,25 @@
 
 #include <assert.h>
 
+#include "util/lock.h"
 #include "util/log.h"
 
 bool
 controller_init(struct controller *controller, socket_t control_socket) {
     cbuf_init(&controller->queue);
 
-    bool ok = receiver_init(&controller->receiver, control_socket);
-    if (!ok) {
+    if (!receiver_init(&controller->receiver, control_socket)) {
         return false;
     }
 
-    ok = sc_mutex_init(&controller->mutex);
-    if (!ok) {
+    if (!(controller->mutex = SDL_CreateMutex())) {
         receiver_destroy(&controller->receiver);
         return false;
     }
 
-    ok = sc_cond_init(&controller->msg_cond);
-    if (!ok) {
+    if (!(controller->msg_cond = SDL_CreateCond())) {
         receiver_destroy(&controller->receiver);
-        sc_mutex_destroy(&controller->mutex);
+        SDL_DestroyMutex(controller->mutex);
         return false;
     }
 
@@ -34,8 +32,8 @@ controller_init(struct controller *controller, socket_t control_socket) {
 
 void
 controller_destroy(struct controller *controller) {
-    sc_cond_destroy(&controller->msg_cond);
-    sc_mutex_destroy(&controller->mutex);
+    SDL_DestroyCond(controller->msg_cond);
+    SDL_DestroyMutex(controller->mutex);
 
     struct control_msg msg;
     while (cbuf_take(&controller->queue, &msg)) {
@@ -48,13 +46,13 @@ controller_destroy(struct controller *controller) {
 bool
 controller_push_msg(struct controller *controller,
                       const struct control_msg *msg) {
-    sc_mutex_lock(&controller->mutex);
+    mutex_lock(controller->mutex);
     bool was_empty = cbuf_is_empty(&controller->queue);
     bool res = cbuf_push(&controller->queue, *msg);
     if (was_empty) {
-        sc_cond_signal(&controller->msg_cond);
+        cond_signal(controller->msg_cond);
     }
-    sc_mutex_unlock(&controller->mutex);
+    mutex_unlock(controller->mutex);
     return res;
 }
 
@@ -75,20 +73,20 @@ run_controller(void *data) {
     struct controller *controller = data;
 
     for (;;) {
-        sc_mutex_lock(&controller->mutex);
+        mutex_lock(controller->mutex);
         while (!controller->stopped && cbuf_is_empty(&controller->queue)) {
-            sc_cond_wait(&controller->msg_cond, &controller->mutex);
+            cond_wait(controller->msg_cond, controller->mutex);
         }
         if (controller->stopped) {
             // stop immediately, do not process further msgs
-            sc_mutex_unlock(&controller->mutex);
+            mutex_unlock(controller->mutex);
             break;
         }
         struct control_msg msg;
         bool non_empty = cbuf_take(&controller->queue, &msg);
         assert(non_empty);
         (void) non_empty;
-        sc_mutex_unlock(&controller->mutex);
+        mutex_unlock(controller->mutex);
 
         bool ok = process_msg(controller, &msg);
         control_msg_destroy(&msg);
@@ -104,16 +102,16 @@ bool
 controller_start(struct controller *controller) {
     LOGD("Starting controller thread");
 
-    bool ok = sc_thread_create(&controller->thread, run_controller,
-                               "controller", controller);
-    if (!ok) {
+    controller->thread = SDL_CreateThread(run_controller, "controller",
+                                          controller);
+    if (!controller->thread) {
         LOGC("Could not start controller thread");
         return false;
     }
 
     if (!receiver_start(&controller->receiver)) {
         controller_stop(controller);
-        sc_thread_join(&controller->thread, NULL);
+        SDL_WaitThread(controller->thread, NULL);
         return false;
     }
 
@@ -122,14 +120,14 @@ controller_start(struct controller *controller) {
 
 void
 controller_stop(struct controller *controller) {
-    sc_mutex_lock(&controller->mutex);
+    mutex_lock(controller->mutex);
     controller->stopped = true;
-    sc_cond_signal(&controller->msg_cond);
-    sc_mutex_unlock(&controller->mutex);
+    cond_signal(controller->msg_cond);
+    mutex_unlock(controller->mutex);
 }
 
 void
 controller_join(struct controller *controller) {
-    sc_thread_join(&controller->thread, NULL);
+    SDL_WaitThread(controller->thread, NULL);
     receiver_join(&controller->receiver);
 }

app/src/controller.h

@@ -4,20 +4,21 @@
 #include "common.h"
 
 #include <stdbool.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 
 #include "control_msg.h"
 #include "receiver.h"
 #include "util/cbuf.h"
 #include "util/net.h"
-#include "util/thread.h"
 
 struct control_msg_queue CBUF(struct control_msg, 64);
 
 struct controller {
     socket_t control_socket;
-    sc_thread thread;
-    sc_mutex mutex;
-    sc_cond msg_cond;
+    SDL_Thread *thread;
+    SDL_mutex *mutex;
+    SDL_cond *msg_cond;
     bool stopped;
     struct control_msg_queue queue;
     struct receiver receiver;

app/src/decoder.c

@@ -3,6 +3,8 @@
 #include <libavformat/avformat.h>
 #include <libavutil/time.h>
 #include <SDL2/SDL_events.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 #include <unistd.h>
 
 #include "events.h"

app/src/file_handler.c

@@ -4,6 +4,7 @@
 #include <string.h>
 
 #include "adb.h"
+#include "util/lock.h"
 #include "util/log.h"
 
 #define DEFAULT_PUSH_TARGET "/sdcard/"
@@ -19,14 +20,12 @@ file_handler_init(struct file_handler *file_handler, const char *serial,
 
     cbuf_init(&file_handler->queue);
 
-    bool ok = sc_mutex_init(&file_handler->mutex);
-    if (!ok) {
+    if (!(file_handler->mutex = SDL_CreateMutex())) {
         return false;
     }
 
-    ok = sc_cond_init(&file_handler->event_cond);
-    if (!ok) {
-        sc_mutex_destroy(&file_handler->mutex);
+    if (!(file_handler->event_cond = SDL_CreateCond())) {
+        SDL_DestroyMutex(file_handler->mutex);
         return false;
     }
 
@@ -34,8 +33,8 @@ file_handler_init(struct file_handler *file_handler, const char *serial,
         file_handler->serial = strdup(serial);
         if (!file_handler->serial) {
             LOGW("Could not strdup serial");
-            sc_cond_destroy(&file_handler->event_cond);
-            sc_mutex_destroy(&file_handler->mutex);
+            SDL_DestroyCond(file_handler->event_cond);
+            SDL_DestroyMutex(file_handler->mutex);
             return false;
         }
     } else {
@@ -55,8 +54,8 @@ file_handler_init(struct file_handler *file_handler, const char *serial,
 
 void
 file_handler_destroy(struct file_handler *file_handler) {
-    sc_cond_destroy(&file_handler->event_cond);
-    sc_mutex_destroy(&file_handler->mutex);
+    SDL_DestroyCond(file_handler->event_cond);
+    SDL_DestroyMutex(file_handler->mutex);
     free(file_handler->serial);
 
     struct file_handler_request req;
@@ -93,13 +92,13 @@ file_handler_request(struct file_handler *file_handler,
         .file = file,
     };
 
-    sc_mutex_lock(&file_handler->mutex);
+    mutex_lock(file_handler->mutex);
     bool was_empty = cbuf_is_empty(&file_handler->queue);
     bool res = cbuf_push(&file_handler->queue, req);
     if (was_empty) {
-        sc_cond_signal(&file_handler->event_cond);
+        cond_signal(file_handler->event_cond);
     }
-    sc_mutex_unlock(&file_handler->mutex);
+    mutex_unlock(file_handler->mutex);
     return res;
 }
 
@@ -108,14 +107,14 @@ run_file_handler(void *data) {
     struct file_handler *file_handler = data;
 
     for (;;) {
-        sc_mutex_lock(&file_handler->mutex);
+        mutex_lock(file_handler->mutex);
         file_handler->current_process = PROCESS_NONE;
         while (!file_handler->stopped && cbuf_is_empty(&file_handler->queue)) {
-            sc_cond_wait(&file_handler->event_cond, &file_handler->mutex);
+            cond_wait(file_handler->event_cond, file_handler->mutex);
         }
         if (file_handler->stopped) {
             // stop immediately, do not process further events
-            sc_mutex_unlock(&file_handler->mutex);
+            mutex_unlock(file_handler->mutex);
             break;
         }
         struct file_handler_request req;
@@ -133,7 +132,7 @@ run_file_handler(void *data) {
                                 file_handler->push_target);
         }
         file_handler->current_process = process;
-        sc_mutex_unlock(&file_handler->mutex);
+        mutex_unlock(file_handler->mutex);
 
         if (req.action == ACTION_INSTALL_APK) {
             if (process_check_success(process, "adb install", false)) {
@@ -151,13 +150,13 @@ run_file_handler(void *data) {
             }
         }
 
-        sc_mutex_lock(&file_handler->mutex);
+        mutex_lock(file_handler->mutex);
         // Close the process (it is necessary already terminated)
         // Execute this call with mutex locked to avoid race conditions with
         // file_handler_stop()
         process_close(file_handler->current_process);
         file_handler->current_process = PROCESS_NONE;
-        sc_mutex_unlock(&file_handler->mutex);
+        mutex_unlock(file_handler->mutex);
 
         file_handler_request_destroy(&req);
     }
@@ -168,9 +167,9 @@ bool
 file_handler_start(struct file_handler *file_handler) {
     LOGD("Starting file_handler thread");
 
-    bool ok = sc_thread_create(&file_handler->thread, run_file_handler,
-                               "file_handler", file_handler);
-    if (!ok) {
+    file_handler->thread = SDL_CreateThread(run_file_handler, "file_handler",
+                                            file_handler);
+    if (!file_handler->thread) {
         LOGC("Could not start file_handler thread");
         return false;
     }
@@ -180,18 +179,18 @@ file_handler_start(struct file_handler *file_handler) {
 
 void
 file_handler_stop(struct file_handler *file_handler) {
-    sc_mutex_lock(&file_handler->mutex);
+    mutex_lock(file_handler->mutex);
     file_handler->stopped = true;
-    sc_cond_signal(&file_handler->event_cond);
+    cond_signal(file_handler->event_cond);
     if (file_handler->current_process != PROCESS_NONE) {
         if (!process_terminate(file_handler->current_process)) {
             LOGW("Could not terminate push/install process");
         }
     }
-    sc_mutex_unlock(&file_handler->mutex);
+    mutex_unlock(file_handler->mutex);
 }
 
 void
 file_handler_join(struct file_handler *file_handler) {
-    sc_thread_join(&file_handler->thread, NULL);
+    SDL_WaitThread(file_handler->thread, NULL);
 }

app/src/file_handler.h

@@ -4,10 +4,11 @@
 #include "common.h"
 
 #include <stdbool.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 
 #include "adb.h"
 #include "util/cbuf.h"
-#include "util/thread.h"
 
 typedef enum {
     ACTION_INSTALL_APK,
@@ -24,9 +25,9 @@ struct file_handler_request_queue CBUF(struct file_handler_request, 16);
 struct file_handler {
     char *serial;
     const char *push_target;
-    sc_thread thread;
-    sc_mutex mutex;
-    sc_cond event_cond;
+    SDL_Thread *thread;
+    SDL_mutex *mutex;
+    SDL_cond *event_cond;
     bool stopped;
     bool initialized;
     process_t current_process;

app/src/fps_counter.c

@@ -3,24 +3,25 @@
 #include <assert.h>
 #include <SDL2/SDL_timer.h>
 
+#include "util/lock.h"
 #include "util/log.h"
 
 #define FPS_COUNTER_INTERVAL_MS 1000
 
 bool
 fps_counter_init(struct fps_counter *counter) {
-    bool ok = sc_mutex_init(&counter->mutex);
-    if (!ok) {
+    counter->mutex = SDL_CreateMutex();
+    if (!counter->mutex) {
         return false;
     }
 
-    ok = sc_cond_init(&counter->state_cond);
-    if (!ok) {
-        sc_mutex_destroy(&counter->mutex);
+    counter->state_cond = SDL_CreateCond();
+    if (!counter->state_cond) {
+        SDL_DestroyMutex(counter->mutex);
         return false;
     }
 
-    counter->thread_started = false;
+    counter->thread = NULL;
     atomic_init(&counter->started, 0);
     // no need to initialize the other fields, they are unused until started
 
@@ -29,8 +30,8 @@ fps_counter_init(struct fps_counter *counter) {
 
 void
 fps_counter_destroy(struct fps_counter *counter) {
-    sc_cond_destroy(&counter->state_cond);
-    sc_mutex_destroy(&counter->mutex);
+    SDL_DestroyCond(counter->state_cond);
+    SDL_DestroyMutex(counter->mutex);
 }
 
 static inline bool
@@ -76,10 +77,10 @@ static int
 run_fps_counter(void *data) {
     struct fps_counter *counter = data;
 
-    sc_mutex_lock(&counter->mutex);
+    mutex_lock(counter->mutex);
     while (!counter->interrupted) {
         while (!counter->interrupted && !is_started(counter)) {
-            sc_cond_wait(&counter->state_cond, &counter->mutex);
+            cond_wait(counter->state_cond, counter->mutex);
         }
         while (!counter->interrupted && is_started(counter)) {
             uint32_t now = SDL_GetTicks();
@@ -89,35 +90,32 @@ run_fps_counter(void *data) {
             uint32_t remaining = counter->next_timestamp - now;
 
             // ignore the reason (timeout or signaled), we just loop anyway
-            sc_cond_timedwait(&counter->state_cond, &counter->mutex, remaining);
+            cond_wait_timeout(counter->state_cond, counter->mutex, remaining);
         }
     }
-    sc_mutex_unlock(&counter->mutex);
+    mutex_unlock(counter->mutex);
     return 0;
 }
 
 bool
 fps_counter_start(struct fps_counter *counter) {
-    sc_mutex_lock(&counter->mutex);
+    mutex_lock(counter->mutex);
     counter->next_timestamp = SDL_GetTicks() + FPS_COUNTER_INTERVAL_MS;
     counter->nr_rendered = 0;
     counter->nr_skipped = 0;
-    sc_mutex_unlock(&counter->mutex);
+    mutex_unlock(counter->mutex);
 
     set_started(counter, true);
-    sc_cond_signal(&counter->state_cond);
+    cond_signal(counter->state_cond);
 
-    // counter->thread_started and counter->thread are always accessed from the
-    // same thread, no need to lock
-    if (!counter->thread_started) {
-        bool ok = sc_thread_create(&counter->thread, run_fps_counter,
-                                   "fps counter", counter);
-        if (!ok) {
+    // counter->thread is always accessed from the same thread, no need to lock
+    if (!counter->thread) {
+        counter->thread =
+            SDL_CreateThread(run_fps_counter, "fps counter", counter);
+        if (!counter->thread) {
             LOGE("Could not start FPS counter thread");
             return false;
         }
-
-        counter->thread_started = true;
     }
 
     return true;
@@ -126,7 +124,7 @@ fps_counter_start(struct fps_counter *counter) {
 void
 fps_counter_stop(struct fps_counter *counter) {
     set_started(counter, false);
-    sc_cond_signal(&counter->state_cond);
+    cond_signal(counter->state_cond);
 }
 
 bool
@@ -136,21 +134,21 @@ fps_counter_is_started(struct fps_counter *counter) {
 
 void
 fps_counter_interrupt(struct fps_counter *counter) {
-    if (!counter->thread_started) {
+    if (!counter->thread) {
         return;
     }
 
-    sc_mutex_lock(&counter->mutex);
+    mutex_lock(counter->mutex);
     counter->interrupted = true;
-    sc_mutex_unlock(&counter->mutex);
+    mutex_unlock(counter->mutex);
     // wake up blocking wait
-    sc_cond_signal(&counter->state_cond);
+    cond_signal(counter->state_cond);
 }
 
 void
 fps_counter_join(struct fps_counter *counter) {
-    if (counter->thread_started) {
-        sc_thread_join(&counter->thread, NULL);
+    if (counter->thread) {
+        SDL_WaitThread(counter->thread, NULL);
     }
 }
 
@@ -160,11 +158,11 @@ fps_counter_add_rendered_frame(struct fps_counter *counter) {
         return;
     }
 
-    sc_mutex_lock(&counter->mutex);
+    mutex_lock(counter->mutex);
     uint32_t now = SDL_GetTicks();
     check_interval_expired(counter, now);
     ++counter->nr_rendered;
-    sc_mutex_unlock(&counter->mutex);
+    mutex_unlock(counter->mutex);
 }
 
 void
@@ -173,9 +171,9 @@ fps_counter_add_skipped_frame(struct fps_counter *counter) {
         return;
     }
 
-    sc_mutex_lock(&counter->mutex);
+    mutex_lock(counter->mutex);
     uint32_t now = SDL_GetTicks();
     check_interval_expired(counter, now);
     ++counter->nr_skipped;
-    sc_mutex_unlock(&counter->mutex);
+    mutex_unlock(counter->mutex);
 }

app/src/fps_counter.h

@@ -6,15 +6,13 @@
 #include <stdatomic.h>
 #include <stdbool.h>
 #include <stdint.h>
-
-#include "util/thread.h"
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 
 struct fps_counter {
-    sc_thread thread;
-    sc_mutex mutex;
-    sc_cond state_cond;
-
-    bool thread_started;
+    SDL_Thread *thread;
+    SDL_mutex *mutex;
+    SDL_cond *state_cond;
 
     // atomic so that we can check without locking the mutex
     // if the FPS counter is disabled, we don't want to lock unnecessarily

app/src/frame_texture.c

@@ -1,247 +0,0 @@
-#include "frame_texture.h"
-
-#include <assert.h>
-#include <libavutil/imgutils.h>
-#include <libswscale/swscale.h>
-
-#include "util/log.h"
-
-static inline bool
-is_swscale_enabled(enum sc_scale_filter scale_filter) {
-    return scale_filter != SC_SCALE_FILTER_NONE
-        && scale_filter != SC_SCALE_FILTER_TRILINEAR;
-}
-
-static SDL_Texture *
-create_texture(struct sc_frame_texture *ftex, struct size size) {
-    SDL_Renderer *renderer = ftex->renderer;
-    SDL_PixelFormatEnum fmt = is_swscale_enabled(ftex->scale_filter)
-                            ? SDL_PIXELFORMAT_RGB24
-                            : SDL_PIXELFORMAT_YV12;
-    SDL_Texture *texture = SDL_CreateTexture(renderer, fmt,
-                                             SDL_TEXTUREACCESS_STREAMING,
-                                             size.width, size.height);
-    if (!texture) {
-        return NULL;
-    }
-
-    if (ftex->scale_filter == SC_SCALE_FILTER_TRILINEAR) {
-        struct sc_opengl *gl = &ftex->gl;
-
-        SDL_GL_BindTexture(texture, NULL, NULL);
-
-        // Enable trilinear filtering for downscaling
-        gl->TexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,
-                          GL_LINEAR_MIPMAP_LINEAR);
-        gl->TexParameterf(GL_TEXTURE_2D, GL_TEXTURE_LOD_BIAS, -1.f);
-
-        SDL_GL_UnbindTexture(texture);
-    }
-
-    return texture;
-}
-
-bool
-sc_frame_texture_init(struct sc_frame_texture *ftex, SDL_Renderer *renderer,
-                      enum sc_scale_filter scale_filter,
-                      struct size initial_size) {
-    SDL_RendererInfo renderer_info;
-    int r = SDL_GetRendererInfo(renderer, &renderer_info);
-    const char *renderer_name = r ? NULL : renderer_info.name;
-    LOGI("Renderer: %s", renderer_name ? renderer_name : "(unknown)");
-
-    ftex->scale_filter = scale_filter;
-
-    // starts with "opengl"
-    bool use_opengl = renderer_name && !strncmp(renderer_name, "opengl", 6);
-    if (use_opengl) {
-        struct sc_opengl *gl = &ftex->gl;
-        sc_opengl_init(gl);
-
-        LOGI("OpenGL version: %s", gl->version);
-
-        if (scale_filter == SC_SCALE_FILTER_TRILINEAR) {
-            bool supports_mipmaps =
-                sc_opengl_version_at_least(gl, 3, 0, /* OpenGL 3.0+ */
-                                               2, 0  /* OpenGL ES 2.0+ */);
-            if (!supports_mipmaps) {
-                LOGW("Trilinear filtering disabled "
-                     "(OpenGL 3.0+ or ES 2.0+ required)");
-                ftex->scale_filter = SC_SCALE_FILTER_NONE;
-            }
-        }
-    } else if (scale_filter == SC_SCALE_FILTER_TRILINEAR) {
-        LOGD("Trilinear filtering disabled (not an OpenGL renderer)");
-    }
-
-    LOGD("Scale filter: %s\n", sc_scale_filter_name(ftex->scale_filter));
-
-    LOGI("Initial texture: %" PRIu16 "x%" PRIu16, initial_size.width,
-                                                  initial_size.height);
-    ftex->renderer = renderer;
-    ftex->texture = create_texture(ftex, initial_size);
-    if (!ftex->texture) {
-        LOGC("Could not create texture: %s", SDL_GetError());
-        SDL_DestroyRenderer(ftex->renderer);
-        return false;
-    }
-
-    ftex->texture_size = initial_size;
-    ftex->decoded_frame = NULL;
-    memset(ftex->data, 0, sizeof(ftex->data));
-    memset(ftex->linesize, 0, sizeof(ftex->linesize));
-
-    return true;
-}
-
-void
-sc_frame_texture_destroy(struct sc_frame_texture *ftex) {
-    if (ftex->texture) {
-        SDL_DestroyTexture(ftex->texture);
-    }
-}
-
-static int
-to_sws_filter(enum sc_scale_filter scale_filter) {
-    switch (scale_filter) {
-        case SC_SCALE_FILTER_BILINEAR:  return SWS_BILINEAR;
-        case SC_SCALE_FILTER_BICUBIC:   return SWS_BICUBIC;
-        case SC_SCALE_FILTER_X:         return SWS_X;
-        case SC_SCALE_FILTER_POINT:     return SWS_POINT;
-        case SC_SCALE_FILTER_AREA:      return SWS_AREA;
-        case SC_SCALE_FILTER_BICUBLIN:  return SWS_BICUBLIN;
-        case SC_SCALE_FILTER_GAUSS:     return SWS_GAUSS;
-        case SC_SCALE_FILTER_SINC:      return SWS_SINC;
-        case SC_SCALE_FILTER_LANCZOS:   return SWS_LANCZOS;
-        case SC_SCALE_FILTER_SPLINE:    return SWS_SPLINE;
-        default: assert(!"unsupported filter");
-    }
-}
-
-static bool
-screen_generate_resized_frame(struct sc_frame_texture *ftex,
-                              struct size target_size) {
-    assert(is_swscale_enabled(ftex->scale_filter));
-    // TODO
-
-    if (ftex->data[0]) {
-        av_freep(&ftex->data[0]);
-    }
-
-    int ret = av_image_alloc(ftex->data, ftex->linesize, target_size.width,
-                             target_size.height, AV_PIX_FMT_RGB24, 16);
-    if (ret < 0) {
-        return false;
-    }
-
-    const AVFrame *input = ftex->decoded_frame;
-    assert(input);
-
-    int flags = to_sws_filter(ftex->scale_filter);
-    struct SwsContext *ctx =
-        sws_getContext(input->width, input->height, AV_PIX_FMT_YUV420P,
-                       target_size.width, target_size.height, AV_PIX_FMT_RGB24,
-                       flags, NULL, NULL, NULL);
-    if (!ctx) {
-        return false;
-    }
-
-    sws_scale(ctx, (const uint8_t *const *) input->data, input->linesize, 0,
-              input->height, ftex->data, ftex->linesize);
-    sws_freeContext(ctx);
-
-    return true;
-}
-
-static bool
-sc_frame_texture_update_direct(struct sc_frame_texture *ftex,
-                               const AVFrame *frame) {
-    struct size frame_size = {frame->width, frame->height};
-    if (ftex->texture_size.width != frame_size.width
-            || ftex->texture_size.height != frame_size.height) {
-        // Frame dimensions changed, destroy texture
-        SDL_DestroyTexture(ftex->texture);
-
-        LOGI("New texture: %" PRIu16 "x%" PRIu16, frame_size.width,
-                                                  frame_size.height);
-        ftex->texture = create_texture(ftex, frame_size);
-        if (!ftex->texture) {
-            LOGC("Could not create texture: %s", SDL_GetError());
-            return false;
-        }
-
-        ftex->texture_size = frame_size;
-    }
-
-    SDL_UpdateYUVTexture(ftex->texture, NULL,
-            frame->data[0], frame->linesize[0],
-            frame->data[1], frame->linesize[1],
-            frame->data[2], frame->linesize[2]);
-
-    if (ftex->scale_filter == SC_SCALE_FILTER_TRILINEAR) {
-        SDL_GL_BindTexture(ftex->texture, NULL, NULL);
-        ftex->gl.GenerateMipmap(GL_TEXTURE_2D);
-        SDL_GL_UnbindTexture(ftex->texture);
-    }
-
-    return true;
-}
-
-static bool
-sc_frame_texture_update_swscale(struct sc_frame_texture *ftex,
-                                const AVFrame *frame, struct size target_size) {
-    if (ftex->texture_size.width != target_size.width
-            || ftex->texture_size.height != target_size.height) {
-        // Frame dimensions changed, destroy texture
-        SDL_DestroyTexture(ftex->texture);
-
-        ftex->texture = create_texture(ftex, target_size);
-        if (!ftex->texture) {
-            LOGC("Could not create texture: %s", SDL_GetError());
-            return false;
-        }
-
-        ftex->texture_size = target_size;
-    }
-
-    // The frame is valid until the next call to
-    // video_buffer_take_rendering_frame()
-    ftex->decoded_frame = frame;
-
-    bool ok = screen_generate_resized_frame(ftex, target_size);
-    if (!ok) {
-        LOGE("Failed to resize frame\n");
-        return false;
-    }
-
-    SDL_UpdateTexture(ftex->texture, NULL, ftex->data[0], ftex->linesize[0]);
-
-    if (ftex->scale_filter == SC_SCALE_FILTER_TRILINEAR) {
-        SDL_GL_BindTexture(ftex->texture, NULL, NULL);
-        ftex->gl.GenerateMipmap(GL_TEXTURE_2D);
-        SDL_GL_UnbindTexture(ftex->texture);
-    }
-
-    return true;
-}
-
-bool
-sc_frame_texture_update(struct sc_frame_texture *ftex, const AVFrame *frame,
-                        struct size target_size) {
-    if (is_swscale_enabled(ftex->scale_filter)) {
-        return sc_frame_texture_update_swscale(ftex, frame, target_size);
-    }
-    return sc_frame_texture_update_direct(ftex, frame);
-}
-
-bool
-sc_frame_texture_resize(struct sc_frame_texture *ftex,
-                        struct size target_size) {
-    if (is_swscale_enabled(ftex->scale_filter)) {
-        return sc_frame_texture_update_swscale(ftex, ftex->decoded_frame,
-                                               target_size);
-    }
-
-    // Nothing to do
-    return true;
-}

app/src/frame_texture.h

@@ -1,44 +0,0 @@
-#ifndef SC_FRAME_TEXTURE_H
-#define SC_FRAME_TEXTURE_H
-
-#include "common.h"
-
-#include <stdbool.h>
-#include <SDL2/SDL.h>
-#include <libavformat/avformat.h>
-
-#include "coords.h"
-#include "opengl.h"
-#include "scrcpy.h"
-
-struct sc_frame_texture {
-    SDL_Renderer *renderer; // owned by struct screen
-
-    enum sc_scale_filter scale_filter;
-    struct sc_opengl gl;
-
-    SDL_Texture *texture;
-    struct size texture_size;
-
-    // For swscaling
-    const AVFrame *decoded_frame; // owned by the video_buffer
-    uint8_t *data[4];
-    int linesize[4];
-};
-
-bool
-sc_frame_texture_init(struct sc_frame_texture *ftex, SDL_Renderer *renderer,
-                      enum sc_scale_filter scale_filter,
-                      struct size initial_size);
-
-void
-sc_frame_texture_destroy(struct sc_frame_texture *ftex);
-
-bool
-sc_frame_texture_update(struct sc_frame_texture *ftex, const AVFrame *frame,
-                        struct size target_size);
-
-bool
-sc_frame_texture_resize(struct sc_frame_texture *ftex, struct size target_size);
-
-#endif

app/src/input_manager.c

@@ -4,6 +4,7 @@
 #include <SDL2/SDL_keycode.h>
 
 #include "event_converter.h"
+#include "util/lock.h"
 #include "util/log.h"
 
 static const int ACTION_DOWN = 1;

app/src/receiver.c

@@ -4,12 +4,12 @@
 #include <SDL2/SDL_clipboard.h>
 
 #include "device_msg.h"
+#include "util/lock.h"
 #include "util/log.h"
 
 bool
 receiver_init(struct receiver *receiver, socket_t control_socket) {
-    bool ok = sc_mutex_init(&receiver->mutex);
-    if (!ok) {
+    if (!(receiver->mutex = SDL_CreateMutex())) {
         return false;
     }
     receiver->control_socket = control_socket;
@@ -18,7 +18,7 @@ receiver_init(struct receiver *receiver, socket_t control_socket) {
 
 void
 receiver_destroy(struct receiver *receiver) {
-    sc_mutex_destroy(&receiver->mutex);
+    SDL_DestroyMutex(receiver->mutex);
 }
 
 static void
@@ -101,9 +101,8 @@ bool
 receiver_start(struct receiver *receiver) {
     LOGD("Starting receiver thread");
 
-    bool ok = sc_thread_create(&receiver->thread, run_receiver, "receiver",
-                               receiver);
-    if (!ok) {
+    receiver->thread = SDL_CreateThread(run_receiver, "receiver", receiver);
+    if (!receiver->thread) {
         LOGC("Could not start receiver thread");
         return false;
     }
@@ -113,5 +112,5 @@ receiver_start(struct receiver *receiver) {
 
 void
 receiver_join(struct receiver *receiver) {
-    sc_thread_join(&receiver->thread, NULL);
+    SDL_WaitThread(receiver->thread, NULL);
 }

app/src/receiver.h

@@ -4,16 +4,17 @@
 #include "common.h"
 
 #include <stdbool.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 
 #include "util/net.h"
-#include "util/thread.h"
 
 // receive events from the device
 // managed by the controller
 struct receiver {
     socket_t control_socket;
-    sc_thread thread;
-    sc_mutex mutex;
+    SDL_Thread *thread;
+    SDL_mutex *mutex;
 };
 
 bool

app/src/recorder.c

@@ -3,6 +3,7 @@
 #include <assert.h>
 #include <libavutil/time.h>
 
+#include "util/lock.h"
 #include "util/log.h"
 
 static const AVRational SCRCPY_TIME_BASE = {1, 1000000}; // timestamps in us
@@ -68,17 +69,17 @@ recorder_init(struct recorder *recorder,
         return false;
     }
 
-    bool ok = sc_mutex_init(&recorder->mutex);
-    if (!ok) {
+    recorder->mutex = SDL_CreateMutex();
+    if (!recorder->mutex) {
         LOGC("Could not create mutex");
         free(recorder->filename);
         return false;
     }
 
-    ok = sc_cond_init(&recorder->queue_cond);
-    if (!ok) {
+    recorder->queue_cond = SDL_CreateCond();
+    if (!recorder->queue_cond) {
         LOGC("Could not create cond");
-        sc_mutex_destroy(&recorder->mutex);
+        SDL_DestroyMutex(recorder->mutex);
         free(recorder->filename);
         return false;
     }
@@ -96,8 +97,8 @@ recorder_init(struct recorder *recorder,
 
 void
 recorder_destroy(struct recorder *recorder) {
-    sc_cond_destroy(&recorder->queue_cond);
-    sc_mutex_destroy(&recorder->mutex);
+    SDL_DestroyCond(recorder->queue_cond);
+    SDL_DestroyMutex(recorder->mutex);
     free(recorder->filename);
 }
 
@@ -257,17 +258,17 @@ run_recorder(void *data) {
     struct recorder *recorder = data;
 
     for (;;) {
-        sc_mutex_lock(&recorder->mutex);
+        mutex_lock(recorder->mutex);
 
         while (!recorder->stopped && queue_is_empty(&recorder->queue)) {
-            sc_cond_wait(&recorder->queue_cond, &recorder->mutex);
+            cond_wait(recorder->queue_cond, recorder->mutex);
         }
 
         // if stopped is set, continue to process the remaining events (to
         // finish the recording) before actually stopping
 
         if (recorder->stopped && queue_is_empty(&recorder->queue)) {
-            sc_mutex_unlock(&recorder->mutex);
+            mutex_unlock(recorder->mutex);
             struct record_packet *last = recorder->previous;
             if (last) {
                 // assign an arbitrary duration to the last packet
@@ -287,7 +288,7 @@ run_recorder(void *data) {
         struct record_packet *rec;
         queue_take(&recorder->queue, next, &rec);
 
-        sc_mutex_unlock(&recorder->mutex);
+        mutex_unlock(recorder->mutex);
 
         // recorder->previous is only written from this thread, no need to lock
         struct record_packet *previous = recorder->previous;
@@ -310,11 +311,11 @@ run_recorder(void *data) {
         if (!ok) {
             LOGE("Could not record packet");
 
-            sc_mutex_lock(&recorder->mutex);
+            mutex_lock(recorder->mutex);
             recorder->failed = true;
             // discard pending packets
             recorder_queue_clear(&recorder->queue);
-            sc_mutex_unlock(&recorder->mutex);
+            mutex_unlock(recorder->mutex);
             break;
         }
 
@@ -329,9 +330,8 @@ bool
 recorder_start(struct recorder *recorder) {
     LOGD("Starting recorder thread");
 
-    bool ok = sc_thread_create(&recorder->thread, run_recorder, "recorder",
-                               recorder);
-    if (!ok) {
+    recorder->thread = SDL_CreateThread(run_recorder, "recorder", recorder);
+    if (!recorder->thread) {
         LOGC("Could not start recorder thread");
         return false;
     }
@@ -341,38 +341,38 @@ recorder_start(struct recorder *recorder) {
 
 void
 recorder_stop(struct recorder *recorder) {
-    sc_mutex_lock(&recorder->mutex);
+    mutex_lock(recorder->mutex);
     recorder->stopped = true;
-    sc_cond_signal(&recorder->queue_cond);
-    sc_mutex_unlock(&recorder->mutex);
+    cond_signal(recorder->queue_cond);
+    mutex_unlock(recorder->mutex);
 }
 
 void
 recorder_join(struct recorder *recorder) {
-    sc_thread_join(&recorder->thread, NULL);
+    SDL_WaitThread(recorder->thread, NULL);
 }
 
 bool
 recorder_push(struct recorder *recorder, const AVPacket *packet) {
-    sc_mutex_lock(&recorder->mutex);
+    mutex_lock(recorder->mutex);
     assert(!recorder->stopped);
 
     if (recorder->failed) {
         // reject any new packet (this will stop the stream)
-        sc_mutex_unlock(&recorder->mutex);
+        mutex_unlock(recorder->mutex);
         return false;
     }
 
     struct record_packet *rec = record_packet_new(packet);
     if (!rec) {
         LOGC("Could not allocate record packet");
-        sc_mutex_unlock(&recorder->mutex);
+        mutex_unlock(recorder->mutex);
         return false;
     }
 
     queue_push(&recorder->queue, next, rec);
-    sc_cond_signal(&recorder->queue_cond);
+    cond_signal(recorder->queue_cond);
 
-    sc_mutex_unlock(&recorder->mutex);
+    mutex_unlock(recorder->mutex);
     return true;
 }

app/src/recorder.h

@@ -5,11 +5,12 @@
 
 #include <stdbool.h>
 #include <libavformat/avformat.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 
 #include "coords.h"
 #include "scrcpy.h"
 #include "util/queue.h"
-#include "util/thread.h"
 
 struct record_packet {
     AVPacket packet;
@@ -25,9 +26,9 @@ struct recorder {
     struct size declared_frame_size;
     bool header_written;
 
-    sc_thread thread;
-    sc_mutex mutex;
-    sc_cond queue_cond;
+    SDL_Thread *thread;
+    SDL_mutex *mutex;
+    SDL_cond *queue_cond;
     bool stopped; // set on recorder_stop() by the stream reader
     bool failed; // set on packet write failure
     struct recorder_queue queue;

app/src/scrcpy.c

@@ -26,29 +26,10 @@
 #include "stream.h"
 #include "tiny_xpm.h"
 #include "video_buffer.h"
+#include "util/lock.h"
 #include "util/log.h"
 #include "util/net.h"
 
-static const char *sc_scale_filter_names[SC_SCALE_FILTER__COUNT] = {
-    [SC_SCALE_FILTER_NONE] = "none",
-    [SC_SCALE_FILTER_TRILINEAR] = "trilinear",
-    [SC_SCALE_FILTER_BILINEAR] = "bilinear",
-    [SC_SCALE_FILTER_BICUBIC] = "bicubic",
-    [SC_SCALE_FILTER_X] = "x",
-    [SC_SCALE_FILTER_POINT] = "point",
-    [SC_SCALE_FILTER_AREA] = "area",
-    [SC_SCALE_FILTER_BICUBLIN] = "bicublin",
-    [SC_SCALE_FILTER_GAUSS] = "gauss",
-    [SC_SCALE_FILTER_SINC] = "sinc",
-    [SC_SCALE_FILTER_LANCZOS] = "lanczos",
-    [SC_SCALE_FILTER_SPLINE] = "spline",
-};
-
-const char *
-sc_scale_filter_name(enum sc_scale_filter scale_filter) {
-    return sc_scale_filter_names[scale_filter];
-}
-
 static struct server server;
 static struct screen screen = SCREEN_INITIALIZER;
 static struct fps_counter fps_counter;
@@ -204,9 +185,7 @@ handle_event(SDL_Event *event, const struct scrcpy_options *options) {
             }
             break;
         case SDL_WINDOWEVENT:
-            if (screen.has_frame) {
-                screen_handle_window_event(&screen, &event->window);
-            }
+            screen_handle_window_event(&screen, &event->window);
             break;
         case SDL_TEXTINPUT:
             if (!options->control) {
@@ -247,20 +226,13 @@ handle_event(SDL_Event *event, const struct scrcpy_options *options) {
             if (!options->control) {
                 break;
             }
-            char *file = strdup(event->drop.file);
-            SDL_free(event->drop.file);
-            if (!file) {
-                LOGW("Could not strdup drop filename\n");
-                break;
-            }
-
             file_handler_action_t action;
-            if (is_apk(file)) {
+            if (is_apk(event->drop.file)) {
                 action = ACTION_INSTALL_APK;
             } else {
                 action = ACTION_PUSH_FILE;
             }
-            file_handler_request(&file_handler, action, file);
+            file_handler_request(&file_handler, action, event->drop.file);
             break;
         }
     }
@@ -454,7 +426,7 @@ scrcpy(const struct scrcpy_options *options) {
                                    options->window_y, options->window_width,
                                    options->window_height,
                                    options->window_borderless,
-                                   options->rotation, options->scale_filter)) {
+                                   options->rotation, options->mipmaps)) {
             goto end;
         }
 

app/src/scrcpy.h

@@ -41,25 +41,6 @@ struct sc_port_range {
     uint16_t last;
 };
 
-enum sc_scale_filter {
-    SC_SCALE_FILTER_NONE,
-    SC_SCALE_FILTER_TRILINEAR, // mipmaps
-    SC_SCALE_FILTER_BILINEAR,
-    SC_SCALE_FILTER_BICUBIC,
-    SC_SCALE_FILTER_X,
-    SC_SCALE_FILTER_POINT,
-    SC_SCALE_FILTER_AREA,
-    SC_SCALE_FILTER_BICUBLIN,
-    SC_SCALE_FILTER_GAUSS,
-    SC_SCALE_FILTER_SINC,
-    SC_SCALE_FILTER_LANCZOS,
-    SC_SCALE_FILTER_SPLINE,
-    SC_SCALE_FILTER__COUNT,
-};
-
-const char *
-sc_scale_filter_name(enum sc_scale_filter scale_filter);
-
 #define SC_WINDOW_POSITION_UNDEFINED (-0x8000)
 
 struct scrcpy_options {
@@ -75,7 +56,6 @@ struct scrcpy_options {
     enum sc_record_format record_format;
     struct sc_port_range port_range;
     struct sc_shortcut_mods shortcut_mods;
-    enum sc_scale_filter scale_filter;
     uint16_t max_size;
     uint32_t bit_rate;
     uint16_t max_fps;
@@ -95,6 +75,7 @@ struct scrcpy_options {
     bool render_expired_frames;
     bool prefer_text;
     bool window_borderless;
+    bool mipmaps;
     bool stay_awake;
     bool force_adb_forward;
     bool disable_screensaver;
@@ -122,7 +103,6 @@ struct scrcpy_options {
         .data = {SC_MOD_LALT, SC_MOD_LSUPER}, \
         .count = 2, \
     }, \
-    .scale_filter = SC_SCALE_FILTER_TRILINEAR, \
     .max_size = DEFAULT_MAX_SIZE, \
     .bit_rate = DEFAULT_BIT_RATE, \
     .max_fps = 0, \
@@ -142,6 +122,7 @@ struct scrcpy_options {
     .render_expired_frames = false, \
     .prefer_text = false, \
     .window_borderless = false, \
+    .mipmaps = true, \
     .stay_awake = false, \
     .force_adb_forward = false, \
     .disable_screensaver = false, \

app/src/screen.c

@@ -5,8 +5,10 @@
 #include <SDL2/SDL.h>
 
 #include "icon.xpm"
+#include "scrcpy.h"
 #include "tiny_xpm.h"
 #include "video_buffer.h"
+#include "util/lock.h"
 #include "util/log.h"
 
 #define DISPLAY_MARGINS 96
@@ -194,12 +196,39 @@ screen_init(struct screen *screen) {
     *screen = (struct screen) SCREEN_INITIALIZER;
 }
 
+static inline SDL_Texture *
+create_texture(struct screen *screen) {
+    SDL_Renderer *renderer = screen->renderer;
+    struct size size = screen->frame_size;
+    SDL_Texture *texture = SDL_CreateTexture(renderer, SDL_PIXELFORMAT_YV12,
+                                             SDL_TEXTUREACCESS_STREAMING,
+                                             size.width, size.height);
+    if (!texture) {
+        return NULL;
+    }
+
+    if (screen->mipmaps) {
+        struct sc_opengl *gl = &screen->gl;
+
+        SDL_GL_BindTexture(texture, NULL, NULL);
+
+        // Enable trilinear filtering for downscaling
+        gl->TexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,
+                          GL_LINEAR_MIPMAP_LINEAR);
+        gl->TexParameterf(GL_TEXTURE_2D, GL_TEXTURE_LOD_BIAS, -1.f);
+
+        SDL_GL_UnbindTexture(texture);
+    }
+
+    return texture;
+}
+
 bool
 screen_init_rendering(struct screen *screen, const char *window_title,
                       struct size frame_size, bool always_on_top,
                       int16_t window_x, int16_t window_y, uint16_t window_width,
                       uint16_t window_height, bool window_borderless,
-                      uint8_t rotation, enum sc_scale_filter scale_filter) {
+                      uint8_t rotation, bool mipmaps) {
     screen->frame_size = frame_size;
     screen->rotation = rotation;
     if (rotation) {
@@ -242,17 +271,39 @@ screen_init_rendering(struct screen *screen, const char *window_title,
                                           SDL_RENDERER_ACCELERATED);
     if (!screen->renderer) {
         LOGC("Could not create renderer: %s", SDL_GetError());
-        SDL_DestroyWindow(screen->window);
+        screen_destroy(screen);
         return false;
     }
 
-    bool ok = sc_frame_texture_init(&screen->ftex, screen->renderer,
-                                    scale_filter, frame_size);
-    if (!ok) {
-        LOGC("Could not init frame texture");
-        SDL_DestroyRenderer(screen->renderer);
-        SDL_DestroyWindow(screen->window);
-        return false;
+    SDL_RendererInfo renderer_info;
+    int r = SDL_GetRendererInfo(screen->renderer, &renderer_info);
+    const char *renderer_name = r ? NULL : renderer_info.name;
+    LOGI("Renderer: %s", renderer_name ? renderer_name : "(unknown)");
+
+    // starts with "opengl"
+    screen->use_opengl = renderer_name && !strncmp(renderer_name, "opengl", 6);
+    if (screen->use_opengl) {
+        struct sc_opengl *gl = &screen->gl;
+        sc_opengl_init(gl);
+
+        LOGI("OpenGL version: %s", gl->version);
+
+        if (mipmaps) {
+            bool supports_mipmaps =
+                sc_opengl_version_at_least(gl, 3, 0, /* OpenGL 3.0+ */
+                                               2, 0  /* OpenGL ES 2.0+ */);
+            if (supports_mipmaps) {
+                LOGI("Trilinear filtering enabled");
+                screen->mipmaps = true;
+            } else {
+                LOGW("Trilinear filtering disabled "
+                     "(OpenGL 3.0+ or ES 2.0+ required)");
+            }
+        } else {
+            LOGI("Trilinear filtering disabled");
+        }
+    } else {
+        LOGD("Trilinear filtering disabled (not an OpenGL renderer)");
     }
 
     SDL_Surface *icon = read_xpm(icon_xpm);
@@ -263,6 +314,15 @@ screen_init_rendering(struct screen *screen, const char *window_title,
         LOGW("Could not load icon");
     }
 
+    LOGI("Initial texture: %" PRIu16 "x%" PRIu16, frame_size.width,
+                                                  frame_size.height);
+    screen->texture = create_texture(screen);
+    if (!screen->texture) {
+        LOGC("Could not create texture: %s", SDL_GetError());
+        screen_destroy(screen);
+        return false;
+    }
+
     // Reset the window size to trigger a SIZE_CHANGED event, to workaround
     // HiDPI issues with some SDL renderers when several displays having
     // different HiDPI scaling are connected
@@ -280,9 +340,15 @@ screen_show_window(struct screen *screen) {
 
 void
 screen_destroy(struct screen *screen) {
-    sc_frame_texture_destroy(&screen->ftex);
-    SDL_DestroyRenderer(screen->renderer);
-    SDL_DestroyWindow(screen->window);
+    if (screen->texture) {
+        SDL_DestroyTexture(screen->texture);
+    }
+    if (screen->renderer) {
+        SDL_DestroyRenderer(screen->renderer);
+    }
+    if (screen->window) {
+        SDL_DestroyWindow(screen->window);
+    }
 }
 
 static void
@@ -343,10 +409,13 @@ screen_set_rotation(struct screen *screen, unsigned rotation) {
 }
 
 // recreate the texture and resize the window if the frame size has changed
-static void
+static bool
 prepare_for_frame(struct screen *screen, struct size new_frame_size) {
     if (screen->frame_size.width != new_frame_size.width
             || screen->frame_size.height != new_frame_size.height) {
+        // frame dimension changed, destroy texture
+        SDL_DestroyTexture(screen->texture);
+
         screen->frame_size = new_frame_size;
 
         struct size new_content_size =
@@ -354,20 +423,46 @@ prepare_for_frame(struct screen *screen, struct size new_frame_size) {
         set_content_size(screen, new_content_size);
 
         screen_update_content_rect(screen);
+
+        LOGI("New texture: %" PRIu16 "x%" PRIu16,
+                     screen->frame_size.width, screen->frame_size.height);
+        screen->texture = create_texture(screen);
+        if (!screen->texture) {
+            LOGC("Could not create texture: %s", SDL_GetError());
+            return false;
+        }
+    }
+
+    return true;
+}
+
+// write the frame into the texture
+static void
+update_texture(struct screen *screen, const AVFrame *frame) {
+    SDL_UpdateYUVTexture(screen->texture, NULL,
+            frame->data[0], frame->linesize[0],
+            frame->data[1], frame->linesize[1],
+            frame->data[2], frame->linesize[2]);
+
+    if (screen->mipmaps) {
+        assert(screen->use_opengl);
+        SDL_GL_BindTexture(screen->texture, NULL, NULL);
+        screen->gl.GenerateMipmap(GL_TEXTURE_2D);
+        SDL_GL_UnbindTexture(screen->texture);
     }
 }
 
 bool
 screen_update_frame(struct screen *screen, struct video_buffer *vb) {
-    const AVFrame *frame = video_buffer_take_rendering_frame(vb);
+    mutex_lock(vb->mutex);
+    const AVFrame *frame = video_buffer_consume_rendered_frame(vb);
     struct size new_frame_size = {frame->width, frame->height};
-    prepare_for_frame(screen, new_frame_size);
-
-    struct size rect_size = {screen->rect.w, screen->rect.h};
-    bool ok = sc_frame_texture_update(&screen->ftex, frame, rect_size);
-    if (!ok) {
+    if (!prepare_for_frame(screen, new_frame_size)) {
+        mutex_unlock(vb->mutex);
         return false;
     }
+    update_texture(screen, frame);
+    mutex_unlock(vb->mutex);
 
     screen_render(screen, false);
     return true;
@@ -377,18 +472,11 @@ void
 screen_render(struct screen *screen, bool update_content_rect) {
     if (update_content_rect) {
         screen_update_content_rect(screen);
-        struct size rect_size = {screen->rect.w, screen->rect.h};
-        if (!sc_frame_texture_resize(&screen->ftex, rect_size)) {
-            // FIXME return error
-            LOGC("oops");
-        }
     }
 
-    struct sc_frame_texture *ftex = &screen->ftex;
-    SDL_RenderClear(ftex->renderer);
+    SDL_RenderClear(screen->renderer);
     if (screen->rotation == 0) {
-        SDL_RenderCopy(screen->renderer, ftex->texture, NULL,
-                       &screen->rect);
+        SDL_RenderCopy(screen->renderer, screen->texture, NULL, &screen->rect);
     } else {
         // rotation in RenderCopyEx() is clockwise, while screen->rotation is
         // counterclockwise (to be consistent with --lock-video-orientation)
@@ -408,10 +496,10 @@ screen_render(struct screen *screen, bool update_content_rect) {
             dstrect = &screen->rect;
         }
 
-        SDL_RenderCopyEx(screen->renderer, ftex->texture, NULL, dstrect,
+        SDL_RenderCopyEx(screen->renderer, screen->texture, NULL, dstrect,
                          angle, NULL, 0);
     }
-    SDL_RenderPresent(ftex->renderer);
+    SDL_RenderPresent(screen->renderer);
 }
 
 void

app/src/screen.h

@@ -8,17 +8,16 @@
 #include <libavformat/avformat.h>
 
 #include "coords.h"
-#include "frame_texture.h"
 #include "opengl.h"
-#include "scrcpy.h"
 
 struct video_buffer;
 
 struct screen {
     SDL_Window *window;
     SDL_Renderer *renderer;
-    struct sc_frame_texture ftex;
-
+    SDL_Texture *texture;
+    bool use_opengl;
+    struct sc_opengl gl;
     struct size frame_size;
     struct size content_size; // rotated frame_size
 
@@ -35,12 +34,15 @@ struct screen {
     bool fullscreen;
     bool maximized;
     bool no_window;
+    bool mipmaps;
 };
 
 #define SCREEN_INITIALIZER { \
     .window = NULL, \
     .renderer = NULL, \
-    .ftex = {0}, \
+    .texture = NULL, \
+    .use_opengl = false, \
+    .gl = {0}, \
     .frame_size = { \
         .width = 0, \
         .height = 0, \
@@ -65,6 +67,7 @@ struct screen {
     .fullscreen = false, \
     .maximized = false, \
     .no_window = false, \
+    .mipmaps = false, \
 }
 
 // initialize default values
@@ -78,7 +81,7 @@ screen_init_rendering(struct screen *screen, const char *window_title,
                       struct size frame_size, bool always_on_top,
                       int16_t window_x, int16_t window_y, uint16_t window_width,
                       uint16_t window_height, bool window_borderless,
-                      uint8_t rotation, enum sc_scale_filter scale_filter);
+                      uint8_t rotation, bool mipmaps);
 
 // show the window
 void

app/src/server.c

@@ -5,10 +5,12 @@
 #include <inttypes.h>
 #include <libgen.h>
 #include <stdio.h>
+#include <SDL2/SDL_thread.h>
 #include <SDL2/SDL_timer.h>
 #include <SDL2/SDL_platform.h>
 
 #include "adb.h"
+#include "util/lock.h"
 #include "util/log.h"
 #include "util/net.h"
 #include "util/str_util.h"
@@ -355,17 +357,18 @@ bool
 server_init(struct server *server) {
     server->serial = NULL;
     server->process = PROCESS_NONE;
+    server->wait_server_thread = NULL;
     atomic_flag_clear_explicit(&server->server_socket_closed,
                                memory_order_relaxed);
 
-    bool ok = sc_mutex_init(&server->mutex);
-    if (!ok) {
+    server->mutex = SDL_CreateMutex();
+    if (!server->mutex) {
         return false;
     }
 
-    ok = sc_cond_init(&server->process_terminated_cond);
-    if (!ok) {
-        sc_mutex_destroy(&server->mutex);
+    server->process_terminated_cond = SDL_CreateCond();
+    if (!server->process_terminated_cond) {
+        SDL_DestroyMutex(server->mutex);
         return false;
     }
 
@@ -390,10 +393,10 @@ run_wait_server(void *data) {
     struct server *server = data;
     process_wait(server->process, false); // ignore exit code
 
-    sc_mutex_lock(&server->mutex);
+    mutex_lock(server->mutex);
     server->process_terminated = true;
-    sc_cond_signal(&server->process_terminated_cond);
-    sc_mutex_unlock(&server->mutex);
+    cond_signal(server->process_terminated_cond);
+    mutex_unlock(server->mutex);
 
     // no need for synchronization, server_socket is initialized before this
     // thread was created
@@ -440,9 +443,9 @@ server_start(struct server *server, const char *serial,
     // things simple and multiplatform, just spawn a new thread waiting for the
     // server process and calling shutdown()/close() on the server socket if
     // necessary to wake up any accept() blocking call.
-    bool ok = sc_thread_create(&server->wait_server_thread, run_wait_server,
-                               "wait-server", server);
-    if (!ok) {
+    server->wait_server_thread =
+        SDL_CreateThread(run_wait_server, "wait-server", server);
+    if (!server->wait_server_thread) {
         process_terminate(server->process);
         process_wait(server->process, true); // ignore exit code
         goto error2;
@@ -532,33 +535,33 @@ server_stop(struct server *server) {
     }
 
     // Give some delay for the server to terminate properly
-    sc_mutex_lock(&server->mutex);
-    bool signaled = false;
+    mutex_lock(server->mutex);
+    int r = 0;
     if (!server->process_terminated) {
 #define WATCHDOG_DELAY_MS 1000
-        signaled = sc_cond_timedwait(&server->process_terminated_cond,
-                                     &server->mutex,
-                                     WATCHDOG_DELAY_MS);
+        r = cond_wait_timeout(server->process_terminated_cond,
+                              server->mutex,
+                              WATCHDOG_DELAY_MS);
     }
-    sc_mutex_unlock(&server->mutex);
+    mutex_unlock(server->mutex);
 
     // After this delay, kill the server if it's not dead already.
     // On some devices, closing the sockets is not sufficient to wake up the
     // blocking calls while the device is asleep.
-    if (!signaled) {
+    if (r == SDL_MUTEX_TIMEDOUT) {
         // The process is terminated, but not reaped (closed) yet, so its PID
         // is still valid.
         LOGW("Killing the server...");
         process_terminate(server->process);
     }
 
-    sc_thread_join(&server->wait_server_thread, NULL);
+    SDL_WaitThread(server->wait_server_thread, NULL);
     process_close(server->process);
 }
 
 void
 server_destroy(struct server *server) {
     free(server->serial);
-    sc_cond_destroy(&server->process_terminated_cond);
-    sc_mutex_destroy(&server->mutex);
+    SDL_DestroyCond(server->process_terminated_cond);
+    SDL_DestroyMutex(server->mutex);
 }

app/src/server.h

@@ -6,21 +6,21 @@
 #include <stdatomic.h>
 #include <stdbool.h>
 #include <stdint.h>
+#include <SDL2/SDL_thread.h>
 
 #include "adb.h"
 #include "scrcpy.h"
 #include "util/log.h"
 #include "util/net.h"
-#include "util/thread.h"
 
 struct server {
     char *serial;
     process_t process;
-    sc_thread wait_server_thread;
+    SDL_Thread *wait_server_thread;
     atomic_flag server_socket_closed;
 
-    sc_mutex mutex;
-    sc_cond process_terminated_cond;
+    SDL_mutex *mutex;
+    SDL_cond *process_terminated_cond;
     bool process_terminated;
 
     socket_t server_socket; // only used if !tunnel_forward

app/src/stream.c

@@ -4,6 +4,8 @@
 #include <libavformat/avformat.h>
 #include <libavutil/time.h>
 #include <SDL2/SDL_events.h>
+#include <SDL2/SDL_mutex.h>
+#include <SDL2/SDL_thread.h>
 #include <unistd.h>
 
 #include "decoder.h"
@@ -277,8 +279,8 @@ bool
 stream_start(struct stream *stream) {
     LOGD("Starting stream thread");
 
-    bool ok = sc_thread_create(&stream->thread, run_stream, "stream", stream);
-    if (!ok) {
+    stream->thread = SDL_CreateThread(run_stream, "stream", stream);
+    if (!stream->thread) {
         LOGC("Could not start stream thread");
         return false;
     }
@@ -294,5 +296,5 @@ stream_stop(struct stream *stream) {
 
 void
 stream_join(struct stream *stream) {
-    sc_thread_join(&stream->thread, NULL);
+    SDL_WaitThread(stream->thread, NULL);
 }

app/src/stream.h

@@ -7,15 +7,15 @@
 #include <stdint.h>
 #include <libavformat/avformat.h>
 #include <SDL2/SDL_atomic.h>
+#include <SDL2/SDL_thread.h>
 
 #include "util/net.h"
-#include "util/thread.h"
 
 struct video_buffer;
 
 struct stream {
     socket_t socket;
-    sc_thread thread;
+    SDL_Thread *thread;
     struct decoder *decoder;
     struct recorder *recorder;
     AVCodecContext *codec_ctx;

app/src/util/lock.h

@@ -0,0 +1,75 @@
+#ifndef LOCK_H
+#define LOCK_H
+
+#include "common.h"
+
+#include <stdint.h>
+#include <SDL2/SDL_mutex.h>
+
+#include "log.h"
+
+static inline void
+mutex_lock(SDL_mutex *mutex) {
+    int r = SDL_LockMutex(mutex);
+#ifndef NDEBUG
+    if (r) {
+        LOGC("Could not lock mutex: %s", SDL_GetError());
+        abort();
+    }
+#else
+    (void) r;
+#endif
+}
+
+static inline void
+mutex_unlock(SDL_mutex *mutex) {
+    int r = SDL_UnlockMutex(mutex);
+#ifndef NDEBUG
+    if (r) {
+        LOGC("Could not unlock mutex: %s", SDL_GetError());
+        abort();
+    }
+#else
+    (void) r;
+#endif
+}
+
+static inline void
+cond_wait(SDL_cond *cond, SDL_mutex *mutex) {
+    int r = SDL_CondWait(cond, mutex);
+#ifndef NDEBUG
+    if (r) {
+        LOGC("Could not wait on condition: %s", SDL_GetError());
+        abort();
+    }
+#else
+    (void) r;
+#endif
+}
+
+static inline int
+cond_wait_timeout(SDL_cond *cond, SDL_mutex *mutex, uint32_t ms) {
+    int r = SDL_CondWaitTimeout(cond, mutex, ms);
+#ifndef NDEBUG
+    if (r < 0) {
+        LOGC("Could not wait on condition with timeout: %s", SDL_GetError());
+        abort();
+    }
+#endif
+    return r;
+}
+
+static inline void
+cond_signal(SDL_cond *cond) {
+    int r = SDL_CondSignal(cond);
+#ifndef NDEBUG
+    if (r) {
+        LOGC("Could not signal a condition: %s", SDL_GetError());
+        abort();
+    }
+#else
+    (void) r;
+#endif
+}
+
+#endif

app/src/util/thread.c

@@ -1,160 +0,0 @@
-#include "thread.h"
-
-#include <assert.h>
-#include <SDL2/SDL_thread.h>
-
-#include "log.h"
-
-bool
-sc_thread_create(sc_thread *thread, sc_thread_fn fn, const char *name,
-                 void *userdata) {
-    SDL_Thread *sdl_thread = SDL_CreateThread(fn, name, userdata);
-    if (!sdl_thread) {
-        return false;
-    }
-
-    thread->thread = sdl_thread;
-    return true;
-}
-
-void
-sc_thread_join(sc_thread *thread, int *status) {
-    SDL_WaitThread(thread->thread, status);
-}
-
-bool
-sc_mutex_init(sc_mutex *mutex) {
-    SDL_mutex *sdl_mutex = SDL_CreateMutex();
-    if (!sdl_mutex) {
-        return false;
-    }
-
-    mutex->mutex = sdl_mutex;
-#ifndef NDEBUG
-    mutex->locker = 0;
-#endif
-    return true;
-}
-
-void
-sc_mutex_destroy(sc_mutex *mutex) {
-    SDL_DestroyMutex(mutex->mutex);
-}
-
-void
-sc_mutex_lock(sc_mutex *mutex) {
-    // SDL mutexes are recursive, but we don't want to use recursive mutexes
-    assert(!sc_mutex_held(mutex));
-    int r = SDL_LockMutex(mutex->mutex);
-#ifndef NDEBUG
-    if (r) {
-        LOGC("Could not lock mutex: %s", SDL_GetError());
-        abort();
-    }
-
-    mutex->locker = sc_thread_get_id();
-#else
-    (void) r;
-#endif
-}
-
-void
-sc_mutex_unlock(sc_mutex *mutex) {
-#ifndef NDEBUG
-    assert(sc_mutex_held(mutex));
-    mutex->locker = 0;
-#endif
-    int r = SDL_UnlockMutex(mutex->mutex);
-#ifndef NDEBUG
-    if (r) {
-        LOGC("Could not lock mutex: %s", SDL_GetError());
-        abort();
-    }
-#else
-    (void) r;
-#endif
-}
-
-sc_thread_id
-sc_thread_get_id(void) {
-    return SDL_ThreadID();
-}
-
-#ifndef NDEBUG
-bool
-sc_mutex_held(struct sc_mutex *mutex) {
-    return mutex->locker == sc_thread_get_id();
-}
-#endif
-
-bool
-sc_cond_init(sc_cond *cond) {
-    SDL_cond *sdl_cond = SDL_CreateCond();
-    if (!sdl_cond) {
-        return false;
-    }
-
-    cond->cond = sdl_cond;
-    return true;
-}
-
-void
-sc_cond_destroy(sc_cond *cond) {
-    SDL_DestroyCond(cond->cond);
-}
-
-void
-sc_cond_wait(sc_cond *cond, sc_mutex *mutex) {
-    int r = SDL_CondWait(cond->cond, mutex->mutex);
-#ifndef NDEBUG
-    if (r) {
-        LOGC("Could not wait on condition: %s", SDL_GetError());
-        abort();
-    }
-
-    mutex->locker = sc_thread_get_id();
-#else
-    (void) r;
-#endif
-}
-
-bool
-sc_cond_timedwait(sc_cond *cond, sc_mutex *mutex, uint32_t ms) {
-    int r = SDL_CondWaitTimeout(cond->cond, mutex->mutex, ms);
-#ifndef NDEBUG
-    if (r < 0) {
-        LOGC("Could not wait on condition with timeout: %s", SDL_GetError());
-        abort();
-    }
-
-    mutex->locker = sc_thread_get_id();
-#endif
-    assert(r == 0 || r == SDL_MUTEX_TIMEDOUT);
-    return r == 0;
-}
-
-void
-sc_cond_signal(sc_cond *cond) {
-    int r = SDL_CondSignal(cond->cond);
-#ifndef NDEBUG
-    if (r) {
-        LOGC("Could not signal a condition: %s", SDL_GetError());
-        abort();
-    }
-#else
-    (void) r;
-#endif
-}
-
-void
-sc_cond_broadcast(sc_cond *cond) {
-    int r = SDL_CondBroadcast(cond->cond);
-#ifndef NDEBUG
-    if (r) {
-        LOGC("Could not broadcast a condition: %s", SDL_GetError());
-        abort();
-    }
-#else
-    (void) r;
-#endif
-}

app/src/util/thread.h

@@ -1,81 +0,0 @@
-#ifndef SC_THREAD_H
-#define SC_THREAD_H
-
-#include "common.h"
-
-#include <stdbool.h>
-#include <stdint.h>
-
-/* Forward declarations */
-typedef struct SDL_Thread SDL_Thread;
-typedef struct SDL_mutex SDL_mutex;
-typedef struct SDL_cond SDL_cond;
-
-typedef int sc_thread_fn(void *);
-typedef unsigned int sc_thread_id;
-
-typedef struct sc_thread {
-    SDL_Thread *thread;
-} sc_thread;
-
-typedef struct sc_mutex {
-    SDL_mutex *mutex;
-#ifndef NDEBUG
-    sc_thread_id locker;
-#endif
-} sc_mutex;
-
-typedef struct sc_cond {
-    SDL_cond *cond;
-} sc_cond;
-
-bool
-sc_thread_create(sc_thread *thread, sc_thread_fn fn, const char *name,
-                 void *userdata);
-
-void
-sc_thread_join(sc_thread *thread, int *status);
-
-bool
-sc_mutex_init(sc_mutex *mutex);
-
-void
-sc_mutex_destroy(sc_mutex *mutex);
-
-void
-sc_mutex_lock(sc_mutex *mutex);
-
-void
-sc_mutex_unlock(sc_mutex *mutex);
-
-sc_thread_id
-sc_thread_get_id(void);
-
-#ifndef NDEBUG
-bool
-sc_mutex_held(struct sc_mutex *mutex);
-# define sc_mutex_assert(mutex) assert(sc_mutex_held(mutex))
-#else
-# define sc_mutex_assert(mutex)
-#endif
-
-bool
-sc_cond_init(sc_cond *cond);
-
-void
-sc_cond_destroy(sc_cond *cond);
-
-void
-sc_cond_wait(sc_cond *cond, sc_mutex *mutex);
-
-// return true on signaled, false on timeout
-bool
-sc_cond_timedwait(sc_cond *cond, sc_mutex *mutex, uint32_t ms);
-
-void
-sc_cond_signal(sc_cond *cond);
-
-void
-sc_cond_broadcast(sc_cond *cond);
-
-#endif

app/src/video_buffer.c

@@ -1,9 +1,11 @@
 #include "video_buffer.h"
 
 #include <assert.h>
+#include <SDL2/SDL_mutex.h>
 #include <libavutil/avutil.h>
 #include <libavformat/avformat.h>
 
+#include "util/lock.h"
 #include "util/log.h"
 
 bool
@@ -11,31 +13,22 @@ video_buffer_init(struct video_buffer *vb, struct fps_counter *fps_counter,
                   bool render_expired_frames) {
     vb->fps_counter = fps_counter;
 
-    vb->decoding_frame = av_frame_alloc();
-    if (!vb->decoding_frame) {
+    if (!(vb->decoding_frame = av_frame_alloc())) {
         goto error_0;
     }
 
-    vb->pending_frame = av_frame_alloc();
-    if (!vb->pending_frame) {
+    if (!(vb->rendering_frame = av_frame_alloc())) {
         goto error_1;
     }
 
-    vb->rendering_frame = av_frame_alloc();
-    if (!vb->rendering_frame) {
+    if (!(vb->mutex = SDL_CreateMutex())) {
         goto error_2;
     }
 
-    bool ok = sc_mutex_init(&vb->mutex);
-    if (!ok) {
-        goto error_3;
-    }
-
     vb->render_expired_frames = render_expired_frames;
     if (render_expired_frames) {
-        ok = sc_cond_init(&vb->pending_frame_consumed_cond);
-        if (!ok) {
-            sc_mutex_destroy(&vb->mutex);
+        if (!(vb->rendering_frame_consumed_cond = SDL_CreateCond())) {
+            SDL_DestroyMutex(vb->mutex);
             goto error_2;
         }
         // interrupted is not used if expired frames are not rendered
@@ -45,14 +38,12 @@ video_buffer_init(struct video_buffer *vb, struct fps_counter *fps_counter,
 
     // there is initially no rendering frame, so consider it has already been
     // consumed
-    vb->pending_frame_consumed = true;
+    vb->rendering_frame_consumed = true;
 
     return true;
 
-error_3:
-    av_frame_free(&vb->rendering_frame);
 error_2:
-    av_frame_free(&vb->pending_frame);
+    av_frame_free(&vb->rendering_frame);
 error_1:
     av_frame_free(&vb->decoding_frame);
 error_0:
@@ -62,78 +53,60 @@ error_0:
 void
 video_buffer_destroy(struct video_buffer *vb) {
     if (vb->render_expired_frames) {
-        sc_cond_destroy(&vb->pending_frame_consumed_cond);
+        SDL_DestroyCond(vb->rendering_frame_consumed_cond);
     }
-    sc_mutex_destroy(&vb->mutex);
+    SDL_DestroyMutex(vb->mutex);
     av_frame_free(&vb->rendering_frame);
-    av_frame_free(&vb->pending_frame);
     av_frame_free(&vb->decoding_frame);
 }
 
 static void
-video_buffer_swap_decoding_frame(struct video_buffer *vb) {
-    sc_mutex_assert(&vb->mutex);
+video_buffer_swap_frames(struct video_buffer *vb) {
     AVFrame *tmp = vb->decoding_frame;
-    vb->decoding_frame = vb->pending_frame;
-    vb->pending_frame = tmp;
-}
-
-static void
-video_buffer_swap_rendering_frame(struct video_buffer *vb) {
-    sc_mutex_assert(&vb->mutex);
-    AVFrame *tmp = vb->rendering_frame;
-    vb->rendering_frame = vb->pending_frame;
-    vb->pending_frame = tmp;
+    vb->decoding_frame = vb->rendering_frame;
+    vb->rendering_frame = tmp;
 }
 
 void
 video_buffer_offer_decoded_frame(struct video_buffer *vb,
                                  bool *previous_frame_skipped) {
-    sc_mutex_lock(&vb->mutex);
+    mutex_lock(vb->mutex);
     if (vb->render_expired_frames) {
         // wait for the current (expired) frame to be consumed
-        while (!vb->pending_frame_consumed && !vb->interrupted) {
-            sc_cond_wait(&vb->pending_frame_consumed_cond, &vb->mutex);
+        while (!vb->rendering_frame_consumed && !vb->interrupted) {
+            cond_wait(vb->rendering_frame_consumed_cond, vb->mutex);
         }
-    } else if (!vb->pending_frame_consumed) {
+    } else if (!vb->rendering_frame_consumed) {
         fps_counter_add_skipped_frame(vb->fps_counter);
     }
 
-    video_buffer_swap_decoding_frame(vb);
+    video_buffer_swap_frames(vb);
 
-    *previous_frame_skipped = !vb->pending_frame_consumed;
-    vb->pending_frame_consumed = false;
+    *previous_frame_skipped = !vb->rendering_frame_consumed;
+    vb->rendering_frame_consumed = false;
 
-    sc_mutex_unlock(&vb->mutex);
+    mutex_unlock(vb->mutex);
 }
 
 const AVFrame *
-video_buffer_take_rendering_frame(struct video_buffer *vb) {
-    sc_mutex_lock(&vb->mutex);
-    assert(!vb->pending_frame_consumed);
-    vb->pending_frame_consumed = true;
-
+video_buffer_consume_rendered_frame(struct video_buffer *vb) {
+    assert(!vb->rendering_frame_consumed);
+    vb->rendering_frame_consumed = true;
     fps_counter_add_rendered_frame(vb->fps_counter);
-
-    video_buffer_swap_rendering_frame(vb);
-
     if (vb->render_expired_frames) {
         // unblock video_buffer_offer_decoded_frame()
-        sc_cond_signal(&vb->pending_frame_consumed_cond);
+        cond_signal(vb->rendering_frame_consumed_cond);
     }
-    sc_mutex_unlock(&vb->mutex);
-
-    // rendering_frame is only written from this thread, no need to lock
     return vb->rendering_frame;
 }
 
 void
 video_buffer_interrupt(struct video_buffer *vb) {
     if (vb->render_expired_frames) {
-        sc_mutex_lock(&vb->mutex);
+        mutex_lock(vb->mutex);
         vb->interrupted = true;
-        sc_mutex_unlock(&vb->mutex);
+        mutex_unlock(vb->mutex);
         // wake up blocking wait
-        sc_cond_signal(&vb->pending_frame_consumed_cond);
+        cond_signal(vb->rendering_frame_consumed_cond);
     }
 }

app/src/video_buffer.h

@@ -4,42 +4,21 @@
 #include "common.h"
 
 #include <stdbool.h>
+#include <SDL2/SDL_mutex.h>
 
 #include "fps_counter.h"
-#include "util/thread.h"
 
 // forward declarations
 typedef struct AVFrame AVFrame;
 
-/**
- * There are 3 frames in memory:
- *  - one frame is held by the decoder (decoding_frame)
- *  - one frame is held by the renderer (rendering_frame)
- *  - one frame is shared between the decoder and the renderer (pending_frame)
- *
- * The decoder decodes a packet into the decoding_frame (it may takes time).
- *
- * Once the frame is decoded, it calls video_buffer_offer_decoded_frame(),
- * which swaps the decoding and pending frames.
- *
- * When the renderer is notified that a new frame is available, it calls
- * video_buffer_take_rendering_frame() to retrieve it, which swaps the pending
- * and rendering frames. The frame is valid until the next call, without
- * blocking the decoder.
- */
-
 struct video_buffer {
     AVFrame *decoding_frame;
-    AVFrame *pending_frame;
     AVFrame *rendering_frame;
-
-    sc_mutex mutex;
+    SDL_mutex *mutex;
     bool render_expired_frames;
     bool interrupted;
-
-    sc_cond pending_frame_consumed_cond;
-    bool pending_frame_consumed;
-
+    SDL_cond *rendering_frame_consumed_cond;
+    bool rendering_frame_consumed;
     struct fps_counter *fps_counter;
 };
 
@@ -51,15 +30,18 @@ void
 video_buffer_destroy(struct video_buffer *vb);
 
 // set the decoded frame as ready for rendering
+// this function locks frames->mutex during its execution
 // the output flag is set to report whether the previous frame has been skipped
 void
 video_buffer_offer_decoded_frame(struct video_buffer *vb,
                                  bool *previous_frame_skipped);
 
 // mark the rendering frame as consumed and return it
-// the frame is valid until the next call to this function
+// MUST be called with frames->mutex locked!!!
+// the caller is expected to render the returned frame to some texture before
+// unlocking frames->mutex
 const AVFrame *
-video_buffer_take_rendering_frame(struct video_buffer *vb);
+video_buffer_consume_rendered_frame(struct video_buffer *vb);
 
 // wake up and avoid any blocking call
 void