Forward Alt to the device

There is no reason not to forward it.
Forward Shift to the device
2020-05-29 01:08:03 +02:00 · 2020-05-29 01:07:42 +02:00
2 changed files with 4 additions and 6 deletions
--- a/app/src/event_converter.c
+++ b/app/src/event_converter.c
@ -93,6 +93,10 @@ convert_keycode(SDL_Keycode from, enum android_keycode *to, uint16_t mod,
        MAP(SDLK_DOWN,         AKEYCODE_DPAD_DOWN);
        MAP(SDLK_UP,           AKEYCODE_DPAD_UP);
        MAP(SDLK_RCTRL,        AKEYCODE_CTRL_RIGHT);
+        MAP(SDLK_LSHIFT,       AKEYCODE_SHIFT_LEFT);
+        MAP(SDLK_RSHIFT,       AKEYCODE_SHIFT_RIGHT);
+        MAP(SDLK_LALT,         AKEYCODE_ALT_LEFT);
+        MAP(SDLK_RALT,         AKEYCODE_ALT_RIGHT);
    }

    if (!(mod & (KMOD_NUM | KMOD_SHIFT))) {
--- a/app/src/input_manager.c
+++ b/app/src/input_manager.c
@ -261,7 +261,6 @@ input_manager_process_key(struct input_manager *im,

    // Only capture Left-Ctrl, Right-Ctrl is forwarded to the device
    bool ctrl = event->keysym.mod & KMOD_LCTRL;
-    bool alt = event->keysym.mod & (KMOD_LALT | KMOD_RALT);
    bool meta = event->keysym.mod & (KMOD_LGUI | KMOD_RGUI);

    // use Cmd on macOS, Ctrl on other platforms
@ -276,11 +275,6 @@ input_manager_process_key(struct input_manager *im,
    bool cmd = ctrl; // && !meta, already guaranteed
 #endif

-    if (alt) {
-        // no shortcuts involve Alt, and it must not be forwarded to the device
-        return;
-    }
-
    struct controller *controller = im->controller;

    // capture all Ctrl events
Author	SHA1	Message	Date
Romain Vimont	d95a52f277	Forward Alt to the device There is no reason not to forward it.	2020-05-29 01:08:03 +02:00
Romain Vimont	ad78ca9cfb	Forward Shift to the device This allows to select text with Shift + arrow keys. Fixes #942 <https://github.com/Genymobile/scrcpy/issues/942>.	2020-05-29 01:07:42 +02:00