345092 Commits

Author SHA1 Message Date
Neil Fuller
f4634736ca Move XML object factory logic to libcore
It makes sense to hide the details of the parser implementation
(and other similar objects) in libcore so it could be changed.

This change removes the "ExpatPerformanceTest" which appears not to have
been maintained and was comparing KxmlParser with itself. It is assumed
that android.util.Xml used to return the expat parser.

Test: build
Bug: 111055375
Merged-In: Ibad247323ba90cd949aecb2bd92f2f73306a4327
Change-Id: Ibad247323ba90cd949aecb2bd92f2f73306a4327
2018-07-11 14:02:00 +01:00
Treehugger Robot
7980b19bc8 Merge "Track changes in libcore to remove a constructor" 2018-07-06 13:58:29 +00:00
Treehugger Robot
cbe9c295a3 Merge "Remove unusual static method call" 2018-07-05 11:12:35 +00:00
Neil Fuller
9c610f7567 Remove unusual static method call
The code is using static method Calendar.getInstance() but via a
subclass of Calendar. It works, and getInstance() returns a
GregorianCalendar on Android, but it's odd and was probably unintended.

Noticed during static analysis of SystemUI bytecode.

Bug: 111055375
Test: build / boot
Change-Id: I1762cbeb2cc7882868f84ec11100815671cd29ec
2018-07-05 10:23:53 +01:00
Treehugger Robot
26025a06ec Merge "Always close file descriptors" 2018-07-05 09:07:21 +00:00
Neil Fuller
f94eb29500 Merge "Track constructor changes in libcore/" 2018-07-05 08:57:13 +00:00
Erik Kline
725e8f6856 Always close file descriptors
Every error thrown leaked a netlink NETFILTER socket.

Test: as follows
    - built, flashed, booted
    - runtest frameworks-net passes
    - enabled tethering and tried to cause conntrack updates to sessions
      that had expired (which causes ErrnoExceptions to be thrown)
      while monitoring lsof for system_server's NETFILTER sockets

Bug: 32163131
Bug: 64976634
Bug: 110122306

Change-Id: Ib52b812e8434c27ad9f2596666400c13e03c2216
2018-07-05 15:23:40 +09:00
Treehugger Robot
d004710e0e Merge "Fix the logic to get tv_pip_settings_class_name" 2018-07-04 22:45:16 +00:00
Neil Fuller
baae7fa357 Track changes in libcore to remove a constructor
Track changes in libcore to remove a constructor + lint
import order changes. Instead of the constructor a utility
method is introduced.

Test: Build / boot
Bug: 111055375
Merged-In: Id683a9d9d6e27d4c8df623dae189da9e74a6d410
Change-Id: Id683a9d9d6e27d4c8df623dae189da9e74a6d410
2018-07-04 09:11:08 +01:00
Tyler Gunn
bc103bdf18 Merge "ImsMultiEndPoint - Sip Notify Change" 2018-07-03 22:15:21 +00:00
Sumit Das
c9373d843e ImsMultiEndPoint - Sip Notify Change
-Added log message, getter method and set/read from parcel

Change-Id: I832bd2cf51382bb0919ab0ea1b5c7fcba8b2b136
2018-07-03 21:41:03 +00:00
Neil Fuller
7e957e57b7 Merge "Make Half class use public APIs" 2018-07-03 18:32:27 +00:00
Neil Fuller
038b20c99b Track constructor changes in libcore/
The 2-arg constructor is being removed.

Test: build / boot
Bug: 111055375
Change-Id: I72413a8c7885f9514a88f59deb649fa755deff92
2018-07-03 19:22:45 +01:00
Treehugger Robot
ef941e192a Merge "Push DNS configuration on network validation" 2018-07-03 09:03:35 +00:00
Erik Kline
c6d00228cd Push DNS configuration on network validation
Test: as follows
    - built, flashed, booted
    - runtest frameworks-net passes
    - connected to captive portal network,
      saw failed validation attempt (opportunistic),
      passed portal, saw successful revalidation attempt
Bug: 64133961
Bug: 72344805
Bug: 109928338

Change-Id: I0471685c2234af8a8c7f5b2ad3205eb6e36333c5
2018-07-03 13:33:34 +09:00
Treehugger Robot
38f7576297 Merge "Reordered the params for network registration" 2018-07-02 23:56:11 +00:00
Treehugger Robot
674fd12278 Merge "Add in-app tracepoints to TouchLatency app." 2018-07-02 23:39:21 +00:00
Carmen Jackson
286cfb1bba Add in-app tracepoints to TouchLatency app.
Test: Traced the TouchLatency app and saw the added tracepoints.
Change-Id: I72ab8f88731e635f98831f045dddd086a05acc3b
2018-07-02 14:40:23 -07:00
Nathan Harold
5e8a5d4b79 Merge "Update Docstrings for CellSignalStrengthLte" 2018-07-02 20:40:55 +00:00
Treehugger Robot
ccd6a0f6c2 Merge "Modify catch when addInterfaceToLocalNetwork() is called." 2018-07-02 11:22:28 +00:00
Neil Fuller
f9d88dfac1 Make Half class use public APIs
Half has a dependency on an internal sun.misc.FloatingDecimal
that can be replaced by an equivalent call on java.lang.Float
(which calls through to FloatingDecimal).

Any performance hit is worth it for a smaller API surface.

Bug: 111055375
Test: Build
Change-Id: Iecdf3aa9414922a77edbdc439b0c2b88033b3af8
2018-07-02 12:04:39 +01:00
Sehee Park
a1874cc580 Modify catch when addInterfaceToLocalNetwork() is called.
Fatal Exception is occured in system process. Becuase addInterfaceToLocalNetwork()
throw IllegalStateException but it can not be handled in TetherInterfaceStateMachine.
Modify catch from "RemoteException" to "Exception" when addInterfaceToLocalNetwork() is called.

Test: Repeat on/off tethering
Test: "runtest --no-hidden-api-checks frameworks-net" passes

Bug: 110396460
Change-Id: I2f2f1325cfcce40c3113ccccf69b2bbd5df4ae5b
Signed-off-by: Sehee Park <sehee32.park@samsung.com>
2018-07-02 18:17:31 +09:00
Jack Yu
2e371c1b5a Merge "Used APN type instead of APN id" 2018-06-29 23:54:32 +00:00
Jack Yu
bfa6635c30 Used APN type instead of APN id
APN id is similar to ApnSetting.ApnType. We can just use the apn
type. No need to use APN id anymore.

Test: Telephony sanity tests + unit tests
Bug: 77511388
Merged-In: If41845604ea14f36272262da110d682eea0d5451
Change-Id: If41845604ea14f36272262da110d682eea0d5451
(cherry picked from commit f42d06010a522b0d519df1a2ce9fa5ba3aefb51f)
2018-06-29 14:52:52 -07:00
Nathan Harold
4d7a010983 Merge changes I0d635067,I1424973b
* changes:
  Simplify equals() method of ServiceState
  Update ServiceState.hashCode()
2018-06-29 21:23:26 +00:00
Treehugger Robot
c8eb9ef591 Merge "Add new carrier config for CDMA registered PLMN when not roaming." 2018-06-29 19:55:16 +00:00
Amit Mahajan
ab790a123b Add new carrier config for CDMA registered PLMN when not roaming.
Test: manual
Bug: 80145031
Merged-in: I6533b4097f729df88f287348924563c6f459401c
Change-Id: I6533b4097f729df88f287348924563c6f459401c
(cherry picked from commit 22e89f4773d9cbc8f5911b65b2dae3e3add7bdb6)
2018-06-29 11:02:56 -07:00
Treehugger Robot
10cfc61774 Merge "Build com.android.future.usb.accessory with java_sdk_library" 2018-06-29 02:51:43 +00:00
Remi NGUYEN VAN
855f0f03e1 Merge "Disable hidden API checks on unit tests" 2018-06-29 02:15:47 +00:00
Jack Yu
7928c4d1c3 Reordered the params for network registration
Test: Build
Bug: 73659459
Change-Id: I1af2c49a937177173b760d30b030da20f03c01d7
2018-06-28 15:29:08 -07:00
Brad Ebinger
36a9fa62be Merge "Emergency SMS carrier config flag" 2018-06-28 22:16:10 +00:00
Nathan Harold
9ca4d43922 Merge "Allow Cell Location for SYSTEM_UID and ROOT_UID" 2018-06-28 22:05:56 +00:00
Nathan Harold
df54d98be6 Allow Cell Location for SYSTEM_UID and ROOT_UID
This change permits the system uid and root uid to
access cellular location information via the binder.
Previously this was restricted to the phone uid, but
running with uid=system is a privileged situation,
which makes me think this this wasn't intentional.

Also add a few lines of debug code to make issues
in LocationAccessPolicy easier to track down in the
future.

Bug: 110806860
Test: manual - ran with SL4A as SYSTEM_UID and
    verified access to getAllCellInfo.

Merged-In: Ie18be2cd72c49f1859d1434428f82f164bed8756
Change-Id: Ie18be2cd72c49f1859d1434428f82f164bed8756
2018-06-28 19:09:51 +00:00
Nathan Harold
7ee5f2185d Simplify equals() method of ServiceState
For whatever reason, ServiceState used a
somewhat-convoluted check for null and
class type. Updating to use a canonical
and brief approach.

Bug: 8675309
Test: compilation
Change-Id: I0d635067a06093affff478e13c28bbbe2bfda7df
2018-06-27 18:55:49 -07:00
Nathan Harold
b220fde296 Update ServiceState.hashCode()
hashCode() was missing about 10 fields and was
using some unnecessary bespoke logic to generate
hashes for individual fields. This CL simplifies
the hashCode() implementation and adds the missing
fields.

Bug: 8675309
Test: compilation
Change-Id: I1424973b11fcc6480d6f8c83d5fd0eb1b5533c7f
2018-06-27 17:13:03 -07:00
Tyler Gunn
af228ca978 Merge "ImsMultiEndPoint - Sip Notify Change" 2018-06-27 20:02:37 +00:00
Brad Ebinger
f03b8e2471 Merge "Telephony: Introduce a base class for ISMS.aidl." 2018-06-27 18:24:51 +00:00
Rubin Xu
9916d4b3e8 Merge "Support seamless handover between VPN fds." 2018-06-27 16:27:26 +00:00
Treehugger Robot
251a0cfb78 Merge "Track dropping of throws clause in Pattern.java." 2018-06-27 16:01:14 +00:00
Avinash Nalluri
ceaf7226cf Emergency SMS carrier config flag
Allow send sms over ims to emergency number when the device is in
lte/limited lte mode without normal ims registration.
Modem will use emergency ims pdn to submit sms to network.

Change-Id: I5762102c695fe309a4a5b318abccded5c50154e0
Bug: 110462046
2018-06-27 08:46:54 -07:00
Tobias Thierer
b5f35aeaf3 Merge "TextUtils: track behavior change of Pattern.split() when targeting > 28." 2018-06-27 13:53:12 +00:00
Neil Fuller
bc38909bf3 Merge "Prepare for migration to the time detector service" 2018-06-27 08:45:36 +00:00
Nathan Harold
bace6e3132 Update Docstrings for CellSignalStrengthLte
Add comments to the docstrings to indicate optional
values that may not always be reported. Users are
still reporting bugs for missing fields, which we
consider optional. This should clarify which methods
are optional vs mandatory for LTE.

For signal strength, RSRP is mandatory, and TA is
mandatory while in LTE_ACTIVE. RSSNR, RSRQ, and CQI
are all optional.

Bug: 36995487
Test: compilation (docstring-only change)
Change-Id: I05af5d42cbf6836109efe6441e95223e81671534
2018-06-26 17:21:28 -07:00
Ajay Nambi
0bfe9438b1 Telephony: Introduce a base class for ISMS.aidl.
Add a dummy base class implementation for
AIDL APIs defined. Clients can override the
required APIs.

Bug: 73994017
Change-Id: Ifd14e04ae0467a7b963cd993cfd514660f14fa95
2018-06-26 22:54:03 +00:00
David Sehr
f40f05229c Merge "Split fork and specialize in zygote" 2018-06-26 22:02:16 +00:00
Treehugger Robot
c00dd28164 Merge "Fix memory leak in RenderThread::dumpGraphicsMemory." 2018-06-26 21:38:14 +00:00
Tyler Gunn
690f008e3f Merge "Update onDeregistered docs to make capability change expectations clear." 2018-06-26 21:14:27 +00:00
David Sehr
9a81005e44 Split fork and specialize in zygote
Separate the portions of the zygote jni library that perform forking
from specialization into system_server or app process.  This is a small
step towards separating forking into a pre-launch activity, possibly
with a pool of pre-application processes.

Bug: 68253328
Test: boot and run
Change-Id: I6ce694d9a69bf7d10cf61cd39989091ee9cabd37
Merged-In: I6ce694d9a69bf7d10cf61cd39989091ee9cabd37
2018-06-26 12:50:30 -07:00
Josh Gao
1c300861d2 Fix memory leak in RenderThread::dumpGraphicsMemory.
This would have been a double-close of fd, except we just leak the
FILE* instead.

Test: treehugger
Change-Id: I519366fbcf0eb6f03f79c22abfa2b1b1b493a70a
2018-06-26 12:37:42 -07:00
Tobias Thierer
a287bfead0 Track dropping of throws clause in Pattern.java.
This is not really an API change because PatternSyntaxException
is unchecked (extends RuntimeException). The behavior has not
changed (PatternSyntaxException can still be thrown).

Bug: 109659282
Test: Treehugger
Change-Id: I5759eee10b27307b68f15fdd6f6f1a258ee01529
2018-06-26 14:48:48 +01:00