All edit-specific data has been moved to an EditData inner class in TextView.
The instance of this class is created as soon as one of its fields is set to
a non-default value. Regular TextViews (buttons, checkboxes...) should never
have to instantiate the Editor, thus reducing their memory footprint.
Note: this is a debug version. The getEditor() method is here to track
possible problems and should be removed in the final version. Indentation
will be fixed then.
Next step is to extract more methods and classes into Editor and create a
dedicated class for it. mMovement may also be Editor specific.
Change-Id: Ic241953a2fb73213180f300c3609a9e6799aa884
Avoid using wp<>::unsafe_get() except in a log, and other specific cases
when it's known to be safe.
Use more specific subclass types for parameters to avoid down-casts.
When a constructor or method parameter is "this" of an object that is
currently being constructed, it's better to use a raw pointer rather
than either sp<> or wp<>.
Using the raw pointer is safe, provided either:
- it is "this" of an object being constructed (which has sp<> refcount of 0),
- or the caller already holds an sp<>
The raw pointer is simpler and faster, and it avoids the problem of the
sp<> reference count being incremented and then decremented to zero on
scope exit, which would cause the object's destructor to run while the
object is still being constructed.
Also removed some dead code per a review comment.
Change-Id: I7375f64da3aec11b928c33cb01faff186252ef5e
Account for adapters that don't inflate item views using the ListView as
a parent.
Unify how AbsListView and subclasses generate layoutparams.
Change-Id: I963a5fcb4d98b721210a4d92d0db307f56acdf59
Bug 6017386
Focused rect in used in ViewRoot when a new view takes focus.
TextView bringPointIntoView defines an other rectangle as text is typed.
Make sure the latter is included in the former to avoid the jump when one
starts typing text.
Change-Id: I0177adc046c77a5fd9c1423c0069d5b9798dc0b9
warning: pointer of type 'void *' used in arithmetic
warning: enumeral and non-enumeral type in conditional expression
Change-Id: I7b8d626a636145ef648e3b5d0e77068216dd012e
Bug 5987568
Get the text type from webkit when initializing the field for
text entry and use that type to specify the IME input type
and options.
Webkit Change: I7eceafdbede8b7b463590a2e875a237241479ad1
Change-Id: Ic8c14687a70727148dfc8115c46f09530ca0c0f6
o also added a check on whether capture rate was set before starting time lapse video recording.
o related-to-bug: 6045507
Change-Id: I8e1fdc8e8931e2684ab3822dc6260db44658e87d
Get rid of the file cache, since it tends to run out of memory for large
numbers of files. This slows down the scanner somewhat, but recent
optimizations more than make up for that.
With this change, the postscan phase of the media scan now only processes
playlists. Removal of entries for files that no longer exist is done as
part of the prescan.
Lookups in the file cache are replaced by simple queries, which are still
reasonably fast because of a new index recently added to the media provider
database. Note that there was a bug in the case-insensitive matching for
file cache entries, in that e.g. an uppercase a-accent-aigue would be mapped
to its lowercase version, whereas the underlying case-insensitive filesystem
treats them as different characters. Getting rid of the file cache also fixes
this issue.
Bug: 4474617
Change-Id: I39c6f1a35bb518ef7ab912e9b9401663821ef48e
