drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling.

Browse Source 
This method is invoked only when the pop-up is currently displayed and the text scrolles.

This is scenario is reproducible only with Voice IME (I think), as the text is inserted without
touching the screen.

Bug: 5290463

Change-Id: I0b842732cc1f115de06e992fbe28cb64eac49b22
This commit is contained in:
Luca Zanolin
2011-09-28 11:43:22 +01:00
parent 9f48d6348d
commit a403cb7e72
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/widget/TextView.java
View File

@ -9433,8 +9433,8 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
return false;
}
int posX = mPositionX + positionX;
int posY = mPositionY + positionY;
int posX = mPositionX + positionX - getScrollX();
int posY = mPositionY + positionY - getScrollY();
// Offset by 1 to take into account 0.5 and int rounding around getPrimaryHorizontal.
return posX >= clip.left - 1 && posX <= clip.right + 1 &&