drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Statsd alerts can inform subscribers probabilistically"

Browse Source
This commit is contained in:
TreeHugger Robot
2018-02-23 18:50:16 +00:00
committed by Android (Google) Code Review
parent e406ac080f 12c1270f8b
commit 193fe201da
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cmds/statsd/src/anomaly/AnomalyTracker.cpp
View File

@ -233,11 +233,19 @@ bool AnomalyTracker::isInRefractoryPeriod(const uint64_t& timestampNs,
void AnomalyTracker::informSubscribers(const MetricDimensionKey& key) {
VLOG("informSubscribers called.");
if (mSubscriptions.empty()) {
ALOGE("Attempt to call with no subscribers.");
// The config just wanted to log the anomaly. That's fine.
VLOG("No Subscriptions were associated with the alert.");
return;
}
for (const Subscription& subscription : mSubscriptions) {
if (subscription.probability_of_informing() < 1
&& ((float)rand() / RAND_MAX) >= subscription.probability_of_informing()) {
// Note that due to float imprecision, 0.0 and 1.0 might not truly mean never/always.
// The config writer was advised to use -0.1 and 1.1 for never/always.
ALOGI("Fate decided that a subscriber would not be informed.");
continue;
}
switch (subscription.subscriber_information_case()) {
case Subscription::SubscriberInformationCase::kIncidentdDetails:
if (!GenerateIncidentReport(subscription.incidentd_details(), mAlert, mConfigKey)) {

2
cmds/statsd/src/statsd_config.proto
View File

@ -307,6 +307,8 @@ message Subscription {
PerfettoDetails perfetto_details = 5;
BroadcastSubscriberDetails broadcast_subscriber_details = 6;
}
optional float probability_of_informing = 7 [default = 1.1];
}
message StatsdConfig {