drgreen/scrcpy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suggest command line arguments without quotes

Browse Source 
Replace argument suggestion:

    --video-encoder='c2.android.avc.encoder'

by:

    --video-encoder=c2.android.avc.encoder

On Linux, the quotes are interpreted by the shell, but on Windows they
are passed as is.

This was harmless, because even transmitted as is, they were interpreted
by the shell on the device. However, special characters are now
validated since commit bec3321fff4c6dc3b3dbc61fdc6fd98913988a78, making
the command fail.

Fixes #5329 <https://github.com/Genymobile/scrcpy/issues/5329>
This commit is contained in:
Romain Vimont 2024-09-30 08:12:08 +02:00
parent 7a9ea5c66f
commit ec602a0334
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/src/main/java/com/genymobile/scrcpy/util/LogUtils.java
View File

@ -31,7 +31,7 @@ public final class LogUtils {
} else { } else {
for (CodecUtils.DeviceEncoder encoder : videoEncoders) { for (CodecUtils.DeviceEncoder encoder : videoEncoders) {
builder.append("\n --video-codec=").append(encoder.getCodec().getName()); builder.append("\n --video-codec=").append(encoder.getCodec().getName());
builder.append(" --video-encoder='").append(encoder.getInfo().getName()).append("'"); builder.append(" --video-encoder=").append(encoder.getInfo().getName());
} }
} }
return builder.toString(); return builder.toString();
@ -45,7 +45,7 @@ public final class LogUtils {
} else { } else {
for (CodecUtils.DeviceEncoder encoder : audioEncoders) { for (CodecUtils.DeviceEncoder encoder : audioEncoders) {
builder.append("\n --audio-codec=").append(encoder.getCodec().getName()); builder.append("\n --audio-codec=").append(encoder.getCodec().getName());
builder.append(" --audio-encoder='").append(encoder.getInfo().getName()).append("'"); builder.append(" --audio-encoder=").append(encoder.getInfo().getName());
} }
} }
return builder.toString(); return builder.toString();