7984854750
AAPT2 was not erroring on invalid resource ids created in layouts with creation syntax. This change causes this to error suring compile. Bug: 71394154 Test: aapt2_tests Change-Id: Idf16fb4bd011ed2d65e8c48f7cba0429ead5a055
78 lines
2.5 KiB
C++
78 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "compile/XmlIdCollector.h"
|
|
|
|
#include <algorithm>
|
|
|
|
#include "test/Test.h"
|
|
|
|
namespace aapt {
|
|
|
|
TEST(XmlIdCollectorTest, CollectsIds) {
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
|
|
|
std::unique_ptr<xml::XmlResource> doc = test::BuildXmlDom(R"EOF(
|
|
<View xmlns:android="http://schemas.android.com/apk/res/android"
|
|
android:id="@+id/foo"
|
|
text="@+id/bar">
|
|
<SubView android:id="@+id/car"
|
|
class="@+id/bar"/>
|
|
</View>)EOF");
|
|
|
|
XmlIdCollector collector;
|
|
ASSERT_TRUE(collector.Consume(context.get(), doc.get()));
|
|
|
|
EXPECT_EQ(
|
|
1, std::count(doc->file.exported_symbols.begin(),
|
|
doc->file.exported_symbols.end(),
|
|
SourcedResourceName{test::ParseNameOrDie("id/foo"), 3u}));
|
|
|
|
EXPECT_EQ(
|
|
1, std::count(doc->file.exported_symbols.begin(),
|
|
doc->file.exported_symbols.end(),
|
|
SourcedResourceName{test::ParseNameOrDie("id/bar"), 3u}));
|
|
|
|
EXPECT_EQ(
|
|
1, std::count(doc->file.exported_symbols.begin(),
|
|
doc->file.exported_symbols.end(),
|
|
SourcedResourceName{test::ParseNameOrDie("id/car"), 6u}));
|
|
}
|
|
|
|
TEST(XmlIdCollectorTest, DontCollectNonIds) {
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
|
|
|
std::unique_ptr<xml::XmlResource> doc =
|
|
test::BuildXmlDom("<View foo=\"@+string/foo\"/>");
|
|
|
|
XmlIdCollector collector;
|
|
ASSERT_TRUE(collector.Consume(context.get(), doc.get()));
|
|
|
|
EXPECT_TRUE(doc->file.exported_symbols.empty());
|
|
}
|
|
|
|
TEST(XmlIdCollectorTest, ErrorOnInvalidIds) {
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
|
|
|
std::unique_ptr<xml::XmlResource> doc =
|
|
test::BuildXmlDom("<View foo=\"@+id/foo$bar\"/>");
|
|
|
|
XmlIdCollector collector;
|
|
ASSERT_FALSE(collector.Consume(context.get(), doc.get()));
|
|
}
|
|
|
|
} // namespace aapt
|