When closing a namespace a } is sufficient. It doesn't need to be }; like closing a class or enum. Within frameworks/base/libs/hwui there is a mix between } and }; when closing a namespace. There are even mixes between a .h and the corresponding .cpp files. In a separate CL I was asked to not close with };. That was a good comment. I adopted the style from nearby code. This CL cleans up the nearby code. Test: I made sure the code still built as expected. Change-Id: Ieb314a4f48d6e33752463f3be4361fdc9be97482
61 lines
1.6 KiB
C++
61 lines
1.6 KiB
C++
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <utils/Log.h>
|
|
#include <utils/RefBase.h>
|
|
|
|
#include "FrameInfo.h"
|
|
#include "FrameMetricsObserver.h"
|
|
|
|
#include <string.h>
|
|
#include <vector>
|
|
|
|
namespace android {
|
|
namespace uirenderer {
|
|
|
|
class FrameMetricsReporter {
|
|
public:
|
|
FrameMetricsReporter() {}
|
|
|
|
void addObserver(FrameMetricsObserver* observer) { mObservers.push_back(observer); }
|
|
|
|
bool removeObserver(FrameMetricsObserver* observer) {
|
|
for (size_t i = 0; i < mObservers.size(); i++) {
|
|
if (mObservers[i].get() == observer) {
|
|
mObservers.erase(mObservers.begin() + i);
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool hasObservers() { return mObservers.size() > 0; }
|
|
|
|
void reportFrameMetrics(const int64_t* stats) {
|
|
for (size_t i = 0; i < mObservers.size(); i++) {
|
|
mObservers[i]->notify(stats);
|
|
}
|
|
}
|
|
|
|
private:
|
|
std::vector<sp<FrameMetricsObserver> > mObservers;
|
|
};
|
|
|
|
} // namespace uirenderer
|
|
} // namespace android
|