1ab598f46c
An early refactor. Some ideas became clearer as development continued. Now the various phases are much clearer and more easily reusable. Also added a ton of tests! Change-Id: Ic8f0a70c8222370352e63533b329c40457c0903e
113 lines
4.2 KiB
C++
113 lines
4.2 KiB
C++
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "link/TableMerger.h"
|
|
|
|
#include "test/Builders.h"
|
|
#include "test/Context.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace aapt {
|
|
|
|
struct TableMergerTest : public ::testing::Test {
|
|
std::unique_ptr<IAaptContext> mContext;
|
|
|
|
void SetUp() override {
|
|
mContext = test::ContextBuilder()
|
|
// We are compiling this package.
|
|
.setCompilationPackage(u"com.app.a")
|
|
|
|
// Merge all packages that have this package ID.
|
|
.setPackageId(0x7f)
|
|
|
|
// Mangle all packages that do not have this package name.
|
|
.setNameManglerPolicy(NameManglerPolicy{ u"com.app.a", { u"com.app.b" } })
|
|
|
|
.build();
|
|
}
|
|
};
|
|
|
|
TEST_F(TableMergerTest, SimpleMerge) {
|
|
std::unique_ptr<ResourceTable> tableA = test::ResourceTableBuilder()
|
|
.setPackageId(u"com.app.a", 0x7f)
|
|
.addReference(u"@com.app.a:id/foo", u"@com.app.a:id/bar")
|
|
.addReference(u"@com.app.a:id/bar", u"@com.app.b:id/foo")
|
|
.addValue(u"@com.app.a:styleable/view", test::StyleableBuilder()
|
|
.addItem(u"@com.app.b:id/foo")
|
|
.build())
|
|
.build();
|
|
|
|
std::unique_ptr<ResourceTable> tableB = test::ResourceTableBuilder()
|
|
.setPackageId(u"com.app.b", 0x7f)
|
|
.addSimple(u"@com.app.b:id/foo")
|
|
.build();
|
|
|
|
ResourceTable finalTable;
|
|
TableMerger merger(mContext.get(), &finalTable);
|
|
|
|
ASSERT_TRUE(merger.merge({}, tableA.get()));
|
|
ASSERT_TRUE(merger.merge({}, tableB.get()));
|
|
|
|
EXPECT_TRUE(merger.getMergedPackages().count(u"com.app.b") != 0);
|
|
|
|
// Entries from com.app.a should not be mangled.
|
|
AAPT_EXPECT_TRUE(finalTable.findResource(test::parseNameOrDie(u"@com.app.a:id/foo")));
|
|
AAPT_EXPECT_TRUE(finalTable.findResource(test::parseNameOrDie(u"@com.app.a:id/bar")));
|
|
AAPT_EXPECT_TRUE(finalTable.findResource(test::parseNameOrDie(u"@com.app.a:styleable/view")));
|
|
|
|
// The unmangled name should not be present.
|
|
AAPT_EXPECT_FALSE(finalTable.findResource(test::parseNameOrDie(u"@com.app.b:id/foo")));
|
|
|
|
// Look for the mangled name.
|
|
AAPT_EXPECT_TRUE(finalTable.findResource(test::parseNameOrDie(u"@com.app.a:id/com.app.b$foo")));
|
|
}
|
|
|
|
TEST_F(TableMergerTest, MergeFileReferences) {
|
|
std::unique_ptr<ResourceTable> tableA = test::ResourceTableBuilder()
|
|
.setPackageId(u"com.app.a", 0x7f)
|
|
.addFileReference(u"@com.app.a:xml/file", u"res/xml/file.xml")
|
|
.build();
|
|
std::unique_ptr<ResourceTable> tableB = test::ResourceTableBuilder()
|
|
.setPackageId(u"com.app.b", 0x7f)
|
|
.addFileReference(u"@com.app.b:xml/file", u"res/xml/file.xml")
|
|
.build();
|
|
|
|
ResourceTable finalTable;
|
|
TableMerger merger(mContext.get(), &finalTable);
|
|
|
|
ASSERT_TRUE(merger.merge({}, tableA.get()));
|
|
ASSERT_TRUE(merger.merge({}, tableB.get()));
|
|
|
|
FileReference* f = test::getValue<FileReference>(&finalTable, u"@com.app.a:xml/file");
|
|
ASSERT_NE(f, nullptr);
|
|
EXPECT_EQ(std::u16string(u"res/xml/file.xml"), *f->path);
|
|
|
|
f = test::getValue<FileReference>(&finalTable, u"@com.app.a:xml/com.app.b$file");
|
|
ASSERT_NE(f, nullptr);
|
|
EXPECT_EQ(std::u16string(u"res/xml/com.app.b$file.xml"), *f->path);
|
|
|
|
std::queue<FileToMerge>* filesToMerge = merger.getFileMergeQueue();
|
|
ASSERT_FALSE(filesToMerge->empty());
|
|
|
|
FileToMerge& fileToMerge = filesToMerge->front();
|
|
EXPECT_EQ(fileToMerge.srcTable, tableB.get());
|
|
EXPECT_EQ(fileToMerge.srcPath, u"res/xml/file.xml");
|
|
EXPECT_EQ(fileToMerge.dstPath, u"res/xml/com.app.b$file.xml");
|
|
}
|
|
|
|
} // namespace aapt
|