5693cee2f9
A strong pointer to PointerController::DisplayInfoListener is given away when the listener is registered, so PC cannot guarantee that the listener is destroyed when it is destroyed. This means the listener can outlive PC, so there is a race condition between PC's destruction and an update to the listener. While it could be argued that it is the caller's responsibility to ensure that the listener is not updated after it is unregistered, there is no way to guarantee that using strong pointers. Here, we can be defensive and protect against this case. Bug: 212672261 Test: atest libinputservice_test Change-Id: I358a725980cc8c7d6ad0483a9b2a8b8715a03424
291 lines
10 KiB
C++
291 lines
10 KiB
C++
/*
|
|
* Copyright (C) 2019 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "mocks/MockSprite.h"
|
|
#include "mocks/MockSpriteController.h"
|
|
|
|
#include <input/PointerController.h>
|
|
#include <input/SpriteController.h>
|
|
|
|
#include <atomic>
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
#include <thread>
|
|
|
|
namespace android {
|
|
|
|
enum TestCursorType {
|
|
CURSOR_TYPE_DEFAULT = 0,
|
|
CURSOR_TYPE_HOVER,
|
|
CURSOR_TYPE_TOUCH,
|
|
CURSOR_TYPE_ANCHOR,
|
|
CURSOR_TYPE_ADDITIONAL,
|
|
CURSOR_TYPE_ADDITIONAL_ANIM,
|
|
CURSOR_TYPE_CUSTOM = -1,
|
|
};
|
|
|
|
using ::testing::AllOf;
|
|
using ::testing::Field;
|
|
using ::testing::Mock;
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
using ::testing::Test;
|
|
|
|
std::pair<float, float> getHotSpotCoordinatesForType(int32_t type) {
|
|
return std::make_pair(type * 10, type * 10 + 5);
|
|
}
|
|
|
|
class MockPointerControllerPolicyInterface : public PointerControllerPolicyInterface {
|
|
public:
|
|
virtual void loadPointerIcon(SpriteIcon* icon, int32_t displayId) override;
|
|
virtual void loadPointerResources(PointerResources* outResources, int32_t displayId) override;
|
|
virtual void loadAdditionalMouseResources(std::map<int32_t, SpriteIcon>* outResources,
|
|
std::map<int32_t, PointerAnimation>* outAnimationResources, int32_t displayId) override;
|
|
virtual int32_t getDefaultPointerIconId() override;
|
|
virtual int32_t getCustomPointerIconId() override;
|
|
|
|
bool allResourcesAreLoaded();
|
|
bool noResourcesAreLoaded();
|
|
|
|
private:
|
|
void loadPointerIconForType(SpriteIcon* icon, int32_t cursorType);
|
|
|
|
bool pointerIconLoaded{false};
|
|
bool pointerResourcesLoaded{false};
|
|
bool additionalMouseResourcesLoaded{false};
|
|
};
|
|
|
|
void MockPointerControllerPolicyInterface::loadPointerIcon(SpriteIcon* icon, int32_t) {
|
|
loadPointerIconForType(icon, CURSOR_TYPE_DEFAULT);
|
|
pointerIconLoaded = true;
|
|
}
|
|
|
|
void MockPointerControllerPolicyInterface::loadPointerResources(PointerResources* outResources,
|
|
int32_t) {
|
|
loadPointerIconForType(&outResources->spotHover, CURSOR_TYPE_HOVER);
|
|
loadPointerIconForType(&outResources->spotTouch, CURSOR_TYPE_TOUCH);
|
|
loadPointerIconForType(&outResources->spotAnchor, CURSOR_TYPE_ANCHOR);
|
|
pointerResourcesLoaded = true;
|
|
}
|
|
|
|
void MockPointerControllerPolicyInterface::loadAdditionalMouseResources(
|
|
std::map<int32_t, SpriteIcon>* outResources,
|
|
std::map<int32_t, PointerAnimation>* outAnimationResources,
|
|
int32_t) {
|
|
SpriteIcon icon;
|
|
PointerAnimation anim;
|
|
|
|
// CURSOR_TYPE_ADDITIONAL doesn't have animation resource.
|
|
int32_t cursorType = CURSOR_TYPE_ADDITIONAL;
|
|
loadPointerIconForType(&icon, cursorType);
|
|
(*outResources)[cursorType] = icon;
|
|
|
|
// CURSOR_TYPE_ADDITIONAL_ANIM has animation resource.
|
|
cursorType = CURSOR_TYPE_ADDITIONAL_ANIM;
|
|
loadPointerIconForType(&icon, cursorType);
|
|
anim.animationFrames.push_back(icon);
|
|
anim.durationPerFrame = 10;
|
|
(*outResources)[cursorType] = icon;
|
|
(*outAnimationResources)[cursorType] = anim;
|
|
|
|
additionalMouseResourcesLoaded = true;
|
|
}
|
|
|
|
int32_t MockPointerControllerPolicyInterface::getDefaultPointerIconId() {
|
|
return CURSOR_TYPE_DEFAULT;
|
|
}
|
|
|
|
int32_t MockPointerControllerPolicyInterface::getCustomPointerIconId() {
|
|
return CURSOR_TYPE_CUSTOM;
|
|
}
|
|
|
|
bool MockPointerControllerPolicyInterface::allResourcesAreLoaded() {
|
|
return pointerIconLoaded && pointerResourcesLoaded && additionalMouseResourcesLoaded;
|
|
}
|
|
|
|
bool MockPointerControllerPolicyInterface::noResourcesAreLoaded() {
|
|
return !(pointerIconLoaded || pointerResourcesLoaded || additionalMouseResourcesLoaded);
|
|
}
|
|
|
|
void MockPointerControllerPolicyInterface::loadPointerIconForType(SpriteIcon* icon, int32_t type) {
|
|
icon->style = type;
|
|
std::pair<float, float> hotSpot = getHotSpotCoordinatesForType(type);
|
|
icon->hotSpotX = hotSpot.first;
|
|
icon->hotSpotY = hotSpot.second;
|
|
}
|
|
class PointerControllerTest : public Test {
|
|
protected:
|
|
PointerControllerTest();
|
|
~PointerControllerTest();
|
|
|
|
void ensureDisplayViewportIsSet();
|
|
|
|
sp<MockSprite> mPointerSprite;
|
|
sp<MockPointerControllerPolicyInterface> mPolicy;
|
|
sp<MockSpriteController> mSpriteController;
|
|
std::shared_ptr<PointerController> mPointerController;
|
|
|
|
private:
|
|
void loopThread();
|
|
|
|
std::atomic<bool> mRunning = true;
|
|
class MyLooper : public Looper {
|
|
public:
|
|
MyLooper() : Looper(false) {}
|
|
~MyLooper() = default;
|
|
};
|
|
sp<MyLooper> mLooper;
|
|
std::thread mThread;
|
|
};
|
|
|
|
PointerControllerTest::PointerControllerTest() : mPointerSprite(new NiceMock<MockSprite>),
|
|
mLooper(new MyLooper), mThread(&PointerControllerTest::loopThread, this) {
|
|
|
|
mSpriteController = new NiceMock<MockSpriteController>(mLooper);
|
|
mPolicy = new MockPointerControllerPolicyInterface();
|
|
|
|
EXPECT_CALL(*mSpriteController, createSprite())
|
|
.WillOnce(Return(mPointerSprite));
|
|
|
|
mPointerController = PointerController::create(mPolicy, mLooper, mSpriteController);
|
|
}
|
|
|
|
PointerControllerTest::~PointerControllerTest() {
|
|
mRunning.store(false, std::memory_order_relaxed);
|
|
mThread.join();
|
|
}
|
|
|
|
void PointerControllerTest::ensureDisplayViewportIsSet() {
|
|
DisplayViewport viewport;
|
|
viewport.displayId = ADISPLAY_ID_DEFAULT;
|
|
viewport.logicalRight = 1600;
|
|
viewport.logicalBottom = 1200;
|
|
viewport.physicalRight = 800;
|
|
viewport.physicalBottom = 600;
|
|
viewport.deviceWidth = 400;
|
|
viewport.deviceHeight = 300;
|
|
mPointerController->setDisplayViewport(viewport);
|
|
}
|
|
|
|
void PointerControllerTest::loopThread() {
|
|
Looper::setForThread(mLooper);
|
|
|
|
while (mRunning.load(std::memory_order_relaxed)) {
|
|
mLooper->pollOnce(100);
|
|
}
|
|
}
|
|
|
|
TEST_F(PointerControllerTest, useDefaultCursorTypeByDefault) {
|
|
ensureDisplayViewportIsSet();
|
|
mPointerController->unfade(PointerController::Transition::IMMEDIATE);
|
|
|
|
std::pair<float, float> hotspot = getHotSpotCoordinatesForType(CURSOR_TYPE_DEFAULT);
|
|
EXPECT_CALL(*mPointerSprite, setVisible(true));
|
|
EXPECT_CALL(*mPointerSprite, setAlpha(1.0f));
|
|
EXPECT_CALL(*mPointerSprite, setIcon(
|
|
AllOf(
|
|
Field(&SpriteIcon::style, CURSOR_TYPE_DEFAULT),
|
|
Field(&SpriteIcon::hotSpotX, hotspot.first),
|
|
Field(&SpriteIcon::hotSpotY, hotspot.second))));
|
|
mPointerController->reloadPointerResources();
|
|
}
|
|
|
|
TEST_F(PointerControllerTest, updatePointerIcon) {
|
|
ensureDisplayViewportIsSet();
|
|
mPointerController->setPresentation(PointerController::Presentation::POINTER);
|
|
mPointerController->unfade(PointerController::Transition::IMMEDIATE);
|
|
|
|
int32_t type = CURSOR_TYPE_ADDITIONAL;
|
|
std::pair<float, float> hotspot = getHotSpotCoordinatesForType(type);
|
|
EXPECT_CALL(*mPointerSprite, setVisible(true));
|
|
EXPECT_CALL(*mPointerSprite, setAlpha(1.0f));
|
|
EXPECT_CALL(*mPointerSprite, setIcon(
|
|
AllOf(
|
|
Field(&SpriteIcon::style, type),
|
|
Field(&SpriteIcon::hotSpotX, hotspot.first),
|
|
Field(&SpriteIcon::hotSpotY, hotspot.second))));
|
|
mPointerController->updatePointerIcon(type);
|
|
}
|
|
|
|
TEST_F(PointerControllerTest, setCustomPointerIcon) {
|
|
ensureDisplayViewportIsSet();
|
|
mPointerController->unfade(PointerController::Transition::IMMEDIATE);
|
|
|
|
int32_t style = CURSOR_TYPE_CUSTOM;
|
|
float hotSpotX = 15;
|
|
float hotSpotY = 20;
|
|
|
|
SpriteIcon icon;
|
|
icon.style = style;
|
|
icon.hotSpotX = hotSpotX;
|
|
icon.hotSpotY = hotSpotY;
|
|
|
|
EXPECT_CALL(*mPointerSprite, setVisible(true));
|
|
EXPECT_CALL(*mPointerSprite, setAlpha(1.0f));
|
|
EXPECT_CALL(*mPointerSprite, setIcon(
|
|
AllOf(
|
|
Field(&SpriteIcon::style, style),
|
|
Field(&SpriteIcon::hotSpotX, hotSpotX),
|
|
Field(&SpriteIcon::hotSpotY, hotSpotY))));
|
|
mPointerController->setCustomPointerIcon(icon);
|
|
}
|
|
|
|
TEST_F(PointerControllerTest, doesNotGetResourcesBeforeSettingViewport) {
|
|
mPointerController->setPresentation(PointerController::Presentation::POINTER);
|
|
mPointerController->setPosition(1.0f, 1.0f);
|
|
mPointerController->move(1.0f, 1.0f);
|
|
mPointerController->unfade(PointerController::Transition::IMMEDIATE);
|
|
mPointerController->fade(PointerController::Transition::IMMEDIATE);
|
|
|
|
EXPECT_TRUE(mPolicy->noResourcesAreLoaded());
|
|
|
|
ensureDisplayViewportIsSet();
|
|
}
|
|
|
|
class PointerControllerWindowInfoListenerTest : public Test {};
|
|
|
|
class TestPointerController : public PointerController {
|
|
public:
|
|
TestPointerController(sp<android::gui::WindowInfosListener>& registeredListener,
|
|
const sp<Looper>& looper)
|
|
: PointerController(
|
|
new MockPointerControllerPolicyInterface(), looper,
|
|
new NiceMock<MockSpriteController>(looper),
|
|
[®isteredListener](const sp<android::gui::WindowInfosListener>& listener) {
|
|
// Register listener
|
|
registeredListener = listener;
|
|
},
|
|
[®isteredListener](const sp<android::gui::WindowInfosListener>& listener) {
|
|
// Unregister listener
|
|
if (registeredListener == listener) registeredListener = nullptr;
|
|
}) {}
|
|
};
|
|
|
|
TEST_F(PointerControllerWindowInfoListenerTest,
|
|
doesNotCrashIfListenerCalledAfterPointerControllerDestroyed) {
|
|
sp<android::gui::WindowInfosListener> registeredListener;
|
|
sp<android::gui::WindowInfosListener> localListenerCopy;
|
|
{
|
|
TestPointerController pointerController(registeredListener, new Looper(false));
|
|
ASSERT_NE(nullptr, registeredListener) << "WindowInfosListener was not registered";
|
|
localListenerCopy = registeredListener;
|
|
}
|
|
EXPECT_EQ(nullptr, registeredListener) << "WindowInfosListener was not unregistered";
|
|
localListenerCopy->onWindowInfosChanged({}, {});
|
|
}
|
|
|
|
} // namespace android
|