3edd472643
When generating multiple APKs from a configuration file, check to see if we have filtered resource by minSdkVersion and update the manifest to reflect this. We only want to inflate and modify the manifest file if there is an update to be applied. Bug: 37944703 Bug: 67005138 Test: Ran unit tests Test: Manually split an APK and verified the manifest by dumping with AAPT (both xmltree and badging). Change-Id: I64a0e4889d7d9e57373369b044a091287b06cc35
174 lines
6.1 KiB
C++
174 lines
6.1 KiB
C++
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include "LoadedApk.h"
|
|
|
|
#include "ResourceValues.h"
|
|
#include "ValueVisitor.h"
|
|
#include "flatten/Archive.h"
|
|
#include "flatten/TableFlattener.h"
|
|
#include "flatten/XmlFlattener.h"
|
|
#include "io/BigBufferInputStream.h"
|
|
#include "io/Util.h"
|
|
#include "xml/XmlDom.h"
|
|
|
|
namespace aapt {
|
|
|
|
using xml::XmlResource;
|
|
|
|
std::unique_ptr<LoadedApk> LoadedApk::LoadApkFromPath(IAaptContext* context,
|
|
const android::StringPiece& path) {
|
|
Source source(path);
|
|
std::string error;
|
|
std::unique_ptr<io::ZipFileCollection> apk = io::ZipFileCollection::Create(path, &error);
|
|
if (!apk) {
|
|
context->GetDiagnostics()->Error(DiagMessage(source) << error);
|
|
return {};
|
|
}
|
|
|
|
io::IFile* file = apk->FindFile("resources.arsc");
|
|
if (!file) {
|
|
context->GetDiagnostics()->Error(DiagMessage(source) << "no resources.arsc found");
|
|
return {};
|
|
}
|
|
|
|
std::unique_ptr<io::IData> data = file->OpenAsData();
|
|
if (!data) {
|
|
context->GetDiagnostics()->Error(DiagMessage(source) << "could not open resources.arsc");
|
|
return {};
|
|
}
|
|
|
|
std::unique_ptr<ResourceTable> table = util::make_unique<ResourceTable>();
|
|
BinaryResourceParser parser(context, table.get(), source, data->data(), data->size(), apk.get());
|
|
if (!parser.Parse()) {
|
|
return {};
|
|
}
|
|
|
|
return util::make_unique<LoadedApk>(source, std::move(apk), std::move(table));
|
|
}
|
|
|
|
bool LoadedApk::WriteToArchive(IAaptContext* context, const TableFlattenerOptions& options,
|
|
IArchiveWriter* writer) {
|
|
FilterChain empty;
|
|
return WriteToArchive(context, table_.get(), options, &empty, writer);
|
|
}
|
|
|
|
bool LoadedApk::WriteToArchive(IAaptContext* context, ResourceTable* split_table,
|
|
const TableFlattenerOptions& options, FilterChain* filters,
|
|
IArchiveWriter* writer, XmlResource* manifest) {
|
|
std::set<std::string> referenced_resources;
|
|
// List the files being referenced in the resource table.
|
|
for (auto& pkg : split_table->packages) {
|
|
for (auto& type : pkg->types) {
|
|
for (auto& entry : type->entries) {
|
|
for (auto& config_value : entry->values) {
|
|
FileReference* file_ref = ValueCast<FileReference>(config_value->value.get());
|
|
if (file_ref) {
|
|
referenced_resources.insert(*file_ref->path);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<io::IFileCollectionIterator> iterator = apk_->Iterator();
|
|
while (iterator->HasNext()) {
|
|
io::IFile* file = iterator->Next();
|
|
|
|
std::string path = file->GetSource().path;
|
|
// The name of the path has the format "<zip-file-name>@<path-to-file>".
|
|
path = path.substr(path.find('@') + 1);
|
|
|
|
// Skip resources that are not referenced if requested.
|
|
if (path.find("res/") == 0 && referenced_resources.find(path) == referenced_resources.end()) {
|
|
if (context->IsVerbose()) {
|
|
context->GetDiagnostics()->Note(DiagMessage()
|
|
<< "Removing resource '" << path << "' from APK.");
|
|
}
|
|
continue;
|
|
}
|
|
|
|
if (!filters->Keep(path)) {
|
|
if (context->IsVerbose()) {
|
|
context->GetDiagnostics()->Note(DiagMessage() << "Filtered '" << path << "' from APK.");
|
|
}
|
|
continue;
|
|
}
|
|
|
|
// The resource table needs to be re-serialized since it might have changed.
|
|
if (path == "resources.arsc") {
|
|
BigBuffer buffer(4096);
|
|
// TODO(adamlesinski): How to determine if there were sparse entries (and if to encode
|
|
// with sparse entries) b/35389232.
|
|
TableFlattener flattener(options, &buffer);
|
|
if (!flattener.Consume(context, split_table)) {
|
|
return false;
|
|
}
|
|
|
|
io::BigBufferInputStream input_stream(&buffer);
|
|
if (!io::CopyInputStreamToArchive(context, &input_stream, path, ArchiveEntry::kAlign,
|
|
writer)) {
|
|
return false;
|
|
}
|
|
|
|
} else if (manifest != nullptr && path == "AndroidManifest.xml") {
|
|
BigBuffer buffer(8192);
|
|
XmlFlattener xml_flattener(&buffer, {});
|
|
if (!xml_flattener.Consume(context, manifest)) {
|
|
context->GetDiagnostics()->Error(DiagMessage(path) << "flattening failed");
|
|
return false;
|
|
}
|
|
|
|
uint32_t compression_flags = file->WasCompressed() ? ArchiveEntry::kCompress : 0u;
|
|
io::BigBufferInputStream manifest_buffer_in(&buffer);
|
|
if (!io::CopyInputStreamToArchive(context, &manifest_buffer_in, path, compression_flags,
|
|
writer)) {
|
|
return false;
|
|
}
|
|
} else {
|
|
uint32_t compression_flags = file->WasCompressed() ? ArchiveEntry::kCompress : 0u;
|
|
if (!io::CopyFileToArchive(context, file, path, compression_flags, writer)) {
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
std::unique_ptr<xml::XmlResource> LoadedApk::InflateManifest(IAaptContext* context) {
|
|
IDiagnostics* diag = context->GetDiagnostics();
|
|
|
|
io::IFile* manifest_file = GetFileCollection()->FindFile("AndroidManifest.xml");
|
|
if (manifest_file == nullptr) {
|
|
diag->Error(DiagMessage(source_) << "no AndroidManifest.xml found");
|
|
return {};
|
|
}
|
|
|
|
std::unique_ptr<io::IData> manifest_data = manifest_file->OpenAsData();
|
|
if (manifest_data == nullptr) {
|
|
diag->Error(DiagMessage(manifest_file->GetSource()) << "could not open AndroidManifest.xml");
|
|
return {};
|
|
}
|
|
|
|
std::unique_ptr<xml::XmlResource> manifest =
|
|
xml::Inflate(manifest_data->data(), manifest_data->size(), diag, manifest_file->GetSource());
|
|
if (manifest == nullptr) {
|
|
diag->Error(DiagMessage() << "failed to read binary AndroidManifest.xml");
|
|
}
|
|
return manifest;
|
|
}
|
|
} // namespace aapt
|