drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
android_frameworks_base/libs/hwui
History
John Reck f3ad324a8d Aggressively unbind GL_PIXEL_UNPACK_BUFFER 
Bug: 27186019

Theory: It appears to be possible for FontRenderer
to not unbind its PBO prior to textures being uploaded,
resulting in trying to glSubTexImage2D with a bound
GL_PIXEL_UNPACK_BUFFER. In that scenario the void* is
the offset into the PBO which given a non-null data
will almost certainly overrun the end of the buffer. This
in turn produces a GL_INVALID_OPERATION error.

Change PixelBuffer to avoid leaking this state for now.
This will result in more calls to glBindBuffer/glUnbindBuffer
in the worst case, but the worst case is already bad so this
shouldn't be a problem. In the normal case we avoid binding
the PBO at all ever, so this doesn't impact that.

Change-Id: I05473f0d2f9a3a5da0e33d8f9ddea4731ce970e3
2016-02-24 15:40:05 -08:00
..
debug
Add fine-grained debug layer
2016-01-25 16:15:14 -08:00
font
Clean up some Skia includes
2016-02-16 16:32:13 +00:00
protos
Serializing display lists
2015-08-26 16:29:15 -07:00
renderstate
Fix copyLayerInto
2016-01-29 14:53:45 -08:00
renderthread
allow for slow FrameMetricsListeners
2016-02-17 12:16:06 -08:00
tests
Merge "Fix drawColor/drawPaint bounds" into nyc-dev
2016-02-23 23:33:53 +00:00
thread
Revert "Revert "TaskManager bench""
2016-02-08 23:28:28 +00:00
utils
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
AmbientShadow.cpp
Remove MathUtils::min/max
2015-08-19 15:53:01 -07:00
AmbientShadow.h
…
Android.mk
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
AnimationContext.cpp
…
AnimationContext.h
…
Animator.cpp
Ensure animator's interpolator is set
2016-02-19 17:19:24 -08:00
Animator.h
Revert "Revert "Check RenderNode's owning view before attaching animators""
2016-02-19 13:52:41 -08:00
AnimatorManager.cpp
Revert "Revert "Check RenderNode's owning view before attaching animators""
2016-02-19 13:52:41 -08:00
AnimatorManager.h
Revert "Revert "Check RenderNode's owning view before attaching animators""
2016-02-19 13:52:41 -08:00
AssetAtlas.cpp
Track texture memory globally
2016-01-14 13:42:12 -08:00
AssetAtlas.h
Track texture memory globally
2016-01-14 13:42:12 -08:00
BakedOpDispatcher.cpp
Fix positioning in path fallback case
2016-02-22 16:42:24 -08:00
BakedOpDispatcher.h
Rework op macros
2016-01-06 14:04:22 -08:00
BakedOpRenderer.cpp
Fix copyLayerInto
2016-01-29 14:53:45 -08:00
BakedOpRenderer.h
Early kickoff of shadow tasks
2016-02-02 17:10:25 -08:00
BakedOpState.cpp
Early kickoff of shadow tasks
2016-02-02 17:10:25 -08:00
BakedOpState.h
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
Caches.cpp
resolve merge conflicts of f1df0f59c1 to master.
2015-12-11 14:47:40 -08:00
Caches.h
Remove almost-all android::Singleton users
2015-11-03 10:09:59 -08:00
Canvas.cpp
Update Canvas API with view system calls.
2016-02-03 09:13:04 -05:00
Canvas.h
Revert "Revert "VectorDrawable native rendering - Step 4 of MANY""
2016-02-04 16:29:51 -08:00
CanvasProperty.h
…
CanvasState.cpp
Add internal Canvas save flags
2016-01-25 15:48:00 -05:00
CanvasState.h
Stencil support in new recorder/reorderer
2016-01-04 17:00:03 -08:00
ClipArea.cpp
Fix build
2016-02-09 16:32:49 -08:00
ClipArea.h
Stencil support in new recorder/reorderer
2016-01-04 17:00:03 -08:00
DamageAccumulator.cpp
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
DamageAccumulator.h
Have RT drive window positioning
2016-02-04 11:23:49 -08:00
Debug.h
Add fine-grained debug layer
2016-01-25 16:15:14 -08:00
DeferredDisplayList.cpp
Add internal Canvas save flags
2016-01-25 15:48:00 -05:00
DeferredDisplayList.h
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
DeferredLayerUpdater.cpp
Add TextureView support to new renderer/reorderer
2015-12-16 15:35:40 -08:00
DeferredLayerUpdater.h
Add TextureView support to new renderer/reorderer
2015-12-16 15:35:40 -08:00
DeviceInfo.cpp
Add temporary layer alpha fallback to OpReorderer
2015-11-17 14:50:49 -08:00
DeviceInfo.h
add DeviceInfo
2015-11-05 10:13:23 -08:00
DisplayList.cpp
Use LinearStdAllocator in DisplayList
2015-10-19 11:32:28 -07:00
DisplayList.h
Support projection in OpReorderer
2015-11-25 14:09:24 -08:00
DisplayListCanvas.cpp
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
DisplayListCanvas.h
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
DisplayListOp.h
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
Dither.cpp
Normalize GL_UNPACK_ALIGNMENT
2016-01-20 13:16:24 -08:00
Dither.h
…
Extensions.cpp
Extensions must load in ctor
2015-11-16 10:42:36 -08:00
Extensions.h
Extensions must load in ctor
2015-11-16 10:42:36 -08:00
FboCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
FboCache.h
…
FloatColor.h
…
FontRenderer.cpp
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
FontRenderer.h
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
FrameBuilder.cpp
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
FrameBuilder.h
Merge "Early kickoff of shadow tasks"
2016-02-03 01:17:37 +00:00
FrameInfo.cpp
Adjust for pipeline stalls
2015-07-06 16:12:46 -07:00
FrameInfo.h
expose hwui frame stats through FrameStatsObserver
2016-01-22 12:58:51 -08:00
FrameInfoVisualizer.cpp
Add ListView rendering benchmark
2015-12-02 15:20:26 -08:00
FrameInfoVisualizer.h
Adjust for pipeline stalls
2015-07-06 16:12:46 -07:00
FrameMetricsObserver.h
allow for slow FrameMetricsListeners
2016-02-17 12:16:06 -08:00
FrameMetricsReporter.h
allow for slow FrameMetricsListeners
2016-02-17 12:16:06 -08:00
GammaFontRenderer.cpp
Fix memory leak in HWUI
2015-12-11 16:05:10 +09:00
GammaFontRenderer.h
Fix memory leak
2015-12-11 14:55:22 -08:00
Glop.h
Stencil support in new recorder/reorderer
2016-01-04 17:00:03 -08:00
GlopBuilder.cpp
Support for stencil clipping in layers
2016-01-05 10:18:35 -08:00
GlopBuilder.h
Add bitmapmesh, rect, and patch rendering
2015-12-09 16:06:09 -08:00
GpuMemoryTracker.cpp
Track texture memory globally
2016-01-14 13:42:12 -08:00
GpuMemoryTracker.h
Track texture memory globally
2016-01-14 13:42:12 -08:00
GradientCache.cpp
Fix build
2016-02-11 14:35:08 -08:00
GradientCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
hwui_static_deps.mk
Update HWUI makefiles to support use by other targets (e.g. Skia)
2016-02-11 16:23:19 -05:00
IContextFactory.h
…
Image.cpp
Clean up unncessary defines
2015-07-14 13:25:38 -07:00
Image.h
…
Interpolator.cpp
Remove MathUtils::min/max
2015-08-19 15:53:01 -07:00
Interpolator.h
…
JankTracker.cpp
Add some options to macrobench
2015-12-16 16:40:02 -08:00
JankTracker.h
…
Layer.cpp
Normalize GL_UNPACK_ALIGNMENT
2016-01-20 13:16:24 -08:00
Layer.h
Track texture memory globally
2016-01-14 13:42:12 -08:00
LayerBuilder.cpp
Add create_trivial_array
2016-02-19 15:51:02 -08:00
LayerBuilder.h
Rename Reorderers to Builders
2016-01-12 14:45:08 -08:00
LayerCache.cpp
Track texture memory globally
2016-01-14 13:42:12 -08:00
LayerCache.h
Remove the rest of utils/Vector.h usage
2015-07-30 09:51:57 -07:00
LayerRenderer.cpp
Fix copyLayerInto
2016-01-29 14:53:45 -08:00
LayerRenderer.h
Add TextureView support to new renderer/reorderer
2015-12-16 15:35:40 -08:00
LayerUpdateQueue.cpp
Initial HW layer support in new reorderer/renderer
2015-11-02 12:59:38 -08:00
LayerUpdateQueue.h
Fix deep copy of entry queue
2016-01-11 19:28:19 -08:00
Matrix.cpp
Remove Matrix4::load(Matrix4&)
2015-08-19 15:10:25 -07:00
Matrix.h
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
MODULE_LICENSE_APACHE2
…
NOTICE
…
OpDumper.cpp
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
OpDumper.h
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
OpenGLRenderer.cpp
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
OpenGLRenderer.h
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
Outline.h
Serializing display lists
2015-08-26 16:29:15 -07:00
Patch.cpp
Remove MathUtils::min/max
2015-08-19 15:53:01 -07:00
Patch.h
Replace most usages of utils/Vector.h
2015-07-30 09:51:52 -07:00
PatchCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
PatchCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
PathCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
PathCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
PathParser.cpp
VectorDrawable native rendering - Step 2 of MANY
2015-11-18 13:38:23 -08:00
PathParser.h
VectorDrawable native rendering - Step 3 of MANY
2015-12-28 16:08:38 -08:00
PathTessellator.cpp
Merged op dispatch in OpReorderer
2015-12-07 12:34:46 -08:00
PathTessellator.h
Remove MathUtils::min/max
2015-08-19 15:53:01 -07:00
PixelBuffer.cpp
Aggressively unbind GL_PIXEL_UNPACK_BUFFER
2016-02-24 15:40:05 -08:00
PixelBuffer.h
Aggressively unbind GL_PIXEL_UNPACK_BUFFER
2016-02-24 15:40:05 -08:00
Program.cpp
Clean up unncessary defines
2015-07-14 13:25:38 -07:00
Program.h
Remove shader based gamma approach
2015-09-22 11:58:32 -07:00
ProgramCache.cpp
Remove shader based gamma approach
2015-09-22 11:58:32 -07:00
ProgramCache.h
…
Properties.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
Properties.h
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
PropertyValuesAnimatorSet.cpp
VectorDrawable native rendering - Step 5 of MANY
2016-02-19 13:51:31 -08:00
PropertyValuesAnimatorSet.h
VectorDrawable native rendering - Step 5 of MANY
2016-02-19 13:51:31 -08:00
PropertyValuesHolder.cpp
Revert "Revert "VectorDrawable native rendering - Step 4 of MANY""
2016-02-04 16:29:51 -08:00
PropertyValuesHolder.h
Revert "Revert "VectorDrawable native rendering - Step 4 of MANY""
2016-02-04 16:29:51 -08:00
RecordedOp.h
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
RecordingCanvas.cpp
Merge "Fix drawColor/drawPaint bounds" into nyc-dev
2016-02-23 23:33:53 +00:00
RecordingCanvas.h
Fix all LA memory leaks forever!
2016-02-11 00:42:23 +00:00
Rect.h
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
RenderBuffer.h
…
RenderBufferCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
RenderBufferCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
RenderNode.cpp
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
RenderNode.h
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
RenderProperties.cpp
Support op dumping in new pipeline
2016-02-23 18:52:54 +00:00
RenderProperties.h
Add temporary layer alpha fallback to OpReorderer
2015-11-17 14:50:49 -08:00
ResourceCache.cpp
Clean up unncessary defines
2015-07-14 13:25:38 -07:00
ResourceCache.h
…
RevealClip.h
Serializing display lists
2015-08-26 16:29:15 -07:00
ShadowTessellator.cpp
When the incoming light source is invalid, don't generate any shadow
2015-11-05 15:48:35 -08:00
ShadowTessellator.h
…
SkiaCanvas.cpp
Revert "Revert "VectorDrawable native rendering - Step 4 of MANY""
2016-02-04 16:29:51 -08:00
SkiaCanvasProxy.cpp
Add internal Canvas save flags
2016-01-25 15:48:00 -05:00
SkiaCanvasProxy.h
Override getSaveLayerStrategy instead of willSaveLayer
2016-01-12 18:20:38 +00:00
SkiaShader.cpp
Track texture memory globally
2016-01-14 13:42:12 -08:00
SkiaShader.h
…
Snapshot.cpp
Add internal Canvas save flags
2016-01-25 15:48:00 -05:00
Snapshot.h
Add create_trivial_array
2016-02-19 15:51:02 -08:00
SpotShadow.cpp
Merge "Fix memory corruption in SpotShadow" am: 8c85c00b5e am: 8c8353a8c3
2015-11-11 18:17:25 +00:00
SpotShadow.h
…
TessellationCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
TessellationCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
TextDropShadowCache.cpp
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
TextDropShadowCache.h
Fix TextDropShadowCacheTests and glyph_t everywhere
2016-02-08 22:45:22 +00:00
Texture.cpp
Fix bytesPerPixel for SurfaceTexture
2016-02-12 08:08:29 -08:00
Texture.h
Fix mismatch in assumed defaults vs. actual defaults
2016-01-22 11:10:32 -08:00
TextureCache.cpp
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
TextureCache.h
Move several property queries to Properties class
2016-02-05 17:38:22 -08:00
TreeInfo.h
Have RT drive window positioning
2016-02-04 11:23:49 -08:00
UvMapper.h
…
Vector.h
Add ShadowBench
2015-10-22 17:13:07 -07:00
VectorDrawable.cpp
Ref count the nodes in VectorDrawable
2016-02-05 11:12:25 -08:00
VectorDrawable.h
Ref count the nodes in VectorDrawable
2016-02-05 11:12:25 -08:00
Vertex.h
Replace most usages of utils/Vector.h
2015-07-30 09:51:52 -07:00
VertexBuffer.h
Merged op dispatch in OpReorderer
2015-12-07 12:34:46 -08:00