My code https://googleplex-android-review.git.corp.google.com/q/topic:%223rd-incall%22+(status:open%20OR%20status:merged), which is adding a proto enum for a new AppOps, is causing presubmit failure (https://android-build.googleplex.com/builds/tests/view?invocationId=I62800006309385464&redirect=http%3A%2F%2Fsponge2%2F8a607de5-e0c3-4349-b3c4-0ee397685e18&testResultId=TR55614315792892488). I cannot check in my code because of this failure. To solve this failure, one of the next step is: adding AppOps 100-102 there Test: Treehugger Bug: 169595473 Change-Id: Ibd0f85575c9bc3d7aca9d5b011f1e5f0cbf960c1 Merged-In: Ibd0f85575c9bc3d7aca9d5b011f1e5f0cbf960c1 (cherry picked from commit 503ee6ad3be976c3a436a783cb4ee65169d92c16)
Conventions for the protos in this directory:
-
As in the rest of Android, use 4 spaces to indent instead of 2.
-
For protos based on Java files, use the same package as the Java file. For example,
com.android.server.thing
instead ofcom.android.server.thing.proto
. -
If the proto describes the top level output of dumpsys, it should contain
Dump
. This makes it easy to understand that the proto is the dumpsys output of a certain service, not the data structure of that service, e.g.WindowManagerServiceDumpProto
vsWindowManagerServiceProto
.- Inner messages whose containing messages have the
Proto
suffix do not need to have aProto
suffix. E.g:
- Inner messages whose containing messages have the
message FooProto {
message Bar {
...
}
}
vs
message FooProto {
message BarProto {
...
}
}
-
If the proto represents the structure of an object, it should have
Proto
as its suffix. Please also include the full package path of the original object as a comment to the proto message. -
Include units in the field names. For example,
screen_time_ms
vsscreen_time
, orfile_size_bytes
orfile_size_mebibytes
vsfile_size
. -
Leave field numbers 50,000 - 100,000 reserved for OEMs.