9302c8796f
This change moves the cached window and application input state into the handle objects themselves. It simplifies the dispatcher somewhat because it no longer needs to fix up references to transient InputWindow objects each time the window list is updated. This change will also make it easier to optimize setInputWindows to avoid doing a lot of redundant data copying. In principle, only the modified fields need to be updated. However, for now we continue to update all fields in unison as before. It turns out that the input dispatcher was inappropriately retaining pointers to InputWindow objects within the mWindows InputWindow vector. This vector is copy-on-write so it is possible and the item pointers to change if an editing operation is performed on the vector when it does not exclusively own the underlying SharedBuffer. This bug was uncovered by a previous change that replaced calls to clear() and appendVector() with a simple use of operator= which caused the buffer to be shared. Consequently after editItemAt was called (which it shouldn't have, actually) the buffer was copied and the cached InputWindow pointers became invalid. Oops. This change fixes the problem. Change-Id: I0a259339a6015fcf9113dc4081a6875e047fd425
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
/*
|
|
* Copyright (C) 2011 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#define LOG_TAG "InputWindow"
|
|
|
|
#include "InputWindow.h"
|
|
|
|
#include <cutils/log.h>
|
|
|
|
namespace android {
|
|
|
|
// --- InputWindowHandle ---
|
|
|
|
bool InputWindowHandle::touchableRegionContainsPoint(int32_t x, int32_t y) const {
|
|
return touchableRegion.contains(x, y);
|
|
}
|
|
|
|
bool InputWindowHandle::frameContainsPoint(int32_t x, int32_t y) const {
|
|
return x >= frameLeft && x <= frameRight
|
|
&& y >= frameTop && y <= frameBottom;
|
|
}
|
|
|
|
bool InputWindowHandle::isTrustedOverlay() const {
|
|
return layoutParamsType == TYPE_INPUT_METHOD
|
|
|| layoutParamsType == TYPE_INPUT_METHOD_DIALOG
|
|
|| layoutParamsType == TYPE_SECURE_SYSTEM_OVERLAY;
|
|
}
|
|
|
|
bool InputWindowHandle::supportsSplitTouch() const {
|
|
return layoutParamsFlags & FLAG_SPLIT_TOUCH;
|
|
}
|
|
|
|
} // namespace android
|