52b9862f87
As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change is automatically generated by a script that identifies relevant "include" directives. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Merged-In: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813 Change-Id: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
These benchmarks use the Caliper benchmark framework, and can be run on a remote device using Vogar: http://code.google.com/p/caliper/ http://code.google.com/p/vogar/ ------------------------- Quick Command Line Reference: # Build vogar and dependencies. $> mmma -j32 external/vogar # First make sure art has permissions to dalvik-cache, otherwise it will run slower with interpreter. $> adb root # Run vogar in benchmark mode, telling it to use app_process (not dalvikvm which is default) # Otherwise you will likely crash with UnsatisfiedLinkError despite having correct JNI code. $> vogar --mode app_process --benchmark path/to/Benchmark.java # Sometimes your benchmarks might time out, if so increase the timeout: # (--timeout goes to vogar, and --time-limit goes to caliper) $> vogar --timeout 1000 --mode app_process --benchmark path/to/Benchmark -- --time-limit 9999s