/* * Copyright (C) 2019 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ #define LOG_TAG "IncrementalService" #include "IncrementalService.h" #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "Metadata.pb.h" using namespace std::literals; using namespace android::content::pm; namespace fs = std::filesystem; constexpr const char* kDataUsageStats = "android.permission.LOADER_USAGE_STATS"; constexpr const char* kOpUsage = "android:loader_usage_stats"; namespace android::incremental { namespace { using IncrementalFileSystemControlParcel = ::android::os::incremental::IncrementalFileSystemControlParcel; struct Constants { static constexpr auto backing = "backing_store"sv; static constexpr auto mount = "mount"sv; static constexpr auto mountKeyPrefix = "MT_"sv; static constexpr auto storagePrefix = "st"sv; static constexpr auto mountpointMdPrefix = ".mountpoint."sv; static constexpr auto infoMdName = ".info"sv; static constexpr auto libDir = "lib"sv; static constexpr auto libSuffix = ".so"sv; static constexpr auto blockSize = 4096; }; static const Constants& constants() { static constexpr Constants c; return c; } template bool mkdirOrLog(std::string_view name, int mode = 0770, bool allowExisting = true) { auto cstr = path::c_str(name); if (::mkdir(cstr, mode)) { if (!allowExisting || errno != EEXIST) { PLOG(level) << "Can't create directory '" << name << '\''; return false; } struct stat st; if (::stat(cstr, &st) || !S_ISDIR(st.st_mode)) { PLOG(level) << "Path exists but is not a directory: '" << name << '\''; return false; } } if (::chmod(cstr, mode)) { PLOG(level) << "Changing permission failed for '" << name << '\''; return false; } return true; } static std::string toMountKey(std::string_view path) { if (path.empty()) { return "@none"; } if (path == "/"sv) { return "@root"; } if (path::isAbsolute(path)) { path.remove_prefix(1); } std::string res(path); std::replace(res.begin(), res.end(), '/', '_'); std::replace(res.begin(), res.end(), '@', '_'); return std::string(constants().mountKeyPrefix) + res; } static std::pair makeMountDir(std::string_view incrementalDir, std::string_view path) { auto mountKey = toMountKey(path); const auto prefixSize = mountKey.size(); for (int counter = 0; counter < 1000; mountKey.resize(prefixSize), base::StringAppendF(&mountKey, "%d", counter++)) { auto mountRoot = path::join(incrementalDir, mountKey); if (mkdirOrLog(mountRoot, 0777, false)) { return {mountKey, mountRoot}; } } return {}; } template static ProtoMessage parseFromIncfs(const IncFsWrapper* incfs, Control&& control, std::string_view path) { auto md = incfs->getMetadata(control, path); ProtoMessage message; return message.ParseFromArray(md.data(), md.size()) ? message : ProtoMessage{}; } static bool isValidMountTarget(std::string_view path) { return path::isAbsolute(path) && path::isEmptyDir(path).value_or(true); } std::string makeBindMdName() { static constexpr auto uuidStringSize = 36; uuid_t guid; uuid_generate(guid); std::string name; const auto prefixSize = constants().mountpointMdPrefix.size(); name.reserve(prefixSize + uuidStringSize); name = constants().mountpointMdPrefix; name.resize(prefixSize + uuidStringSize); uuid_unparse(guid, name.data() + prefixSize); return name; } } // namespace const bool IncrementalService::sEnablePerfLogging = android::base::GetBoolProperty("incremental.perflogging", false); IncrementalService::IncFsMount::~IncFsMount() { if (dataLoaderStub) { dataLoaderStub->destroy(); } LOG(INFO) << "Unmounting and cleaning up mount " << mountId << " with root '" << root << '\''; for (auto&& [target, _] : bindPoints) { LOG(INFO) << "\tbind: " << target; incrementalService.mVold->unmountIncFs(target); } LOG(INFO) << "\troot: " << root; incrementalService.mVold->unmountIncFs(path::join(root, constants().mount)); cleanupFilesystem(root); } auto IncrementalService::IncFsMount::makeStorage(StorageId id) -> StorageMap::iterator { std::string name; for (int no = nextStorageDirNo.fetch_add(1, std::memory_order_relaxed), i = 0; i < 1024 && no >= 0; no = nextStorageDirNo.fetch_add(1, std::memory_order_relaxed), ++i) { name.clear(); base::StringAppendF(&name, "%.*s_%d_%d", int(constants().storagePrefix.size()), constants().storagePrefix.data(), id, no); auto fullName = path::join(root, constants().mount, name); if (auto err = incrementalService.mIncFs->makeDir(control, fullName, 0755); !err) { std::lock_guard l(lock); return storages.insert_or_assign(id, Storage{std::move(fullName)}).first; } else if (err != EEXIST) { LOG(ERROR) << __func__ << "(): failed to create dir |" << fullName << "| " << err; break; } } nextStorageDirNo = 0; return storages.end(); } static std::unique_ptr openDir(const char* path) { return {::opendir(path), ::closedir}; } static int rmDirContent(const char* path) { auto dir = openDir(path); if (!dir) { return -EINVAL; } while (auto entry = ::readdir(dir.get())) { if (entry->d_name == "."sv || entry->d_name == ".."sv) { continue; } auto fullPath = android::base::StringPrintf("%s/%s", path, entry->d_name); if (entry->d_type == DT_DIR) { if (const auto err = rmDirContent(fullPath.c_str()); err != 0) { PLOG(WARNING) << "Failed to delete " << fullPath << " content"; return err; } if (const auto err = ::rmdir(fullPath.c_str()); err != 0) { PLOG(WARNING) << "Failed to rmdir " << fullPath; return err; } } else { if (const auto err = ::unlink(fullPath.c_str()); err != 0) { PLOG(WARNING) << "Failed to delete " << fullPath; return err; } } } return 0; } void IncrementalService::IncFsMount::cleanupFilesystem(std::string_view root) { rmDirContent(path::join(root, constants().backing).c_str()); ::rmdir(path::join(root, constants().backing).c_str()); ::rmdir(path::join(root, constants().mount).c_str()); ::rmdir(path::c_str(root)); } IncrementalService::IncrementalService(ServiceManagerWrapper&& sm, std::string_view rootDir) : mVold(sm.getVoldService()), mDataLoaderManager(sm.getDataLoaderManager()), mIncFs(sm.getIncFs()), mAppOpsManager(sm.getAppOpsManager()), mJni(sm.getJni()), mIncrementalDir(rootDir) { if (!mVold) { LOG(FATAL) << "Vold service is unavailable"; } if (!mDataLoaderManager) { LOG(FATAL) << "DataLoaderManagerService is unavailable"; } if (!mAppOpsManager) { LOG(FATAL) << "AppOpsManager is unavailable"; } mJobQueue.reserve(16); mJobProcessor = std::thread([this]() { mJni->initializeForCurrentThread(); runJobProcessing(); }); mountExistingImages(); } IncrementalService::~IncrementalService() { { std::lock_guard lock(mJobMutex); mRunning = false; } mJobCondition.notify_all(); mJobProcessor.join(); } inline const char* toString(TimePoint t) { using SystemClock = std::chrono::system_clock; time_t time = SystemClock::to_time_t( SystemClock::now() + std::chrono::duration_cast(t - Clock::now())); return std::ctime(&time); } inline const char* toString(IncrementalService::BindKind kind) { switch (kind) { case IncrementalService::BindKind::Temporary: return "Temporary"; case IncrementalService::BindKind::Permanent: return "Permanent"; } } void IncrementalService::onDump(int fd) { dprintf(fd, "Incremental is %s\n", incfs::enabled() ? "ENABLED" : "DISABLED"); dprintf(fd, "Incremental dir: %s\n", mIncrementalDir.c_str()); std::unique_lock l(mLock); dprintf(fd, "Mounts (%d):\n", int(mMounts.size())); for (auto&& [id, ifs] : mMounts) { const IncFsMount& mnt = *ifs.get(); dprintf(fd, "\t[%d]:\n", id); dprintf(fd, "\t\tmountId: %d\n", mnt.mountId); dprintf(fd, "\t\troot: %s\n", mnt.root.c_str()); dprintf(fd, "\t\tnextStorageDirNo: %d\n", mnt.nextStorageDirNo.load()); if (mnt.dataLoaderStub) { const auto& dataLoaderStub = *mnt.dataLoaderStub; dprintf(fd, "\t\tdataLoaderStatus: %d\n", dataLoaderStub.status()); dprintf(fd, "\t\tdataLoaderStartRequested: %s\n", dataLoaderStub.startRequested() ? "true" : "false"); const auto& params = dataLoaderStub.params(); dprintf(fd, "\t\tdataLoaderParams:\n"); dprintf(fd, "\t\t\ttype: %s\n", toString(params.type).c_str()); dprintf(fd, "\t\t\tpackageName: %s\n", params.packageName.c_str()); dprintf(fd, "\t\t\tclassName: %s\n", params.className.c_str()); dprintf(fd, "\t\t\targuments: %s\n", params.arguments.c_str()); } dprintf(fd, "\t\tstorages (%d):\n", int(mnt.storages.size())); for (auto&& [storageId, storage] : mnt.storages) { dprintf(fd, "\t\t\t[%d] -> [%s]\n", storageId, storage.name.c_str()); } dprintf(fd, "\t\tbindPoints (%d):\n", int(mnt.bindPoints.size())); for (auto&& [target, bind] : mnt.bindPoints) { dprintf(fd, "\t\t\t[%s]->[%d]:\n", target.c_str(), bind.storage); dprintf(fd, "\t\t\t\tsavedFilename: %s\n", bind.savedFilename.c_str()); dprintf(fd, "\t\t\t\tsourceDir: %s\n", bind.sourceDir.c_str()); dprintf(fd, "\t\t\t\tkind: %s\n", toString(bind.kind)); } } dprintf(fd, "Sorted binds (%d):\n", int(mBindsByPath.size())); for (auto&& [target, mountPairIt] : mBindsByPath) { const auto& bind = mountPairIt->second; dprintf(fd, "\t\t[%s]->[%d]:\n", target.c_str(), bind.storage); dprintf(fd, "\t\t\tsavedFilename: %s\n", bind.savedFilename.c_str()); dprintf(fd, "\t\t\tsourceDir: %s\n", bind.sourceDir.c_str()); dprintf(fd, "\t\t\tkind: %s\n", toString(bind.kind)); } } void IncrementalService::onSystemReady() { if (mSystemReady.exchange(true)) { return; } std::vector mounts; { std::lock_guard l(mLock); mounts.reserve(mMounts.size()); for (auto&& [id, ifs] : mMounts) { if (ifs->mountId == id) { mounts.push_back(ifs); } } } if (mounts.empty()) { return; } std::thread([this, mounts = std::move(mounts)]() { mJni->initializeForCurrentThread(); for (auto&& ifs : mounts) { if (ifs->dataLoaderStub->create()) { LOG(INFO) << "Successfully started data loader for mount " << ifs->mountId; } else { // TODO(b/133435829): handle data loader start failures LOG(WARNING) << "Failed to start data loader for mount " << ifs->mountId; } } }).detach(); } auto IncrementalService::getStorageSlotLocked() -> MountMap::iterator { for (;;) { if (mNextId == kMaxStorageId) { mNextId = 0; } auto id = ++mNextId; auto [it, inserted] = mMounts.try_emplace(id, nullptr); if (inserted) { return it; } } } StorageId IncrementalService::createStorage( std::string_view mountPoint, DataLoaderParamsParcel&& dataLoaderParams, const DataLoaderStatusListener& dataLoaderStatusListener, CreateOptions options) { LOG(INFO) << "createStorage: " << mountPoint << " | " << int(options); if (!path::isAbsolute(mountPoint)) { LOG(ERROR) << "path is not absolute: " << mountPoint; return kInvalidStorageId; } auto mountNorm = path::normalize(mountPoint); { const auto id = findStorageId(mountNorm); if (id != kInvalidStorageId) { if (options & CreateOptions::OpenExisting) { LOG(INFO) << "Opened existing storage " << id; return id; } LOG(ERROR) << "Directory " << mountPoint << " is already mounted at storage " << id; return kInvalidStorageId; } } if (!(options & CreateOptions::CreateNew)) { LOG(ERROR) << "not requirested create new storage, and it doesn't exist: " << mountPoint; return kInvalidStorageId; } if (!path::isEmptyDir(mountNorm)) { LOG(ERROR) << "Mounting over existing non-empty directory is not supported: " << mountNorm; return kInvalidStorageId; } auto [mountKey, mountRoot] = makeMountDir(mIncrementalDir, mountNorm); if (mountRoot.empty()) { LOG(ERROR) << "Bad mount point"; return kInvalidStorageId; } // Make sure the code removes all crap it may create while still failing. auto firstCleanup = [](const std::string* ptr) { IncFsMount::cleanupFilesystem(*ptr); }; auto firstCleanupOnFailure = std::unique_ptr(&mountRoot, firstCleanup); auto mountTarget = path::join(mountRoot, constants().mount); const auto backing = path::join(mountRoot, constants().backing); if (!mkdirOrLog(backing, 0777) || !mkdirOrLog(mountTarget)) { return kInvalidStorageId; } IncFsMount::Control control; { std::lock_guard l(mMountOperationLock); IncrementalFileSystemControlParcel controlParcel; if (auto err = rmDirContent(backing.c_str())) { LOG(ERROR) << "Coudn't clean the backing directory " << backing << ": " << err; return kInvalidStorageId; } if (!mkdirOrLog(path::join(backing, ".index"), 0777)) { return kInvalidStorageId; } auto status = mVold->mountIncFs(backing, mountTarget, 0, &controlParcel); if (!status.isOk()) { LOG(ERROR) << "Vold::mountIncFs() failed: " << status.toString8(); return kInvalidStorageId; } if (controlParcel.cmd.get() < 0 || controlParcel.pendingReads.get() < 0 || controlParcel.log.get() < 0) { LOG(ERROR) << "Vold::mountIncFs() returned invalid control parcel."; return kInvalidStorageId; } int cmd = controlParcel.cmd.release().release(); int pendingReads = controlParcel.pendingReads.release().release(); int logs = controlParcel.log.release().release(); control = mIncFs->createControl(cmd, pendingReads, logs); } std::unique_lock l(mLock); const auto mountIt = getStorageSlotLocked(); const auto mountId = mountIt->first; l.unlock(); auto ifs = std::make_shared(std::move(mountRoot), mountId, std::move(control), *this); // Now it's the |ifs|'s responsibility to clean up after itself, and the only cleanup we need // is the removal of the |ifs|. firstCleanupOnFailure.release(); auto secondCleanup = [this, &l](auto itPtr) { if (!l.owns_lock()) { l.lock(); } mMounts.erase(*itPtr); }; auto secondCleanupOnFailure = std::unique_ptr(&mountIt, secondCleanup); const auto storageIt = ifs->makeStorage(ifs->mountId); if (storageIt == ifs->storages.end()) { LOG(ERROR) << "Can't create a default storage directory"; return kInvalidStorageId; } { metadata::Mount m; m.mutable_storage()->set_id(ifs->mountId); m.mutable_loader()->set_type((int)dataLoaderParams.type); m.mutable_loader()->set_package_name(dataLoaderParams.packageName); m.mutable_loader()->set_class_name(dataLoaderParams.className); m.mutable_loader()->set_arguments(dataLoaderParams.arguments); const auto metadata = m.SerializeAsString(); m.mutable_loader()->release_arguments(); m.mutable_loader()->release_class_name(); m.mutable_loader()->release_package_name(); if (auto err = mIncFs->makeFile(ifs->control, path::join(ifs->root, constants().mount, constants().infoMdName), 0777, idFromMetadata(metadata), {.metadata = {metadata.data(), (IncFsSize)metadata.size()}})) { LOG(ERROR) << "Saving mount metadata failed: " << -err; return kInvalidStorageId; } } const auto bk = (options & CreateOptions::PermanentBind) ? BindKind::Permanent : BindKind::Temporary; if (auto err = addBindMount(*ifs, storageIt->first, storageIt->second.name, std::string(storageIt->second.name), std::move(mountNorm), bk, l); err < 0) { LOG(ERROR) << "adding bind mount failed: " << -err; return kInvalidStorageId; } // Done here as well, all data structures are in good state. secondCleanupOnFailure.release(); auto dataLoaderStub = prepareDataLoader(*ifs, std::move(dataLoaderParams), &dataLoaderStatusListener); CHECK(dataLoaderStub); mountIt->second = std::move(ifs); l.unlock(); if (mSystemReady.load(std::memory_order_relaxed) && !dataLoaderStub->create()) { // failed to create data loader LOG(ERROR) << "initializeDataLoader() failed"; deleteStorage(dataLoaderStub->id()); return kInvalidStorageId; } LOG(INFO) << "created storage " << mountId; return mountId; } StorageId IncrementalService::createLinkedStorage(std::string_view mountPoint, StorageId linkedStorage, IncrementalService::CreateOptions options) { if (!isValidMountTarget(mountPoint)) { LOG(ERROR) << "Mount point is invalid or missing"; return kInvalidStorageId; } std::unique_lock l(mLock); const auto& ifs = getIfsLocked(linkedStorage); if (!ifs) { LOG(ERROR) << "Ifs unavailable"; return kInvalidStorageId; } const auto mountIt = getStorageSlotLocked(); const auto storageId = mountIt->first; const auto storageIt = ifs->makeStorage(storageId); if (storageIt == ifs->storages.end()) { LOG(ERROR) << "Can't create a new storage"; mMounts.erase(mountIt); return kInvalidStorageId; } l.unlock(); const auto bk = (options & CreateOptions::PermanentBind) ? BindKind::Permanent : BindKind::Temporary; if (auto err = addBindMount(*ifs, storageIt->first, storageIt->second.name, std::string(storageIt->second.name), path::normalize(mountPoint), bk, l); err < 0) { LOG(ERROR) << "bindMount failed with error: " << err; return kInvalidStorageId; } mountIt->second = ifs; return storageId; } IncrementalService::BindPathMap::const_iterator IncrementalService::findStorageLocked( std::string_view path) const { auto bindPointIt = mBindsByPath.upper_bound(path); if (bindPointIt == mBindsByPath.begin()) { return mBindsByPath.end(); } --bindPointIt; if (!path::startsWith(path, bindPointIt->first)) { return mBindsByPath.end(); } return bindPointIt; } StorageId IncrementalService::findStorageId(std::string_view path) const { std::lock_guard l(mLock); auto it = findStorageLocked(path); if (it == mBindsByPath.end()) { return kInvalidStorageId; } return it->second->second.storage; } int IncrementalService::setStorageParams(StorageId storageId, bool enableReadLogs) { const auto ifs = getIfs(storageId); if (!ifs) { LOG(ERROR) << "setStorageParams failed, invalid storageId: " << storageId; return -EINVAL; } const auto& params = ifs->dataLoaderStub->params(); if (enableReadLogs) { if (auto status = mAppOpsManager->checkPermission(kDataUsageStats, kOpUsage, params.packageName.c_str()); !status.isOk()) { LOG(ERROR) << "checkPermission failed: " << status.toString8(); return fromBinderStatus(status); } } if (auto status = applyStorageParams(*ifs, enableReadLogs); !status.isOk()) { LOG(ERROR) << "applyStorageParams failed: " << status.toString8(); return fromBinderStatus(status); } if (enableReadLogs) { registerAppOpsCallback(params.packageName); } return 0; } binder::Status IncrementalService::applyStorageParams(IncFsMount& ifs, bool enableReadLogs) { using unique_fd = ::android::base::unique_fd; ::android::os::incremental::IncrementalFileSystemControlParcel control; control.cmd.reset(unique_fd(dup(ifs.control.cmd()))); control.pendingReads.reset(unique_fd(dup(ifs.control.pendingReads()))); auto logsFd = ifs.control.logs(); if (logsFd >= 0) { control.log.reset(unique_fd(dup(logsFd))); } std::lock_guard l(mMountOperationLock); return mVold->setIncFsMountOptions(control, enableReadLogs); } void IncrementalService::deleteStorage(StorageId storageId) { const auto ifs = getIfs(storageId); if (!ifs) { return; } deleteStorage(*ifs); } void IncrementalService::deleteStorage(IncrementalService::IncFsMount& ifs) { std::unique_lock l(ifs.lock); deleteStorageLocked(ifs, std::move(l)); } void IncrementalService::deleteStorageLocked(IncrementalService::IncFsMount& ifs, std::unique_lock&& ifsLock) { const auto storages = std::move(ifs.storages); // Don't move the bind points out: Ifs's dtor will use them to unmount everything. const auto bindPoints = ifs.bindPoints; ifsLock.unlock(); std::lock_guard l(mLock); for (auto&& [id, _] : storages) { if (id != ifs.mountId) { mMounts.erase(id); } } for (auto&& [path, _] : bindPoints) { mBindsByPath.erase(path); } mMounts.erase(ifs.mountId); } StorageId IncrementalService::openStorage(std::string_view pathInMount) { if (!path::isAbsolute(pathInMount)) { return kInvalidStorageId; } return findStorageId(path::normalize(pathInMount)); } FileId IncrementalService::nodeFor(StorageId storage, std::string_view subpath) const { const auto ifs = getIfs(storage); if (!ifs) { return kIncFsInvalidFileId; } std::unique_lock l(ifs->lock); auto storageIt = ifs->storages.find(storage); if (storageIt == ifs->storages.end()) { return kIncFsInvalidFileId; } if (subpath.empty() || subpath == "."sv) { return kIncFsInvalidFileId; } auto path = path::join(ifs->root, constants().mount, storageIt->second.name, subpath); l.unlock(); return mIncFs->getFileId(ifs->control, path); } std::pair IncrementalService::parentAndNameFor( StorageId storage, std::string_view subpath) const { auto name = path::basename(subpath); if (name.empty()) { return {kIncFsInvalidFileId, {}}; } auto dir = path::dirname(subpath); if (dir.empty() || dir == "/"sv) { return {kIncFsInvalidFileId, {}}; } auto id = nodeFor(storage, dir); return {id, name}; } IncrementalService::IfsMountPtr IncrementalService::getIfs(StorageId storage) const { std::lock_guard l(mLock); return getIfsLocked(storage); } const IncrementalService::IfsMountPtr& IncrementalService::getIfsLocked(StorageId storage) const { auto it = mMounts.find(storage); if (it == mMounts.end()) { static const android::base::NoDestructor kEmpty{}; return *kEmpty; } return it->second; } int IncrementalService::bind(StorageId storage, std::string_view source, std::string_view target, BindKind kind) { if (!isValidMountTarget(target)) { return -EINVAL; } const auto ifs = getIfs(storage); if (!ifs) { return -EINVAL; } std::unique_lock l(ifs->lock); const auto storageInfo = ifs->storages.find(storage); if (storageInfo == ifs->storages.end()) { return -EINVAL; } std::string normSource = normalizePathToStorageLocked(storageInfo, source); if (normSource.empty()) { return -EINVAL; } l.unlock(); std::unique_lock l2(mLock, std::defer_lock); return addBindMount(*ifs, storage, storageInfo->second.name, std::move(normSource), path::normalize(target), kind, l2); } int IncrementalService::unbind(StorageId storage, std::string_view target) { if (!path::isAbsolute(target)) { return -EINVAL; } LOG(INFO) << "Removing bind point " << target; // Here we should only look up by the exact target, not by a subdirectory of any existing mount, // otherwise there's a chance to unmount something completely unrelated const auto norm = path::normalize(target); std::unique_lock l(mLock); const auto storageIt = mBindsByPath.find(norm); if (storageIt == mBindsByPath.end() || storageIt->second->second.storage != storage) { return -EINVAL; } const auto bindIt = storageIt->second; const auto storageId = bindIt->second.storage; const auto ifs = getIfsLocked(storageId); if (!ifs) { LOG(ERROR) << "Internal error: storageId " << storageId << " for bound path " << target << " is missing"; return -EFAULT; } mBindsByPath.erase(storageIt); l.unlock(); mVold->unmountIncFs(bindIt->first); std::unique_lock l2(ifs->lock); if (ifs->bindPoints.size() <= 1) { ifs->bindPoints.clear(); deleteStorageLocked(*ifs, std::move(l2)); } else { const std::string savedFile = std::move(bindIt->second.savedFilename); ifs->bindPoints.erase(bindIt); l2.unlock(); if (!savedFile.empty()) { mIncFs->unlink(ifs->control, path::join(ifs->root, constants().mount, savedFile)); } } return 0; } std::string IncrementalService::normalizePathToStorageLocked( IncFsMount::StorageMap::iterator storageIt, std::string_view path) { std::string normPath; if (path::isAbsolute(path)) { normPath = path::normalize(path); if (!path::startsWith(normPath, storageIt->second.name)) { return {}; } } else { normPath = path::normalize(path::join(storageIt->second.name, path)); } return normPath; } std::string IncrementalService::normalizePathToStorage(const IncrementalService::IfsMountPtr& ifs, StorageId storage, std::string_view path) { std::unique_lock l(ifs->lock); const auto storageInfo = ifs->storages.find(storage); if (storageInfo == ifs->storages.end()) { return {}; } return normalizePathToStorageLocked(storageInfo, path); } int IncrementalService::makeFile(StorageId storage, std::string_view path, int mode, FileId id, incfs::NewFileParams params) { if (auto ifs = getIfs(storage)) { std::string normPath = normalizePathToStorage(ifs, storage, path); if (normPath.empty()) { LOG(ERROR) << "Internal error: storageId " << storage << " failed to normalize: " << path; return -EINVAL; } auto err = mIncFs->makeFile(ifs->control, normPath, mode, id, params); if (err) { LOG(ERROR) << "Internal error: storageId " << storage << " failed to makeFile: " << err; return err; } return 0; } return -EINVAL; } int IncrementalService::makeDir(StorageId storageId, std::string_view path, int mode) { if (auto ifs = getIfs(storageId)) { std::string normPath = normalizePathToStorage(ifs, storageId, path); if (normPath.empty()) { return -EINVAL; } return mIncFs->makeDir(ifs->control, normPath, mode); } return -EINVAL; } int IncrementalService::makeDirs(StorageId storageId, std::string_view path, int mode) { const auto ifs = getIfs(storageId); if (!ifs) { return -EINVAL; } std::string normPath = normalizePathToStorage(ifs, storageId, path); if (normPath.empty()) { return -EINVAL; } auto err = mIncFs->makeDir(ifs->control, normPath, mode); if (err == -EEXIST) { return 0; } else if (err != -ENOENT) { return err; } if (auto err = makeDirs(storageId, path::dirname(normPath), mode)) { return err; } return mIncFs->makeDir(ifs->control, normPath, mode); } int IncrementalService::link(StorageId sourceStorageId, std::string_view oldPath, StorageId destStorageId, std::string_view newPath) { auto ifsSrc = getIfs(sourceStorageId); auto ifsDest = sourceStorageId == destStorageId ? ifsSrc : getIfs(destStorageId); if (ifsSrc && ifsSrc == ifsDest) { std::string normOldPath = normalizePathToStorage(ifsSrc, sourceStorageId, oldPath); std::string normNewPath = normalizePathToStorage(ifsDest, destStorageId, newPath); if (normOldPath.empty() || normNewPath.empty()) { return -EINVAL; } return mIncFs->link(ifsSrc->control, normOldPath, normNewPath); } return -EINVAL; } int IncrementalService::unlink(StorageId storage, std::string_view path) { if (auto ifs = getIfs(storage)) { std::string normOldPath = normalizePathToStorage(ifs, storage, path); return mIncFs->unlink(ifs->control, normOldPath); } return -EINVAL; } int IncrementalService::addBindMount(IncFsMount& ifs, StorageId storage, std::string_view storageRoot, std::string&& source, std::string&& target, BindKind kind, std::unique_lock& mainLock) { if (!isValidMountTarget(target)) { return -EINVAL; } std::string mdFileName; if (kind != BindKind::Temporary) { metadata::BindPoint bp; bp.set_storage_id(storage); bp.set_allocated_dest_path(&target); bp.set_allocated_source_subdir(&source); const auto metadata = bp.SerializeAsString(); bp.release_dest_path(); bp.release_source_subdir(); mdFileName = makeBindMdName(); auto node = mIncFs->makeFile(ifs.control, path::join(ifs.root, constants().mount, mdFileName), 0444, idFromMetadata(metadata), {.metadata = {metadata.data(), (IncFsSize)metadata.size()}}); if (node) { return int(node); } } return addBindMountWithMd(ifs, storage, std::move(mdFileName), std::move(source), std::move(target), kind, mainLock); } int IncrementalService::addBindMountWithMd(IncrementalService::IncFsMount& ifs, StorageId storage, std::string&& metadataName, std::string&& source, std::string&& target, BindKind kind, std::unique_lock& mainLock) { { std::lock_guard l(mMountOperationLock); const auto status = mVold->bindMount(source, target); if (!status.isOk()) { LOG(ERROR) << "Calling Vold::bindMount() failed: " << status.toString8(); return status.exceptionCode() == binder::Status::EX_SERVICE_SPECIFIC ? status.serviceSpecificErrorCode() > 0 ? -status.serviceSpecificErrorCode() : status.serviceSpecificErrorCode() == 0 ? -EFAULT : status.serviceSpecificErrorCode() : -EIO; } } if (!mainLock.owns_lock()) { mainLock.lock(); } std::lock_guard l(ifs.lock); const auto [it, _] = ifs.bindPoints.insert_or_assign(target, IncFsMount::Bind{storage, std::move(metadataName), std::move(source), kind}); mBindsByPath[std::move(target)] = it; return 0; } RawMetadata IncrementalService::getMetadata(StorageId storage, FileId node) const { const auto ifs = getIfs(storage); if (!ifs) { return {}; } return mIncFs->getMetadata(ifs->control, node); } std::vector IncrementalService::listFiles(StorageId storage) const { const auto ifs = getIfs(storage); if (!ifs) { return {}; } std::unique_lock l(ifs->lock); auto subdirIt = ifs->storages.find(storage); if (subdirIt == ifs->storages.end()) { return {}; } auto dir = path::join(ifs->root, constants().mount, subdirIt->second.name); l.unlock(); const auto prefixSize = dir.size() + 1; std::vector todoDirs{std::move(dir)}; std::vector result; do { auto currDir = std::move(todoDirs.back()); todoDirs.pop_back(); auto d = std::unique_ptr(::opendir(currDir.c_str()), ::closedir); while (auto e = ::readdir(d.get())) { if (e->d_type == DT_REG) { result.emplace_back( path::join(std::string_view(currDir).substr(prefixSize), e->d_name)); continue; } if (e->d_type == DT_DIR) { if (e->d_name == "."sv || e->d_name == ".."sv) { continue; } todoDirs.emplace_back(path::join(currDir, e->d_name)); continue; } } } while (!todoDirs.empty()); return result; } bool IncrementalService::startLoading(StorageId storage) const { DataLoaderStubPtr dataLoaderStub; { std::unique_lock l(mLock); const auto& ifs = getIfsLocked(storage); if (!ifs) { return false; } dataLoaderStub = ifs->dataLoaderStub; if (!dataLoaderStub) { return false; } } return dataLoaderStub->requestStart(); } void IncrementalService::mountExistingImages() { for (const auto& entry : fs::directory_iterator(mIncrementalDir)) { const auto path = entry.path().u8string(); const auto name = entry.path().filename().u8string(); if (!base::StartsWith(name, constants().mountKeyPrefix)) { continue; } const auto root = path::join(mIncrementalDir, name); if (!mountExistingImage(root)) { IncFsMount::cleanupFilesystem(path); } } } bool IncrementalService::mountExistingImage(std::string_view root) { auto mountTarget = path::join(root, constants().mount); const auto backing = path::join(root, constants().backing); IncrementalFileSystemControlParcel controlParcel; auto status = mVold->mountIncFs(backing, mountTarget, 0, &controlParcel); if (!status.isOk()) { LOG(ERROR) << "Vold::mountIncFs() failed: " << status.toString8(); return false; } int cmd = controlParcel.cmd.release().release(); int pendingReads = controlParcel.pendingReads.release().release(); int logs = controlParcel.log.release().release(); IncFsMount::Control control = mIncFs->createControl(cmd, pendingReads, logs); auto ifs = std::make_shared(std::string(root), -1, std::move(control), *this); auto mount = parseFromIncfs(mIncFs.get(), ifs->control, path::join(mountTarget, constants().infoMdName)); if (!mount.has_loader() || !mount.has_storage()) { LOG(ERROR) << "Bad mount metadata in mount at " << root; return false; } ifs->mountId = mount.storage().id(); mNextId = std::max(mNextId, ifs->mountId + 1); // DataLoader params DataLoaderParamsParcel dataLoaderParams; { const auto& loader = mount.loader(); dataLoaderParams.type = (android::content::pm::DataLoaderType)loader.type(); dataLoaderParams.packageName = loader.package_name(); dataLoaderParams.className = loader.class_name(); dataLoaderParams.arguments = loader.arguments(); } prepareDataLoader(*ifs, std::move(dataLoaderParams), nullptr); CHECK(ifs->dataLoaderStub); std::vector> bindPoints; auto d = openDir(path::c_str(mountTarget)); while (auto e = ::readdir(d.get())) { if (e->d_type == DT_REG) { auto name = std::string_view(e->d_name); if (name.starts_with(constants().mountpointMdPrefix)) { bindPoints.emplace_back(name, parseFromIncfs(mIncFs.get(), ifs->control, path::join(mountTarget, name))); if (bindPoints.back().second.dest_path().empty() || bindPoints.back().second.source_subdir().empty()) { bindPoints.pop_back(); mIncFs->unlink(ifs->control, path::join(ifs->root, constants().mount, name)); } } } else if (e->d_type == DT_DIR) { if (e->d_name == "."sv || e->d_name == ".."sv) { continue; } auto name = std::string_view(e->d_name); if (name.starts_with(constants().storagePrefix)) { int storageId; const auto res = std::from_chars(name.data() + constants().storagePrefix.size() + 1, name.data() + name.size(), storageId); if (res.ec != std::errc{} || *res.ptr != '_') { LOG(WARNING) << "Ignoring storage with invalid name '" << name << "' for mount " << root; continue; } auto [_, inserted] = mMounts.try_emplace(storageId, ifs); if (!inserted) { LOG(WARNING) << "Ignoring storage with duplicate id " << storageId << " for mount " << root; continue; } ifs->storages.insert_or_assign(storageId, IncFsMount::Storage{ path::join(root, constants().mount, name)}); mNextId = std::max(mNextId, storageId + 1); } } } if (ifs->storages.empty()) { LOG(WARNING) << "No valid storages in mount " << root; return false; } int bindCount = 0; for (auto&& bp : bindPoints) { std::unique_lock l(mLock, std::defer_lock); bindCount += !addBindMountWithMd(*ifs, bp.second.storage_id(), std::move(bp.first), std::move(*bp.second.mutable_source_subdir()), std::move(*bp.second.mutable_dest_path()), BindKind::Permanent, l); } if (bindCount == 0) { LOG(WARNING) << "No valid bind points for mount " << root; deleteStorage(*ifs); return false; } mMounts[ifs->mountId] = std::move(ifs); return true; } IncrementalService::DataLoaderStubPtr IncrementalService::prepareDataLoader( IncrementalService::IncFsMount& ifs, DataLoaderParamsParcel&& params, const DataLoaderStatusListener* externalListener) { std::unique_lock l(ifs.lock); if (ifs.dataLoaderStub) { LOG(INFO) << "Skipped data loader preparation because it already exists"; return ifs.dataLoaderStub; } FileSystemControlParcel fsControlParcel; fsControlParcel.incremental = aidl::make_nullable(); fsControlParcel.incremental->cmd.reset(base::unique_fd(::dup(ifs.control.cmd()))); fsControlParcel.incremental->pendingReads.reset( base::unique_fd(::dup(ifs.control.pendingReads()))); fsControlParcel.incremental->log.reset(base::unique_fd(::dup(ifs.control.logs()))); fsControlParcel.service = new IncrementalServiceConnector(*this, ifs.mountId); ifs.dataLoaderStub = new DataLoaderStub(*this, ifs.mountId, std::move(params), std::move(fsControlParcel), externalListener); return ifs.dataLoaderStub; } template static long elapsedMcs(Duration start, Duration end) { return std::chrono::duration_cast(end - start).count(); } // Extract lib files from zip, create new files in incfs and write data to them bool IncrementalService::configureNativeBinaries(StorageId storage, std::string_view apkFullPath, std::string_view libDirRelativePath, std::string_view abi) { auto start = Clock::now(); const auto ifs = getIfs(storage); if (!ifs) { LOG(ERROR) << "Invalid storage " << storage; return false; } // First prepare target directories if they don't exist yet if (auto res = makeDirs(storage, libDirRelativePath, 0755)) { LOG(ERROR) << "Failed to prepare target lib directory " << libDirRelativePath << " errno: " << res; return false; } auto mkDirsTs = Clock::now(); ZipArchiveHandle zipFileHandle; if (OpenArchive(path::c_str(apkFullPath), &zipFileHandle)) { LOG(ERROR) << "Failed to open zip file at " << apkFullPath; return false; } // Need a shared pointer: will be passing it into all unpacking jobs. std::shared_ptr zipFile(zipFileHandle, [](ZipArchiveHandle h) { CloseArchive(h); }); void* cookie = nullptr; const auto libFilePrefix = path::join(constants().libDir, abi); if (StartIteration(zipFile.get(), &cookie, libFilePrefix, constants().libSuffix)) { LOG(ERROR) << "Failed to start zip iteration for " << apkFullPath; return false; } auto endIteration = [](void* cookie) { EndIteration(cookie); }; auto iterationCleaner = std::unique_ptr(cookie, endIteration); auto openZipTs = Clock::now(); std::vector jobQueue; ZipEntry entry; std::string_view fileName; while (!Next(cookie, &entry, &fileName)) { if (fileName.empty()) { continue; } auto startFileTs = Clock::now(); const auto libName = path::basename(fileName); const auto targetLibPath = path::join(libDirRelativePath, libName); const auto targetLibPathAbsolute = normalizePathToStorage(ifs, storage, targetLibPath); // If the extract file already exists, skip if (access(targetLibPathAbsolute.c_str(), F_OK) == 0) { if (sEnablePerfLogging) { LOG(INFO) << "incfs: Native lib file already exists: " << targetLibPath << "; skipping extraction, spent " << elapsedMcs(startFileTs, Clock::now()) << "mcs"; } continue; } // Create new lib file without signature info incfs::NewFileParams libFileParams = { .size = entry.uncompressed_length, .signature = {}, // Metadata of the new lib file is its relative path .metadata = {targetLibPath.c_str(), (IncFsSize)targetLibPath.size()}, }; incfs::FileId libFileId = idFromMetadata(targetLibPath); if (auto res = mIncFs->makeFile(ifs->control, targetLibPathAbsolute, 0777, libFileId, libFileParams)) { LOG(ERROR) << "Failed to make file for: " << targetLibPath << " errno: " << res; // If one lib file fails to be created, abort others as well return false; } auto makeFileTs = Clock::now(); // If it is a zero-byte file, skip data writing if (entry.uncompressed_length == 0) { if (sEnablePerfLogging) { LOG(INFO) << "incfs: Extracted " << libName << "(0 bytes): " << elapsedMcs(startFileTs, makeFileTs) << "mcs"; } continue; } jobQueue.emplace_back([this, zipFile, entry, ifs = std::weak_ptr(ifs), libFileId, libPath = std::move(targetLibPath), makeFileTs]() mutable { extractZipFile(ifs.lock(), zipFile.get(), entry, libFileId, libPath, makeFileTs); }); if (sEnablePerfLogging) { auto prepareJobTs = Clock::now(); LOG(INFO) << "incfs: Processed " << libName << ": " << elapsedMcs(startFileTs, prepareJobTs) << "mcs, make file: " << elapsedMcs(startFileTs, makeFileTs) << " prepare job: " << elapsedMcs(makeFileTs, prepareJobTs); } } auto processedTs = Clock::now(); if (!jobQueue.empty()) { { std::lock_guard lock(mJobMutex); if (mRunning) { auto& existingJobs = mJobQueue[ifs->mountId]; if (existingJobs.empty()) { existingJobs = std::move(jobQueue); } else { existingJobs.insert(existingJobs.end(), std::move_iterator(jobQueue.begin()), std::move_iterator(jobQueue.end())); } } } mJobCondition.notify_all(); } if (sEnablePerfLogging) { auto end = Clock::now(); LOG(INFO) << "incfs: configureNativeBinaries complete in " << elapsedMcs(start, end) << "mcs, make dirs: " << elapsedMcs(start, mkDirsTs) << " open zip: " << elapsedMcs(mkDirsTs, openZipTs) << " make files: " << elapsedMcs(openZipTs, processedTs) << " schedule jobs: " << elapsedMcs(processedTs, end); } return true; } void IncrementalService::extractZipFile(const IfsMountPtr& ifs, ZipArchiveHandle zipFile, ZipEntry& entry, const incfs::FileId& libFileId, std::string_view targetLibPath, Clock::time_point scheduledTs) { if (!ifs) { LOG(INFO) << "Skipping zip file " << targetLibPath << " extraction for an expired mount"; return; } auto libName = path::basename(targetLibPath); auto startedTs = Clock::now(); // Write extracted data to new file // NOTE: don't zero-initialize memory, it may take a while for nothing auto libData = std::unique_ptr(new uint8_t[entry.uncompressed_length]); if (ExtractToMemory(zipFile, &entry, libData.get(), entry.uncompressed_length)) { LOG(ERROR) << "Failed to extract native lib zip entry: " << libName; return; } auto extractFileTs = Clock::now(); const auto writeFd = mIncFs->openForSpecialOps(ifs->control, libFileId); if (!writeFd.ok()) { LOG(ERROR) << "Failed to open write fd for: " << targetLibPath << " errno: " << writeFd; return; } auto openFileTs = Clock::now(); const int numBlocks = (entry.uncompressed_length + constants().blockSize - 1) / constants().blockSize; std::vector instructions(numBlocks); auto remainingData = std::span(libData.get(), entry.uncompressed_length); for (int i = 0; i < numBlocks; i++) { const auto blockSize = std::min(constants().blockSize, remainingData.size()); instructions[i] = IncFsDataBlock{ .fileFd = writeFd.get(), .pageIndex = static_cast(i), .compression = INCFS_COMPRESSION_KIND_NONE, .kind = INCFS_BLOCK_KIND_DATA, .dataSize = blockSize, .data = reinterpret_cast(remainingData.data()), }; remainingData = remainingData.subspan(blockSize); } auto prepareInstsTs = Clock::now(); size_t res = mIncFs->writeBlocks(instructions); if (res != instructions.size()) { LOG(ERROR) << "Failed to write data into: " << targetLibPath; return; } if (sEnablePerfLogging) { auto endFileTs = Clock::now(); LOG(INFO) << "incfs: Extracted " << libName << "(" << entry.compressed_length << " -> " << entry.uncompressed_length << " bytes): " << elapsedMcs(startedTs, endFileTs) << "mcs, scheduling delay: " << elapsedMcs(scheduledTs, startedTs) << " extract: " << elapsedMcs(startedTs, extractFileTs) << " open: " << elapsedMcs(extractFileTs, openFileTs) << " prepare: " << elapsedMcs(openFileTs, prepareInstsTs) << " write: " << elapsedMcs(prepareInstsTs, endFileTs); } } bool IncrementalService::waitForNativeBinariesExtraction(StorageId storage) { struct WaitPrinter { const Clock::time_point startTs = Clock::now(); ~WaitPrinter() noexcept { if (sEnablePerfLogging) { const auto endTs = Clock::now(); LOG(INFO) << "incfs: waitForNativeBinariesExtraction() complete in " << elapsedMcs(startTs, endTs) << "mcs"; } } } waitPrinter; MountId mount; { auto ifs = getIfs(storage); if (!ifs) { return true; } mount = ifs->mountId; } std::unique_lock lock(mJobMutex); mJobCondition.wait(lock, [this, mount] { return !mRunning || (mPendingJobsMount != mount && mJobQueue.find(mount) == mJobQueue.end()); }); return mRunning; } void IncrementalService::runJobProcessing() { for (;;) { std::unique_lock lock(mJobMutex); mJobCondition.wait(lock, [this]() { return !mRunning || !mJobQueue.empty(); }); if (!mRunning) { return; } auto it = mJobQueue.begin(); mPendingJobsMount = it->first; auto queue = std::move(it->second); mJobQueue.erase(it); lock.unlock(); for (auto&& job : queue) { job(); } lock.lock(); mPendingJobsMount = kInvalidStorageId; lock.unlock(); mJobCondition.notify_all(); } } void IncrementalService::registerAppOpsCallback(const std::string& packageName) { sp listener; { std::unique_lock lock{mCallbacksLock}; auto& cb = mCallbackRegistered[packageName]; if (cb) { return; } cb = new AppOpsListener(*this, packageName); listener = cb; } mAppOpsManager->startWatchingMode(AppOpsManager::OP_GET_USAGE_STATS, String16(packageName.c_str()), listener); } bool IncrementalService::unregisterAppOpsCallback(const std::string& packageName) { sp listener; { std::unique_lock lock{mCallbacksLock}; auto found = mCallbackRegistered.find(packageName); if (found == mCallbackRegistered.end()) { return false; } listener = found->second; mCallbackRegistered.erase(found); } mAppOpsManager->stopWatchingMode(listener); return true; } void IncrementalService::onAppOpChanged(const std::string& packageName) { if (!unregisterAppOpsCallback(packageName)) { return; } std::vector affected; { std::lock_guard l(mLock); affected.reserve(mMounts.size()); for (auto&& [id, ifs] : mMounts) { if (ifs->mountId == id && ifs->dataLoaderStub->params().packageName == packageName) { affected.push_back(ifs); } } } for (auto&& ifs : affected) { applyStorageParams(*ifs, false); } } IncrementalService::DataLoaderStub::~DataLoaderStub() { waitForDestroy(); } bool IncrementalService::DataLoaderStub::create() { { std::unique_lock lock(mStatusMutex); mStartRequested = false; mDestroyRequested = false; } bool created = false; auto status = mService.mDataLoaderManager->initializeDataLoader(mId, mParams, mControl, this, &created); if (!status.isOk() || !created) { LOG(ERROR) << "Failed to create a data loader for mount " << mId; return false; } return true; } bool IncrementalService::DataLoaderStub::requestStart() { { std::unique_lock lock(mStatusMutex); mStartRequested = true; if (mStatus != IDataLoaderStatusListener::DATA_LOADER_CREATED) { return true; } } return start(); } bool IncrementalService::DataLoaderStub::start() { sp dataloader; auto status = mService.mDataLoaderManager->getDataLoader(mId, &dataloader); if (!status.isOk()) { return false; } if (!dataloader) { return false; } status = dataloader->start(mId); if (!status.isOk()) { return false; } return true; } void IncrementalService::DataLoaderStub::destroy() { { std::unique_lock lock(mStatusMutex); mDestroyRequested = true; } mService.mDataLoaderManager->destroyDataLoader(mId); waitForDestroy(); } bool IncrementalService::DataLoaderStub::waitForDestroy() { auto now = std::chrono::steady_clock::now(); std::unique_lock lock(mStatusMutex); return mStatusCondition.wait_until(lock, now + 60s, [this] { return mStatus == IDataLoaderStatusListener::DATA_LOADER_DESTROYED; }); } binder::Status IncrementalService::DataLoaderStub::onStatusChanged(MountId mountId, int newStatus) { if (mStatus == newStatus) { return binder::Status::ok(); } if (mListener) { mListener->onStatusChanged(mountId, newStatus); } bool startRequested; bool destroyRequested; { std::unique_lock lock(mStatusMutex); if (mStatus == newStatus) { return binder::Status::ok(); } startRequested = mStartRequested; destroyRequested = mDestroyRequested; mStatus = newStatus; } switch (newStatus) { case IDataLoaderStatusListener::DATA_LOADER_CREATED: { if (startRequested) { LOG(WARNING) << "Start was requested, triggering, for mount: " << mountId; start(); } break; } case IDataLoaderStatusListener::DATA_LOADER_DESTROYED: { if (!destroyRequested) { LOG(WARNING) << "DataLoader destroyed, reconnecting, for mount: " << mountId; create(); } break; } case IDataLoaderStatusListener::DATA_LOADER_STARTED: { break; } case IDataLoaderStatusListener::DATA_LOADER_STOPPED: { break; } case IDataLoaderStatusListener::DATA_LOADER_IMAGE_READY: { break; } case IDataLoaderStatusListener::DATA_LOADER_IMAGE_NOT_READY: { break; } case IDataLoaderStatusListener::DATA_LOADER_UNRECOVERABLE: { // Nothing for now. Rely on externalListener to handle this. break; } default: { LOG(WARNING) << "Unknown data loader status: " << newStatus << " for mount: " << mountId; break; } } return binder::Status::ok(); } void IncrementalService::AppOpsListener::opChanged(int32_t, const String16&) { incrementalService.onAppOpChanged(packageName); } binder::Status IncrementalService::IncrementalServiceConnector::setStorageParams( bool enableReadLogs, int32_t* _aidl_return) { *_aidl_return = incrementalService.setStorageParams(storage, enableReadLogs); return binder::Status::ok(); } FileId IncrementalService::idFromMetadata(std::span metadata) { return IncFs_FileIdFromMetadata({(const char*)metadata.data(), metadata.size()}); } } // namespace android::incremental