bug:3421690
This change is related to change:Idfec7e6a
1. Added tests for cases in which the previous
implementation was not behaving as expected.
2. Refatered the tests to be intrumentation tests
since the code under tests uses the DOM element
dimensions to determine visibility and if the
the WebView has no size i.e. not attached to
ViewRoot the size of all DOM elements is zero
forcing all tests to fail.
Change-Id: Ib4c01af8feb09f2b2a6b9d906e08bfaaa9e9bc74
PackageManagerService shouldn't check features that a package declares
that it uses because this will cause problems in the future when we add
more features that older phones didn't explicitly declare. We must rely
on markets to know about phones and filter them for us to avoid this
situation.
Bug: 3409434
Change-Id: I419a5b936be3572b83a485081a6c81b2f1c8741c
1. Added tests for the new code added by change:I5a796aef
2. WebCore thread now calls the UI thread to set the cursor to
the current position enabling the user to interact with
the content that is being selected on the page.
3. Removed the code that changes the selection on movement of the
cursor ring. We are dropping the "default web view behavior"
as granularity of reading the document since with this change
a user can freely access inputs/buttons/links.
Change-Id: I7a3f6677eff0bc95e8127973d07cec78e3465c7b
AppCacheTest was multiplying two integers that were too large for
devices that had more free space than 32-bits could represent.
Hopefully no one releases devices with 1TB soon.
The testAppCacheClear test doesn't work currently because it has an
"imax" attribute that doesn't allow the disk to be filled up entirely.
It only writes a couple hundred MB before it gives up.
Bug: 3216419
Change-Id: Ie371f42211bab65f2c767b36d9837ce76922501e
Tests were giving false failures when they should instead be skipped.
Forcing an install to an SD card on a device without one shouldn't count
as a failure. It's expected behavior.
Bug: 3216422
Change-Id: Ia523861d1331e74c76b434f7ba73b642d474a9cc
The finalize() call did not clean up completely, this eventually
caused the android.process.acore to crash since it ran out of fds
and GREF to increased above 2000 if an application forgot to close
its cursor objects. A warning was also added when this happens so
that application developers can correct their mistake. The
included test case tries to verify that the finalizer works as
expected by creating a bunch of Cursor objects without closing
them (without this fix the acore process crashes after about 400
iterations and the test case ends with "Process crashed").
Change-Id: I11e485cef1ac02e718b2742108aa88793666c31d
The required features check was in an null check for usesLibraries, so
it wasn't checking for required features when an application did not use
a library.
Bug: 3331713
Change-Id: I96d366ba00d4962b84f3796be97e2b622eb331a5
Inspired by https://review.source.android.com/#change,16606
Test class has been revamped to mimic new behavior: selectCurrentWord
is no longer used to add words to the dictionary. We rely on the suggestion
bar in the IME for that.
Change-Id: I1cb88df54dffb166c75f75fefb743ff55a33519b
the reason for bug:3281533, bug:3127159 is probably too many cursors are left
un-closed in the process.
print the info on the number of cursors left open when the exception
"cursorwindow allocation failed" occurs.
This should help us figure out if that indeed is the reason
and which process is leaving the cursors open.
Change-Id: I4b46be63f5dfbe9b102ad7a9cf9dd21e70f71e14
* commit '672ebb61a755e4bbe60e4e884b1adadf186733b6':
Improved ignore-backoff handling Allow a non-epidited ignore-backoff op to pass through an expidited backed off op.
Add the missing wifi disable broadcast and also send out
supplicant disconnect on shutdown.
Added unit test cases.
Bug: 3294055
Change-Id: Ia56a8ec9d17784c5aac5b8b369c04837f9057c54
Allow a non-epidited ignore-backoff op to pass through
an expidited backed off op.
To do this, I first refactored the complicated if statement:
if (best == null
|| ((bestSyncableIsUnknownAndNotARetry == syncableIsUnknownAndNotARetry)
? (best.expedited == op.expedited
? opRunTime < bestRunTime
: op.expedited)
: syncableIsUnknownAndNotARetry)) {
best = op;
bestSyncableIsUnknownAndNotARetry = syncableIsUnknownAndNotARetry;
bestRunTime = opRunTime;
}
Into a more readable:
boolean setBest = false;
if (best == null) {
setBest = true;
} else if (bestSyncableIsUnknownAndNotARetry == syncableIsUnknownAndNotARetry) {
if (best.expedited == op.expedited) {
if (opRunTime < bestRunTime) {
// if both have same level, earlier time wins
setBest = true;
}
} else {
if (op.expedited) {
setBest = true;
}
}
} else {
if (syncableIsUnknownAndNotARetry) {
setBest = true;
}
}
if (setBest) {
best = op;
bestSyncableIsUnknownAndNotARetry = syncableIsUnknownAndNotARetry;
bestRunTime = opRunTime;
}
The refactoring was all done automatically with IntelliJ to avoid human error
in the conversion.
After verifying this code still behaved as expected including the error
condition in the bug, I added handling for the cases when a non-expidited op
may override an expedited op if certain conditions occur, specificaly, if the
expidited op is backed off and the non-expidited op is not.
Finally, refactored to make it testable and added tests and logging.
Bug: 3128963
Change-Id: I131cbcec6073ea5fe425f6b5aa88ca56c02b6598
Add WIFI_IDLE_MS to 1min in Wi-Fi stress test. bug#3284797
Wake up device using PowerManagerService.userActivityWithForce instead
of full wake lock.
Turn screen on when running Wi-Fi tests.
Change-Id: Ib763136cef515eec8b1d25183cf7a84ae1038ef2
