5680 Commits

Author SHA1 Message Date
Jim Miller
253f7295c8 am 1693f6a5: Prevent having multiple seek runnables in flight.
* commit '1693f6a5639a1f993bdc1dca9dade5e3eb3c14f2':
  Prevent having multiple seek runnables in flight.
2013-10-21 17:23:54 -07:00
Jim Miller
1693f6a563 Prevent having multiple seek runnables in flight.
This fix ensures that only one runnable is running at a time, no matter how
many events come in.  There's probably a better way to do this, but this is a
safe fix.

Fixes bug 11307391

Change-Id: I007c95062b20285571f39603c95fb9174b9a2da3
2013-10-21 17:17:40 -07:00
Jim Miller
262e5281d7 am 644696f0: Merge "Workaround for corner case in TransitionManager" into klp-dev
* commit '644696f0a0bee1714868b9e9cf351f1380e68f39':
  Workaround for corner case in TransitionManager
2013-10-21 16:12:18 -07:00
Jim Miller
ee186de4b2 Workaround for corner case in TransitionManager
This works around a problem where removing a review with unfinished
transitions results in leaked object references to KeyguardTransportControlView.

The workaround disables transitions until we have a better fix.

Fixes bug 11307391

Change-Id: I1df82f2c6f1cd9f5c9076d4c76cfd4aec3b6806c
2013-10-21 15:36:54 -07:00
Winson Chung
5b0da90a68 am 1bab99c8: Merge "DO NOT MERGE Fix null pointer exception when updating rotation tile. (Bug 11111473)" into klp-dev
* commit '1bab99c8cebbf23379c2ccad9188da1dce6fef09':
  DO NOT MERGE Fix null pointer exception when updating rotation tile. (Bug 11111473)
2013-10-21 14:20:57 -07:00
Winson Chung
1bab99c8ce Merge "DO NOT MERGE Fix null pointer exception when updating rotation tile. (Bug 11111473)" into klp-dev 2013-10-21 21:16:23 +00:00
Alan Viverette
c5aa0ab2e8 am ba551061: Merge "Don\'t clip keyguard security container children (e.g. glow pad)" into klp-dev
* commit 'ba551061482780264ab5bc80381e480128789bb6':
  Don't clip keyguard security container children (e.g. glow pad)
2013-10-21 13:51:10 -07:00
Alan Viverette
ba55106148 Merge "Don't clip keyguard security container children (e.g. glow pad)" into klp-dev 2013-10-21 20:48:57 +00:00
Jim Miller
495bd54c63 am 42b7b692: Merge "Revert "Fix dodgy states of keyguard transport controls"" into klp-dev
* commit '42b7b6927cd31679691b216d1ba09be31c24206e':
  Revert "Fix dodgy states of keyguard transport controls"
2013-10-18 18:10:57 -07:00
Jim Miller
42b7b6927c Merge "Revert "Fix dodgy states of keyguard transport controls"" into klp-dev 2013-10-19 01:08:12 +00:00
Jim Miller
4d20ed3f26 Revert "Fix dodgy states of keyguard transport controls"
This reverts commit bdb5ac7ddbabec0ba947a32937d8b95738d513dc.

Change-Id: Iea8db9a590a2a3b65d941b2918345eb27f690240
2013-10-19 01:00:16 +00:00
Svetoslav Ganov
a53e1f8138 am 23757527: Merge "Hide the print dialog if the printing activity is destroyed." into klp-dev
* commit '237575278de8cae5d20ee333fcb2ccceee257d67':
  Hide the print dialog if the printing activity is destroyed.
2013-10-18 17:29:05 -07:00
Svetoslav Ganov
237575278d Merge "Hide the print dialog if the printing activity is destroyed." into klp-dev 2013-10-19 00:26:44 +00:00
Svetoslav
0acad1de81 am 30d9161b: Merge "Printer list items have wrong width." into klp-dev
* commit '30d9161b8e84652d9ac504b70adacaf729fdb58b':
  Printer list items have wrong width.
2013-10-18 13:28:32 -07:00
Svetoslav
30d9161b8e Merge "Printer list items have wrong width." into klp-dev 2013-10-18 20:27:06 +00:00
Svetoslav Ganov
858a1850e2 Hide the print dialog if the printing activity is destroyed.
1. For an app to print it creates a PrintDocumentAdapter implementation
   which is passed to the print dialog activity. If the activity that
   created the adapter is destroyed then the adapter, which may rely on
   the activity state, may be in an invalid state. For example, an app
   creates an adapter and calls print resuting in the app activity and
   the print dialog activity being stacked. Now the user rotates the
   device which triggers the recreating of the activity stack (assume the
   app does not handle rotation). The recreated print dialog activity
   receives the intent that originally created it with containing the
   adapter that was constructed in the context of the old, now destroyed,
   app activity instance.

   To handle this we are limiting an app to be able to print only from
   and activity and when this activity is destroyed we mark the adapter
   as invalid which will result in hiding the print dialog activity. Note
   that if the app process is killed we already handle this in the print
   dialog activiy by registering a death recipient on the adapter binder.

2. In the PrintManager.PrintDocumentAdapterDelegate some of the state is
   accessed only on the main thread and some from miltiple threads. The
   code was trying to avoid locking for state that is not accessed by
   multiple threads but this is error prone and the benefit does not
   justify the complexity and added fragility. Now grabbing a lock all
   the time.

3. The PrintJobConfigActivity waits for it to bind to the print spooler
   service before instantiating its print controller and editor. However,
   these can be accessed by invoking some of the activity cycle callbacks.
   This change is adding null checks for the case where the activity
   callbacks are called before the binding to the spooler is completed.

bug:11242661

Change-Id: Id906b3170e4f0a0553772dfa62686f06fdca0eaf
2013-10-18 13:12:06 -07:00
Winson Chung
0e9ce34d1c DO NOT MERGE Fix null pointer exception when updating rotation tile. (Bug 11111473)
This occurs when switching users on devices that
don't have a rotation lock quick settings tile.

Change-Id: I738ca15ca754be90cec7eaf3a8eda3e38ed96b33
(cherry picked from commit e8f50a1400d288e6fd7c20ec7947270e204ee57d)
2013-10-18 09:50:37 -07:00
Jeff Sharkey
1a5804d7aa am 0c0f1e2e: Merge "Include external storage devices in DocumentsUI." into klp-dev
* commit '0c0f1e2eac76a3b65349d4d5d6cc8c63a393f025':
  Include external storage devices in DocumentsUI.
2013-10-17 18:50:34 -07:00
Jeff Sharkey
0c0f1e2eac Merge "Include external storage devices in DocumentsUI." into klp-dev 2013-10-18 01:46:52 +00:00
Jim Miller
0149127198 am 53cb242f: Merge "Fix issue where keyguard adds widgets before the system is ready" into klp-dev
* commit '53cb242f39c9ccfee3381ff28625e74e365d29b7':
  Fix issue where keyguard adds widgets before the system is ready
2013-10-17 16:19:31 -07:00
Jim Miller
53cb242f39 Merge "Fix issue where keyguard adds widgets before the system is ready" into klp-dev 2013-10-17 23:17:19 +00:00
Svetoslav Ganov
a225bbddec am 54e55759: Merge "All printers list has incorrect padding and item height." into klp-dev
* commit '54e5575924d3abba8129268d2d0553efc9a841eb':
  All printers list has incorrect padding and item height.
2013-10-17 11:11:35 -07:00
Svetoslav Ganov
54e5575924 Merge "All printers list has incorrect padding and item height." into klp-dev 2013-10-17 18:06:55 +00:00
Jeff Sharkey
1f706c6cd1 Include external storage devices in DocumentsUI.
Include volume UUID in generated document IDs to uniquely identify
volumes over time.  Show volume label to users.  Watch for mount
changes to update available roots.

Bug: 11175082
Change-Id: Ia151bde768587468efde0c1d97a740b5353d1582
2013-10-17 10:55:32 -07:00
Svetoslav Ganov
ed513d7e4a All printers list has incorrect padding and item height.
1. We were using the layout for the printer drop down from the
   print dialog as the list item in the all printers activity.
   This layout was not high enough. Now we have a separate
   layout for the drop down and for the list. Note that they
   are almost identical but this is better that writing java
   code to lookup the height from the theme and change it
   programatically since the java code is almost half the size
   of the layout and leads to spreading the logic in both the
   layout file and the java code.

2. The padding of the printers list was not correct. Now it
   mimics the bahavior in settings where we change the padding
   based on orientation.

bug:11261157

Change-Id: I8507c4ee86e9196fe1777cf9577f1886ccfbb1ad
2013-10-17 10:33:14 -07:00
Adam Powell
11c746abf3 am a9412556: Merge "Fix stale data in keyguard transport control display" into klp-dev
* commit 'a9412556d213e07b248ef7e924f0e4cee183efc5':
  Fix stale data in keyguard transport control display
2013-10-17 10:32:19 -07:00
Adam Powell
a9412556d2 Merge "Fix stale data in keyguard transport control display" into klp-dev 2013-10-17 17:29:52 +00:00
Jim Miller
e5f910a667 Fix issue where keyguard adds widgets before the system is ready
While under heavy system load,  keyguard was able to create widgets before
before ActivityManagerService was ready.  The result was a race
between keyguard adding widgets and ActivityManagerService being
ready to send broadcasts.

This fix provides keyguard with an additional signal to know when
the system is booted and widgets are safe to load.

Fixes bug b/11217169

Change-Id: I7a714d65b068678f961e52bdde4e1c20f9c287f0
2013-10-16 19:42:34 -07:00
Baligh Uddin
192a856df2 Merge "Import translations. DO NOT MERGE" into klp-dev 2013-10-17 01:08:31 +00:00
Baligh Uddin
829ebd42b2 Import translations. DO NOT MERGE
Change-Id: I0642a5841c24a7866dfe8a72ab2fc9acb696fd7d
Auto-generated-cl: translation import
2013-10-16 17:57:29 -07:00
Svetoslav
b196106a43 Printer list items have wrong width.
1. There was leftover code in the printers adapter that was
   hard coding the item width with no reason to do so.

2. Changed the icon view visibility to invisible to allow
   the text of all list items including save to PDF and all
   printers to be left aligned.

bug:11225340

Change-Id: I5b51d0d30577699f5cd73c7c58521358653d135b
2013-10-16 16:45:33 -07:00
Baligh Uddin
477af29d35 Merge "Import translations. DO NOT MERGE" into klp-dev 2013-10-16 23:20:39 +00:00
Baligh Uddin
b65ab00e10 Merge "Import translations. DO NOT MERGE" into klp-dev 2013-10-16 23:20:10 +00:00
Baligh Uddin
d232a6f988 Import translations. DO NOT MERGE
Change-Id: I45af8da3d23c08e5f32133336e1805149dbdba64
Auto-generated-cl: translation import
2013-10-16 14:40:31 -07:00
Baligh Uddin
f6cfa3de15 Import translations. DO NOT MERGE
Change-Id: I0d8bd44f316030e84c59cfcc88559adfd1215825
Auto-generated-cl: translation import
2013-10-16 14:38:03 -07:00
Baligh Uddin
5c9c04b0a2 Import translations. DO NOT MERGE
Change-Id: I8d3db29afb854493c03f60946e41720a0eea53e0
Auto-generated-cl: translation import
2013-10-16 14:36:28 -07:00
Jim Miller
7c95ae91b6 am 67fc6b0b: Merge "Fix issue where keyguard reports a valid token but doesn\'t draw" into klp-dev
* commit '67fc6b0b4708161bc8e716f7effc47e7c15d1ca6':
  Fix issue where keyguard reports a valid token but doesn't draw
2013-10-16 00:08:06 -07:00
Jim Miller
67fc6b0b47 Merge "Fix issue where keyguard reports a valid token but doesn't draw" into klp-dev 2013-10-16 07:05:22 +00:00
Jim Miller
f3cad9184f am db148b65: Merge "Fix memory leak and slowness in keyguard" into klp-dev
* commit 'db148b655633ed554fed70347fb227bf2f23f7de':
  Fix memory leak and slowness in keyguard
2013-10-15 20:55:47 -07:00
Jim Miller
db148b6556 Merge "Fix memory leak and slowness in keyguard" into klp-dev 2013-10-16 03:52:10 +00:00
Jim Miller
b2c64690a3 Fix memory leak and slowness in keyguard
This fixes an issue where the mUpdateSeekBars runnable was being
repeatedly posted to the handler while keeping a reference to
the transport control (and hence keyguard).  Even after the view
was detached from keyguard it would continue to post events that
would ultimately keep the instance of keyguard from being GC'd and
cause keyguard to slow down.

Fixes 11169793

Change-Id: If2bb238adf6d78101589926b60a61d9f187c6d1c
2013-10-15 20:11:50 -07:00
Adam Powell
3b435fb2f0 Fix stale data in keyguard transport control display
Make sure that caches are cleared at the right times and views have
their data populated correctly. Also fix a caching issue in
RemoteController.

Bug 11218218

Change-Id: Ieb833b5dc440ccd1b82050f12eb7059a4e0a412f
2013-10-15 19:18:04 -07:00
Adam Powell
cb13a54604 am 49b6d38f: Merge "Fix dodgy states of keyguard transport controls" into klp-dev
* commit '49b6d38fe7308d4641046af4a2d062cdc6033c30':
  Fix dodgy states of keyguard transport controls
2013-10-15 18:43:03 -07:00
Adam Powell
49b6d38fe7 Merge "Fix dodgy states of keyguard transport controls" into klp-dev 2013-10-16 01:41:22 +00:00
Adam Powell
bdb5ac7ddb Fix dodgy states of keyguard transport controls
If a layout has already been requested when we want to show the
correct widget pane, post the event for later and immediately return.

This works because PagedView has some interesting ideas about
maintaining a consistent state. It will attempt to recalculate the
current page position during measurement, but thanks to a reliance on
this measurement to establish scrolling boundaries that scrollTo uses
for clamping plus other code that depends on the idea that it can add
a new widget pane view and immediately scroll to it, this attempt to
scroll fails if the target page was added and measurement is not yet
complete. This patch ensures we don't hit these edge cases in a few
known ways.

While this ends things in the correct state, it predictably has a few
visual artifacts. Situations where things would completely fail
before, positioning pages incorrectly or fading out wrong pages now
will briefly flash and fade the widget frames or in some cases will
visibly animate from the starting page to the correct one. We should
address these issues in a future release.

Bug 11217368
Bug 9760604

Change-Id: I989d03b5bfdd5b6403a6b67a8aae7585ca0c8ae0
2013-10-15 18:10:41 -07:00
Jim Miller
ed80f3f01e Fix issue where keyguard reports a valid token but doesn't draw
This fixes an issue where keyguard isn't showing but tells
PhoneWindowManager to wait anyway.  The fix is to send a null token
when keyguard isn't showing.

Fixes bug 11216030

Change-Id: I4985fe50c63819415d9d5a1de0b741c8aa6391d8
2013-10-15 17:50:17 -07:00
Michael Wright
19fa212251 am 6bd7603a: Merge "Force the wallpaper to reload when dimensions change" into klp-dev
* commit '6bd7603a56cd671c4523d66c1e7378c27a6ac33c':
  Force the wallpaper to reload when dimensions change
2013-10-15 16:45:10 -07:00
Michael Wright
6bd7603a56 Merge "Force the wallpaper to reload when dimensions change" into klp-dev 2013-10-15 23:40:14 +00:00
Baligh Uddin
ffe8b79f36 am e1b6b6c5: Bring deleted files from the dead. These files were dropped by the translation pipelines because they do not contain any translated elements, but in reality they are needed.
* commit 'e1b6b6c5816b321864b6a5d72a46860fda8fa7cd':
  Bring deleted files from the dead. These files were dropped by the translation pipelines because they do not contain any translated elements, but in reality they are needed.
2013-10-15 16:00:13 -07:00
Baligh Uddin
e1b6b6c581 Bring deleted files from the dead.
These files were dropped by the translation
pipelines because they do not contain any
translated elements, but in reality they
are needed.

Bug: 11226380
2013-10-15 22:47:02 +00:00