CloseGuard instances are allocated in constructors and usually
assigned to final fields. This implies they're non-null in finalizers
except in the case where the constructor throws. We add a null check
to make sure we can continue cleaning up other state in the finalizer
(if applicable).
Also, this change decouples closeguard warnings in constructors
from other state based logic. This because the logic there is usually
duplicated with the call to close().
NOTE: This change is not a "complete" fix. Many of these finalizers
are broken in the case where <init> throws. The only objective of
this change is to make such errors more obvious.
Note that some of these classes don't have CTS tests.
Test: make, CtsMediaTestCases.
Bug: 35609098
Change-Id: I24d9e0215f80e44914dba8ab99b6312fd6ed1fc0
In order to differentiate between various reasons for authentication
failure, add reason codes. These will be hidden since we don't intend to
have API change.
Bug: 33245941
Test: Unit test
Change-Id: I7222520df18e54d684ba9e50ff95be5d46a7d70c
Per API Council, we should use the trademark name Passpoint
instead of passpoint in the code comments.
Bug: 35854283
Test: make -j32
Change-Id: Iea6697191a936d1d779c0ea50cd19c134bc7df02
An UnsupportedOperationException will be thrown for Passpoint related
API calls if Passpoint is not enabled on the device (build config
config_wifi_hotspot2_enabled is set to false).
Bug: None
Test: None
Change-Id: Id0ba1f7b80091d55a839fa3eee36baf9b45b7f5f
Simplify API: semantics of publish/subscribe count restrictions
aren't clear at the app level. They depend on DW configuration as
well as discovery session type - number of packets transmitted over
the air.
There's already an app-facing discovery session lifetime configuration -
the TTL. That has clearer semantics and is sufficient (for now).
Bug: 36446307
Test: unit tests and integration (sl4a) tests.
Change-Id: I9129975bd2e1a61b3d23a4b6acaae703b42216c7
This is now deprecated in the public API and instead calls
isWifiEnabled(). So, remove this AIDL call.
Bug: 36493092
Test: Compiles
Change-Id: I6339d5bb18f423d84fa9222a87e2df7eb9c336a9
Merged-In: I6339d5bb18f423d84fa9222a87e2df7eb9c336a9
Each vendor might put additional headers and content type attributes
in the installation file, and will not be useful for us. So just
ignore them when parsing the installation file instead of error out.
While there, add support for parsing "Extension" node in PpsMoParser.
This an interior node containing vendor specific information, only
meaningful to the vendor. So we will ignore fields under this node.
Bug: 36477333
Test: frameworks/base/wifi/tests/runtests.sh
Test: manual test by installing ruckus Passpoint profile
Change-Id: I9954ed000387bc8048d0452a5bfb0f339e676659
This is now deprecated in the public API and instead calls
isWifiEnabled(). So, remove this AIDL call.
Bug: 36493092
Test: Compiles
Change-Id: I6339d5bb18f423d84fa9222a87e2df7eb9c336a9
Addressing the concerns raised by API council for deprecating this
field.
Bug: 35854198
Test: make update-api
Change-Id: If9ca582f5d3bd8539a226b425662832241a447cc
Adding some documentation to explain the expected contents of this
field.
Bug: 35967623
Test: make update-api
Change-Id: Ia28e2c79834c4d7b0de7350c18d5f32633e6309d
Addressing the concerns raised by API council for deprecating this
field.
Bug: 35854198
Test: make update-api
Change-Id: If9ca582f5d3bd8539a226b425662832241a447cc
Adding some documentation to explain the expected contents of this
field.
Bug: 35967623
Test: make update-api
Change-Id: Ia28e2c79834c4d7b0de7350c18d5f32633e6309d
