588450 Commits

Author SHA1 Message Date
Treehugger Robot
c34b1748fe Merge "Use public API of Settings.Secure to get/put secure settings" am: d7203652f7 am: dbb2d21bbb am: 93d09dde3a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1463904

Change-Id: I44485af3218d14808c5bdee2269ad1cc503bd5e1
2020-10-21 09:42:59 +00:00
Gavin Corkery
b6a3409500 Fix Rescue Party observability criteria
The previous behavior erroneously returned if the package
was not found by PackageManager#getModuleInfo, which means
the persistent process check would never be performed. This
caused packages like com.android.systemui to not be handled
by Rescue Party's mitigation logic. Instead, ensure that
both cases are checked.

Test: setprop persist.sys.enable_rescue true,
      adb shell setprop debug.crash_sysui 1,
      adb shell kill `pidof com.android.systemui`,
      ensure recovery mode is reached
Bug: 169284310
Change-Id: Ifec19b8daba1dacc7f5efcfa47ed3c3a046612e3
Merged-In: Ifec19b8daba1dacc7f5efcfa47ed3c3a046612e3
(cherry picked from commit f2abc4e6fa6ed79462e0ddfc6ede526edc646378)
2020-10-21 10:37:41 +01:00
Eran Messeri
df3eb6cff2 Merge "Rename methods that take caller identity" 2020-10-21 09:35:08 +00:00
Treehugger Robot
1fc3b18284 Merge "CEC: Set IO looper to control service in message validator test" am: 8c82061a05 am: 0220e9b3f4
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1463903

Change-Id: Ib7ce8d5b81469894fa1dbbcd8c528e0eb4984944
2020-10-21 09:30:19 +00:00
Bill Yi
25f3e9a3a8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie666cd5674eab6f8746f41e3bd1af2947ef51393
2020-10-21 02:28:24 -07:00
Treehugger Robot
0220e9b3f4 Merge "CEC: Set IO looper to control service in message validator test" am: 8c82061a05
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1463903

Change-Id: I9af41dc2ea88671abe760de8de4fb93379d7703b
2020-10-21 09:26:10 +00:00
Treehugger Robot
93d09dde3a Merge "Use public API of Settings.Secure to get/put secure settings" am: d7203652f7 am: dbb2d21bbb
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1463904

Change-Id: I007c12c13166e38181b5d45b9c106b8c1d832c91
2020-10-21 09:24:42 +00:00
Louis Chang
e71f6765b6 Merge "Revert "Pausing the resumed activity when making it invisible"" 2020-10-21 09:20:16 +00:00
Galia Peycheva
224c843af0 Merge "Add background blur in WindowManager" 2020-10-21 09:09:04 +00:00
Treehugger Robot
8c82061a05 Merge "CEC: Set IO looper to control service in message validator test" 2020-10-21 09:02:42 +00:00
Treehugger Robot
dbb2d21bbb Merge "Use public API of Settings.Secure to get/put secure settings" am: d7203652f7
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1463904

Change-Id: Ic681954e4daf5242ef5cc5f02fb48f080e57d533
2020-10-21 08:43:37 +00:00
Treehugger Robot
91114249ef Merge "Address comments on aosp/1448415" am: 1a41c294c5 am: bafa575166 am: 2920fb27af am: 94040f7db0
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465505

Change-Id: If14a6913d9d721f0fa680afe0ee51e089fddb749
2020-10-21 08:32:11 +00:00
Treehugger Robot
d7203652f7 Merge "Use public API of Settings.Secure to get/put secure settings" 2020-10-21 08:32:04 +00:00
Chiachang Wang
73a919980a Merge "Remove the usage of SystemProperties.set()" am: fe1f37de9c am: 1ed76ebfe8 am: 5382021e07 am: 85cc3c889c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465504

Change-Id: I8e9e35a830f2329a94eb6da93ea2fb17e912dd00
2020-10-21 08:31:49 +00:00
Chiachang Wang
0e02e2f209 Merge "Do not use hidden SystemProperties.set" am: 8c6ec17bac am: d7146b6742 am: 988643b724 am: 357cd1d2a0
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1460971

Change-Id: Ie125f2d0d5605180189fa1dfbef70286ad79c23e
2020-10-21 08:31:09 +00:00
Treehugger Robot
94040f7db0 Merge "Address comments on aosp/1448415" am: 1a41c294c5 am: bafa575166 am: 2920fb27af
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465505

Change-Id: I20be1778be2f00d8cbd310743f0a93b350fd8313
2020-10-21 08:14:05 +00:00
Chiachang Wang
85cc3c889c Merge "Remove the usage of SystemProperties.set()" am: fe1f37de9c am: 1ed76ebfe8 am: 5382021e07
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465504

Change-Id: Ie38e0ce264c899b278c2e46379bbeb9e787fb25a
2020-10-21 08:13:44 +00:00
Chiachang Wang
357cd1d2a0 Merge "Do not use hidden SystemProperties.set" am: 8c6ec17bac am: d7146b6742 am: 988643b724
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1460971

Change-Id: Iac749359f15229a89782e16309352ef8f0624da1
2020-10-21 08:13:21 +00:00
Treehugger Robot
2920fb27af Merge "Address comments on aosp/1448415" am: 1a41c294c5 am: bafa575166
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465505

Change-Id: I86a2f48ee199c83c429d99d5025ece56f42251cd
2020-10-21 08:03:39 +00:00
Chiachang Wang
5382021e07 Merge "Remove the usage of SystemProperties.set()" am: fe1f37de9c am: 1ed76ebfe8
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465504

Change-Id: Ia709f1949930beb65191e197110114414332e72a
2020-10-21 07:59:50 +00:00
Treehugger Robot
bafa575166 Merge "Address comments on aosp/1448415" am: 1a41c294c5
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465505

Change-Id: Ia08a2d1f91651db42b5f04065ce02e139774f572
2020-10-21 07:58:26 +00:00
Chiachang Wang
988643b724 Merge "Do not use hidden SystemProperties.set" am: 8c6ec17bac am: d7146b6742
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1460971

Change-Id: I3ff0ce12f3b12e0eb78f330a75675fb79ecf561d
2020-10-21 07:55:31 +00:00
Chiachang Wang
1ed76ebfe8 Merge "Remove the usage of SystemProperties.set()" am: fe1f37de9c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1465504

Change-Id: I66e32ac8164fce2e205c49e407eb901994bcd5c8
2020-10-21 07:55:18 +00:00
TreeHugger Robot
bab493d0fb Merge "Import translations. DO NOT MERGE ANYWHERE" 2020-10-21 07:29:58 +00:00
Chiachang Wang
d7146b6742 Merge "Do not use hidden SystemProperties.set" am: 8c6ec17bac
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1460971

Change-Id: I83579fdfe9f1e29ff8dda5995f0772a223a9d1c2
2020-10-21 07:27:27 +00:00
Treehugger Robot
1a41c294c5 Merge "Address comments on aosp/1448415" 2020-10-21 07:05:49 +00:00
TreeHugger Robot
a7fc923821 Merge "Import translations. DO NOT MERGE ANYWHERE" 2020-10-21 07:04:10 +00:00
Chiachang Wang
fe1f37de9c Merge "Remove the usage of SystemProperties.set()" 2020-10-21 07:01:38 +00:00
Chiachang Wang
8c6ec17bac Merge "Do not use hidden SystemProperties.set" 2020-10-21 07:00:56 +00:00
Louis Chang
fc2507c74e Revert "Pausing the resumed activity when making it invisible"
This reverts commit 9cbadee7412303bb080370647e960917e417075f.

Reason for revert: b/171220278

Change-Id: Ib73285473168f1541a41564a6ef02f9ca18ac4c3
2020-10-21 05:37:21 +00:00
TreeHugger Robot
e8dde5dd10 Merge "Remove unused SEAMLESS_TRANSFER constant" 2020-10-21 05:03:46 +00:00
Chalard Jean
da33a05297 Address comments on aosp/1448415
Adds the necessary jarjar rules to FrameworksTestNet and
removes the test for CompareResult which has moved to its
right place.

Test: FrameworksTestNet
Change-Id: I50e51e72268e432a65a831aa5eebd606584ac721
2020-10-21 13:54:02 +09:00
Bill Yi
535967f573 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5c4ce8f43dc36fc999c7897ee9c0a94ceca7f7f7
2020-10-21 04:41:16 +00:00
Amy Zhang
ad45461f58 Merge "Remove the ScanCallback API default implementation logs" 2020-10-21 04:00:21 +00:00
Jeff Sharkey
c603ca2dd8 Apply fixes for EfficientStrings.
Refactoring to avoid StringBuffer synchronization overhead.

Bug: 170978902
Test: none
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: Ibf843ed780c1202d5d96a11eaca889e592f19263
2020-10-20 22:00:20 -06:00
Jeff Sharkey
f18719bb73 Apply fixes for EfficientStrings.
Refactoring to avoid paying the cost of extra StringBuilder that are
quickly disposed.

Bug: 170978902
Test: none
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: Icd914a63cdadf8123c1e5a5073f85245f0791f0b
2020-10-20 22:00:18 -06:00
Jeff Sharkey
1c08f48253 Apply fixes for EfficientStringsChecker.
The recently-built Error Prone checker has found many instances where
we're always paying the cost of StringBuilder concatenation, even in
the typical cases where preconditions are successfully met.

Benchmarks have shown that even when replacing these with varargs
formatter strings, the default case is 20x faster.

Bug: 170978902
Test: none
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: If8c00bc73467bfb91ec16c162969c9d26ca53646
2020-10-20 22:00:16 -06:00
Jeff Sharkey
df8dc2b4a5 Apply fixes for EfficientCollections.
Drop-in replacements suggested for inefficient collections.  Also
annotate a handful of places where we're unable to update.

Bug: 155703208
Test: none
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: I48b600508df8160ac9b40fea7afca974b2c972f6
2020-10-20 21:57:00 -06:00
Jeff Sharkey
a49ba3ac12 Trivial refactor for consistent naming.
This gives all our various new performance-related checkers a
consistent "EfficientFooChecker" naming style.

Bug: 155703208
Test: atest error_prone_android_framework_test
Change-Id: I8809fe46d20357201c8559037b468d717319afb9
2020-10-20 21:54:37 -06:00
Jeff Sharkey
caf66d02fd Expand formatSimple() to support widths.
One of the highest-traffic users of String.format() is in the
notification code, which uses argument widths.  To support these
use-cases, this change adds argument width support, with tests.

Bug: 170978902
Test: atest error_prone_android_framework_test
Exempt-From-Owner-Approval: trivial additions
Change-Id: I8e36d4725a6d0cc896dedc5c457eb5f38486d7b6
2020-10-20 21:54:26 -06:00
Suprabh Shukla
2511a5420f Moving alarm service dump to IndentingPrintWriter
IndentingPrintWriter provides more consistent formatting and syntax.
Removing any unused legacy methods.

Test: Build, flash and manually inspect the output of:
adb shell dumpsys alarm

Fixes: 171340137
Change-Id: I8adb9280ed3c8c835562c2c158e0bfb668f8b1cb
2020-10-20 20:11:56 -07:00
Treehugger Robot
ebf97e4b17 Merge changes I732f0e78,I7a8f668c,I1f439621,I55122a7b,I83c43497, ... am: d318d93dd5 am: bad1cba5f0 am: 0e38639186 am: 7ffb852738
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1457564

Change-Id: I27cba4403a1b24ed4567a82783755ad8d2f4fed3
2020-10-21 02:43:31 +00:00
Treehugger Robot
7ffb852738 Merge changes I732f0e78,I7a8f668c,I1f439621,I55122a7b,I83c43497, ... am: d318d93dd5 am: bad1cba5f0 am: 0e38639186
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1457564

Change-Id: I36756ceda42bf38df9ccd30e76ea7aa6f4d5266e
2020-10-21 02:25:30 +00:00
Bill Yi
ac6de5e80b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I507d20b249c1e2be1f6bdbfe193e345969f32ca9
2020-10-21 02:11:08 +00:00
Jeongik Cha
7e56edb84f Merge "Expose 'ParcelableHolder' as SystemApi" am: 135efb0b73 am: 5e1cacaa28 am: d5bae241d4 am: 0522a33e24
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1458065

Change-Id: Ic28ef16a1e1d08db0f2ea6c735295d748b3f8a89
2020-10-21 02:01:58 +00:00
Treehugger Robot
0e38639186 Merge changes I732f0e78,I7a8f668c,I1f439621,I55122a7b,I83c43497, ... am: d318d93dd5 am: bad1cba5f0
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1457564

Change-Id: I5c8819a4061c0c7746ecb1d3a19c806aa50cd5fe
2020-10-21 02:01:31 +00:00
Jeff Sharkey
5c46da2a14 Refinement of EfficientStringsChecker.
It's okay if callers try mixing "static final" values into strings,
since the compiler will inline these to avoid the StringBuilder.

We also expand to catch any arguments that might be dynamically
calculated, such as method invocations.

Identify additional inefficient code patterns:

-- Passing dynamic strings into a StringBuilder, which acquires a
transparent StringBuilder for each append.
-- Using "str += val;" style concatenation, which acquires a
transparent StringBuilder for each append.
-- Using StringBuffer which has synchronization overhead.

Bug: 170978902
Test: atest error_prone_android_framework_test
Change-Id: Ia3758dd55a0e6753b0cc5bc83ae8fe45b6bfde1f
2020-10-20 19:58:16 -06:00
Jeongik Cha
0522a33e24 Merge "Expose 'ParcelableHolder' as SystemApi" am: 135efb0b73 am: 5e1cacaa28 am: d5bae241d4
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1458065

Change-Id: I5f8d912b43a546aca9cbbd8d9c480ffa101c1452
2020-10-21 01:42:20 +00:00
Treehugger Robot
bad1cba5f0 Merge changes I732f0e78,I7a8f668c,I1f439621,I55122a7b,I83c43497, ... am: d318d93dd5
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1457564

Change-Id: I1bfc5b934e7d455fd49c65f3b3fa07cdf7a4fbf4
2020-10-21 01:25:12 +00:00
Jeongik Cha
d5bae241d4 Merge "Expose 'ParcelableHolder' as SystemApi" am: 135efb0b73 am: 5e1cacaa28
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1458065

Change-Id: I7af96574a930efed7c5c7d45a0c5bfd40a569d22
2020-10-21 01:14:09 +00:00