115 Commits

Author SHA1 Message Date
Jeff Sharkey
0ab7007631 resolve merge conflicts of 358f0d4fc8c248498cf113c41e043877a14e89a1 to master
Bug: 174932174
Test: I solemnly swear I tested this conflict resolution.
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I9262a08ffc1ccede8e519d0eed90ed2bfcf0232c
2020-12-08 11:01:05 -07:00
Jeff Sharkey
52b9862f87 Improve OWNERS coverage across frameworks/base/.
As general background, OWNERS files expedite code reviews by helping
code authors quickly find relevant reviewers, and they also ensure
that stakeholders are involved in code changes in their areas.

Some teams under frameworks/base/ have been using OWNERS files
successfully for many years, and we're ready to expand them to cover
more areas.  Here's the historical coverage statistics for the last
two years of changes before these new OWNERS changes land:

-- 56% of changes are fully covered by OWNERS
-- 17% of changes are partially covered by OWNERS
-- 25% of changes have no OWNERS coverage

Working closely with team leads, we've now identified clear OWNERS on
a per-package basis, and we're using "include" directives whenever
possible to to simplify future maintenance.  With this extensive
effort, we've now improved our coverage as follows:

-- 98% of changes are fully covered by OWNERS
-- 1% of changes are partially covered by OWNERS
-- 1% of changes have no OWNERS coverage

This specific change is automatically generated by a script that
identifies relevant "include" directives.

Bug: 174932174
Test: manual
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Merged-In: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
Change-Id: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
2020-12-08 08:36:28 -07:00
TreeHugger Robot
af764c805b Merge "incfs: Create incomplete folder" 2020-11-21 01:09:21 +00:00
Paul Lawrence
87a92e1bc5 incfs: Create incomplete folder
incfs 2 also creates a .incomplete folder, so we need to set correct
permissions on that folder too

Bug: 169084168
Test: With updated kernel, incfs_test works and adb install
	--incremental works
Change-Id: Id7b9d017973777e37628664530dfed18c55c269f
2020-11-20 13:18:01 -08:00
Songchun Fan
6944f1e484 [incremental] add last pending reads info in dumpsys
Example section of dumpsys output:
        lastPendingReads:
          fileId: 03300000000000000000000000000000
          metadataHex: 0330
          blockIndex: 857738
          bootClockTsUs: 166877488

Test: manual
BUG: 162600251
Change-Id: I37b04751c2a11972450ce7e9082116f8047e87df
2020-11-09 22:07:54 +00:00
Songchun Fan
2570ec01c6 [incremental/pm] set health listener on commit and on reboot
This changes allow Incremental Service to directly report health status
to package manager service.

A health listener is created during package installation session to
monitor incremental storage health. After commit, a new listener is
created and will overwrite the old one.

The new listener will listen to incremental storage health and report
the status to package manager service, which will then send the status
to IncrementalStates, where the startability state and unstartable
reason might change, based on the health status code.

During reboot, for each incremental package, if it is not fully loaded,
the package manager service will register a health status listener to
continue monitor the health status of this package.

Test: unit test
Test: manual
BUG: 170435166
Change-Id: I220f230c523cfaf2c96019f9478554665e6af486
2020-10-20 01:13:07 +00:00
Songchun Fan
3309398cbf [incremental/pm] app states and transitions
Based on go/incremental-states-design with basic
setter/getters.

Defines IncrementalStates class which handles state transitions.

New (internal) Intent actions: PACKAGE_FULLY_LOADED, PACKAGE_STARTABLE,
PACKAGE_UNSTARTABLE.

BUG: 168043976
Test: unit tests
Change-Id: I7b0ec2dd9f028ee620a9307a1e71ddf12ea5a9af
2020-10-01 16:36:25 -07:00
Songchun Fan
2ff2a488e6 [incremental] fix x86 native lib extraction
Test: atest CtsIncrementalInstallHostTestCases
BUG: 168138334
Change-Id: I7b76afbd88cf3f38c1527c9c917ce179e0bde589
2020-09-29 18:53:18 +00:00
Alex Buynytskyy
bd8444d1e3 Excessive battery usage fix.
Using wake to forcefully wake up the looper instead of 1s timeout.

Fixed: 168156055
Test: atest ApkVerityTest:com.android.apkverity.ApkVerityTest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: If65f65f9214b34bf057ed5f1877348d835251d14
Merged-In: If65f65f9214b34bf057ed5f1877348d835251d14
2020-09-24 21:50:38 +00:00
Alex Buynytskyy
b65a77f7b5 Using wake to forcefully wake up the looper instead of 1s timeout.
Bug: 168156055
Test: atest ApkVerityTest:com.android.apkverity.ApkVerityTest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest ChecksumsTest
Change-Id: If65f65f9214b34bf057ed5f1877348d835251d14
2020-09-22 11:45:21 -07:00
Alex Buynytskyy
b39d13ed7f Installer digests for Incremental installations.
Bug: 160605420
Test: atest ChecksumsTest
Change-Id: I9d46c218cccf87781e9b33711c4d02d94bf824f5
2020-09-21 12:40:56 -07:00
Songchun Fan
a70985945b [incremental/pm] register progress listener
Incremental Serivce periodically polls loading progress and sends to
Package Manager Service. Package Manager provides APIs for other
interested parties to listen to the loading progress.

BUG: 165841827
Test: unit test
Change-Id: I44b9e17c2240b9efe53bc09fc728b6671f1f7dfe
2020-09-15 17:39:41 -07:00
Jeongik Cha
388d5136b5 Add '-unstable' to solve ODR violation
The interface which is imported by an unstable interface is 'unstable'
as well. Until now, the ODR violation checker in aidl has omitted an
interface imported, but it will be checked, accordingly, fix the current
problem

Bug: 146436251
Test: m nothing
Change-Id: I3a9ae6e17e49c731e825ef00b9b9574c3f2e2719
Merged-In: I3a9ae6e17e49c731e825ef00b9b9574c3f2e2719
Exempt-From-Owner-Approval: cp from internal
2020-09-11 15:39:46 +09:00
Xin Li
628590d7ec Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)
Bug: 166295507
Merged-In: I3d92a6de21a938f6b352ec26dc23420c0fe02b27
Change-Id: Ifdb80563ef042738778ebb8a7581a97c4e3d96e2
2020-08-31 21:21:38 -07:00
TreeHugger Robot
99a44d8579 Merge "Add '-unstable' to solve ODR violation" into rvc-dev-plus-aosp am: 2555567ca2 am: 7cab297dc3 am: 7cfc3735c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12377822

Change-Id: If65dbd2062c742d4056bf50441aeb86619d180ce
2020-08-28 02:57:14 +00:00
Alex Buynytskyy
bc0a7e6cbf Wait for APK to be fully downloaded for full APK digests.
Bug: 160605420
Test: atest ChecksumsTest
Change-Id: Ib9fd591c67290786268b6dcdc57c7db153612e01
2020-08-27 10:33:46 -07:00
Songchun Fan
425862f3e7 [incremental] storage is regarded as fully loaded if there's no file or only empty files
Test: atest service.incremental_test
BUG: 165799231
Change-Id: I3b6be3918d53ce4ab0a30a4da493d9730a31ed3c
2020-08-25 13:17:28 -07:00
Songchun Fan
374f7654df [IncrementalService] getLoadingProgress (v1)
This is to unblock Launcher's work on progress ring. Currently it uses
incfs getFilledBlocks(). Will switch to the new incfs progress reporting
API once it is ready.

Test: unit test
Test: adb shell dumpsys incremental
BUG: 165799231
Change-Id: Icd68124806454f888826294da36f109bca9771ac
2020-08-22 04:17:02 +00:00
Jeongik Cha
b3288fbdd5 Add '-unstable' to solve ODR violation
The interface which is imported by an unstable interface is 'unstable'
as well. Until now, the ODR violation checker in aidl has omitted an
interface imported, but it will be checked, accordingly, fix the current
problem

Bug: 146436251
Test: m nothing
Change-Id: I3a9ae6e17e49c731e825ef00b9b9574c3f2e2719
2020-08-14 14:36:32 +00:00
Jooyung Han
16bac8513e Switch aidl::nullable to std::optional
AIDL's @nullable is represented as std::optional in C++ backend.
The previous aidl::nullable was a temporary solution to avoid
merge-conflicts between rvc-dev and master branches.

Bug: 151275535
Test: m
Change-Id: I8fe5bfc1763087e7ff364b4408f862436492d1db
2020-08-10 08:36:35 +00:00
Songchun Fan
6618aa74a7 Merge "[IncrementalService] fix native lib check after OTA" into rvc-dev am: 9093346b9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12141813

Change-Id: I7c7fec04934ff6f4773d71673b7e10f43067787a
2020-07-15 16:48:42 +00:00
Songchun Fan
c8975312c5 [IncrementalService] fix native lib check after OTA
The lib dir should always be at the same dir level as the APK file.

Test: manual with OTA
Test: atest CtsExtractNativeLibsHostTestCases
BUG: 160826412
Change-Id: I87d715c4739c78bb56b85d375838db08bafa1594
2020-07-13 12:14:37 -07:00
TreeHugger Robot
84f65247cb Merge "Don't provide read logs for shell-initiated installations." into rvc-dev am: e0ba6d9dff
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11778056

Change-Id: I866bc89927ae11a0da7069d33e3e06d5c1f1b51f
2020-06-15 16:42:24 +00:00
Alex Buynytskyy
0403545508 Don't provide read logs for shell-initiated installations.
Only if the application is profileable.

Bug: 158238023
Fixes: 158238023
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest PackageParserTest
Change-Id: I8575830ec3f29850297fdbfbaa157072d6350a28
Merged-In: I8575830ec3f29850297fdbfbaa157072d6350a28
2020-06-12 13:30:45 -07:00
Orion Hodson
8c238bab8c Add explicit dependencies on jni_headers
Preparation for removing implicit include paths for jni.h from
soong.

Bug: 152482542
Test: m checkbuild
Change-Id: I7e7a0df96249fad3eb07977b87ae7953c4b22b5f
Merged-In: I7e7a0df96249fad3eb07977b87ae7953c4b22b5f
Exempt-From-Owner-Review: cherry pick
(cherry picked from commit b9b2b7a42654a006301fdb5ae8ce274b82f57be9)
2020-06-02 19:18:38 +01:00
Alex Buynytskyy
4115191cc4 Merge "Healthcheck: proper job allocation and test." into rvc-dev am: c4ac9d2321
Change-Id: I9257064a3c0a064f2217adbe8ab5c00f26027896
2020-06-01 16:04:42 +00:00
Alex Buynytskyy
46d3ddb311 Healthcheck: proper job allocation and test.
Bug: 153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest

Change-Id: Iede1f2297cc4f8e3c3f0acd43cee597f75dff179
2020-06-01 00:25:23 +00:00
TreeHugger Robot
27ee72a794 Merge "Lifecycle: detecting blocked and unhealthy, part 2." into rvc-dev am: 825ad11167
Change-Id: I5dd609fb62c658b056c2b32efe85354ec90ffea3
2020-05-29 19:19:06 +00:00
Alex Buynytskyy
4760d8ff75 Lifecycle: detecting blocked and unhealthy, part 2.
Part 2: continuous health checking, blocked and unhealthy states.

Bug: 153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ifdbff7dfa24b3bd9b96c534a40bb1226082749ca
2020-05-29 10:32:59 -07:00
Songchun Fan
b8e087607b Merge "[incremental] respect extractNativeLibs in native lib config" into rvc-dev am: f2a6af4b8a
Change-Id: Ibc96844cf6737663c48c9133b49bc9c972ed632f
2020-05-28 00:59:35 +00:00
Songchun Fan
f2a6af4b8a Merge "[incremental] respect extractNativeLibs in native lib config" into rvc-dev 2020-05-27 22:17:23 +00:00
Songchun Fan
14f6c3c735 [incremental] respect extractNativeLibs in native lib config
Makes sure the behavior is consistent with legacy installs:

When the flag is on, the native libs will be extracted to subdirs under
lib/.
When the flag is off, the lib/ subdirs will be created but the native
libs are not extracted.
When the flag is off, check if the native libs are uncompressed and well
aligned.

Test: atest android.extractnativelibs.cts.CtsExtractNativeLibsHostTest
BUG: 157173358
Change-Id: Idb57fd7ca1115f787faf5cde3056c32ff3f60890
2020-05-27 22:16:57 +00:00
Alex Buynytskyy
53ea003df2 Merge "Lifecycle: detecting blocked and unhealthy." into rvc-dev am: 4e5ff2eb7d
Change-Id: If0f24b8549fbf78aecf4586551528606064ecfe7
2020-05-27 04:17:10 +00:00
Alex Buynytskyy
8ef61aebee Lifecycle: detecting blocked and unhealthy.
Part 1: interfaces and PM implementation.

Bug: 153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I312dd919d2bb552bea3d72fb49fd1579882da14b
2020-05-26 19:34:39 +00:00
TreeHugger Robot
6bbe3e40a7 Merge "Don't restart non-system DataLoaders on reboot." into rvc-dev am: afdf940276
Change-Id: I48e7d1ed40e787fb63445d68aa0e198e555c0857
2020-05-18 21:46:51 +00:00
Alex Buynytskyy
ea96c1f624 Don't restart non-system DataLoaders on reboot.
This saves system's resources.
Healthcheck will automatically start data loader on pending reads.

Bug: 153874006
Test: test PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I160153f1d3e7e653db5de06b59d6fbbc3667fdf2
2020-05-18 11:40:43 -07:00
TreeHugger Robot
880974ebd0 Merge "Don't try to recreate IncrementalFileStorages on re-commit." into rvc-dev am: eb191392e6
Change-Id: I8ac2224ccd7d4a7d1e69da137e598800187bdf92
2020-05-13 16:14:40 +00:00
Alex Buynytskyy
4dbc0607ee Don't try to recreate IncrementalFileStorages on re-commit.
Bug: 156287164
Fixes 156287164
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest

Change-Id: I75e392a1fa84df8b6ac0b855233f9a2662998e96
2020-05-12 13:49:29 -07:00
Alex Buynytskyy
8186dcc0a3 Merge "Addressing CL comments." into rvc-dev am: 9bd14c445e
Change-Id: I5b32e751573a8f91433731426fd2f16be7502208
2020-05-10 05:15:34 +00:00
Alex Buynytskyy
d0855a3ad8 Addressing CL comments.
Bug: 153874006
Test: test PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ie8b86cdc382955840cc3718d79a45991cf89b879
2020-05-08 10:35:58 -07:00
Alex Buynytskyy
c25f3b1cd0 Merge "Lifecycle: detecting pending reads." into rvc-dev am: d59d694f11
Change-Id: I3e015fa74dc293a9de0f45c1e6574d15539aa840
2020-05-08 00:45:27 +00:00
Alex Buynytskyy
cca2c1110c Lifecycle: detecting pending reads.
Once pending read detected, try to start the dataloader.

Bug: 153874006
Test: test PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest

Change-Id: Ia8169ccbb0f710317715e6fddb9bc6a718543766
2020-05-07 21:22:14 +00:00
Alex Buynytskyy
9c1aebb8d1 Merge "Additional lock to avoid access to deleted object." into rvc-dev am: 28d1236852
Change-Id: I51ba1e6068c9f1bf6f9bf73d07ab831a7094a8be
2020-05-05 05:24:36 +00:00
Alex Buynytskyy
b0ea448eeb Additional lock to avoid access to deleted object.
Bug: b/155692497
Fixes: 155692497
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ie02012bd5a6c0640d54c5390d3726a5405042408
2020-05-04 18:41:47 -07:00
Orion Hodson
8f1303d39e Remove unneeded dependency on libnativehelper
Bug: 151443957
Test: m service.incremental
Change-Id: I251796cf521ed3804b2c9018c43469289032e315
Merged-In: I251796cf521ed3804b2c9018c43469289032e315
(cherry picked from commit 90f0e7a53c00650783dc97fa41235b09a22d6414)
2020-04-30 09:16:32 +00:00
Alex Buynytskyy
7e0a1a8ec7 Unavailable DataLoader status.
This is a temporary failure, does not fail the session, but requires
caller to re-commit. E.g. there are connectivity issues which can be
fixed later.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I02791a2963130dbecb510c4a7cafcf04f6245761
2020-04-29 04:23:49 +00:00
Alex Buynytskyy
64067b25b1 Fix for Binder one-way deadlock.
Dispatch session destroy to be executed later.
We can't do anything blocking during one-way transaction processing.
This blocks all one-way transactions to this Binder, including other
status updates.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Test: atest IncrementalInstallerTest#testIncrementalInstallFails_onPrepareImageReturnsFalse
Change-Id: Ie4385d603fca8b5205775e849e92846cff672f56
2020-04-27 11:06:29 -07:00
Alex Buynytskyy
0bdbccf37c Corner cases handling.
- crash on disappearing dataloaders,
- more robust binder callbacks processing,
- heavy unbind lifting moved to a separate thread to unblock Binder.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: Ie06c3c4dbecbdd552dd868e2092bf0ee48f8547a
2020-04-23 22:28:36 -07:00
Alex Buynytskyy
ea1390ff32 Keep only service binding in DataLoaderManager.
This simplifies:
- resource management - no extra copies of controls,
- state management - all states in one place, no more hidden (bound but
not created) state.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I3d16a099c7f42fcf14637c5a8e96bd6f99e073d1
2020-04-23 19:38:44 +00:00
Yurii Zubrytskyi
510037b064 [cleanup] Enable clang-tidy and fix warnings
Moving out of a const variable doesn't really work, apparently

Bug: 153704006
Test: builds & boots
Change-Id: Id7322f7045c08a20d72dda50808c0be427064cdd
2020-04-22 22:34:24 -07:00