This makes sure DataLoader won't be able to obtain read logs once user
denies access.
Bug: b/152633648
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Test: adb shell appops set 1000 GET_USAGE_STATS deny
Change-Id: Ibbb74933b4ef0dd8f5fe27732743e5820b8ee4dc
To avoid code review comments about code style, line length, and
spacing, enable clang-format for frameworks/base/services/core/jni
Bug: none
Test: repo upload
Change-Id: Ie38ecca2d5face78367d3eab450e497120ce12b1
To have consistent code style and avoid format-related comments in code
review, enable clang-format in frameworks/base/core/jni.
Bug: none
Test: repo upload
Change-Id: Ie9e5408d85036dfabae3a9c60b238b4a190da5fc
Currently, there is no format enforcement for hid command. Add
clang-format hook for all input-related code in frameworks/base.
Bug: None
Test: repo upload
Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
The kotlin linter is particularly useful for tests written in Kotlin in
frameworks/base.
This is already merged in internal master.
Test: Tried uploading change with/without kotlin style problems.
Merged-In: Ie8659765b674ac7b2d82ed3d343f387195c07d83
Change-Id: I420366c49d071e022b8988c3d6293dbc8e9a283a
This was done in internal master in ag/5397886. Do it in AOSP as
well so we can benefit from checkstyle in AOSP as well.
Test: None
Change-Id: Ib00fc8d318e8127224846e0a69cb542178631437
Merged-In: I7d350c2bbb9fcd1019abd1addb035ce5e9e05acc
The libcore related projects (see below) have been (mostly) switched
over to use UnsupportedAppUsage annotations, This change will prevent
entries for those projects being added to a config/hiddenapi-* file.
* libcore
* external/bouncycastle
* external/conscrypt
* external/icu
* external/okhttp
* external/libphonenumber - still has a couple of entries in
config/hiddenapi-light-greylist.txt due to limitations in
UnsupportedAppUsage/class2greylist.
Tested by attempting to upload the file with entries for libcore
projects and without those entries and checking that the behavior
is expected.
Test: see above
Bug: 117818301
Change-Id: I67a30b307e12e842b28cfb2160fab0029868fa06
The canonical location of certain parts of the source tree live in
AOSP, and should not be changed internally to avoid merge conflicts.
This initially starts with "OWNERS" files, but the hook can easily
be repeated to match any files based on file path regexes.
Bug: 113136846
Test: manual
Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
Check that they're sorted as expected and contain no duplicates.
The sort order now uses:
$ LC_COLLATE=C sort -f
So that non-alphanumeric characters are not ignored, giving a more
intuitive sort order. the '-f' means ignore case.
Also sort the existing lists accordingly.
Test: repo upload
Bug: 64382372
Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218
Change-Id: I4cdd3bc5c11be91a9a3f678580af49ac67f3c968
Strings are tedious to get right, so write a lint script that catches
common errors to warn developers before they're uploaded.
Test: builds, boots
Bug: 76097999
Change-Id: I9826ca796c17cd93a100951d56214653de63a379
This CL enables Checkstyle for the following directories:
- telephony/
Bug: 34746646, 32954735
Test: Compilation
Change-Id: Ia67eaf5b871e6b74f21344fef1572835801843a5
Currently will never block upload, only considered a warning, but
will print out any lint issues discovered.
Test: do an upload
Bug: 69115822
Change-Id: I69b8e5a3f92ac28ee3c954408e88a1056c33af65
This CL enables Checkstyle for the following directories:
- core/java/android/
- core/tests/coretests/src/android/
Bug: 34746646
Test: None
Change-Id: Ib8b3f198000be19e9a7a61aa5abd61d827454eba
Enables Checkstyle preupload hook for the following directories:
- core/java/android/animation/
- core/java/android/text/
- core/java/android/view/
- core/java/android/transition/
- core/java/android/widget/
Test: tested manually uploading a CL that contained many changes
to directories outside of the listed ones and checkstyle did
not complain about those.
Change-Id: I795ba478fad7af124c43ca1e18d51b33d7800976
