95 Commits

Author SHA1 Message Date
Hugo Benichi
0c913bac46 DO NOT MERGE Instrument captive portal login activity
Also add CAPTIVE_PORTAL_LOGIN_ACTIVITY_SSL_ERROR constants to
metrics_constants.proto for counting ssl error pages shown by the
captive portal login activity.

Bug: 36203355
Bug: 34901696
Bug: 36532213
Test: manually tested with captive portal testing setup while watching
      event logs: adb logcat -b events | grep captiveportallogin
        06-08 16:25:20.279 21558 21558 I sysui_action: [1004,com.android.captiveportallogin]
        06-08 17:01:04.052 21558 21558 I sysui_action: [1007,com.android.captiveportallogin]

Merged-In: Ia05853506d424ad4cb2c11770ae7718fbef3f01c

(cherry picked from commit c61dc92fc0619d101c4b789f6305012701cc47a0)
(cherry picked with DO NOT MERGE because oc-dev-plus-aosp already
contains a version of this commit compatible with proto2).

Change-Id: I55ea3c61842f16bf6a98e812fb6dc940f96f895c
2017-06-19 22:10:37 +09:00
Hugo Benichi
828512f14c Revert "Instrument captive portal login activity"
This reverts commit f867da14eaa194cb53b0726b50e570268e70f1d7.

Change-Id: Ic900c91ed87c2d65c151f8386954bd7b74128348
2017-06-09 11:30:05 +00:00
Hugo Benichi
f867da14ea Instrument captive portal login activity
Also add CAPTIVE_PORTAL_LOGIN_ACTIVITY_SSL_ERROR constants to
metrics_constants.proto for counting ssl error pages shown by the
captive portal login activity.

Bug: 36203355
Bug: 34901696
Bug: 36532213
Test: manually tested with captive portal testing setup while watching
      event logs: adb logcat -b events | grep captiveportallogin
        06-08 16:25:20.279 21558 21558 I sysui_action: [1004,com.android.captiveportallogin]
        06-08 17:01:04.052 21558 21558 I sysui_action: [1007,com.android.captiveportallogin]

Merged-In: Ia05853506d424ad4cb2c11770ae7718fbef3f01c

(cherry picked from commit c61dc92fc0619d101c4b789f6305012701cc47a0)

Change-Id: I9184f6263a003c2be28f41a550c6164c8d6ee907
2017-06-09 14:08:39 +09:00
Hugo Benichi
5153e2f608 New Metrics constants for captive portal related UI
This patch adds 5 new constants in metrics_constants for counting
various UI interactions involving captive portals:
  - sign-in button in wifi network details card
  - captive portal login activity start up
  - captive portal login activity menu interactions (2 constants)
  - captive portal login activity auto-closes on portal dismissed

Bug: 34901696
Bug: 26303355
Test: compiled, flashed
Merged-In: I489e5f2f8ff27da60fed215fa5f51326933fd79e

(cherry pick from commit 11da42bbb63dba98515e6a3ca7c55e77cbb3c7bf)

Change-Id: Ifc553b08a65e78a630e235de087b7659a228bec8
2017-06-05 13:41:20 +09:00
Rebecca Silberstein
e1dd7de75e Merge "wifi.proto: add SoftApReturnCode enum"
am: 84374678e0

Change-Id: I22d8aca86a5a5c28c393db372b4399e5ddd99f46
2017-02-23 21:46:51 +00:00
Rebecca Silberstein
28d9de269c wifi.proto: add SoftApReturnCode enum
SoftAp startup returns a failure mode if it does not start.  This
additional information is useful in determining where we need to add
logging and retry logic to make SoftAp mode more reliable.  The
combination of Failure + failure reason is mapped to an enum defined for
wifi metrics.

Bug: 30899122
Test: checked WifiMetricsProto.java for the enum
Test: frameworks/base/wifi/tests/runtests.sh
Test: frameworks/opt/net/wifi/tests/wifitests/runtests.sh
Change-Id: I944e3e249d3be5738352b26a1d12139fdd50bf80
2017-02-23 10:42:05 -08:00
Glen Kuhne
d0dcf559c5 Merge "Move wifi.proto to shared service .jar"
am: 9ca5ddff4c

Change-Id: I3c10728fdbcd2882723a1bd519a47a63aeba0ac0
2017-02-21 17:56:13 +00:00
Glen Kuhne
173c3b3e89 Move wifi.proto to shared service .jar
Changes to ART are causing nano-proto's generated java base classes
to conflict with their duplicates in other projects, leading to a
NullPointerException.

Moving wifi.proto to the same build as other framework service protos in order
for them to share and not generate a duplicate CodedOutputByteBufferNano
classes.

wifi.proto previously lived at:
frameworks/opt/net/wifi/service/proto/wifi.proto

Merged-In: Ia30391453e8d6614edc7f4397e9c17cfe95cf63e
Bug: 32261442
Test: Builds, and existing Unit tests pass
Change-Id: Ia30391453e8d6614edc7f4397e9c17cfe95cf63e
2017-02-17 16:43:41 -08:00
Hugo Benichi
6776f79012 Revert "Merge "Define Network notification proto constants." am: 05550d9ed8 am: 6236f49f0e am: 7b39349792"
This reverts commit 814a59ba829642d09b6d1eaf9bcf06ee44bffad4 because it broke the build by duplicating code that was already there.

Change-Id: I1e32fd9e70629e5725e503ca372fb20c0aa0035d
2017-02-02 07:32:16 +00:00
Hugo Benichi
814a59ba82 Merge "Define Network notification proto constants." am: 05550d9ed8 am: 6236f49f0e
am: 7b39349792

Change-Id: I3d475b36e505e402d18a3942f557e2823d21416f
2017-02-02 06:52:37 +00:00
Hugo Benichi
2b7c408501 Define Network notification proto constants.
This patch defines 4 new constants in metrics_constants.proto
corresponding to the 4 network notifications shown by
NetworkNotificationManager.

Estimates for the average number of notifications:
  - SIGN_IN:        3/day/device
  - NO_INTERNET:    5/day/device
  - LOST_INTERNET:  5/day/device
  - NETWORK_SWITCH: 3/day/device (turned off right now)

Test: no functional change
Bug: 32198726
Bug: 33030620

(cherry picked from commit e1cbf15f1ad7f2f7e1cc1e96e6a82c3fa2f70bdf)

Change-Id: I6020c283329f752170cef451725b4e5287509bc5
2017-01-30 11:51:58 +09:00
Jason Monk
8cff199b09 resolve merge conflicts of 54bce9c6ff1f to nyc-mr2-dev-plus-aosp
Change-Id: Ifaea1d0f58ea81a7d929dc891fe69c8d7c15af4e
2017-01-18 13:45:59 -05:00
Anas Karbila
f7648f4483 SystemUI: Add NFC tile
This patch adds a tile for QuickSettings
which controls the setting of NFC.

The drawable is from material.io.

Test: Enable and disable NFC using tile

Change-Id: I7dfaf3a4dca0c01d24be397e43ab131eb9885f62
Signed-off-by: Anas Karbila <anaskarbila@aospa.co>
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
2017-01-18 12:12:03 +00:00
Chris Wren
99a16ab0ec Create a global registry for system message IDs
am: 117d5b4f28

Change-Id: Iaa792c9dbffaae807bdf0a8cfb30e66aecb442d6
2017-01-12 21:23:11 +00:00
Santos Cordon
d6a5660a2c Add Brightness setting for VR Mode.
This change saves and loads a different brightness setting when the user
goes in and out of VR Mode.

Bug: 30984614
Change-Id: If3c3e81b592e0c6fd037e5783559683e5cb58379
2017-01-09 17:33:14 -08:00
Chris Wren
117d5b4f28 Create a global registry for system message IDs
Port all system UI notifications to use the registry.  Retain stable
integer IDs where they exist. Assign new stable IDs where resource IDs
were previously used.

Using "message" rather than "notification" since we may eventually
want to include dialogs and toasts.

Bug: 32584866
Bug: 30995038
Test: runtest systemui
Change-Id: Iec4d7cebbd88683e339ada29a279315222699942
(cherry picked from commit 5e6c0ffd3e91cf0c5872de3e2d99e225ad1468f4)
2017-01-06 11:34:22 -08:00
Selim Cinek
966045d070 DO NOT MERGE Revert "Add Brightness setting for VR Mode."
This reverts commit 84980c7a93e93e7134c0198212e222e11eb5ccbd.

Bug: 33895226
Bug: 30984614
Change-Id: I2652e77512bc870190e2172a629abac9341b2c4f
2016-12-27 18:28:40 +00:00
Santos Cordon
84980c7a93 Add Brightness setting for VR Mode.
This change saves and loads a different brightness setting when the user
goes in and out of VR Mode.

Bug: 30984614
Merged-In: Ie5578bbd6ea346f0eb34fe4abbfd604a5d7c0c93
Change-Id: Ie5578bbd6ea346f0eb34fe4abbfd604a5d7c0c93
2016-12-22 23:26:49 +00:00
Hugo Benichi
065acc5a6c DO NOT MERGE Define Network notification proto constants.
This patch defines 4 new constants in metrics_constants.proto
corresponding to the 4 network notifications shown by
NetworkNotificationManager.

Estimates for the average number of notifications:
  - SIGN_IN:        3/day/device
  - NO_INTERNET:    5/day/device
  - LOST_INTERNET:  5/day/device
  - NETWORK_SWITCH: 3/day/device (turned off right now)

Test: no functional change
Bug: 32198726
Bug: 33030620

(cherry pick from commit 74264329da5c52fbbafc1d20457056fdeabe19dc)

Change-Id: I74702938694fea9b573524d1a2ae3c20ce52b54d
2016-12-15 14:32:45 +09:00
Adrian Roos
fd61f22210 DO NOT MERGE Show keyguard when SIM is removed
If the device has a secure lockscreen and the device'
SIM card is removed, lock the device.

Change-Id: I0369af81297169d65254b85bc9a056e4f4a02b7b
Merged-In: I5b0deea8851b38781059732a3cf6fa0a4a00e3ca
Fixes: 30997251
2016-12-01 22:49:50 +00:00
Doris Ling
319c806cc0 Add metrics logging for Settings -> Help & Feedback
Add new metrics event constant for Settings->Help & Feedback, and log it
whenever user selects the help option menu, passing the context extra for
the corresponding settings preference where the help menu is launched.

Change-Id: I971e8e50b959a5451ed085e5da5fd8504111e6c3
Fixes: 30140281
2016-08-23 14:49:15 -07:00
Doris Ling
f3cd2c6116 Add metrics event for Settings->Display->Ambient Display.
Bug: 29994493
Change-Id: I2eb71063db254cbe92511ca5cbe93b32c6b2c601
2016-08-04 13:21:53 -07:00
Doris Ling
3c00afba0b Add metrics logging for fingerprint swipe for notification panel.
Add metrics log when fingerprint swipe to expand/collapse notification
panel is handled, and increment the notification and quick setting open
count correspondingly.

Bug: 29257528
Change-Id: Ic24c6463a4400711874602157e2fcadc7f0f6da6
2016-08-02 10:25:39 -07:00
Justin Klaassen
19494275a2 Add SETTINGS_CONDITION_NIGHT_DISPLAY
Bug: 30043281
Change-Id: Icf218a8fdc7421620d2bb6057b55f1d511621b8b
2016-07-19 14:36:48 -07:00
Justin Klaassen
137909005c Add Night display QSTile
Bug: 28615069
Bug: 29619615
Change-Id: Ie23bd1ed9266941682eceb5f2086201bf02af765
2016-07-13 15:47:39 -07:00
TreeHugger Robot
9f311f6827 Merge "Fix QS gear metrics" into nyc-mr1-dev 2016-07-13 22:39:35 +00:00
Jason Monk
484fd36dfa Fix QS gear metrics
Change-Id: If1eeefa3831010d1567861dd71af6f29833496b3
Fixes: 30117924
2016-07-13 16:07:28 -04:00
Chris Wren
38f988120c sync rich comments back from google3
Bug: 30116535
Change-Id: I6e43ffda3d15b331c18752b5ee15770c6cdbfe85
2016-07-13 14:45:55 -04:00
Daniel Nishi
ff69a4ba1b Add a constant for when the storage manager is toggled on and off.
Bug: 30095915
Change-Id: I9fef3ec47552d344cff51fc1f2cf2e02e9b51574
2016-07-12 13:59:37 -07:00
Justin Klaassen
911e88939c Add Night display feature
Bug: 28615069

Tints the display at night automatically according to your schedule or
using the sunrise/sunset corresponding to your current location.

Change-Id: Ie56b4eed88cc2fcbae88002492b1edad5820b6b1
2016-07-08 11:47:50 -07:00
Fan Zhang
8080721854 Add metrics for toll-free/travel-abroad buttons in Settings
Bug: 29105266
Change-Id: I44cf2bdc3b01d0755e0305e8c26e6bf871ae9d52
2016-06-30 16:41:06 -07:00
Fan Zhang
a198550804 Add metrics for button taps in Settings support tab.
Bug: 29282762
Change-Id: I62f840fbc312ce759b5e6559e26d916181739d75
2016-06-20 09:47:47 -07:00
Fan Zhang
5e956e8ccd Add metrics for new tabs in Settings.
Bug: 28141203
Change-Id: I37b6fce7a5c4ca1cf2dbe0795aeb58bb23ae2160
2016-06-16 16:47:43 -07:00
Daniel Nishi
597e67ffe2 Add metrics for the deletion helper.
Bug: 28918007
Change-Id: Iead0cba7c35367be4e03fb8af6a038f709c95146
2016-06-15 11:10:14 -07:00
Bhavik Singh
3451da4a27 Logging tron metrics for ambient display gestures
Introducing new TRON metric (ACTION_AMBIENT_GESTURE)
and implementing logging for metric in DozeService.java

BUG=27907309

Change-Id: I324b6ef65e251f62b277beb1cb76af25159dbd90
2016-06-08 18:30:51 -07:00
Chris Wren
c6a9857f35 Give the auto-merger somthing to hang on to.
Bug: 29001173
Change-Id: Ie244f79f1569e2b32be4046d111919120ce6111e
2016-06-02 15:11:48 -04:00
Chris Wren
7ee8418076 resolve merge conflicts of cd9ea74 to nyc-mr1-dev
Change-Id: I37bc8256b8b91274f418cbefe2797f068cd98dd4
2016-05-27 13:34:02 -04:00
Chris Wren
5b3b72e7b7 resolve merge conflicts of 0f97b8f to nyc-mr1-dev
Change-Id: I5e03144e3ae95777eb651add098eabe8af6ad08e
2016-05-26 22:28:03 -04:00
Chris Wren
6abeeb9119 add metrics for gestural notification expansions
Bug: 28146482
Change-Id: If202846c0d235830c7b41d76b55bdcc21d0ab90d
2016-05-26 17:20:33 -04:00
Doris Ling
5b2c0ad312 Added new action for gesture settings.
Added new event for Settings -> Gestures

Bug: 28565958
Change-Id: I126ab29cf312b09cad1bd86cf614019616642536
2016-05-25 15:08:29 -07:00
Chris Wren
698b1706be add metrics for notification and group expansion
Bug: 28146482
Change-Id: Id7f71873ba33f85c1a1f2c48b47f78d40df46c0d
2016-05-25 17:08:17 -04:00
Daniel Nishi
010aa499cd Add new action for the storage manager settings.
Bug: 28560570
Change-Id: I7a17feff51c96634bfcc7d238ab168f0878e0e62
2016-05-13 12:10:00 -07:00
Julia Reynolds
94ad652c7a resolve merge conflicts of 407c434 to nyc-mr1-dev
Change-Id: I7d4590dc22902dade7a8f81bb1a8321b526a4925
2016-05-12 12:45:29 -04:00
Julia Reynolds
8f3e66f2fe Logging for QS settings launch.
Change-Id: Iff8bbb448454c8a82196d292a285827846b28357
Fixes: 28678032
2016-05-12 10:33:47 -04:00
Jason Monk
d0ea9bafaa resolve merge conflicts of 8b3cb1b to nyc-mr1-dev
Change-Id: Ifc87af6444612f67cace41da9bb96d3283cf33b2
2016-05-11 11:35:46 -04:00
Jason Monk
9fa5f82e1b resolve merge conflicts of 25118d1 to nyc-mr1-dev
Change-Id: I6adc48f30d21f99cd2cb105d0fca2643afb0cff5
2016-05-11 10:26:31 -04:00
Jason Monk
a1f697f537 Add metrics constant for new settings activity
Bug: 28554048
Change-Id: I3e2008890779867ecbc5fe485f33d52d75f0b324
2016-05-11 09:58:48 -04:00
Jason Monk
25118d1aa2 Add constants for settings pages
Some settings pages weren't extending SettingsPreferenceFragment
and they need to.

Bug: 28634520
Change-Id: Iebb63027b6390974eb2070b3388763d49e9529e6
2016-05-11 09:56:49 -04:00
Clara Bayarri
fa902aaa61 Add Tron logging for open/close App Disambig
This change adds
- Open/close the disambig shade with a featured app
- Open/close the disambig shade with no featured app
- User selected "Always" for the featured app
- User selected "Just Once" for the featured app
- User chose a non-featured app

Bug: 26108706
Change-Id: I4d2c99cee1a784aa1cab156939c57c83d35a4aa5
2016-05-10 15:15:29 -07:00
Narayan Kamath
3496fdbd2f Patrially revert 4ec026930bfbbb5d8923f359c8.
In preparation for using MetricsLogger.histogram / count. The main
purpose of this change is to remove the (now bogus) action IDs
associated with this logging.

bug: 28528058
bug: 28544474

Change-Id: Id79de2d34c3f937a327ac21d44e55c18047bce85
2016-05-10 14:26:46 +01:00