314621 Commits

Author SHA1 Message Date
Jeff Sharkey
a00c7c0a99 Merge "Fix some issues found by new doclava linter." into oc-dev 2017-04-25 22:11:01 +00:00
Eugene Susla
722463ff95 Follow acronym convention for Companion BLE filter
Test: Ensure no compilation error
Fixes: 37514177
Change-Id: I4c255cf6b3c62d762755a9822928561371ecd88d
2017-04-25 14:42:35 -07:00
Seigo Nonaka
5313eee98a Merge "Font provider cleaning ups." into oc-dev 2017-04-25 21:40:42 +00:00
Jason Monk
f06a317039 Guard against incorrect context use.
Instead of just having random tests fail, fail all the tests with a
slightly more useful message.

Also remove all the code around acquiring and contention, now that
we have a test rule in place for TestableContext, we can just use
that for cleanup and have a simple copy-on-write provider.

Test: runtest -x frameworks/base/tests/testables && runtest systemui
Change-Id: I907da23730a4a96cfa2bb112100a06980f01b078
Fixes: 37302051
2017-04-25 21:38:40 +00:00
Adrian Roos
60a7739798 AOD: Remove wake up fully config flag
Fixes: 37270258
Test: Double tap, make sure device does not wake up to lockscreen, only to ambient display
Change-Id: Iaf0c3bfb5dcf566adae7f37b51c866d92bce7a1d
2017-04-25 14:28:41 -07:00
TreeHugger Robot
885b5f4466 Merge "Remove underscore from Companion service name" into oc-dev 2017-04-25 21:26:15 +00:00
Fyodor Kupolov
ec00b5199c Call getAllowedUid on a separate thread
Test: manual
Bug: 37673384
Change-Id: If7480a8cd3fd1ccb5b7179b613a124db010efa8e
2017-04-25 14:19:31 -07:00
Felipe Leme
e4f30650ac Provide a way to set AutofillId on ViewStructure.
So far that was done indirectly by public methods that could
be overridden in away that does not set the proper id in the structure,
which would crash apps.

Bug: 36171235
Test: modified VirtualContainerActivityTest#testAutofillOverrideDispatchprovideAutofillStructure

Change-Id: I3f1c64020125cbb8349971a0bc52ccd1e0c81e62
2017-04-25 14:12:03 -07:00
TreeHugger Robot
105f55ee8f Merge "Add tests for iconSpaceReserved attribute in Preference" into oc-dev 2017-04-25 21:07:53 +00:00
Adrian Roos
afad82ba85 Merge "ImmersiveCling: Allow interacting with underlying view" into oc-dev 2017-04-25 21:07:20 +00:00
Steve McKay
76b2770214 Address API Council feedback.
Bug: 37422306, 37419881
Test: Build and read docs.
Change-Id: Id6c8bad6ad6b311017094ce5dbd66cfd72c477ad
(cherry picked from commit d74a3bd7d1d3175856f450a9e77dabb89f2e5060)
2017-04-25 21:03:45 +00:00
Julia Reynolds
bad4297600 Api updates
- Better documentation on DEFAULT_CHANNEL_ID
- Renaming getChannel/setChannel/getTimeout/setTimeout
- Add documentation to getShortcutId
- @hide parcel constructors

Test: make, make cts
Bug: 37672218

Change-Id: I695b2620c51638a84930e9d1c5fbfd6d85699b55
2017-04-25 17:00:05 -04:00
TreeHugger Robot
3ce611f1b4 Merge "Switch ActivityRecord last reported config. to MergeConfiguration" into oc-dev 2017-04-25 20:58:38 +00:00
Fyodor Kupolov
701a85f321 Blame services for slow operations
The system will now log a warning if a service takes 50+ ms to handle
a lifecycle callback.

Example:
SystemServiceManager: Service class com.android.server.appwidget.AppWidgetService took 404 ms in onUnlockUser

Test: device boots, times are logged
Bug: 37579992
Change-Id: Id1f339d02e1854f3a9acf85eb54b03f35ff68b89
2017-04-25 13:52:46 -07:00
TreeHugger Robot
27e5ec0bb7 Merge "Reorder USB_STATE updates so config_changed is not replaced." into oc-dev 2017-04-25 20:49:44 +00:00
Rob Carr
b8bb3f7137 Merge "WindowManager: Take care with Surface lifetime during relayout to invisible." into oc-dev 2017-04-25 20:44:21 +00:00
Chris Craik
66c3a829dc Fix include
Bug: 35387665
Test: builds with HWUI_ENABLE_OPENGL_VALIDATION := false

Dependency on gl3.h was added while that header was auto-included for
error checking purposes. Add the include to enable us to disable gl
error checking.

Change-Id: Ic969da716e2323f8e42d20da8fd0a6fa653f9775
2017-04-25 13:42:53 -07:00
TreeHugger Robot
26ba9f8833 Merge "Fixed issue with turn-screen-on activities" into oc-dev 2017-04-25 20:36:58 +00:00
TreeHugger Robot
6338cd8155 Merge "Clear default-browser state when it's uninstalled" into oc-dev 2017-04-25 20:35:59 +00:00
Todd Kennedy
c05f5d12d9 Add concept of implicitly exposed components
Implicitly exposed components are those that can still be accessed
via generic startActivity() calls. However, they cannot be started
by specifying a package or component. Additionally, package info
can't be obtained if the package only has implicitly shared
components.

Change-Id: I404a4dff87559cfeee6ad78f7dcc7f5d849d6869
Fixes: b_37343345
Test: cts-tradefed run commandAndExit cts-dev -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.EphemeralTest
2017-04-25 13:34:23 -07:00
Chris Craik
bc44b1a693 Fix ViewOverlay#onDescendantInvalidated
Fixes: 37307001
Test: android.view.ViewInvalidateTest

Also removes damageChildInParent, since it's not called anywhere.

Change-Id: Ic81d4465e4828c5826957ace2c44ac263b4662bd
2017-04-25 13:32:19 -07:00
Makoto Onuki
fe73970116 DeviceAdminService must be protected with BIND_DEVICE_ADMIN.
Bug: 37625902
Bug: 36226832

Test: cts-tradefed run cts-dev --skip-device-info --skip-preconditions --skip-system-status-check com.android.compatibility.common.tradefed.targetprep.NetworkConnectivityChecker -a armeabi-v7a -l DEBUG -m CtsDevicePolicyManagerTestCases -t com.android.cts.devicepolicy.DeviceAdminServiceDeviceOwnerTest
Test: cts-tradefed run cts-dev --skip-device-info --skip-preconditions --skip-system-status-check com.android.compatibility.common.tradefed.targetprep.NetworkConnectivityChecker -a armeabi-v7a -l DEBUG -m CtsDevicePolicyManagerTestCases -t com.android.cts.devicepolicy.DeviceAdminServiceProfileOwnerTest
Change-Id: I0bee75d758b565c6587d0e9cabf63bec351a0669
2017-04-25 13:31:37 -07:00
TreeHugger Robot
21fb35048f Merge "Revert "Revert "Integrate new looper apis into testables""" into oc-dev 2017-04-25 20:27:23 +00:00
Jakub Pawlowski
91fe3080e7 Bluetooth: expand comments on new PHY constants
Bug: 37544152
Test: the all-knowing eyes of the reviewers
Change-Id: I8f5a756a204fe90960700e1dc42f64824d3b844a
(cherry picked from commit 60c7dac77533163ed951dee09ec7b42a49bdf54a)
2017-04-25 13:00:52 -07:00
Jakub Pawlowski
e7c6e6ae1f Bluetooth: document status value in PHY read/update
Bug: 37544152
Test: none
Change-Id: I2bac468f833c73cd282b1dac80b6553917996604
(cherry picked from commit e55c4469771f9f88626b362aa7b7226c4f424ed7)
2017-04-25 13:00:43 -07:00
Jakub Pawlowski
b0f647492f Bluetooth: Add handler parameter to connectGatt
Bug: 37544152
Test: sl4a GattReadTest GattWriteTest
Change-Id: I043dfefaafe9f3700418f2c855c52aac3644310f
(cherry picked from commit 4eab49652e48159fd37f827d30b822f2f187551e)
2017-04-25 13:00:36 -07:00
Jakub Pawlowski
d2ac8b94e7 Get rid of the IAdvertiserCallabck
Bug: 30622771
Test: none
Change-Id: I2c55f96e71cd3be67f88201ab07c91730cd85971
(cherry picked from commit 89e10d3eb4a4728ffdb5a5eba76d772d28bcb855)
2017-04-25 13:00:25 -07:00
Sudheer Shanka
7a3d901453 Update VIMS internal state when a packge is modified.
When the package that contains the current voice interaction service component
is changed, internal state of VoiceInteractionManagerService needs to
modified to correctly reflect that.

Bug: 36649034
Test: manual
Change-Id: I7e21ac25785b035711affd87f1b04efa717b13c4
2017-04-25 12:57:38 -07:00
Eugene Susla
d74e65944d Drop uses-feature requirement for system process
Fixes: 37673382
Test: go through setup wizard and ensure no exception from bug report
  is present
Change-Id: I5a64586c1baec54ae579f47771546493f82b19df
2017-04-25 12:57:23 -07:00
Julia Reynolds
fa04e143d8 Update app level fields when misc channel is updated
So user settings aren't lost when the app migrates
to using channels

Test: runtest systemui-notification
Change-Id: I5774997ea33a892fa45f614bb3dd8de7e681f58c
Fixes: 37603697
2017-04-25 15:50:56 -04:00
TreeHugger Robot
1c35554c5f Merge "Add getVisualVoicemailSettings()" into oc-dev 2017-04-25 19:45:47 +00:00
Seigo Nonaka
54084b64b1 Font provider cleaning ups.
- Remove Columns.STYLE
- Decouple Context from Typeface.
- Make FontsContract constructor private since it is essentially static.
- Removed unused constants.

Bug: 37281200
Bug: 37268410
Test: am instrument -w -e class android.provider.FontsContractE2ETest
      com.android.frameworks.coretests/\
      android.support.test.runner.AndroidJUnitRunner
Test: am instrument -w -e class android.provider.FontsContractTest
      com.android.frameworks.coretests/\
      android.support.test.runner.AndroidJUnitRunner
Test: am instrument -w -e class android.graphics.cts.TypefaceTest
      android.graphics.cts/android.support.test.runner.AndroidJUnitRunner
Change-Id: Ic46c256141d27ca28f30023bcc40f4e1161d5338
2017-04-25 19:40:58 +00:00
Adrian Roos
79e88dbe27 ImmersiveCling: Allow interacting with underlying view
Fixes: 23740894
Test: adb shell settings delete secure immersive_mode_confirmations && "set an alarm" && "try interacting with the ringing alarm beneath the immersive mode confirmation"
Change-Id: Ic0c672603db34bcb71fc21c1a674a89fd4779f3d
2017-04-25 12:38:04 -07:00
Sundeep Ghuman
ce6bab87e6 Use synchronization rather than locking in WifiTracker.
This vastly simplifies WifiTracker usage. The existing locking behavior
closed a lock on thread A, depended on thread B to open it, and would
block on Thread A until thread B did. However, thread B can also block
on this lock, hence if Thread A closes the lock between thread B opening
it and blocking on it, and deadlock would result in an ANR that would
crash WifiSettings (see b/37530557 for another example).

All work on the WorkHandler is now synchronized, as a preliminary step
to removing the worker thread altogether, pending discussions with original
author on the threads creation.

Also fix test flakiness, an indirect byproduct of now simplifying concurrency
issues in this class. Fixes b/37581732.

Together with the other changes in this topic, this CL resolves all known
wifi picker jank and no ANRs have been witnessed.

Bug: b/37504190
Test: runtest --path
frameworks/base/packages/SettingsLib/tests/integ/src/com/android/settingslib/wifi/WifiTrackerTest.java

Change-Id: I0e47a4d50372beb2d141189276b1a4d9230c0d98
2017-04-25 12:37:38 -07:00
Phil Weaver
cd68c334ba Merge "Remove a11y web flags and associated settings" into oc-dev 2017-04-25 19:25:23 +00:00
Julia Reynolds
9685128edf Merge "Allow some notifications in a group to be muted" into oc-dev 2017-04-25 19:25:05 +00:00
Joachim Sauer
0a1066a454 Deprecate internal Calendar methods.
These methods suffer from a potential integer overflow that can't be
fixed without changing their signature as described at
http://bugs.icu-project.org/trac/ticket/11632.

Since they could be overridden, we need to deprecate them for at least
one release before changing/removing them.

Bug: 30300853
Test: m checkbuild && m offline-sdk-referenceonly-docs

(cherry picked from commit 40a72dc87821b8870042d99b4ec9335a229ec737)

Change-Id: I18f97a7085b69a6d0d95b0cf10f7dfce1077ee9f
2017-04-25 20:18:09 +01:00
TreeHugger Robot
0a001ed37f Merge "Fix javadoc to clearly express units and base for time value." into oc-dev 2017-04-25 19:17:28 +00:00
Jeff Sharkey
0f3f60b576 Fix some issues found by new doclava linter.
Add missing API annotations for permissions and SdkConstants, and
invoke doclava with new "-android" flag.

Test: make -j32 offline-sdk-docs
Bug: 37526420
Change-Id: I970bb2655eb568fd25004636f134c794663a6c33
2017-04-25 13:12:45 -06:00
Mady Mellor
47ba140cbf Add ability to fling to dismiss PIP from anywhere
This is by default turned off and is behind a tuner flag.

Allows the PIP to be dismissed if it is flung towards the bottom center
of the screen and the finger is released within the bottom area of the
screen.

Test: Manual - enable tuner setting, have a PIP, position it at top of
      screen, long- fling it towards bottom center of screen, it dismisses.
Bug: 35358628
Change-Id: I2d3d50093f6523c7bb321e0486dab360095a398e
2017-04-25 12:08:08 -07:00
Robert Carr
3651ab8e09 Fix logspam NPE.
Harmless but spammy.

Bug: 37622525
Test: Repro from bug.
Change-Id: I7fa2404fddb0c62efdd4553d5c61e92ae8f3a876
2017-04-25 12:05:34 -07:00
TreeHugger Robot
ecabc596b7 Merge "Do not deliver INSTALL_SHORTCUT." into oc-dev 2017-04-25 18:58:57 +00:00
Joe Fernandez
8e342c7b75 docs: Update Button JavaDoc comments
- Simplify first-line description
- Update top-level code sample
- Add caveat about onClick running on main thread
- Simplify button style discussion
- Add distinct See Also section
- Convert future tense to present tense
- Add closing paragraph tags
- Remove references to push-button
- Clean up code introduction sentence
- Use present tense
- Connect reasoning to user experience
- Format threading information as aside
- Change future tense to present tense
- Add transition statement
- Use active language in parameter description
- Use cannot instead of can not
- Use common parlance name for button
- Clean up parameter descriptions

Test: Docs change only. Tested with a doc build run.

Change-Id: Ie0cd25ed4f8372ba5ec58bdf8b7dfce9100ee3fc
2017-04-25 11:55:26 -07:00
TreeHugger Robot
730bf42e44 Merge "Revert "Whitelist DMAgent from bg check"" into oc-dev 2017-04-25 18:55:08 +00:00
TreeHugger Robot
bad4573bd4 Merge changes from topic 'experio-scoring' into oc-dev
* changes:
  Remove Settings.CURATE_SAVED_OPEN_NETWORKS
  Remove request recommendation from AIDL files.
  Remove the recommendation request impl and test code.
  Deprecate the recommendation request code.
2017-04-25 18:51:51 +00:00
Joe Fernandez
a3aa879166 docs: Update ListView JavaDoc comments
- Use more active and descriptive terms in first-line description
 - Recommend using RecyclerView
 - Add XML example code
 - Direct reader to set an adapter to populate list with views
 - Add pre tags to XML code snippet
 - Give example of displaying more complex views in list
 - Add aside about using convertView if provided
 - Link to guide on handling click events
 - Add cross-link to contextual action mode guide
 - Reframe link to list view guide
 - Advise reader to favor alternative approach to using ListActivity
 - Add paragraph tags
 - Escape @ symbol
 - Fix sentence fragment and change modern -> advanced
 - Fix title of cross-reference to layout guide
 - Remove reference to filename
 - Remove cross-link to contextual action mode
 - Fix malformed link tag
 - Add connecting word
 - Clean up links

Test: Docs change only. Tested with docs build.

Change-Id: Ideb5cc517a7bc08056bb2fe8025c7acea388128b
2017-04-25 11:51:17 -07:00
Wale Ogunwale
e610d3dba8 Switch ActivityRecord last reported config. to MergeConfiguration
Clean-up before actual fix for b/36897968 that makes the code easier to
follow.

Test: Existing tests pass
Bug: 36897968
Change-Id: I3039548929440f922dc69d7f130169a3d60b1eef
2017-04-25 11:48:43 -07:00
Michal Karpinski
b81243f523 Offload the mRunningFullBackupTask.handleCancel() call from the main
thread to another thread

The system_server process was being killed by Watchdog, as the main
thread was waiting for the mCancelLock for over a minute.

Bug: 35968123
Test: make gts -j40 && gts-tradefed run gts -m GtsGmscoreHostTestCases -t com.google.android.gts.backup.BackupManagerHostTest
Change-Id: Ia146569d2c741b35a6f6c9bfc4c5ddf8539b6242
2017-04-25 19:33:18 +01:00
TreeHugger Robot
3411adc4b3 Merge "Make new onFill/onSave methods abstract." into oc-dev 2017-04-25 18:31:12 +00:00
Tony Wickham
974cea8f4c Merge "Address API Review comments" into oc-dev 2017-04-25 18:16:55 +00:00