It is using system APIs, but we might want to update it via the play
store.
Hence, replace all internal APIs used with support lib APIs. There is
no replacement for @Immutable, but this is just a informational
annotation, so it can just be removed.
As system-api is tied to a specific platform version, remove all
minSDK/targetSDK settings in the manifest.
Change-Id: Ia8f9c718fd688db295c7bc3bfe05e2074f9bd413
Fixes: 78162439
Test: Looked at print service recommendations
Test: Before taimen never resolved nsd servives. How it resolved nsd
services reliably when built in print service and print service
recommendation service used NsdService
Fixes: 75316187
Change-Id: I02f83fc2ea624174e61ddf0d61fdaed005b741eb
This change sets LOCAL_SDK_VERSION for all packages where
this is possible without breaking the build, and
LOCAL_PRIVATE_PLATFORM_APIS := true otherwise.
Setting one of these two will be made required soon, and this
is a change in preparation for that. Not setting LOCAL_SDK_VERSION
makes the app implicitly depend on the bootclasspath, which is
often not required. This change effectively makes depending on
private apis opt-in rather than opt-out.
Test: make relevant packages
Bug: 73535841
Change-Id: I4233b9091d9066c4fa69f3d24aaf367ea500f760
... by extending the RecommendationInfo to store the inet addresses not
just the count. Thankfully the recommendation plugins already contained
all the printers, not only the count.
Also expose the print service state as system APIs as they will be used
by the default print service.
Bug: 35765644
Test: Ran AddPrinterActivity on network that had printers to discover
Change-Id: I929a177adb75f6848848ba30a472cf0343d2e67e
Reuses already existing infrastructure. The mMDNSFilteredDiscovery lambda
is called for every network service that supports #PRIVET_SERVICE. Then
the plugin checks the txt fields to make sure the printer is valid. The
check is not complete but good enough to make sure this is either a
cloud print capable printer or something that tries really hard.
Test: Connected to network with three printers, 2 GCP capable. Found the
two printers
Fixes: 35766193
Change-Id: I7c9180c8c154fa092fec5b943a94bad77da74c86
- Extract common part of MDNSFilterPlugin to common utils, MDNSFilteredDiscovery.java (other vendors can use it too)
- Refactor Samsung Print Recomendation Plugin to use MDNSFilteredDiscovery.java
- Add Mopria devices detection to Samsung Print Recomendation Plugin
*Samsung Print Service Plugin supports Mopria printers since v3.00.161011.
Test: Tested manually. Test app was developed to make sure that Samsung Print Recommendation plugin can find both Samsung and Mopria devices. Additionally MDNSFilterPlugin was tested on HP printers.
Change-Id: Idc0d311171495f879564336370a86f7a8890378b
Only minimal changes just to make it work together with the other
plugins.
Bug: 28908572
Change-Id: Icac226b45e8a6885036466451d0e9f54a3b3c640
(cherry picked from commit d97fdfd943295ea90d37b092e66b7ad1701587a1)
The code follows the same pattern as the HP and Mopria plugins. As this code is contributed by a 3rd I'd rather submit this as is and let the original submitter clean it up once it appears in AOSP.
The code should not affect anything outside of the package it is in. In the package the code is strongly isolated so that one plugin cannot cause issues with another plugin.
The code was minimally tested on a Samsung SCX-3406FW .
Bug: 28908572
Change-Id: I33c2673d06711902dbd0f1d82563cf5d3fbfe86a
(cherry picked from commit 83defde08560ae2f1c3426466a2aa3e6944d6b79)
The reported that:
- Name should be Koni_c_a Minolta
- kmkmkm should not be used as a mDNS identifier
Change-Id: I1ab1910f9a54a396c3bfa109266f6e805349d036
am: 747b3d7de8
* commit '747b3d7de89fa6b7330d59a47fd982d38192e3c3':
Add HP and Mopria print recommendation service
Change-Id: Idba97dabb1dcdefc528541d9c2955705d2e787eb
- Make util.MDnsUtils local to the mdnsFilter plugins
- Remove HP from the vendors recommended via the mdnsFilter plugin
- Copy in HP's code for HP and Mopria plugin
- Do not change any code, beside
- change "_ipp.tcp" to "_ipp._tcp"
- Change package name
- Do not use support lib annotations
- Reduce class visibility if possible
- Add AOSP copyright
- Make ServiceResolveQueue a proper sigleton
- Merge donottranslate and strings
- Add HP and Mopria plugin to RecommendationServiceImpl
- I needed to implement a multiplexer for NsdManager.DiscoveryListener
as we can only have 10 of them active at a time.
Change-Id: I61caa3f4822f9c013140721ed801d18e6839df55