weak pointer comparison operators were implemented wrong,
they were using the internal "unsafe" pointer. We could end up
with two "equal" weak pointer pointing to different objects.
this caused KeyedVector keyed by weak pointer to work incorrectly, in
turn causing a window that just got added to a list to be immediately
removed.
Change-Id: Ib191010c39aafa9229109e4211f6c3b2b2f9696d
Every method implementing a delegate needed by the
layoutlib_create bytecode modification must now be
annotated with LayoutlibDelegate.
The methods in the original source code that are delegated
are already automatically annotated. Now with the implementations
being annotated we can do bi-directional tests and find not
only missing implementations but also dead obsolete code.
This will be useful when backporting to earlier versions of
Android, or when native (non public) method disappear. In fact,
the new test detected one such method in Shader.
Change-Id: I491708b68ac2736ca5669aa86cd5e930a00f9db3
Bug 3415891
With the current behavior, as soon as the list is expanded by
'long' pressing on or scrolling its content, it will always further appear
in its long state, thus hiding the IME.
This fix changes this behavior so that the default state is always
compact, not hiding the IME, and an explicit expansion
is always required.
Also fixes a bug in ListPopupWindow that prevented the timer that
expands the list from being started.
Change-Id: I896e92d54961769c10b276c36f6510e91ff096a2
Bug 3330651.
The first item in the list is not selected by default. From discussions
in other related bugs, there does not seem to be an agreement on this.
Supporting the actual token separator has also been punted. This would
require a new method in the Tokenizer, which could be ill-defined for
exotic tokenizer, plus typing a comma (for instance) to achieve a
completion is not a common pattern.
Change-Id: I30baf62077c412256175f871d21f4841e104f212
There were some subtle timing issues in animators with ending animations that
were not completely initialized (possibly because a startDelay'd animator
was ended before the delay elapsed).
Also, LayoutTransition had bugs around running a transition on a container
while a previously-started transition was still in progress. This could result
in some minor artifacts or crash bugs, depending on the durations and delays set
on the transition animations.
Change-Id: Ic6a69601f1ce9a55db15fff6b8ed25950b354491
Holding down the enter key on a physical keyboard
doesn't make sense to map to long press; the desktop
doesn't work that way either.
bug:3344108
Change-Id: Icf02940dcadf194357b680ae1e3028751d16a1ea
bug:3421690
This change is related to change:Idfec7e6a
1. Added tests for cases in which the previous
implementation was not behaving as expected.
2. Refatered the tests to be intrumentation tests
since the code under tests uses the DOM element
dimensions to determine visibility and if the
the WebView has no size i.e. not attached to
ViewRoot the size of all DOM elements is zero
forcing all tests to fail.
Change-Id: Ib4c01af8feb09f2b2a6b9d906e08bfaaa9e9bc74
they are becoming pretty disruptive bugs.
many more instances of gmail crashing with locking protocol error.
and a positive identification of WAL as the problem in Music app
AND one instance of gmail crash that I know of.
who knows how many folks are NOT reporting the gmail crash.
too bad we relied on pre-released version sqlite feature
without seeing it complettly tested in the field.
not a safe feature to turn on at this point in time.
maybe more testing and debugging in Ice timeframe.
Change-Id: I283ad26ba7e1793772a372aa8e24df0cb96ce2ef
