1213 Commits

Author SHA1 Message Date
Tomasz Mikolajewski
04c85c98f2 Merge "Fix directory/root opening animations when launching DocumentsUI." 2016-02-03 08:05:18 +00:00
Tomasz Mikolajewski
42bd98f426 Fix directory/root opening animations when launching DocumentsUI.
We should only show an opening animation, when back button would get us
back.

Change-Id: I9b3f43592a87c1c13944d382b7201b5727fd08ee
2016-02-03 16:41:37 +09:00
Tomasz Mikolajewski
df676dc015 Do not load Download roots multiple times.
Change-Id: I26685db7fc7a4fb98db695ba6e0e351974eadd6c
2016-02-03 15:21:20 +09:00
Tomasz Mikolajewski
ba7753c941 Merge "Open zip files nicely from the Download app with Files app." 2016-02-03 03:20:11 +00:00
Tomasz Mikolajewski
a6120da1e3 Open zip files nicely from the Download app with Files app.
Bug: 26321218
Change-Id: I8a7a7e914d290ea1b6f424ee5fbd38a4b09c362d
2016-02-03 11:56:54 +09:00
Tomasz Mikolajewski
ccda74f5ec Merge "Fix flaky testFilesList_LiveUpdate()." 2016-02-03 02:08:15 +00:00
Tomasz Mikolajewski
12f11c55e6 Merge "Fix tapping on more than one failure notification." 2016-02-03 02:05:23 +00:00
Tomasz Mikolajewski
cd270153ff Fix tapping on more than one failure notification.
Bug: 26809248
Change-Id: I4e52b7e7a9e09d57b8a2231a09c9121b5fd19e51
2016-02-03 11:03:47 +09:00
Aga Wronska
18e191c1a8 Merge "Fix root selection after search" 2016-02-03 01:23:41 +00:00
Steve McKay
d87277d37f Merge "Show view mode button in action bar on Downloads." 2016-02-03 00:48:15 +00:00
Aga Wronska
7592987761 Merge "Add tests for action bar's search icon behavior - Icon hidden when root doesn't support search - Icon visible whan root supports search" 2016-02-02 23:46:12 +00:00
Aga Wronska
8e1c9637ec Fix root selection after search
Bug: 26160443
Change-Id: Ib05719c8219565db7ef88ce41227079537d1fac4
2016-02-02 15:04:52 -08:00
Steve McKay
3ce95951bd Show view mode button in action bar on Downloads.
A grab bag also with:
Report Roots while loading (in DEBUG).
Null check DirectoryFragment before calling methods on it.

Bug:26936660,26143397
Change-Id: Ief2c943eb24fb14349bbd9cc4a5fbd670f57d567
2016-02-02 14:51:04 -08:00
Ben Kwa
3182a92a16 Merge "Refactor key handling and selection." 2016-02-02 21:36:39 +00:00
Ben Kwa
0ef8fcca4d Merge "Add a config file for linting." 2016-02-02 21:17:18 +00:00
Ben Kwa
6792489dc4 Refactor key handling and selection.
- Pull key handling code out of the MultiSelectManager.

- Tighten up the semantics around range selection:
  - Create an API on MultiSelectManager for handling multi-select.
  - Make the range selection more opinionated (e.g. more state checks),
    to simplify the design and code.

BUG=25195767

Change-Id: I4bbe446ed3059150499db3d28e581b2e68405266
2016-02-02 10:34:19 -08:00
Ben Kwa
79c94de054 Add a config file for linting.
Change-Id: Ic76e8ea1cd2277c2cc1cf9588410bc142378f8a0
2016-02-02 10:07:15 -08:00
Steve McKay
4ee5d5d5cf Merge "Decouple SD card from ADVANCED storage toggle." 2016-02-02 17:29:04 +00:00
Steve McKay
efa1761776 Decouple SD card from ADVANCED storage toggle.
A variety of related fixes:
- don't force size enable when browsing from device mounted notifications.
- don't show settings menu item as action (put in overflow).
- add sd card icon (not quite yet used, need to suss that out).

Bug:26880985,26883578,26771127
Change-Id: I36f153c42217f8092f157ded2a756c02525593ab
2016-02-02 09:28:30 -08:00
Tomasz Mikolajewski
b005e14e46 Fix flaky testFilesList_LiveUpdate().
Change-Id: I76fe7977c47f7b225ec42d64484942ce059b91fd
2016-02-02 19:26:09 +09:00
Aga Wronska
cfba4f6809 Add tests for action bar's search icon behavior
- Icon hidden when root doesn't support search
    - Icon visible whan root supports search

Bug: 26903635
Change-Id: I7a73d44e83c87be7d25abe55477fa54572833e32
2016-02-01 17:16:44 -08:00
Ben Kwa
f10b1c21a8 Merge "Fix a crash in Metrics code." 2016-02-01 23:40:16 +00:00
Ben Kwa
1a8fbfce6f Merge "Don't clear the selection when directory contents change." 2016-02-01 19:17:36 +00:00
Aga Wronska
f5c027460e Merge "Add tests for rename documents feature - Add helper class for the Ui tests. It creates basic test environment. It is intermediate layer between UiBot/DocumentsProviderHelper and UiTest classes. - Refactor SearchView tests - Add renaming support in the test DocumentsProvider - Add renaming tests" 2016-02-01 18:43:41 +00:00
Aga Wronska
0950df196f Add tests for rename documents feature
- Add helper class for the Ui tests. It creates basic test environment.
      It is intermediate layer between UiBot/DocumentsProviderHelper and UiTest classes.
    - Refactor SearchView tests
    - Add renaming support in the test DocumentsProvider
    - Add renaming tests

Bug=26799799

Change-Id: I2849913a1addabff0087bb06b80f36de7cb144f3
2016-02-01 10:36:02 -08:00
Ben Kwa
d4d0e7085a Don't clear the selection when directory contents change.
Update the selection to remove IDs that no longer exist, but don't clear
it - doing so causes the selection to vanish whenever the underlying
directory contents change, which is disruptive to the user.

BUG=22765812

Change-Id: Ice6ae54d0748cf842addf1342541ae7759435811
2016-02-01 09:11:55 -08:00
Wale Ogunwale
3b93a4d351 Renamed Activity class multi-window APIs
As requested by API council.

Bug: 26507736
Change-Id: I2a87c5eb3c1b48d52703103c2a4f72c250a9a827
2016-02-01 06:58:31 -08:00
Geoff Mendal
9eb94d7173 Import translations. DO NOT MERGE
Change-Id: I67ade5e23bfdea3b831bcdf4868456e27d735ff0
Auto-generated-cl: translation import
2016-02-01 05:18:12 -08:00
Wale Ogunwale
174d36d87a Merge "Renamed FLAG_ACTIVITY_LAUNCH_TO_SIDE to FLAG_ACTIVITY_LAUNCH_ADJACENT" 2016-01-31 19:57:16 +00:00
Aga Wronska
f6ede47b78 Merge "Hide action bar search icon in directories that do not support search operation." 2016-01-30 22:01:50 +00:00
Wale Ogunwale
2a25a62739 Renamed FLAG_ACTIVITY_LAUNCH_TO_SIDE to FLAG_ACTIVITY_LAUNCH_ADJACENT
Per feedback from API council.

Bug: 26508215
Change-Id: Id17166fe981587c9c16c382ccbdf0846ed2ae5d6
2016-01-30 11:27:21 -08:00
Aga Wronska
91c7fb3b83 Hide action bar search icon in directories that do not support search operation.
Bug:26593318
Change-Id: Ibb8945e6eba508aaaa55b1f666ac434f30b2aaaa
2016-01-29 18:47:23 -08:00
Steve McKay
51635f9c1a Load correct thumbnail size when switching to grid from list (and visa versa).
This is a quickie change where we clear the cache, but I think there could be
a better behavior where we don't clear the cache, show low res (instantly)
then load higher resolution ontop of the low res.

Bug: 26763078
Change-Id: If9883d507984b555e790a06692390d4fa3334c28
2016-01-29 15:25:42 -08:00
Ben Kwa
a3cdbdda9b Fix a crash in Metrics code.
Check for null URIs when logging metrics for DocsUI launches.  This
prevents a NPE caused if DocsUI is started by an intent with a null URI.

BUG=26848462

Change-Id: Iea02488581f582f60eabf61deec1e89c13449d78
2016-01-29 14:18:26 -08:00
Ben Kwa
4b1b3e98e0 Merge "Add logging for MTP roots." 2016-01-29 20:12:08 +00:00
Ben Kwa
da518c9e61 Add logging for MTP roots.
BUG=26737132

Change-Id: I09d7f644edd775ce54a06dbed9f4b716eeb662d3
2016-01-29 12:11:01 -08:00
Ben Kwa
9445345ea1 Merge "Add metrics logging for file operations." 2016-01-29 19:57:12 +00:00
Steve McKay
957c742f1f Merge "Clear selection after copy and when back is pressed." 2016-01-29 19:21:24 +00:00
Ben Kwa
d5b2af1544 Add metrics logging for file operations.
Log to two new histograms - one for operations originating from system
providers, the other for operations originating from external providers.

Events in these histograms are bucketed by
- type (copy, move, delete, etc)
- destination (system vs external provider, with a special bucket for
    intra-provider operations)
- result (success vs failure)

BUG=26737132

Change-Id: Ic24c7a22fa3c1227e23cfbd42ae80ca1f70a19ba
2016-01-29 08:31:42 -08:00
Steve McKay
5a2120820a Merge "Files always visible, same for new window menu." 2016-01-28 23:42:34 +00:00
Steve McKay
cbee544a53 Clear selection after copy and when back is pressed.
Change-Id: I5240c825016b9e21bc147591b72bb969eb765597
2016-01-28 15:30:36 -08:00
Steve McKay
a7e923c57c Create new windows on *other* side in multi-window mode.
Bug:26831180
Change-Id: Ie3fb22847e70cd78998d467a8af9bf20642304e5
2016-01-28 12:03:48 -08:00
Steve McKay
5fe5c458dc Files always visible, same for new window menu.
Remove "productivity_device" bit.

Change-Id: I28ee3e210fc5f8c367d45a74edab0e04667ddd5e
2016-01-28 11:43:08 -08:00
Tomasz Mikolajewski
748ea8cc78 Show a warning notification and a dialog in case of conversion when copying.
Change-Id: I451b0944069deb5f0b49b54c514e7761be449e3d
2016-01-28 13:12:55 +09:00
Steve McKay
3eb2d07fd3 Remember view mode by root.
Now stored in local prefs, not recents DB.
Don't consult preferences for recents from DocumentsActivity.

Bug: 22671255 26689962 26411301
Change-Id: I492d85c450253bce984c929a6dd15d7c31ee6a0b
2016-01-27 16:28:28 -08:00
Steve McKay
0bbf302573 Merge "Remove variants of "show/hide" internal storage string." 2016-01-27 19:47:50 +00:00
Steve McKay
de3f4c89ca Merge "Revert "Eliminate the "productivity_device" setting."" 2016-01-27 19:25:07 +00:00
Steve McKay
8fa9ffcdc0 Revert "Eliminate the "productivity_device" setting."
This reverts commit d0a0fc2cd1fbb629f329cf10e0413a674a8e54b6.

Missed a use. Prema-revert.

Change-Id: I6bce595646e2e2bf1e506388a2da9e1cd8f61a09
2016-01-27 19:24:25 +00:00
Ben Kwa
3ca3a3db5e Merge "Eliminate the "productivity_device" setting." 2016-01-27 18:48:01 +00:00
Felipe Leme
10f673a2ff Merge "Initial implementation of OPEN_EXTERNAL_DIRECTORY." 2016-01-27 16:56:20 +00:00