22336 Commits

Author SHA1 Message Date
Gilles Debunne
5ca6f9e56f Merge "EditText-specific data extracted from TextView" 2012-02-22 14:30:43 -08:00
Gilles Debunne
60e2186c35 EditText-specific data extracted from TextView
All edit-specific data has been moved to an EditData inner class in TextView.

The instance of this class is created as soon as one of its fields is set to
a non-default value. Regular TextViews (buttons, checkboxes...) should never
have to instantiate the Editor, thus reducing their memory footprint.

Note: this is a debug version. The getEditor() method is here to track
possible problems and should be removed in the final version. Indentation
will be fixed then.

Next step is to extract more methods and classes into Editor and create a
dedicated class for it. mMovement may also be Editor specific.

Change-Id: Ic241953a2fb73213180f300c3609a9e6799aa884
2012-02-22 14:24:56 -08:00
Gilles Debunne
36a5822484 Merge "Added bottom padding in textview's focused rectangle" 2012-02-22 14:18:17 -08:00
Daisuke Miyakawa
c4bec73f3b Merge "Remove the entire PIM directory." 2012-02-22 13:06:58 -08:00
Adam Powell
2a23e88486 Merge "Fix bug 6048643 - verify ListView layoutparams while tracking stable IDs" 2012-02-22 12:22:31 -08:00
Adam Powell
aebd28f729 Fix bug 6048643 - verify ListView layoutparams while tracking stable IDs
Account for adapters that don't inflate item views using the ListView as
a parent.

Unify how AbsListView and subclasses generate layoutparams.

Change-Id: I963a5fcb4d98b721210a4d92d0db307f56acdf59
2012-02-22 12:04:12 -08:00
Gilles Debunne
322044abe4 Added bottom padding in textview's focused rectangle
Bug 6017386

Focused rect in used in ViewRoot when a new view takes focus.
TextView bringPointIntoView defines an other rectangle as text is typed.

Make sure the latter is included in the former to avoid the jump when one
starts typing text.

Change-Id: I0177adc046c77a5fd9c1423c0069d5b9798dc0b9
2012-02-22 12:01:42 -08:00
George Mount
0b2cfd8cb1 Use input type for IME options.
Bug 5987568
 Get the text type from webkit when initializing the field for
 text entry and use that type to specify the IME input type
 and options.
 Webkit Change: I7eceafdbede8b7b463590a2e875a237241479ad1

Change-Id: Ic8c14687a70727148dfc8115c46f09530ca0c0f6
2012-02-22 11:25:59 -08:00
John Reck
d3fcaa4504 Merge "Turn off the focus animation" 2012-02-22 10:18:43 -08:00
John Reck
fbf9cf8d6b Turn off the focus animation
Change-Id: I860220622415c6d3f93f526c854237ac1dd001ce
2012-02-22 10:14:03 -08:00
John Reck
3843939002 Merge "Add null parent check to startActionMode" 2012-02-22 09:43:27 -08:00
John Reck
5160e2a197 Add null parent check to startActionMode
Bug: 6012515

Change-Id: I9f684bf0fd314285c4d4933ba2a7645f10c9dc7b
2012-02-22 09:41:25 -08:00
Steve Block
1e17ecae25 Remove unused cache methods
These were added in https://mondrian.corp.google.com/changelist/19077-p9.

CacheManager.setCacheDisabled() has been unused since
https://mondrian.corp.google.com/changelist/20678-p9 (see change to WebView),
so the WebKit cache is always enabled.

BrowserFrame.setCacheDisabled() has been unused since
https://mondrian.corp.google.com/changelist/33679-p9, so the WebCore cache is
always enabled.

BrowserFrame.CacheDisabled() has been unused since
https://mondrian.corp.google.com/changelist/32803-p9 (see change to WebView).

See WebKit change https://android-git.corp.google.com/g/167298.

Change-Id: I68bf334f4a34df1b88d2b5204e50c2eb04db7e69
2012-02-22 16:48:25 +00:00
satok
5c9b4329f3 Merge "Refactor sentence level spell checking APIs" 2012-02-21 22:59:12 -08:00
satok
d404fe1105 Refactor sentence level spell checking APIs
Support sentence level spell checking APIs: Step 1

Change-Id: I31c0b88e7885f33a0694ab60b8f2dbceeffe42f1
2012-02-22 15:35:46 +09:00
Adam Powell
69d7558227 Merge "Fix bug 5971117 - Action bar does not update icon used for collapsible action views" 2012-02-21 17:19:29 -08:00
Svetoslav Ganov
a6cdf86518 Merge "Improving accessibility APIs used for UI automation." 2012-02-21 17:17:33 -08:00
Daisuke Miyakawa
232106b47f Remove the entire PIM directory.
ContactsAsyncHelper had been used by multiple projects, but now
only Phone app is using that. By moving the file to Phone package,
the entire PIM directory becomes unnecessary.

Bug: 5236130
Change-Id: I3daf087dbeb9059c2884dbf0e4d40d1508790aa3
2012-02-21 17:16:01 -08:00
Adam Powell
f821819a88 Fix bug 5971117 - Action bar does not update icon used for collapsible
action views

Change-Id: Ib25cd40b046ab4b7dc382476345f95727fde3955
2012-02-21 17:10:10 -08:00
Svetoslav Ganov
0d04e24553 Improving accessibility APIs used for UI automation.
1. UiTestAutomationBridge was accessing the root node in the
   active window by tracking the accessibility event stream
   and keeping the last active window changing event. Now
   the bridge is stateless and the root node is fetched by
   passing special window and view id with the request to
   the system.

2. AccessibilityNodeInfos that are cached were not finished,
   i.e. not sealed, causing exception when trying to access
   their children or rpedecessors.

3. AccessibilityManagerService was not properly restoring its
   state after the UI automation bridge disconnects from it.
   I particular the devices was still in explore by touch mode
   event if no services are enabled and the sutomation bridge
   is disconnected.

4. ViewRootImpl for the focused window now fires accessibility
   events when accessibility is enabled to allow accessibility
   services to determine the current user location.

5. Several missing null checks in ViewRootImpl are fixed since
   there were scenraios in which a NPE can occur.

6. Update the internal window content querying tests.

7. ViewRootImpl was firing one extra focus event.
bug:6009813
bug:6026952

Change-Id: Ib2e058d64538ecc268f9ef7a8f36ead047868a05
2012-02-21 17:09:09 -08:00
John Reck
8352e51db3 Merge "Improved keyboard navigation cursor rings" 2012-02-21 15:43:38 -08:00
Adam Powell
4d6f066b19 Have View call setPressed explicitly instead of just twiddling flags.
This allows apps to override setPressed to reliably observe changes in
pressed state for custom views.

Change-Id: I59f472a9d864f4abcc4f692fef0a13f004348432
2012-02-21 15:13:20 -08:00
Victoria Lease
47d0ee9766 async find-on-page implementation via WebKit
Change-Id: I63c6f8fc97bf452ea4456c77a89c5d2540c3d1ea
2012-02-21 11:08:27 -08:00
John Reck
37c4a9f99a Improved keyboard navigation cursor rings
Change-Id: I77b974bb9eae0f9dc8e57320632e5915e8295839
2012-02-21 10:04:54 -08:00
Martin Kosiba
4c69fc575e Merge "Update the JavaDoc on getVisibleTitleHeight." 2012-02-21 08:58:21 -08:00
Steve Block
303bc083c5 Clean up JavaDoc for CacheManager
Clean-up only, no functional change.

Bug: 5461416
Change-Id: I272b1456e797f398014a6a4159319e5519fcaf64
2012-02-21 14:19:26 +00:00
Steve Block
ffefba15e3 Fix CacheManager.getCacheFile() with the Chromium HTTP stack
We need to populate the headers map with both the Android and Chromium HTTP
stacks.

Change-Id: I2df0aa2fce917ad43a1cac1426a324e49b2950f9
2012-02-21 14:19:15 +00:00
Steve Block
2601dccdc0 Merge "Don't try to use Network timing with the Chromium HTTP stack" 2012-02-21 03:52:02 -08:00
Steve Block
35067317a4 Merge "Clean up JavaDoc for WebResourceResponse" 2012-02-21 03:51:47 -08:00
Martin Kosiba
dd409dfbc4 Update the JavaDoc on getVisibleTitleHeight.
Changed 'titlebarview' to 'embedded title bar' and added information
about the return value of the method.

Change-Id: I970ab76282bfed4949f1d738f34359d8c1950aba
2012-02-21 11:25:26 +00:00
Steve Block
acd7e2eb8b Don't try to use Network timing with the Chromium HTTP stack
Change-Id: Ibba20a13e1389c2a7b1cc0cc45d3ef012894cb99
2012-02-21 10:21:40 +00:00
Steve Block
938d2fbc57 Clean up JavaDoc for WebResourceResponse
Clean-up only, no functional change.

Bug: 5461416
Change-Id: Iec37d5f67674b0fb9b5521c179773b7d09a3985c
2012-02-21 10:21:37 +00:00
Steve Block
e5602e057e Merge "Clean up JavaDoc for CookieManager" 2012-02-21 02:18:12 -08:00
Steve Block
77db999077 Clean up JavaDoc for CookieManager
Also fix naming of CookieManager.pendingCookieOperations.

Clean-up only, no functional change.

Bug: 5461416
Change-Id: Ia129c4535b8ef6a5a314e588c34ee6db2fe5b386
2012-02-21 10:15:34 +00:00
Steve Block
28e0390da2 Merge "Make LoadListener.willLoadFromCache() private" 2012-02-21 02:09:34 -08:00
Steve Block
b1affa1747 Make LoadListener.willLoadFromCache() private
This is only called only via JNI. Clean-up only, no functional change.

Change-Id: I8d4ef85ac7634333b3b2283ff12afd7b6a99095f
2012-02-21 10:07:27 +00:00
Todd Poynor
94d0024557 Power HAL PowerManagerService hookup
Use PowerHAL to set system awake/suspend state.

Change-Id: If58a6f548564ea141b68f304455997d9ff04eace
Signed-off-by: Todd Poynor <toddpoynor@google.com>
2012-02-17 22:19:45 -08:00
Romain Guy
e8585b1721 Correctly offset the dirty bounds by 0.5px in every direction
The existing code was behaving differently for the leaf view and its parents.

Change-Id: I14c1ce5cc149ff840ad957408d6a41bbb4137264
2012-02-17 18:31:31 -08:00
Adam Powell
539ee8716b Add transient state tracking to Views
Transient state is temporary bookkeeping that Views need to perform
that the app should not need to be aware of. Examples include text
selection regions and animation state.

Transient state is a problem for AdapterViews like ListView that do
view recycling. Unless the app takes responsibility for tracking and
restoring transient state as if it were a part of the adapter's data
set, it cannot correctly recycle views. Selections disappear when an
EditText is scrolled out of sight and animations seem to play on the
wrong views.

Views can now flag themselves as having transient state. (As the name
implies, this should be a temporary condition.) If a ViewGroup
contains a child with transient state, that ViewGroup also has
transient state.

AbsListView's recycler now tracks views with transient state
separately. Views with transient state will be retained, and until a
data set change occurs the same view will be reused for that position
instead of calling the adapter's getView() method.

The API to set and check transient state is currently hidden.

Change-Id: Idfd8eaac2c548337686d8d9f98fda4c64be5b8a0
2012-02-17 16:40:24 -08:00
Romain Guy
6917e6550d Merge "Record possible clip rejects when recording display lists" 2012-02-17 15:18:14 -08:00
Romain Guy
33f6beb10f Record possible clip rejects when recording display lists
This optimization allows us to quickly skip operations that lie
entirely outside of the known bounds of a display list. Because
of ViewGroup.setClipChildren, we must keep the operations recorded
in the display list. setClipChildren(false) is however a very
uncommon operation and we will therefore often benefit from this
new optimization.

Change-Id: I0942c864e55298e6dccd9977d15adefbce3ba3ad
2012-02-17 13:10:00 -08:00
Philip Milne
580d079101 Merge "Fix remaining issue with bug #5904777" 2012-02-17 10:06:47 -08:00
Jeff Brown
2bf372888c Merge "Mark input and sensor messages as asynchronous." 2012-02-16 19:49:14 -08:00
Jeff Brown
aa917f8522 Merge "Improve MessageQueue sync barrier implementation." 2012-02-16 19:49:03 -08:00
Jeff Brown
50eb3b9bf9 Merge "Encapsulate the ViewRootImpl's handler." 2012-02-16 19:43:43 -08:00
Fabrice Di Meglio
101d5aade4 Fix #5050417 Update View class Javadoc for padding start / end
Change-Id: Iec9533616d94e4a738378bafeb1867dd74e53127
2012-02-16 18:36:40 -08:00
Jeff Brown
e0dbd00275 Mark input and sensor messages as asynchronous.
Set a barrier on traversals.

Vsync is still not enabled by default in this patch so there
should be no observable effect from these changes.

Change-Id: Ie12081b95a8f1e81ed686edf747cc62f2e044b7e
2012-02-16 18:19:56 -08:00
Philip Milne
6216e87fe8 Fix remaining issue with bug #5904777
LEFT alignment in an RTL environment had the wrong 'gravity'.

This was due to a modelling error in GridLayout which is fixed in this CL.

Also apply some very minor simplifications and refactorings following the
addition of RTL support.

Change-Id: I153bc06d3c22dcb9954e4cbdfa89625823239b89
2012-02-16 17:23:31 -08:00
Fabrice Di Meglio
30e2fbe0d2 Merge "Improve textDirection APIs" 2012-02-16 16:58:47 -08:00
Romain Guy
add3239ffb Merge "Ensure we always reset graphics modifiers Bug #6025838" 2012-02-16 16:52:53 -08:00