263 Commits

Author SHA1 Message Date
Nataniel Borges
4e4babec1a Create owner test files for subpackages
Now failures can be automatically directed to the correct buganizer components and forwarded directly to the correct assignees, instead of being all created into the Winscope for further triage

Test: check owners file
Change-Id: I6876a702b4f46443328aab027f7fee994b2bb819
2022-01-20 10:21:40 +00:00
Nataniel Borges
b81392c9cd Add pablogamito to flicker test owners
Test: check owners file
Change-Id: If8adecda0d23d6d673825695e57813b281c0f6bc
2021-11-09 19:11:37 +01:00
Tracy Zhou
626522d77f Update ReOpenImeWindowTest to be in gestural nav mode
- and update some test assumptions accordingly (live tile)

Bug: 185934639
Test: ReOpenImeWindowTest
Change-Id: If6f40dce174bef5ccc3c3731764607a5826b4762
2021-06-29 23:09:07 -07:00
Nataniel Borges
a50b03521f Merge "Promote stable flicker tests (ime)" into sc-dev 2021-06-07 12:56:31 +00:00
Nataniel Borges
128a9fdbcb Merge "Promote stable flicker tests (app launch)" into sc-dev 2021-06-07 12:56:23 +00:00
Nataniel Borges
9ac4eb345a Merge "Promote stable flicker tests (rotation)" into sc-dev 2021-06-04 15:32:49 +00:00
Nataniel Borges
fb8237605a Promote stable flicker tests (ime)
The tests have been stable since last week when the underlying bugs were closed.

Bug: 185401242
Bug: 185400889
Test: atest FlickerTests:com.android.server.wm.flicker.ime
Change-Id: I8cea435a9fa295626c45d9d11549c1a4d4f4e63b
2021-06-04 17:05:11 +02:00
Nataniel Borges
b77a5fb78a Promote stable flicker tests (app launch)
The tests have been stable since last week when the underlying bugs were closed.

Bug: 185401242
Bug: 185400889
Test: atest FlickerTests:com.android.server.wm.flicker.launch
Change-Id: I8ef26ac7144766f7269bef2589842e07d098efc3
2021-06-04 16:26:32 +02:00
Nataniel Borges
f420024bf5 Promote stable flicker tests (rotation)
The tests have been stable since last weeks when the underlying bugs were closed.

Bug: 185401242
Bug: 185400889
Test: atest FlickerTests:com.android.server.wm.flicker.rotation
Change-Id: I4aa13016f214f99bcff5adcd98e71096eacada2d
2021-06-04 16:04:56 +02:00
Nataniel Borges
b94ab5c28f Promote stable flicker tests (app close)
The tests have been stable since last weeks when the underlying bugs were closed.

Bug: 185401242
Bug: 185400889
Test: atest FlickerTests:com.android.server.wm.flicker
Change-Id: I6c99e84f0da01c122d8ff6a28eebbdb9bcc6582a
2021-06-04 15:23:54 +02:00
Nataniel Borges
8aaaeea849 Split flicker tests into groups
The flicker test suite grew and now trigger a treehuger SLO violation. To address this problem create different groups for different tests using: --module-arg <TEST SUITE>:include-annotation:<GROUP>

Where:
   <TEST SUITE> = FlickerTests or WMShellFlickerTests
   <GROUP> = com.android.server.wm.flicker.annotation.Group1 or com.android.server.wm.flicker.annotation.Group2 or com.android.server.wm.flicker.annotation.Group3

For example:

1) to run only tests in the first group in flicker use: `--module-arg FlickerTests:include-annotation:com.android.server.wm.flicker.annotation.Group1`

2) to run only the third group of tests from wmshell flicker: ``--module-arg FlickerTests:include-annotation:com.android.server.wm.flicker.annotation.Group3`

Bug: 180620475
Test: atest FlickerTests WMShellFlickerTests with the respective parameters
Change-Id: I82f668713ba262bafe2758e2c618bfc060cc2c8a
2021-05-20 09:36:44 +02:00
Nataniel Borges
4f741f2e89 Promote stable flicker tests
Move:
- Stable postsubmit to presubmit
- Stable flaky to postsubmit

Bug: 186115871
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Ia4b1a4868595d6f9c5134e92851664137d79098e
2021-05-10 14:05:15 +02:00
Nataniel Borges
73e2773099 Disable flaky pip/app close tests (flicker)
Some tests are still flaky and affecting presubmit

Bug: 185400889
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I477799646791c69b71c6f29d71e87caba900a983
2021-04-27 14:58:56 +02:00
Nataniel Borges
91b6830e38 Disable flaky flicker tests
Some tests are still flaky and affecting presubmit

Bug: 185400889
Bug: 186119282
Bug: 186115871
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Ie4e21d01d5ea7586f88470543321ce26ed74afa6
2021-04-22 19:10:04 +02:00
TreeHugger Robot
502c75489d Merge "Remove quicksearchbox from home window list" into sc-dev 2021-04-16 10:22:35 +00:00
Nataniel Borges
f226bc0878 Remove quicksearchbox from home window list
Previously Winscope considered only the `isVisible` property to determine if the window was visible or not. This failed in cases such as `com.google.android.googlequicksearchbox/android.app.ContextImpl` when launching apps, where `isVisible=true` and `alpha=0`

Bug: 181630910
Bug: 182720234
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I75fab0c6de02e43265002986901353f8e230baa5
2021-04-15 17:50:34 +02:00
Nataniel Borges
ce86f719c4 Disable flaky flicker tests
Bug: 185400889
Bug: 185401242
Test: atest FlickerTests
Change-Id: I834e24e772f7faab7c825dc40b5b871fd3ffd61e
2021-04-14 22:21:32 +02:00
Nataniel Borges
c258d7f4ca Disable some trace assertions
Previously some assertions didn't run on the whole trace because of a missing `forAllEntries` statement in the library. When activating this statement these tests fail and should be disabled.

Test: atest FlickerTests WMShellFlickerTests
Bug: 183547024
Bug: 181630910
Change-Id: I28f92e2d9de1a5465a4da5971c438bc4c0b311f9
2021-04-13 20:55:39 +02:00
Nataniel Borges
e852b071ff Fix use of NavigationModeRule on flicker
The method was ignored before and now should be activated to enable 3 button mode. Some tests become flaky in 3-button mode and should be disabled for the moment.

Test: atest FlickerTests WMShellFlickerTests
Bug: 162925924
Change-Id: Ife24ad85c302da6fc193f1a5a226722cfed51b2b
2021-04-12 15:15:56 +02:00
Nataniel Borges
400197ade7 Merge changes from topic "remove-all-tasks" into sc-dev
* changes:
  Ensure apps not running on cold launch test
  Remove all tasks before flicker tests
2021-03-31 16:54:05 +00:00
Ming-Shin Lu
57f2f51eb6 Merge "Add a test for verifying switching IME app with gesture" into sc-dev 2021-03-31 03:01:33 +00:00
Nataniel Borges
0eaa0f1cb0 Ensure apps not running on cold launch test
Currently the only test is not stopping existing apps and may be affected by previous runs on the same device.

Now, ensure all apps are closed when launching the test

Bug: 167521849
Test: atest FlickerTests:com.android.server.wm.flicker.launch
Change-Id: Ib29fb4835cd728e5855ae66452ff1ac9333499ed
2021-03-30 21:20:35 +02:00
Nataniel Borges
ba72075844 Remove all tasks before flicker tests
Ensures no other tasks are executing (cleanup) when a flicker test states to mitigate flakiness

Test: atest FlickerTests WMShellFlickerTests
Bug: 162925924
Change-Id: I84f712c8aba13ac845b9467f6c9753bc91e21a27
2021-03-30 21:19:08 +02:00
TreeHugger Robot
179ae14e8c Merge "Remove IME state assertions from Helper" into sc-dev 2021-03-30 13:51:38 +00:00
Ming-Shin Lu
e9ce91e9c6 Add a test for verifying switching IME app with gesture
Add SwitchImeWindowsFromGestureNavTest in FlickerTests to support
verifying flickers when switching IME app tasks with 2-Buttons or
gestural navigation.

Fix: 181832209
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
Change-Id: I677d08543c75746f1405b50eab9061befeb75fc3
2021-03-30 10:00:14 +08:00
Nataniel Borges
887a3c9d38 Introduce a subject to assert changes over rectangles
In several flicker tests it is necessary to check if a window or layer position is moving or resizing.

To facilitate these checks this CL introduces RectSubject (accessible through WindowStateSubject and LayerSubject) to assert rectangle behaviors

Bug: 174238224
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id568fd9dbd59f176eeb84323c321553221932685
2021-03-29 22:33:41 +02:00
Nataniel Borges
47dd2e6f0b Demote unstable assertions from presubmit
Test: atest FlickerTests WMShellFlickerTests
Bug: 183108736
Bug: 181630910
Bug: 183547024
Bug: 183402546
Change-Id: I5b8d4f9db126bd4c3c9a67327cdfad986f37891b
2021-03-25 14:20:21 +01:00
Nataniel Borges
583e0ed362 Remove IME state assertions from Helper
To display additional error information, these assertions should be tests and not part of the transition.

Test: atest FlickerTests WMShellFlickerTests
Bug: 162925924
Change-Id: I94bd751a37487af49f9b12e55fce60305367200a
2021-03-24 10:41:53 +01:00
Nataniel Borges
6d6bfeb775 Demote unstable assertions from presubmit
Test: atest FlickerTests:com.android.server.wm.flicker
Bug: 167521849
Change-Id: Ifb124f257daa4654ce5c0ab7674959de86a9e8d4
2021-03-18 19:17:05 +01:00
Nataniel Borges
e3cdc17206 Demote unstable assertions from presubmit
Test: atest FlickerTests:com.android.server.wm.flicker
Bug: 167521849
Change-Id: Ifead85b7e5e7c4e8e8207c93984aeeeee258ec49
2021-03-18 15:50:38 +01:00
TreeHugger Robot
249237692c Merge "Promote stable ime tests to presubmit" into sc-dev 2021-03-18 12:16:49 +00:00
TreeHugger Robot
4cdcf41265 Merge "Promote stable rotation tests to presubmit" into sc-dev 2021-03-18 11:42:42 +00:00
TreeHugger Robot
4c5a91244e Merge "Promote stable app launch tests to presubmit" into sc-dev 2021-03-18 11:38:22 +00:00
TreeHugger Robot
0fc7834f74 Merge "Promote stable close app tests to presubmit" into sc-dev 2021-03-18 11:07:10 +00:00
Nataniel Borges
c01fb40a34 Promote stable ime tests to presubmit
These flaky tests have been stable for the past week and can be promoted

Test: atest FlickerTests:com.android.server.wm.flicker.ime
Bug: 171049649
Bug: 167521849
Change-Id: Iae35556c20ce2928b36fd1dfdcdf80633e802dba
2021-03-18 11:38:15 +01:00
Nataniel Borges
e4ef2478c5 Promote stable rotation tests to presubmit
These flaky tests have been stable for the past week and can be promoted

Test: atest FlickerTests:com.android.server.wm.flicker.rotation
Bug: 171049719
Bug: 167521849
Change-Id: Iebe3abe89857e96d1985ab3f840e92fa7b168844
2021-03-18 11:04:37 +01:00
Nataniel Borges
4247e14da5 Promote stable app launch tests to presubmit
These flaky tests have been stable for the past week and can be promoted

Test: atest FlickerTests:com.android.server.wm.flicker.close
Bug: 171049683
Bug: 171049760
Bug: 167521849
Change-Id: I8fb98f3c9a4866bd82e2e39fb90b861719401960
2021-03-18 11:00:35 +01:00
Nataniel Borges
d562be3fe7 Merge "3-button mode tests for IME tests" into sc-dev 2021-03-18 09:51:17 +00:00
Nataniel Borges
c913f04a65 Promote stable close app tests to presubmit
These flaky tests have been stable for the past week and can be promoted

Test: atest FlickerTests:com.android.server.wm.flicker.close
Bug: 171049778
Bug: 171049647
Bug: 167521849
Change-Id: Ic7e45a27120f69b4a4d5e5ca9266809fcd969939
2021-03-18 10:24:10 +01:00
Nataniel Borges
5ec748f76e Merge "3-button mode tests close app tests" into sc-dev 2021-03-17 15:21:41 +00:00
Nataniel Borges
aa48f0eddc 3-button mode tests for IME tests
Tests now run in:
  - Portrait + 3 Button
  - Landscape + 3 Button
  - Portrait + Gestural
  - Landscape + Gestural

Test: atest FlickerTests:com.android.server.wm.flicker.ime
Bug: 167521849
Change-Id: Ib7deb76b0c9b6db9a812c615dec6223b50223c18
2021-03-17 15:36:21 +01:00
Nataniel Borges
e52c38f750 3-button mode tests close app tests
Tests now run in:
  - Portrait + 3 Button
  - Landscape + 3 Button
  - Portrait + Gestural
  - Landscape + Gestural

Moreover, the tests now share the code and assertions because they should behave exactly the same (except for the transition)

Test: atest FlickerTests
Bug: 167521849
Change-Id: Id88514d83e40c04bce3135cccdc142a2b2745597
2021-03-17 14:42:56 +01:00
Nataniel Borges
765f55d9b7 Merge "3-button mode tests app launch tests" into sc-dev 2021-03-17 13:41:57 +00:00
Nataniel Borges
5b0f9fa4f5 3-button mode tests for rotation tests
Tests now run in:
  - Portrait to Landscape + 3 Button
  - Landscape to Portrait + 3 Button
  - Portrait to Landscape + Gestural
  - Landscape to Portrait + Gestural

Test: atest FlickerTests
Bug: 167521849
Change-Id: I997c7af9c4895452aafb1f8e3b13b15168697963
2021-03-17 14:28:48 +01:00
Nataniel Borges
006fbdea31 3-button mode tests app launch tests
Tests now run in:
  - Portrait + 3 Button
  - Landscape + 3 Button
  - Portrait + Gestural
  - Landscape + Gestural

Test: atest FlickerTests
Bug: 167521849
Change-Id: I12137d9a41e36e48263e81d8d8318d21f32f8384
2021-03-17 14:28:42 +01:00
Nataniel Borges
89740805f3 Merge "Remove Snapshot and Splash Screen from consecutive entry check" into sc-dev 2021-03-16 14:14:02 +00:00
Nataniel Borges
8b15b01c43 Remove Snapshot and Splash Screen from consecutive entry check
It is already possible to ignore windows/layers on the verification of  visibleWindowsShownMoreThanOneConsecutiveEntry and visibleLayersShownMoreThanOneConsecutiveEntry. However many tests need to manually add the Snapshot and Splash Screen entries.

Those entries are not guaranteed to show for more than 1 entry, they depend on the app behavior and when the SF actually renders the information sent by WM.

This CL removes those windows by default from the verification and refactor the tests to make it easier to update in the future

Test: atest FlickerTests WMShellFlickerTests
Bug: 182720234
Change-Id: I0e3346e078515b3e9a2065256ac04696acfa59fb
2021-03-16 10:26:55 +01:00
Nataniel Borges
8ef0e48edf Support different navigation modes on WM flicker
By default use only Gestural navigation, but more navigation modes can now be enabled on each test

Test: atest FlickerTests
Bug: 167521849
Change-Id: Ic8dcd2390da63663b228977928925fb1e2f99ed5
2021-03-15 17:01:36 +01:00
Nataniel Borges
dc740c128c Merge "Revert "Promote IME postsubmit tests to presubmit"" into sc-dev 2021-03-12 22:51:15 +00:00
Nataniel Borges
edb9fafdc6 Revert "Promote IME postsubmit tests to presubmit"
This reverts commit fb45d19101dbf20763e72f98fd84be5e9778dc07.

Reason for revert: 90 degrees tests break go/wm-tests-flicker

Change-Id: I70d16061887e623a4bc572cff8f6328d488d3c0b
2021-03-12 20:12:14 +00:00