Also...sorry, snowball, don't automatically open folders
that are created in Files app. Only do this in DocumentsActivity.
Change-Id: I271655fd3566496eced4aaa7a44d5110233150a0
- Always open drawer for copy/move operations.
- Set title to match operation.
- Update button to say "move" for move operations.
- Other minor fixes.
Also fix "Home" tests broken by ag/867110
Bug: 26506479
Change-Id: I3ccb4ddc72be0a21b91744bcb610c1ca490ac30c
Update State test to cover different conditions separately.
Update DirectoryInfo test to best practices.
Update RootInfo to follow DirectoryInfo equals pattern.
Also, allow null cursors from Model...since they happen...I seen it mahself.
Bug: 27118725
Change-Id: Id0a0be053b91c887a745bfca5416e64f0edba995
- Introduce an API on MultiSelectManager for starting/ending range
selections.
- Navigation with the shift key pressed extends the current range
selection (or starts a new one, if one isn't in progress).
- Navigation without the shift key pressed will end the current range
selection.
BUG=27124371
Change-Id: Ieddf3ee816812bf5210463536fe63179ef1809ad
(cherry picked from commit 09792ef1506f4cbd944e16651508be435d92c5be)
- Turn the DirectoryFragment (DF) and the RootsFragment (RF) into
top-level views, and allow switching between them via the tab key.
- Disallow arrow-key navigation from switching the user between the
DF and RF.
- When nothing is explicitly focused, make navigation keys focus the
DF. This makes it so that if a user opens DocumentsUI and just starts
pressing arrow keys, they'll navigate in the directory listing.
- When restoring focus on the DF and RF, remember the last thing that
was focused, and restore focus on that thing.
BUG=25195767
BUG=25121367
Change-Id: I00e20cbdbe9edfe269fb356440a93ef5d67c5298
(cherry picked from commit 1c9f9222e56482682461013b703590c5c9471018)
Also, update Selection model to use a discrete provisional selection,
rather than a superset "total" selection
Bug: 27075323
Change-Id: I855e6b66010b3cdd599cc0a9f0046a7efadca5fe
The tests should fail, as the features are broken.
Change-Id: Ib760ba5469164b8ca0d08c57f24273268ae2436f
(cherry picked from commit 94eca73fec7aa1857f5847df355877d523d0c8a6)
ActivityInstrumentationTestCase2 takes care of starting and closing
the activity, which prevents flakyness.
Change-Id: I2d3908f6605a67a3c2d11e18a9c4799443828df9
(cherry picked from commit e366886c7d91b62fe1478a057fc4c0a104d12b02)
The test was resuming a previously opened activity, so naturally the
redirect to Home didn't happen.
This CL fixes the issue by closing the activity in TearDown().
Change-Id: I43e78a83c2b53c52745bc7eef515a8f759559e46
- Pull key handling code out of the MultiSelectManager.
- Tighten up the semantics around range selection:
- Create an API on MultiSelectManager for handling multi-select.
- Make the range selection more opinionated (e.g. more state checks),
to simplify the design and code.
BUG=25195767
Change-Id: I4bbe446ed3059150499db3d28e581b2e68405266
- Add helper class for the Ui tests. It creates basic test environment.
It is intermediate layer between UiBot/DocumentsProviderHelper and UiTest classes.
- Refactor SearchView tests
- Add renaming support in the test DocumentsProvider
- Add renaming tests
Bug=26799799
Change-Id: I2849913a1addabff0087bb06b80f36de7cb144f3
- Remove whitespace from the GridModel, which isn't set up to deal with
it.
- Use absolute column bounds whenever translating the band rectangle
into column indices. This necessitates additional binary searching,
but is necessary when columns aren't fully populated, which happens
with the new grid layout.
BUG=26512327
Change-Id: I5016d5de8f00c366f575f0722739007ac1612923
- Remove the gesture detector from the MultiSelectManager, and
consolidate gesture detection and event dispatch logic in
DirectoryFragment.GestureListener.
- Route single-tap events through the DocumentHolder, so that it can
apply view-specific logic, like making a tap on the item's icon
select rather than activate.
- Consolidate event handling logic in the ItemEventListener.
- Add new unit tests for DocumentHandler.
BUG=24326546
Change-Id: Id15cdd11b13e4c063c1baff95aa8ee09c190d6c3
Refactor Jobs to work with files from multiple providers.
Don't shut down threadpool until service#onDestroy is called.
Bug: 26696797, 26462789, 26567205, 25162803, 26714663
Change-Id: Id43e8e3dc2294cd07dcd6a3477b19efb298c260f
Swith to using a regular service.
Perform file ops on thread pool.
Separate Job tests from service test.
Check in service test that wake lock is released and service shut down.
Increase copy buffer size to 32k (suggested by mtomasz).
Rework Copy testing to use an out-of-process provider (which has caused a content validation problem).
Move copy testing logic into base test and share it with Move testing.
Change-Id: I2f97d6c9f23c205b0f39ca6ba93bec119d63c80b
- Move SearchManager out of BaseActivity.
- Refactor usage of onCurrentDirectoryChanged(int anim).
- Cancel search when directory changes.
- Enable testing for cancelling search when directory changes.
- Avoid recreating action bar when only the content of the directory is
changed.
BUG=26495573
Change-Id: I1400090fcb529ad3905018d1640fdb7416542989
This is necessary to prevent UI thrash (items continually shuffling
around) when the underlying Provider doesn't return its contents in a
stable order from one load event to another (DownloadStorageProvider is
an example).
BUG=26417297
Change-Id: Ie99e56b610f5d01d5318be07c0379b506c828735