307 Commits

Author SHA1 Message Date
Felipe Leme
dac815ae98 Merge "Make bugreport details dialog confirm to Material Guidelines for Dialogs." into nyc-dev am: 2bb39839fd
am: cfdfb09c4f

* commit 'cfdfb09c4fea16c5e9ba6ce3010326a8048aa87c':
  Make bugreport details dialog confirm to Material Guidelines for Dialogs.
2016-03-01 01:06:45 +00:00
Felipe Leme
cfdfb09c4f Merge "Make bugreport details dialog confirm to Material Guidelines for Dialogs." into nyc-dev
am: 2bb39839fd

* commit '2bb39839fd802459fd494b6ea0c182485277bd5e':
  Make bugreport details dialog confirm to Material Guidelines for Dialogs.
2016-03-01 01:00:42 +00:00
Felipe Leme
bbd91e5844 Make bugreport details dialog confirm to Material Guidelines for Dialogs.
Changes:
- Removed hints.
- Added TextViews for field labels.
- Added padding for inner dialog
- Adedd autoCorrect and capSentences to title and summary
- Changed strings.
- Set name to be selectAllOnFocus initially.

Also improved some logging statements.

BUG: 26324085
Change-Id: I32597a7c2839ca706dbbcf13660e976469ab8dd0
2016-02-29 16:46:54 -08:00
Felipe Leme
2757b3ed79 Merge "Open bugreport info when touching notification (as well as DETAILS button)." into nyc-dev am: 1e33af88ed
am: f7ea5b161a

* commit 'f7ea5b161ac16ce0c388d7fd0c70825b60771324':
  Open bugreport info when touching notification (as well as DETAILS button).
2016-02-26 17:59:16 +00:00
Felipe Leme
f7ea5b161a Merge "Open bugreport info when touching notification (as well as DETAILS button)." into nyc-dev
am: 1e33af88ed

* commit '1e33af88edf3109bc8e6484c5f66e259a247cd01':
  Open bugreport info when touching notification (as well as DETAILS button).
2016-02-26 17:55:23 +00:00
Felipe Leme
1e33af88ed Merge "Open bugreport info when touching notification (as well as DETAILS button)." into nyc-dev 2016-02-26 17:49:54 +00:00
Felipe Leme
db31363aa9 Open bugreport info when touching notification (as well as DETAILS button).
Also added test case for CANCEL button on system notification.

BUG: 26906985
Change-Id: I92eac2e5ec18a8d1d4412f5c1832a52705caf3b3
2016-02-25 17:09:46 -08:00
Felipe Leme
55f708baa2 Merge "Using Message.obtain() to decrease number of Messages allocated." into nyc-dev am: 17fc60e13c
am: 41065fe9ef

* commit '41065fe9efc7cb80cc8b42aed5c3bf4b892bddd9':
  Using Message.obtain() to decrease number of Messages allocated.
2016-02-26 00:51:13 +00:00
Felipe Leme
41065fe9ef Merge "Using Message.obtain() to decrease number of Messages allocated." into nyc-dev
am: 17fc60e13c

* commit '17fc60e13c2a3b78c0f613d46355e23664fd69f3':
  Using Message.obtain() to decrease number of Messages allocated.
2016-02-26 00:39:18 +00:00
Felipe Leme
17fc60e13c Merge "Using Message.obtain() to decrease number of Messages allocated." into nyc-dev 2016-02-26 00:32:29 +00:00
Felipe Leme
8648a15406 Using Message.obtain() to decrease number of Messages allocated.
BUG: 26906985
Change-Id: Ide8c6e308dcc83e9627ec775a4d977d17cd2f0a9
2016-02-25 16:24:43 -08:00
Felipe Leme
19108d3ab8 Merge "Removed toast messsage sent after screenshot is taken." into nyc-dev am: 8c0412c8d3
am: 0d243005d3

* commit '0d243005d3d43619f2e65355714497b7ff34aaae':
  Removed toast messsage sent after screenshot is taken.
2016-02-25 22:33:53 +00:00
Felipe Leme
0d243005d3 Merge "Removed toast messsage sent after screenshot is taken." into nyc-dev
am: 8c0412c8d3

* commit '8c0412c8d3b033f84f7ec8fbd9e3b96899543a40':
  Removed toast messsage sent after screenshot is taken.
2016-02-25 22:27:53 +00:00
Felipe Leme
5d9000aa45 Removed toast messsage sent after screenshot is taken.
That toast was kind of reduntant (since the phone already vibrates
before taking a screenshot) and often useless (because it was displayed
seconds after requested).

BUG: 26577203
Change-Id: I0ba6f974eefd473d158f7fefb12f6a5d2a50b772
2016-02-25 13:10:14 -08:00
Felipe Leme
9da77c0c06 Reset UI fields when dialog is reused, otherwise it might contain fields from a previous bug report. am: 262887834c
am: cd8fed062a

* commit 'cd8fed062aa988c528b1051d86828de71596b47e':
  Reset UI fields when dialog is reused, otherwise it might contain fields from a previous bug report.
2016-02-25 20:44:59 +00:00
Felipe Leme
070d87833b Merge "Final (?) fixes on id / pid split." into nyc-dev am: 3fd6d9b371
am: 5fa0b80c5e

* commit '5fa0b80c5e3eb6f5e526b52e3595311675f5d3ac':
  Final (?) fixes on id / pid split.
2016-02-25 20:36:24 +00:00
Felipe Leme
cd8fed062a Reset UI fields when dialog is reused, otherwise it might contain fields from a previous bug report.
am: 262887834c

* commit '262887834c7938b7a7bbbd7ef026b5965d6412fc':
  Reset UI fields when dialog is reused, otherwise it might contain fields from a previous bug report.
2016-02-25 20:14:16 +00:00
Felipe Leme
262887834c Reset UI fields when dialog is reused, otherwise it might contain fields
from a previous bug report.

BUG: 26524513
Change-Id: If9d176806b28120b57dddeb62b636065f8ff7cf6
2016-02-25 12:10:43 -08:00
Felipe Leme
5fa0b80c5e Merge "Final (?) fixes on id / pid split." into nyc-dev
am: 3fd6d9b371

* commit '3fd6d9b3713bab828174dfba00f8c25c8d933d62':
  Final (?) fixes on id / pid split.
2016-02-25 20:04:11 +00:00
Felipe Leme
85ae3cf46a Final (?) fixes on id / pid split.
The main goal of this CL was to change the test cases to send an
EXTRA_ID instead of EXTRA_PID, but in changing that it was revealed 2
minor bugs:

- When setting the name property, it was using id instead of pid (which
  is what dumpstate expects).
- When the pid is replaced by the name in the screenshots, it would be
  replaced twice if the pid was small enough (because the call to
  String.replace() would also replace the counter).

This CL fixes these issues, and removes the temporary assignment of id =
pid when the former is missing.

BUG: 27076108
Change-Id: I70e7ce7d145019438272594686ac0d4d5dbe1723
2016-02-25 11:14:03 -08:00
Felipe Leme
fbe175fc69 Merge "Created counter (tron_varz_dumpstate_duration) for dumpstate duration." into nyc-dev am: fe9731f4f2
am: 343b9150b2

* commit '343b9150b26f97e2ebcede22b45ceeec8a63cfb4':
  Created counter (tron_varz_dumpstate_duration) for dumpstate duration.
2016-02-23 18:24:53 +00:00
Felipe Leme
343b9150b2 Merge "Created counter (tron_varz_dumpstate_duration) for dumpstate duration." into nyc-dev
am: fe9731f4f2

* commit 'fe9731f4f287560d43f9af48c5be555e8a727955':
  Created counter (tron_varz_dumpstate_duration) for dumpstate duration.
2016-02-23 18:20:50 +00:00
Felipe Leme
f39bac884b Merge "Initial implementation of logging metrics for bugreport." into nyc-dev am: 4e34c4e53c
am: 5e43dcfc02

* commit '5e43dcfc0253f86d7259bd6c8af87b21953312b8':
  Initial implementation of logging metrics for bugreport.
2016-02-23 18:02:03 +00:00
Felipe Leme
5e43dcfc02 Merge "Initial implementation of logging metrics for bugreport." into nyc-dev
am: 4e34c4e53c

* commit '4e34c4e53c21f004cb575c0d46c83565b33fed88':
  Initial implementation of logging metrics for bugreport.
2016-02-23 17:56:54 +00:00
Felipe Leme
510e922e47 Created counter (tron_varz_dumpstate_duration) for dumpstate duration.
BUG: 26759986
Change-Id: I18534c127b35776a03e31b9d5cd190d864dff9e6
2016-02-23 09:40:13 -08:00
Felipe Leme
6605bd89c5 Initial implementation of logging metrics for bugreport.
This change logs the following user actions:

  - Interactive bug report initiated from power menu.
  - Full bug report initiated from power menu.
  - Bug report canceled using system notification.
  - Bug report details screen open using system notification.
  - Additional Bug report screen shot taken using system notification.
  - User changed bug report name using the details screen.
  - User changed bug report title using the details screen.
  - User changed bug report description using the details screen.
  - Changes made on bug report details screen were saved by user.
  - Changes made on bug report details screen were canceled by user.

BUG: 26759986
Change-Id: I1aae98b87a4dea66a1030a024dd799b97c25dd6d
2016-02-23 09:08:56 -08:00
Felipe Leme
7341a00809 Merge "Fixed permissions so Shell can call netpolicy methods." into nyc-dev am: b055c1b51a
am: cf20a742ed

* commit 'cf20a742ed679861d91bd1e3bf6a9caf5786aedf':
  Fixed permissions so Shell can call netpolicy methods.
2016-02-20 08:15:41 +00:00
Felipe Leme
cf20a742ed Merge "Fixed permissions so Shell can call netpolicy methods." into nyc-dev
am: b055c1b51a

* commit 'b055c1b51a6d13f53535386f7ffe32018b21fe64':
  Fixed permissions so Shell can call netpolicy methods.
2016-02-20 02:30:53 +00:00
Felipe Leme
6a05eee2bd Fixed permissions so Shell can call netpolicy methods.
BUG: 27127112
Change-Id: I5548aba70a1c25be139462fbabe9a854fa96d2a6
2016-02-19 17:47:46 -08:00
Michal Karpinski
5cca05d1bc Merge "Be less aggressive in removing old remote bugreport files" into nyc-dev am: f58179a24b
am: 3d3b3481fe

* commit '3d3b3481fe49f77f204eb070f88e78f9a1a9e1d1':
  Be less aggressive in removing old remote bugreport files
2016-02-17 17:29:36 +00:00
Michal Karpinski
3d3b3481fe Merge "Be less aggressive in removing old remote bugreport files" into nyc-dev
am: f58179a24b

* commit 'f58179a24b4de90d0d1a5601530f7c19a57405f6':
  Be less aggressive in removing old remote bugreport files
2016-02-17 17:23:30 +00:00
Michal Karpinski
f58179a24b Merge "Be less aggressive in removing old remote bugreport files" into nyc-dev 2016-02-17 17:18:19 +00:00
Felipe Leme
657591e417 Merge "Cancel notifications when user tap on Details or Take Screenshot after service died." into nyc-dev am: 6cb955826b
am: d8ab544929

* commit 'd8ab5449292ce6f758b0f5a44955b58085e5d854':
  Cancel notifications when user tap on Details or Take Screenshot after service died.
2016-02-17 16:21:58 +00:00
Felipe Leme
d8ab544929 Merge "Cancel notifications when user tap on Details or Take Screenshot after service died." into nyc-dev
am: 6cb955826b

* commit '6cb955826b752189002727cb1db62cfac64bc58a':
  Cancel notifications when user tap on Details or Take Screenshot after service died.
2016-02-17 16:16:10 +00:00
Felipe Leme
6cb955826b Merge "Cancel notifications when user tap on Details or Take Screenshot after service died." into nyc-dev 2016-02-17 16:11:16 +00:00
Geoff Mendal
878b249c90 Import translations. DO NOT MERGE
Change-Id: If833e6af6b9206411e02db9c081d410c4893d73e
Auto-generated-cl: translation import
2016-02-17 07:14:57 -08:00
Michal Karpinski
a57f0e6b14 Be less aggressive in removing old remote bugreport files
Always keep all the files of the remote bugreport
operation and keep them for at least a day.

Bug: 27215341
Change-Id: I514956004bf982e868a87b39c705d7c4a4a7b001
2016-02-17 13:47:17 +00:00
Geoff Mendal
d43baac9b4 Import translations. DO NOT MERGE
Change-Id: Idaf3b3413d142a3107bd11ad228d5ed58f2b5fad
Auto-generated-cl: translation import
2016-02-17 05:43:28 -08:00
Felipe Leme
1eee1996f5 Cancel notifications when user tap on Details or Take Screenshot after
service died.

There are scenarios when the user is running low on resources and it
kills Shell after it start monitoring a dumpstate process, in which case
the BugreportInfo is not available anymore when the user tap a
notification action.

We could add a mechanism to recover that info (like persistenting the
user-provided values in a shared preference), but would incur in more
costs when the device is already in a resource-constrained state, so
it's better to just stop monitoring and switch back to the traditional
model where the user is notified after the bugreport finishes (the
drawback is that all user-provided information will be lost).

Also improved how info.name is checked to avoid crash in similar cases.

BUG: 27186542
BUG: 27203559
Change-Id: I57076b098a3fce493e1a27121b6e070366808668
2016-02-16 13:17:53 -08:00
Geoff Mendal
68e221ec0c Import translations. DO NOT MERGE
Change-Id: I5450d165959f42088148bf3aa9789d73137475bc
Auto-generated-cl: translation import
2016-02-15 07:19:37 -08:00
Geoff Mendal
f72cafb202 Import translations. DO NOT MERGE
Change-Id: Id9ed0f3b68c7aa7f42a42d410985388ec5725930
Auto-generated-cl: translation import
2016-02-15 05:44:31 -08:00
Felipe Leme
40ee6181a5 Merge "Split bugreport identifier into id and pid." into nyc-dev am: e2dd62ea5a
am: dc2b9c0a29

* commit 'dc2b9c0a29ad6390e032a88b8b8a92c3561abd1a':
  Split bugreport identifier into id and pid.
2016-02-12 01:10:48 +00:00
Felipe Leme
dc2b9c0a29 Merge "Split bugreport identifier into id and pid." into nyc-dev
am: e2dd62ea5a

* commit 'e2dd62ea5a69df9ed7d9b7cd1a7c55b3014215c1':
  Split bugreport identifier into id and pid.
2016-02-12 00:45:27 +00:00
Felipe Leme
e2dd62ea5a Merge "Split bugreport identifier into id and pid." into nyc-dev 2016-02-12 00:40:40 +00:00
Geoff Mendal
b817910b14 Import translations. DO NOT MERGE
Change-Id: Iba4fcac2427bf5213b78626aefdbabf17131e652
Auto-generated-cl: translation import
2016-02-10 07:23:03 -08:00
Geoff Mendal
70790ff7cf Import translations. DO NOT MERGE
Change-Id: Ia3fb6e364278dac0cf28e7fd3b966978d5f59c14
Auto-generated-cl: translation import
2016-02-10 05:48:28 -08:00
Felipe Leme
fd8ea077c0 Split bugreport identifier into id and pid.
Although 'pid' is more useful when diagnosing problems with the
bugreport workflow, it could be confusing to the end user. Hence, a
sequential id (started at 1 after a reboot) would be more useful, and this CL changes Shell to accommodate such id (dumpstate will be changed separately).

BUG: 27076108
Change-Id: I5c42dc49a100b43266787d4f79698a22a4e533a9
2016-02-09 10:18:23 -08:00
Felipe Leme
0b3a579f0f Merge "Add pid on main bugreport notifications." into nyc-dev am: 000b84451d
am: 75f37009f4

* commit '75f37009f481d0effcb9b2de12536f10fbb2d9aa':
  Add pid on main bugreport notifications.
2016-02-09 00:43:43 +00:00
Felipe Leme
75f37009f4 Merge "Add pid on main bugreport notifications." into nyc-dev
am: 000b84451d

* commit '000b84451d6a0b83345421ac1eae4ab402d1b8d3':
  Add pid on main bugreport notifications.
2016-02-08 23:56:35 +00:00
Felipe Leme
000b84451d Merge "Add pid on main bugreport notifications." into nyc-dev 2016-02-08 23:25:39 +00:00