15 Commits

Author SHA1 Message Date
Chih-Hung Hsieh
4fd1ddf4d2 Fix google-explicit-constructor warnings.
Bug: 28341362
Change-Id: I1b6e9613b7244581485e6440010b96b8114b03d1
2016-05-06 10:16:13 -07:00
Daichi Hirono
07f48ad0df Do not terminate AppFuse message loop when FUSE_FORGET.
Currently AppFuse tries to terminate its message loop when it receives
FUSE_FORGET. But kernel continues to dispatch messages after FUSE_FORGET
and it should not terminate AppFuse meesage loop.

Change-Id: I070a71c35a8d80bcaaf7603305d219e65be97bc9
Fixes: 28508169
2016-05-02 12:55:35 +09:00
Daichi Hirono
d0ef1394d2 Remove LOG_NDEBUG 0 from AppFuse JNI.
"LOG_NDEBUG 0" enforces to output verbose log even for release build.

Change-Id: I9ab2f5b86065d360222cbabc8d6be2431b06d785
Fix: 28055420
2016-04-08 10:07:01 +09:00
Daichi Hirono
f4e7fa8038 Use AppFuse to write document.
Previously MtpDocumentsProvider used pipes to transfer bytes from an
application to the provider when writing a document.  The problem was
application could not ensure that the last chunk of bytes was
successfully written to MTP device, since pipes had been already closed
when the provider transferred bytes to MTP device. Though the provider
encountered an error, the provider could not report the error to an
application.

The CL switches the method to transfer bytes from pipes to AppFuse. Now
application can flush() bytes on the file descriptor, and flush will not
complete until the provider completes writing bytes to MTP device.

Fixed: 23093747
Change-Id: I4e28f8cbf19d6c97e591943349a7535241d768f7
2016-03-29 16:27:59 +09:00
Daichi Hirono
09ece6c68b Implement FUSE_WRITE command in app fuse.
The CL adds a handler for FUSE_WRITE command which invokes a Java
handler.

BUG=23093747

Change-Id: I1903fca6b5663e6241ad540a89fe812310ba6810
(cherry picked from commit 35693da25af11583053d4af6a70d4acbf446978d)
2016-03-25 11:18:44 +09:00
Daichi Hirono
2f310f6d5d Reuse buffer when reading bytes from files.
Previously AppFuse getObjectBytes returns byte array and the array's
length needs to equals to the exact number of bytes the method read.

The CL change the function signature so that it can return the number of
read bytes. And reuse a buffer array instead of slicing the array with
valid length.

BUG=None

Change-Id: I78b714554cac9ae71b895cb8929bc98969f5a8ca
2016-01-28 14:09:26 +09:00
Daichi Hirono
b36b15586a Fix bugs that prevent from using AppFuse.
* Allow buffer size that is greater than requested read size in JNI,
   because we reuse fixed-size buffer among multiple requests.
 * Fix condition to check if the file size is greater than 4GB or
   not. We need to use 0xffffffffl instead of 0xffffffff because
   0xffffffff is int and its value is -1.

BUG=None
Change-Id: I155916e139353b15dc1ab535234faf50d942996d
2016-01-26 16:30:08 +09:00
Daichi Hirono
af6b66529e Ensure to release local reference in AppFuse JNI.
Previously get_object_bytes() leaked local reference of Java buffer
array.

BUG=None

Change-Id: Ic27e57281f984fee4aa285ad21de522ccb0fe4ed
2016-01-21 11:07:48 +09:00
Daichi Hirono
e6054c0ff0 Fix race in AppFuseTest.
Previously IllegalStateException is thrown in app fuse main loop, if the
loop thread starts just after closing device FD.

BUG=None

Change-Id: Ia5232857d29f9f324446aa38acf3c062f359d406
2016-01-21 10:51:25 +09:00
Daichi Hirono
fab4a97a79 Fix compile error introduced by ag/842950.
BUG=25756419

Change-Id: I8ac270946b3915c02b21a07cf0a9c5b62d69effc
2016-01-15 16:54:24 +09:00
Daichi Hirono
2153e822ee Fix AppFuse JNI.
* Return attributes for all files as well as root.
 * Fix buffer size for reading and add a check for reading size.

BUG=25756419

Change-Id: I572f718bc01d96616ec94f85d800b8b57eedd2ea
2016-01-15 13:45:47 +09:00
Daichi Hirono
cc9a7d78d5 Implement FUSE operations in AppFuse JNI.
The CL adds the following operations.

 * FUSE_LOOKUP
 * FUSE_OPEN
 * FUSE_READ
 * FUSE_RELEASE
 * FUSE_FLUSH

BUG=25756145

Change-Id: Ib57d7d0ade3343a604a1c40e4b2c2a2d089f3715
2015-12-24 11:11:27 +09:00
Daichi Hirono
91e3b50636 Unmount appfuse when the device FD is closed.
The CL lets MountService to observe device FD, and request unmount to
vold when the device FD was closed, or remote application providing
appfuse is crashed.

BUG=25756420

Change-Id: I7990694d32affa7f89e3f40badb25098d74d744d
2015-12-22 13:41:33 +09:00
Daichi Hirono
01cf378e04 Fix compiler error on com_android_mtp_AppFuse.cpp.
The CL adds explicit assigning for reply_size to prevent 'unused'
compiler error.

Change-Id: I307758debb23b5bf56ddf71d54813b8cd81d8f49
2015-12-21 13:13:57 +09:00
Daichi Hirono
bee50c0543 Add AppFuse class and its JNI module.
BUG=25756145

Change-Id: I10597e3377cf860412e006a118cd979b6f108af3
2015-12-21 12:07:13 +09:00