1026 Commits

Author SHA1 Message Date
Steve McKay
27fd7c6727 Followup changes to ag/810782.
Note, one of the requested changes already happened.

Change-Id: I253cbc2b3b7f2091ca80f43c90e951263fc50ad2
2015-12-04 12:13:25 -08:00
Jeff Sharkey
a1fbe28218 Bring along the rest of the change too.
Change-Id: Ic1ca033e7f4003f7c7d10d3a47de00006f18fe02
2015-12-03 20:12:45 -07:00
Jeff Sharkey
28b41a3bd6 Grr, fix build from a skipped merge.
Change-Id: Id5961399c6057b8d721ad2a858aa91d107b0ab94
2015-12-03 20:06:46 -07:00
Steve McKay
362ab0dd68 Merge "Add DownloadsActivity functional test." 2015-12-02 23:06:35 +00:00
Steve McKay
dbdaa49be4 Add DownloadsActivity functional test.
Bug: 25809806
Change-Id: I43ceaf3a99715a57e3d349bee60f2edf7f6666bd
2015-12-02 14:11:47 -08:00
Steve McKay
ad133298f0 Merge "Don't deselect files after copy." 2015-12-02 19:24:58 +00:00
Steve McKay
c2b4b3dcda Don't deselect files after copy.
Bug: 5419032
Change-Id: Ib00e232c81b6400583cb4091882e5874decd0be2
2015-12-02 10:24:30 -08:00
Steve McKay
02794193c9 Show share button in downloads.
Also, rename "ManagerRootActivity" to "DownloadsActivity"
    since because...well, it is almost always Downloads
    and is specialized for this case.

Bug: 25809806
Change-Id: I496d34393d269d2120c8e214413cb87df8bf171d
2015-12-01 16:21:34 -08:00
Steve McKay
84a860f2a8 Merge "Guard against null key events...which can happen." 2015-12-01 23:26:57 +00:00
Steve McKay
7e392b7845 Guard against null key events...which can happen.
Bug: 25772143
Change-Id: I0c2665aea25c65b92e6f6c0b1454f1e07112fc9c
2015-12-01 15:01:04 -08:00
Steve McKay
d3afdeebeb Don't copy a directory into itself...doesn't go well.
Minimally deform CopyService such that we can listen
    to the completion of operations in the test.
Add test coverage.
Add equals and hashcode to DocumentInfo...so we can compare
    the heck out of 'em. + a test.
WIP: Expose (@hide style) DocumentsProvider.isChildDocument via
    DocumentsContract. Use that to check for recusive copies.

Bug: 25794511

Change-Id: I05bb329eb10b43540c6806d634e5b96a753e8178
2015-12-01 14:16:38 -08:00
Steve McKay
6c88085547 Intent-filter for BROWSE action.
Missing from ag/777423
Bug: 25806013

Change-Id: I79ac0946f0d4548efab23e363dfa864ad8b1426a
2015-11-20 08:52:00 -08:00
Tomasz Mikolajewski
a8057a9dce Add first-class support for virtual files in SAF.
Bug: 20820363
Change-Id: Ic509a6003a99997126f129a836fdd8c0e843108f
2015-11-20 16:26:18 +09:00
Steve McKay
acd29b5c99 Merge "Add "Home" directory support." 2015-11-20 00:01:25 +00:00
Steve McKay
c6a4cd8c0f Add "Home" directory support.
Update FilesActivityUiTests to verify Home is present
    and that clicking a root sets the title accordingly.
Guard addition of WRITABLE flag with a volume test.

Bug: 25147243
Change-Id: Ic20372737cae08a82af0aade0c0dbbd8c22d5f34
2015-11-19 15:56:05 -08:00
Ben Kwa
d27906e581 Tweak grid item layout. Adjust colors to match spec.
BUG=10960718
BUG=24326989

Change-Id: I74da23fe0b40d713a3f435d1467d26d707e76fca
2015-11-19 10:50:35 -08:00
Ben Kwa
84cebbeb69 Open the destination dir when a copy notification is tapped.
- Cleanup: rename the "open copy destination" action to "pick copy
  destination", which better reflects what it does.
- Move DocumentsIntent from BaseActivity to Shared.
- Rename ACTION_BROWSE_DOCUMENT_ROOT to ACTION_BROWSE for general browsing.
- Use the new ACTION_BROWSE to open the copy destination when copy
  notifications are tapped.

BUG=23137963

Change-Id: I10480b45a16ce716febac5453cb5015d26bb0062
2015-11-18 11:22:30 -08:00
Steve McKay
c89cc4419e Merge "Add test size annotations to docsui tests." 2015-11-16 19:47:53 +00:00
Steve McKay
53c774b572 Add test size annotations to docsui tests.
Required by APCT.

Bug: 25152838
Change-Id: I18629036a7b290719d8faf326117e25b52f0ae07
2015-11-12 14:09:29 +09:00
Steve McKay
57a93babd7 Handle shift+arrow correctly in single select mode.
Bug: 25603626
Change-Id: I2f71152b303ac218ecec59e8200acf8a716ea0ee
2015-11-11 16:48:26 +09:00
Ben Kwa
d50b45ccbf Merge "Adjust grid item layouts to match mocks." 2015-11-11 05:09:59 +00:00
Ben Kwa
9094585eb4 Adjust grid item layouts to match mocks.
BUG=24326989

Change-Id: I8a4133890036a2ef9173f20828f062a7e991525d
2015-11-10 20:32:17 -08:00
Ben Kwa
bab08460ee Merge "Clean up/fix some minor focus-related code." 2015-11-10 06:09:29 +00:00
Ben Kwa
02f22f370d Merge "Clean up some unnecessary imports." 2015-11-10 05:16:39 +00:00
Steve McKay
f69502ca42 Make folders unselectable in as needed.
In some intent handling modes folders shouldn't be selectable.

Note: There are probably *other* conditions where this should be true too.

Bug: 23936872
Change-Id: I5a1f6853df265d65415cc09e95005720bf5f91d7
2015-11-10 13:45:10 +09:00
Ben Kwa
38e94747e7 Clean up/fix some minor focus-related code.
- Cleanup: Set the focusable flag in xml rather than in java.
- Add a border for the currently focused item in grid mode.

BUG=24326989

Change-Id: Ib17e93c377fb6b16bf8a7eccfb213f521d9596f0
2015-11-05 11:31:21 -08:00
Ben Kwa
aaee6aff52 Clean up some unnecessary imports.
Change-Id: I10560826cbf3b2ae151f9fe7294560bf7e0f1911
2015-11-05 10:09:54 -08:00
Tomasz Mikolajewski
261b6bdd36 Remove TRANSFER_MODE_NONE from CopyManager.
This field is not necessary, as an operation is always either copy or move.

Change-Id: Ide68bb2bf5d237ed4c9abe8c443edd8e12dd82dd
2015-11-05 11:31:32 +09:00
Tomasz Mikolajewski
35534d97c6 Merge "Wire copyDocument and moveDocument to CopyService." 2015-11-05 02:25:23 +00:00
Tomasz Mikolajewski
54c14948ee Wire copyDocument and moveDocument to CopyService.
Bug:24884665
Change-Id: Iaeac9ffa468150853f0f36c439f98df53937e519
2015-11-05 11:24:37 +09:00
Steve McKay
f862155e34 Move DirectoryFragment and family to dirlist pkg.
Stuff was getting out of control in the main package.

Change-Id: Ia06ba96f5bbe13388d51e6ad52a9dac76af97cc0
2015-11-04 15:04:57 -08:00
Geoff Mendal
fdefd0496e Import translations. DO NOT MERGE
Change-Id: I06b7fdd459fbb74d91376bc93ae8d035145d2234
Auto-generated-cl: translation import
2015-11-04 05:23:43 -08:00
Steve McKay
541b168c03 Merge "Show only selection count in ActionBar." 2015-11-03 22:52:09 +00:00
Steve McKay
dc127a0919 Merge "Don't show advanced menu in downloads ui." 2015-11-03 22:50:05 +00:00
Steve McKay
9c62fd8dd6 Don't show advanced menu in downloads ui.
Also, don't show search, and file size....and maybe others.

Bug: 25383741
Change-Id: I4bc867254b89011786fdf087b371974ee80d09da
2015-11-03 14:45:30 -08:00
Steve McKay
639938f3dc Merge "Handle SpacerItem on click correctly." 2015-11-03 22:42:20 +00:00
Steve McKay
35820cfe96 Handle SpacerItem on click correctly.
Bug: 13319202
Change-Id: I22f556f512f55cc09eead462a4eb8cea99dc5e64
2015-11-03 14:01:34 -08:00
Steve McKay
fafb81b74c Merge "Use StubProvider for functional tests." 2015-11-03 21:34:14 +00:00
Steve McKay
0c3c695469 Use StubProvider for functional tests.
Add a "UiBot" class for driving the UI from tests.
Add a "DocumentsProviderHelper" class for convenient test doc setup.
Update FilesActivityUiTest to use "TargetContext" which is
    necessary in order to perform ContentProvider
    operations.
Fix a bug where CopyTest relied on implicit order of roots.
Don't include guava in tests...since it breaks functional tests (incompatible class def).
Add test coverage for:
- basic roots list.
- basic files list.
- Live updates to files list.
- basic delete operations.

Bug: 24988170
Change-Id: I2ec01a5e1a474314cb33efb6e92df0f61dfcc1da
NOTE: This is currently broken at the point I try to init files in the stub roots.
2015-11-03 13:18:00 -08:00
Ben Kwa
68dfdb6525 Merge "Fix focus issues on animated items." 2015-11-03 20:00:40 +00:00
Ben Kwa
e48e4ca564 Fix focus issues on animated items.
Implement a custom ItemAnimator to enable focus to persist across change
animations in the DirectoryFragment's RecyclerView.

Note that this is a temporary stop-gap - a better fix would be to have
the RecyclerView restore focus to the appropriate item after a change
animation.

BUG=24802917

Change-Id: I4e4e6f758a2ea87e6235533860863c822d71a27a
2015-11-03 11:59:24 -08:00
Ben Kwa
c11f46f416 Merge "Update DocumentUI styles to match mocks." 2015-10-30 15:13:15 +00:00
Ben Kwa
a7e9eb04e2 Update DocumentUI styles to match mocks.
BUG=24870921

Change-Id: Ic91c9fbbe8c577c2276a4afc79753ba702c53733
2015-10-29 15:43:23 -07:00
Steve McKay
9f425a8ad0 Merge "Move FragmentTuners to new dirlist dir." 2015-10-29 20:03:20 +00:00
Steve McKay
5aacf1fdbd Show only selection count in ActionBar.
According to mocks.
Also, remove padding on RecyclerView.

Bug: 24542381
Change-Id: I8abfa96020fb457641605dc184079de92f8b265b
2015-10-27 16:54:16 -07:00
Steve McKay
d3f6f14c30 Move FragmentTuners to new dirlist dir.
Create a new "Manage" tuner for Downloads.
Aiming to reduce the single-file complexity of DirectoryFragment.

Change-Id: I22b04f776fbd1fdc02ca54083cb1e144eda60799
2015-10-27 16:01:48 -07:00
Daichi Hirono
decb832094 Merge "Show MTP roots at the bottom of root list." 2015-10-27 22:46:51 +00:00
Daichi Hirono
abf397458d Show MTP roots at the bottom of root list.
MTP is removable device, so we should show it at the buttom of volume
list.

BUG=24813611

Change-Id: I0b78405ec169d576de4c709bbe21b5bb9b856b87
2015-10-27 09:12:04 +09:00
Steve McKay
bbbb644a2e Delete TestDocumentsProvider.
We can use StubProvider.

Change-Id: I8a38acd86e2ce57ff50f05710cb7f7f4c1fec63d
2015-10-26 16:09:06 -07:00
Steve McKay
44063d7559 Merge "Address followup comments from 793838." 2015-10-26 20:51:09 +00:00