12 Commits

Author SHA1 Message Date
Mathew Inwood
1b216d84c0 Merge "Add presubmit hook for hidden API lists." into pi-dev
am: 02033386c2

Change-Id: I6c437a6ffa62794f1fc88d0c8bcdcef798b68d8c
2018-04-24 09:47:36 -07:00
Mathew Inwood
e5dc64d428 Add presubmit hook for hidden API lists.
Check that they're sorted as expected and contain no duplicates.
The sort order now uses:
$ LC_COLLATE=C sort -f

So that non-alphanumeric characters are not ignored, giving a more
intuitive sort order. the '-f' means ignore case.

Also sort the existing lists accordingly.

Test: repo upload
Bug: 64382372
Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218
Change-Id: I4cdd3bc5c11be91a9a3f678580af49ac67f3c968
2018-04-24 15:15:13 +01:00
Jeff Sharkey
6527cd70a2 Merge "Add linter for strings.xml." into pi-dev
am: 642c0be3f3

Change-Id: I9677257b4ddfe5c1347b6de13b98e2b25fd649ac
2018-03-27 01:06:54 +00:00
Jeff Sharkey
abe058c0f0 Add linter for strings.xml.
Strings are tedious to get right, so write a lint script that catches
common errors to warn developers before they're uploaded.

Test: builds, boots
Bug: 76097999
Change-Id: I9826ca796c17cd93a100951d56214653de63a379
2018-03-26 11:04:48 -06:00
Jack Yu
2ea5e20c8b Merge "Enable Checkstyle for "repo upload" for more projects." am: dd6764a522
am: 2ff91e5132

Change-Id: Ie880f61f511ad51011607c531c9028376e5683d1
2018-03-23 02:31:36 +00:00
Jack Yu
8ee42c2b95 Enable Checkstyle for "repo upload" for more projects.
This CL enables Checkstyle for the following directories:
- telephony/

Bug: 34746646, 32954735
Test: Compilation
Change-Id: Ia67eaf5b871e6b74f21344fef1572835801843a5
2018-03-22 16:47:16 -07:00
Siyamed Sinir
56eed89bb6 Add checkstyle check to graphics package
Test: None
Change-Id: I1c8342dda2678917e245e48ab141b2953a522197
2018-02-09 11:34:57 -08:00
Jason Monk
53b2a73c37 Add api lint to upload checks
Currently will never block upload, only considered a warning, but
will print out any lint issues discovered.

Test: do an upload
Bug: 69115822
Change-Id: I69b8e5a3f92ac28ee3c954408e88a1056c33af65
2017-11-13 13:25:05 -05:00
Aurimas Liutikas
e5abb866a5 Enable Checkstyle for "repo upload" for more projects.
This CL enables Checkstyle for the following directories:
- core/java/android/
- core/tests/coretests/src/android/

Bug: 34746646
Test: None
Change-Id: Ib8b3f198000be19e9a7a61aa5abd61d827454eba
2017-04-28 21:39:48 +00:00
Aurimas Liutikas
cb494a3031 Point to the new checkstyle location for frameworks/base PREUPLOAD hook.
This change depends on r.android.com/314437

Bug: 33666900
Test: None
Change-Id: I301723d516803146943f0866ea35b68cc36af6af
2016-12-15 15:01:36 -08:00
Philip P. Moltmann
d7cee3cf5a Check USB and Print Framework code.
Test: Uploaded
Change-Id: Ib103a4fdc1dea0efc3a1a1be8c864541d283343a
2016-10-20 17:27:48 -07:00
Aurimas Liutikas
5c19b5428d Enable Checkstyle preupload hook for certain frameworks/base directories.
Enables Checkstyle preupload hook for the following directories:
- core/java/android/animation/
- core/java/android/text/
- core/java/android/view/
- core/java/android/transition/
- core/java/android/widget/

Test: tested manually uploading a CL that contained many changes
      to directories outside of the listed ones and checkstyle did
      not complain about those.

Change-Id: I795ba478fad7af124c43ca1e18d51b33d7800976
2016-10-12 13:09:24 -07:00