59 Commits

Author SHA1 Message Date
Anton Hansson
a3e79fbb8c frameworks/base: Set LOCAL_SDK_VERSION where possible.
This change sets LOCAL_SDK_VERSION for all packages where
this is possible without breaking the build, and
LOCAL_PRIVATE_PLATFORM_APIS := true otherwise.

Setting one of these two will be made required soon, and this
is a change in preparation for that. Not setting LOCAL_SDK_VERSION
makes the app implicitly depend on the bootclasspath, which is
often not required. This change effectively makes depending on
private apis opt-in rather than opt-out.

Test: make relevant packages
Bug: 73535841
Change-Id: Ibcffec873a693d1c792ca210fb597d2bf37e9068
Merged-In: I4233b9091d9066c4fa69f3d24aaf367ea500f760
2018-02-28 17:15:21 +00:00
Alan Viverette
51efddbd3b Remove unnecessary casts on calls to findViewById
Just frameworks/ this time. More paths to come.

Bug: 24137209
Test: make -j32
Change-Id: Iff27abd26fa43296ac2fff8f534fc6742d2ae80c
2017-04-14 11:15:50 -04:00
Tor Norbye
a7726271f7 Replace wildcard imports with explicit imports
The wildcard imports interfered with the new typedef annotations (and
99% of the tests were using explicit imports anyway.)

Change-Id: I3784b9d700131fe4a0ba30283f052820b2fa5122
2013-09-13 14:22:36 -07:00
Fabrice Di Meglio
665f02c667 Fix bug #8437358 Clean any ICU related code from TextLayout / Paint and their dependencies
- remove the ICU related methods and update the methods using the "reserved" argument
- update to CTS in another CL too

Change-Id: I5509736568c342d9d17bfeafc17951117ab5d3cc
2013-03-20 14:56:05 -07:00
Fabrice Di Meglio
da12f389eb Revert "Clean Paint.mBidiFlags as it is no longer used"
This reverts commit 6d9fe5bd22b531bfce69b146254a4791c76acddc.
2013-03-15 11:26:56 -07:00
Fabrice Di Meglio
6d9fe5bd22 Clean Paint.mBidiFlags as it is no longer used
See bug #7623824

Change-Id: Ie2f9422821f6dcc73c99e8695f448e966b587b1d
2013-02-12 13:12:13 -08:00
Fabrice Di Meglio
9da0f8a5c4 Add View textAlignment
- fix bug #6163772
- use bits field and pack them as much as possible
- take care of "supportsRtl" flag from Manifest
- add visual unit tests

CTS unit tests in another CL

Change-Id: Ib77c4eb423854209af130688c5ef9977401a9c1c
2012-04-04 12:20:45 -07:00
Fabrice Di Meglio
59dfce8bda Fix bug #6140391 Make RTL awareness as an opt-in into the AndroidManifest
- introduce "supportsRtl" as a new application attribute in the AndroidManifest
- "supportsRtl" default value is FALSE (no RTL support)
- adapt the View layoutDirection and textDirection logic to take care of "supportsRtl" value

Change-Id: I5e4f9f576e14f35dedc6b0c29a7142c397f598e0
2012-04-03 11:43:20 -07:00
Fabrice Di Meglio
3fd29d908a Unhide BiDiTests app
- unhide its makefile so that now it is part of the standard build process

Change-Id: Ied86c252975e30da8e3e75180869835f00a5969d
2012-03-01 18:15:25 -08:00
Fabrice Di Meglio
0d2bda319d Update BiDiTest app for GridLayout RTL tests
- add unit tests for GridLayout in RTL mode

Change-Id: Icc983a6e2cc75b30e457fd822d81ef5630de0f10
2012-02-13 14:44:22 -08:00
Fabrice Di Meglio
2a7e7a08d9 Update BiDiTests app
- add more unit tests for GridLayout (layout created by code)

Change-Id: I462c41a7c5bdcb6c5d3762570f5d415cc0fa0bde
2012-02-09 17:32:24 -08:00
Fabrice Di Meglio
bf2ab0b80c Update BiDiTest app for adding GridLayout unit tests
- added basic GridLayout unit tests for LTR / RTL / Locale cases

Change-Id: Ied9814b2f56acb5d3666e78ad600f487ce4dc911
2012-02-06 17:20:25 -08:00
Fabrice Di Meglio
2b9ac31db4 Update BiDiTest app
- update basic layout for being scrollable
- add more test strings

Change-Id: Iec1b495619cdd76639f127fb1ac4e4f41d0726d8
2012-02-02 13:16:51 -08:00
Fabrice Di Meglio
03e250aefa Fix bug #5870701 Thai text can be clipped when there are more glyphs generated than the initial number of code points
- compute total advances correctly by iterating on the advances array for up to mShaperItem.num_glyphs
- update unit tests

Change-Id: I00af68bef88702215e9222ed80dbffcc81df51a7
2012-01-13 19:49:46 -08:00
Fabrice Di Meglio
7810b5f8cf Fix bug #5199577 TextView with android:password="true" is showing the "dots" on the left even if the password chars are RTL
- force TextView to LOCALE text heuristic when in "password" mode
- remove TEXT_LAYOUT_DIRECTION_UNKNOWN_DO_NOT_USE
- LocaleUtils.getLayoutDirectionFromLocale() returns "LTR" is locale is NULL or ROOT

Change-Id: I182c46aaf2d73c8b18967fffa230bfabec91ed06
2011-08-25 18:43:37 -07:00
Fabrice Di Meglio
af3e6d64d1 Update BiDiTest app
- add a default TextView

Change-Id: I0ce92503204e370d9c928440cdd4876701c6c4cb
2011-08-18 13:12:43 -07:00
Fabrice Di Meglio
f2ce877c1d Fix bug #4584320 Single Line EditText not drawing correctly with spans applied (ICS)
- use correct 0 index for computing advance thru the char buffer (the buffer is created from TextUtils.getChars())
- udpate unit tests

Change-Id: Iaeb07658b79ecdf5e17395d55afb7c84965bb0fc
2011-08-05 20:54:54 -07:00
Fabrice Di Meglio
fd0b623c33 Update BiDi unit tests
- update basic layout for having LTR and RTL TextView

Change-Id: Ic4cc6c27d431fe69bb62c55cd76a46ea6e241b4d
2011-08-05 15:04:12 -07:00
Fabrice Di Meglio
1180644280 Fix bug #4772392 Check what needs to be done for RTL specific new attributes that are in public.xml
- cleanup public.xml
- make BiDiTest makefile non visible to the build system
- provide file for injecting the new attributes by hand

Change-Id: I5037ec323066ebd254be51fff7070a5a0101dff7
2011-07-20 11:38:59 -07:00
Fabrice Di Meglio
5f9fa88268 Merge "Test Gallery layout direction." 2011-07-19 10:16:04 -07:00
Fabrice Di Meglio
c2063a5b18 Fix bug #5037425 Canvas.drawText can't handle Right-to-Left text and text composing
- optimization for single run case was broken
- pass isRTL boolean along the call stack instead of the dirFlags integer
  (which was only used as a "isRTL" in the shaper)
- update unit tests

Change-Id: I33110b76a433633a0b92fbd1db03785204e0c3e6
2011-07-18 17:47:04 -07:00
Doug Felt
3d0124f176 Test Gallery layout direction.
Change-Id: If88f559e8cc46bb72ed45f33d7fc52802f1e1246
2011-07-18 17:39:07 -07:00
Fabrice Di Meglio
c6f247ca31 Add unit tests for bug #5037425 Canvas.drawText can't handle Right-to-Left text and text composing
Change-Id: Ic71a563ad0f4ba6de5b7f030f04a3a9615b7617c
2011-07-18 15:59:10 -07:00
Fabrice Di Meglio
46c7250798 Merge "Clean test APIs for Harfbuzz support" 2011-07-18 14:26:34 -07:00
Fabrice Di Meglio
9c83011005 Merge "Fix bug #4972141 Overlapping content in single-choice dialogs" 2011-07-15 17:51:46 -07:00
Fabrice Di Meglio
796cc96243 Clean test APIs for Harfbuzz support
- also update unit tests

Change-Id: I557f61e84c4c4b6165163b783d9c679a6b3b4106
2011-07-15 17:49:22 -07:00
Fabrice Di Meglio
54d6962555 Fix bug #4972141 Overlapping content in single-choice dialogs
- need to take care about padding resolution

Change-Id: Ida9738ffada6c6455b7949f933fa61924c4f7961
2011-07-15 17:05:11 -07:00
Fabrice Di Meglio
9703ac8e6f Merge "Some code refactoring" 2011-07-15 16:52:03 -07:00
Fabrice Di Meglio
50e95eba5c Merge "Implement textDirection heuristic selection." 2011-07-15 09:49:48 -07:00
Fabrice Di Meglio
d2b5d1cf4a Some code refactoring
- make Layout.Alignment.ALIGN_LEFT as the default case
- update unit tests for reproducing bug #5002512

Change-Id: Id7ec17abd115bcda7f3434e6d64dbbba6915f108
2011-07-14 15:24:35 -07:00
Doug Felt
cb37912045 Implement textDirection heuristic selection.
Change-Id: I2fcf18de573f2d66494fa5ed61e4273c3c6078c7
2011-07-14 11:24:33 -07:00
Fabrice Di Meglio
a3b6b95f99 Introduce TextView drawableStart and drawableEnd
- update also unit tests

Change-Id: I20b82f5fea2cc48c93fd9e26eb03290ad730c08a
2011-07-12 14:04:24 -07:00
Fabrice Di Meglio
222688682e Add textDirection support for TextView and ViewGroup
- use ViewGroup inheritance if defined
- use different heuristics (inherit, firstStrong, anyRtl, ltr, rtl)
- add more unit tests

Change-Id: Ic1325aa7d9e4689b181e0a2d08b7dd7fb3f0dbeb
2011-06-28 20:29:08 -07:00
Fabrice Di Meglio
b76023afd1 Introduce MarginLayoutParams marginStart and margingEnd
- update BiDiTest app for adding more unit tests concerning margin

Change-Id: Ia6a7e0a1948a2c375e8f3cc87d120a85351a8c27
2011-06-24 18:55:24 -07:00
Doug Felt
468d8afad2 add TextView page to BiDiTests
Change-Id: If6ba2d7f96283041d254d6d53bb268d88fed2c74
2011-06-23 10:01:02 -07:00
Fabrice Di Meglio
53a73bcddf Update BiDiTest app for adding more unit tests
- add some menu that will show up in compatibility mode
- add more unit tests for padding and background drawable

Change-Id: I90db23c68d2371c35913b039a10f9d9f34c3931e
2011-06-20 17:38:41 -07:00
Fabrice Di Meglio
d8703a9824 Add View paddingStart and paddingEnd
- use a lazy padding resolution (because layout direction is lazyly resolved too)
- cache resolved layout direction as getResolvedLayoutDirection() will be more called
- enable resetting layout direction cache if needed
- update unit tests

Change-Id: I30ce19e3100cc137f84e60163b60e1577ff61819
2011-06-20 11:11:05 -07:00
Fabrice Di Meglio
b07124082e Update BiDiTest app for testing View padding
Change-Id: I7b956bd1d16cc4d27f33595f09f14f5d4e17e469
2011-06-16 16:19:59 -07:00
Fabrice Di Meglio
67f8de04fc Fix Gravity start/end
- fix missing attribute value change
- update BiDiTest app

Change-Id: I0bb8a1ebf0b6097b7b8d488580fea6e882202e23
2011-06-14 17:08:32 -07:00
Fabrice Di Meglio
c0053223be Add View.getResolvedLayoutDirection()
- update Callback2 interface
- update Gravity.getAbsoluteGravity() and Gravity.apply() to be more generic
 by changing "boolean isRtl" parameter to "int layoutDirection"
- fix BiDiTests for RTL FrameLayout

Change-Id: I97bb456c22d5fd3ecb34f08564ce4dbed37e7459
2011-06-14 16:16:39 -07:00
Fabrice Di Meglio
7af05226b9 Refactor BiDiTest unit tests app
- make it more extensible (suppress tabs in favor of a list selection and fragments)

Change-Id: If6f6c3a33f7c03e00205edbeab2945024b477f0d
2011-06-10 18:20:47 -07:00
Fabrice Di Meglio
26e432d25f Make View respect LAYOUT_DIRECTION_LOCALE
- update also unit tests for taking care of the locale direction
- code formatting on the layout test files

Change-Id: I4037eac3c572de9abb0178f36ca03803cc2c1522
2011-06-10 14:30:32 -07:00
Fabrice Di Meglio
c46f7ffa90 Rename atribute View horizontalDirection to layoutDirection and update unit tests
- update before/after to start/end in unit test app

Change-Id: Id7286ef5d9390540faf8ecd5f0b1c140d04bb364
2011-06-07 14:21:31 -07:00
Fabrice Di Meglio
de7fc15ff4 Update BiDiTest app for Gravity renaming
- BEFORE?AFTER is now START/END

Change-Id: I44cfdc17090052704024d8c5386553f0c83e9ab2
2011-06-06 17:58:17 -07:00
Fabrice Di Meglio
2f9cad27fd Update BiDiTest app
- change buttons text to follow their Gravity

Change-Id: Ie0d79ced9c14bf8b0f12d1c31da5e2fe6f162c88
2011-06-02 16:35:21 -07:00
Fabrice Di Meglio
88f9fd2316 Add more unit tests for RTL layouts
- update LinearLayout tests with default case (no horizontalDirection specified)
- add TableLayout tests

Change-Id: I9ad2239fca96b896c5aae4dfe67b8113faf2f96e
2011-06-02 10:55:58 -07:00
Fabrice Di Meglio
c715528c96 Add more unit tests cases for BiDi / RTL
- update FrameLayout tests
- add more RelativeLayout tests

Change-Id: I2ae522c5e6ec216f7ade45935f8309b543f380b9
2011-06-02 09:29:03 -07:00
Fabrice Di Meglio
c2e989021e Add more unit tests for RelativeLayout
- update BiDiTest test app

Change-Id: I8c0734fc8a94765d269b0040ebfa048c13e11728
2011-06-01 19:11:15 -07:00
Fabrice Di Meglio
77c1cc0aa4 Merge "Fix bug #4509967 (layout_gravity not always respected)" 2011-06-01 17:40:11 -07:00
Fabrice Di Meglio
de35ceeeb9 Fix bug #4509967 (layout_gravity not always respected)
- fix FrameLayout
- code refactoring on LinearLayout
- add more unit tests

Change-Id: I49302582c61aa31a4eb7eded92327b10408f71a4
2011-06-01 16:46:25 -07:00