4399 Commits

Author SHA1 Message Date
Gao Shuo
7e05ff35fa Avoid fake high input latency while vsync drifting
Usually isTrippleBuffered should be true when mSwapDeadline bigger
than IntendedVsync. However, vsync could be drifting on some platforms,
which make isTrippleBuffered to be true and report a fake high input
latency.

So add a small threshold to avoid this case.

Test: Manually
Change-Id: Ib6ff1046cfb94f89f4985361b84ad2d34850f783
Signed-off-by: Gao Shuo <shuo.gao@intel.com>
Signed-off-by: Wu Zhongmin <zhongmin.wu@intel.com>
Signed-off-by: Zhu Tingting <tingting.zhu@intel.com>
2019-05-27 14:14:57 +08:00
Haibo Huang
bbd62aff7a Merge "Update to follow the new google benchmark API"
am: d22ba181d0

Change-Id: Ie5065ff193bfe187683e729d589138c24f4f2fac
2019-05-08 14:48:57 -07:00
Haibo Huang
5eb2e96898 Update to follow the new google benchmark API
Test: build
Change-Id: Icc25b81e9b863c35c02c9673518fa4d30e9ae321
2019-05-08 18:29:01 +00:00
Xin Li
b455c3a7f3 DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-master
Bug: 120848293
Change-Id: I2f9a524f2ba552de3f62e343075cf0abf400bbae
2019-02-21 16:02:06 -08:00
Xin Li
07ec9dbec5 Merge "DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into stage-aosp-master" into stage-aosp-master 2019-02-14 22:11:32 +00:00
Xin Li
0e71b4f19b DO NOT MERGE - Merge pi-platform-release (PPRL.190205.001) into
stage-aosp-master

Bug: 124234733
Change-Id: Ic4f67fde0835da0b1c363906cccef0d244e38393
2019-02-14 09:48:06 -08:00
Pirama Arumuga Nainar
459afe96d1 Mark FrameMetricsObserver::notify() as pure virtual
Bug: http://b/116873221

If not, Clang assumes that the TU which defines this function will
contain the vtable for the class as well.  Since there's no out-of-line
definition of this funciton, no TU ends up with the vtable.

This causes a problem with coverage builds, which are built with -O0,
where calls don't get inlined, thereby requiring a definition of the
vtable.  For non -O0 builds, the vtable is not required since the
virtual calls get inlined/optimized-out.

Test: Build with and without -O0.
Change-Id: I60a5cefcd1c327f1e00785fedbb2163c682b33d1
2019-02-07 13:24:24 -08:00
Chih-Hung Hsieh
739cf0d659 Merge "Fix/suppress hwui google-explicit-constructor warnings" am: dcfef16295
am: 50991469e3

Change-Id: Ic97c02ca4f0f903e3e9c861b4dd605ce0b7c1905
2019-01-09 15:09:06 -08:00
Chih-Hung Hsieh
f21b0b6d36 Fix/suppress hwui google-explicit-constructor warnings
* Add explicit to conversion constructors/operators
* Use NOLINT or NOLINTNEXTLINE to suppress warnings on intended converters

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: I8c6ebb99679b0a71251024d70a13f8164e67db5e
2019-01-09 19:50:30 +00:00
liulvping
be2b5dab88 Merge "fix mmap leak of graphicsstats service" am: 9ebc299b73
am: a2b2a415f0

Change-Id: I9da0210799cee14bb36afd186d26fbb1718ffc19
2019-01-07 21:36:12 -08:00
Treehugger Robot
9ebc299b73 Merge "fix mmap leak of graphicsstats service" 2019-01-08 05:03:47 +00:00
Chih-hung Hsieh
c545d54389 Merge "Fix/suppress hwui/tests google-explicit-constructor warnings" am: 6832595911
am: 0e0edd08ac

Change-Id: I8199a26c717fe80b3a733d796b85f28d3acc25a9
2019-01-07 17:29:54 -08:00
Chih-Hung Hsieh
1c57378eed Fix/suppress hwui/tests google-explicit-constructor warnings
* Add explicit to conversion constructors/operators

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: I59c61af29ab09209c5a4c2bf43b10215bf59756a
2019-01-04 17:42:27 +00:00
liulvping
4832438c3a fix mmap leak of graphicsstats service
Test: repeat dumpsys graphicsstats and check process maps

Change-Id: Iae2baa7eb7761aefb867644edfaaf8dbe2132c7b
Signed-off-by: liulvping <liulvping@xiaomi.com>
2019-01-02 10:54:57 +00:00
Chih-hung Hsieh
b6ecc7ca92 Merge "Fix/suppress pipeline google-explicit-constructor warnings" am: 63790135f4
am: 2cd94bae8d

Change-Id: I4163be5e021a4d14ba51985984b924e74ac324c2
2018-12-21 09:04:07 -08:00
Chih-hung Hsieh
63790135f4 Merge "Fix/suppress pipeline google-explicit-constructor warnings" 2018-12-21 16:29:55 +00:00
Chih-Hung Hsieh
4e628bc772 Merge "Fix/suppress renderthread google-explicit-constructor warnings" am: 138aae8eaf
am: 2e2028aee4

Change-Id: I27d1a114816f6ce94751816f7d17720e0a6d8091
2018-12-20 22:09:53 -08:00
Chih-Hung Hsieh
f9336412b3 Fix/suppress pipeline google-explicit-constructor warnings
* Add explicit to conversion constructors/operators

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: Iadeb6cf7ba65d646ec131e567b3ef90c3a699885
2018-12-20 15:36:19 -08:00
Chih-Hung Hsieh
d736d4b845 Fix/suppress renderthread google-explicit-constructor warnings
* Add explicit to conversion constructors/operators
* Use NOLINT or NOLINTNEXTLINE to suppress warnings on intended converters

Bug: 28341362
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor
Change-Id: Ib7d634bf1e0e9a1dda35b0a1d92de4d460193296
2018-12-20 15:10:23 -08:00
Chih-Hung Hsieh
2296036a40 Merge "Fix performance-for-range-copy warnings" am: bc29242288
am: 7adb73f332

Change-Id: I0ab1a28f5490f96bc8b08f073d364a01ff2f20df
2018-12-17 14:17:57 -08:00
Chih-Hung Hsieh
a1b644e88c Fix performance-for-range-copy warnings
Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: Ie481e88025a7a1f3abde8ff63420d5ccd8577e52
2018-12-17 20:00:55 +00:00
Xin Li
15b123ef45 DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into master
Bug: 120502534
Change-Id: Idc8bfb6d97a869b76cfb87ca1a494201baf9e8bd
2018-12-11 14:13:44 -08:00
Elliott Hughes
8dd21cd6b5 Merge "C++17 is the default now." am: fbb102ea84
am: ccb3d1d61a

Change-Id: I9d422db18f2c87c5f44e8f6e3598d6e597b32c21
2018-12-03 17:46:41 -08:00
Elliott Hughes
60a42ccac5 C++17 is the default now.
Test: builds
Change-Id: I64495775afe4ded7d3312cc35a154fecba64adc3
2018-12-03 09:38:35 -08:00
John Reck
0ff158799a Merge "Remove USE_HWC2 usage" am: 8757179e52
am: 70a2813e86

Change-Id: Ida5cf0bb3a644e29c9216fabb89670bf4ec58220
2018-11-28 17:15:58 -08:00
John Reck
c77543022d Remove USE_HWC2 usage
It's always true now

Test: didn't
Change-Id: Ibefde5feaeaec8fb68cbc6ea1c019bf8b5e608bb
2018-11-28 13:07:24 -08:00
Peter Collingbourne
96a4e5a412 Merge "Fix a use-after-free found by HWAsan." am: 82cf8de1f3
am: 2557458766

Change-Id: I074b3c035442466b03476dca68987981d570440b
2018-11-20 10:56:17 -08:00
Peter Collingbourne
13a734dc96 Fix a use-after-free found by HWAsan.
The variable sizeResult is an iterator pointing into mCurrentValues,
and clearing mCurrentValues invalidates the iterator.

Bug: 119773465
Change-Id: I940ea397af87561d33f74a9d52abc3afd0a7538f
2018-11-19 20:15:26 +00:00
Stan Iliev
575e267a23 Merge "Disable blending for opaque TextureView" into pi-dev
am: 5a3b666ab0

Change-Id: Ifc11ee820172117e3740e82829e37ff38ad8ca29
2018-11-07 13:54:42 -08:00
TreeHugger Robot
5a3b666ab0 Merge "Disable blending for opaque TextureView" into pi-dev 2018-11-07 21:35:14 +00:00
Colin Cross
e217b6222c Merge changes from topic "revert-protobuf3.5.2" am: a4680e1ebe
am: 3e312d20cd

Change-Id: I096f3b5a5a985ce7926ccb71fa07eda69d078ed3
2018-11-06 11:21:11 -08:00
Colin Cross
c836696a92 Merge changes from topic "protobuf3.5.2" am: 1d899f6be8
am: 11a4d77516

Change-Id: I6ad3772bc16f236c2c5e7ba381593b10292aabde
2018-11-04 18:13:52 -08:00
Colin Cross
054b0c0e06 Revert "Adapt to google::protobuf::uint64 type change"
This reverts commit fa6bc27df0820a362e0ceae7f9ea73e8a058fe47.

Change-Id: I9f778e6daa9ae0c6080016ab0bd1e6e414ae6061
2018-11-04 17:24:27 -08:00
Colin Cross
1d899f6be8 Merge changes from topic "protobuf3.5.2"
* changes:
  Adapt to google::protobuf::uint64 type change
  Convert statsd_test and statsd_benchmark to proto lite
2018-11-05 01:13:15 +00:00
Elliott Hughes
0782a629aa Merge "Track google-benchmark API changes." am: 9a8757ded5
am: b55d843217

Change-Id: Ia1f1454a91cd22aa1263cbdcc00adf90b511f935
2018-11-02 22:40:46 -07:00
Colin Cross
fa6bc27df0 Adapt to google::protobuf::uint64 type change
Protobuf 3.5.2 redefines google::protobuf::uint64 from unsigned long
long to uint64_t, which is sometimes unsigned long and sometimes
unsigned long long.  Use PRIu64 to print it, and add an implementation
of ProtoOutputStream::write for long.

Bug: 117607748
Test: m checkbuild
Change-Id: I48912f58e2f63f4a98c3aefaa4f78cc2c719bb68
2018-11-02 11:35:48 -07:00
Stan Iliev
f071820f78 Merge "Use bilerp sampling when drawing TextureView with non-translate matrix" into pi-dev
am: 9dff553798

Change-Id: I3dbea21c751d914d8704ba564c9567029216450c
2018-10-30 11:56:21 -07:00
Elliott Hughes
a06d5174df Track google-benchmark API changes.
Bug: N/A
Test: builds
Change-Id: I126734361d367529a8175aff6cc10fc426b39e1a
2018-10-30 10:12:57 -07:00
Stan Iliev
402fff1259 Use bilerp sampling when drawing TextureView with non-translate matrix
Draw TextureView with bilerp sampling, when the matrix is not
integer translate or identity. For example scaling matrix or
translation on X by 0.4f will draw with GL_LINEAR on OpenGL pipeline.
Translation on X by 3.0f will draw TextureView with GL_NEAREST.

Bug: 117890671
Test: Passed CtsViewTestCases and CtsUiRenderingTestCases
Change-Id: I72033410c8b0ab637c2e6b816ac9b04434286fbb
Merged-In: I3acd710ff2cb4ee7b14dd4b7d9227842187130c9
2018-10-25 16:28:27 -04:00
Chih-Hung Hsieh
bd0093e182 Merge "Fix implicit-fallthrough warnings." am: 8f520e6f83
am: a6c90c99cd

Change-Id: I5efd04bf9dae335e03181b6443a3a85e69c1c042
2018-10-24 14:19:26 -07:00
Treehugger Robot
46049f5fec Merge "Fix implicit-fallthrough warnings. DO NOT MERGE." 2018-10-20 01:08:55 +00:00
Tim Murray
7d4945ca86 hwui: purge malloc pages on bitmap destruction
Immediately purge malloc pages on bitmap destruction. Bitmaps are often
big and can cause memory to stay high for much longer than it should.

Test: boots and works
bug 117795621

Merged-in: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
Change-Id: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
(cherry picked from commit 535fae32e597445a480896ea8e01662ada444c0c)
2018-10-20 00:17:47 +00:00
Treehugger Robot
8f520e6f83 Merge "Fix implicit-fallthrough warnings." 2018-10-20 00:15:20 +00:00
Chih-Hung Hsieh
df891f8a31 Fix implicit-fallthrough warnings. DO NOT MERGE.
These changes are not needed in goog/master.

Test: make checkbuild
Bug: 112564944
Change-Id: I75972e680c9502e1b83845f08e79b99a8084cc4c
2018-10-19 15:32:26 -07:00
Chih-Hung Hsieh
672a4fd863 Fix implicit-fallthrough warnings.
Test: make checkbuild
Bug: 112564944
Change-Id: Iaebada5e1a5d94ed06d9b584b888a4f78c0b8505
2018-10-19 14:19:29 -07:00
Tim Murray
64fee6148b hwui: purge malloc pages on bitmap destruction
Immediately purge malloc pages on bitmap destruction. Bitmaps are often
big and can cause memory to stay high for much longer than it should.

Test: boots and works
bug 117795621

Merged-in: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
Change-Id: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
2018-10-18 23:30:35 +00:00
Tim Murray
535fae32e5 hwui: purge malloc pages on bitmap destruction
Immediately purge malloc pages on bitmap destruction. Bitmaps are often
big and can cause memory to stay high for much longer than it should.

Test: boots and works
bug 117795621

Merged-in: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
Change-Id: If2e8c5f1fc07039cf3dc3edcd3dc06861dbce1a1
2018-10-18 23:26:10 +00:00
Stan Iliev
9b7887736a Disable blending for opaque TextureView
Opaque TextureView set by TextureView.setOpaque(true), should
draw with SRC blending, which in practice disables GL
blending.

Test: Ran Naver app, which is using opaque TextureView
Bug: 113845024
Change-Id: I5daa455a72b0ded50d6f9578f3b8a8701532f9d4
Merged-In: I5daa455a72b0ded50d6f9578f3b8a8701532f9d4
(cherry picked from commit 8fc3d8e09d7788a96559d31dc502e99fce4f1378)
2018-10-02 15:33:43 -04:00
John Reck
21013eebd7 Merge "Don't run comparisons on non-jank frames" am: 903dad812e
am: 4007dd103f

Change-Id: I175e245bd2ced35505a2295f4037c6d9c932f056
2018-09-19 18:34:59 -07:00
John Reck
4007dd103f Merge "Don't run comparisons on non-jank frames"
am: 903dad812e

Change-Id: I7cbca9acb9f14149868f18af8970d5324d51e260
2018-09-19 18:21:47 -07:00