2165 Commits

Author SHA1 Message Date
Steve McKay
2499e8deb2 Move GestureListener to own file.
And:
- make MotionInputEvent AutoCloseable (and update obtainers accordingly).
- remove unused constructor args and overloading from MultiSelectManager.

Change-Id: I335a95c3d05ab10bdcbfebab8dc69f0b2f681e3a
2016-07-01 02:19:42 +00:00
Steve McKay
73e2a7d2c4 Merge \"Merge \\"Allow quick view package to be set via setprop.\\" into nyc-mr1-dev am: 24cea93b4a\" into nyc-mr1-dev-plus-aosp
am: 35c77908f0

Change-Id: Ib4b46c435e38caf362f91c9674766621146ac770
2016-06-30 23:51:16 +00:00
Steve McKay
265173d85c Merge \"Allow quick view package to be set via setprop.\" into nyc-mr1-dev
am: 24cea93b4a

Change-Id: I6b95a25e1b038d8b3ffcbce1019688be3a3980db
2016-06-30 23:44:23 +00:00
TreeHugger Robot
24cea93b4a Merge "Allow quick view package to be set via setprop." into nyc-mr1-dev 2016-06-30 23:22:33 +00:00
TreeHugger Robot
4682205151 Merge "[multi-part] Eliminate 1k selection limit" 2016-06-30 06:08:48 +00:00
Steve McKay
38212a4974 Fix Angler search tests.
Use a matcher compatible with all devices.
Move constant matchers into respective Bot files.
Suppress testCreateDir test which is failing *ALOT*.

Change-Id: I67d41d54bc36648ed4d7384a046ee4c9c20d753b
2016-06-30 04:23:11 +00:00
Garfield, Tan
05df8ec38d [multi-part] Eliminate 1k selection limit
* Rename class ClipDetails.
* Add FileOperation class and merge it with JobFactory.

Bug: 28194201
Change-Id: I46639b21c9e424644289a1bf34b85234a9becd2b
(cherry picked from commit 7f17819f1320d12f1f35a8f5327e0c7e63dfed54)
2016-06-30 01:33:14 +00:00
Steve McKay
c4011fceaa Allow quick view package to be set via setprop.
This allows testers to turn it on via adb.

Bug: 29875957
Change-Id: If4563a1799a7c1a1adead9ecfdb4c6ef0c07f82b
2016-06-29 14:00:54 -07:00
Bill Yi
04f363ae01 Import translations. DO NOT MERGE
Change-Id: Ic3e7f43083a8b512a01c252a8bbcd0cb004a9611
Auto-generated-cl: translation import
2016-06-29 11:51:46 -07:00
Steve McKay
63e37fb506 Load layout specific breadcrumb view.
Because two diffrn't view types can't share an resource id....
else we get ClassCastExceptions bubbling out of Spinner when
tryihng to restore from RecyclerView state.

Also:
Move Bots to own file and make BaseBot inner to that.
Extract searchbot from UiBot.
Fix broken search icon logic in phone layout.
Separate somewhat complicated breadcrumb bot functioanlity in a separate bot.
Simplify Search test.
Check for drawer vs. fixed layout instead of "tablet" mode...which didn't
    work when rotating tablets.
Update a dialog entry to use Espresso.
Update breadcrumb stuff to use Espresso.
Move *default state* checking to a different test so we can
    enjoy the default location support from ActivityTest.

Change-Id: I0a60ba93a1cbbb990ec3b36d4f9fd5dc8b86ff00
2016-06-29 00:39:45 +00:00
TreeHugger Robot
8262b4601b Merge "Enable drag & drop -> Springload for breadcrumb." 2016-06-27 18:13:10 +00:00
Ben Lin
ce92c5b8f7 Enable drag & drop -> Springload for breadcrumb.
Bug: 29519481
Change-Id: I54d98c48c08153c22b2f01c7728187927c4fe1a2
(cherry picked from commit 81d903bc083807c6048ac9ce1d1d3ca18b6643a3)
2016-06-27 16:41:16 +00:00
Bill Yi
5ff6b66b7b Import translations. DO NOT MERGE
Change-Id: I2e16ea6b671a016c06c99d44a68816fc3f8c47e6
Auto-generated-cl: translation import
2016-06-27 00:45:42 -07:00
Garfield, Tan
f46958bebd [multi-part] Eliminate 1k selection limit
* Remove clearing clip files at app launch.
* Remove clip files when they won't be used.
* Stop adding clip items to jumbo clip data.
* Repurpose ClipDetails to hold operation type, srcParent and file list.
* Use ClipDetails for copyTo/moveTo/delete menu actions.
* Make FileOperationService consume ClipDetails.
* Add set up state to jobs; show set up notification in set up phase.
* Make copy job cancelable at set up phase.

Bug: 28194201
Change-Id: I2018ff9bc51515c1f6a029f0ede3f4c7d2beee43
(cherry picked from commit 664881e4b1fdc3416648f000287f52168978364f)
2016-06-24 23:56:55 +00:00
TreeHugger Robot
b0c7111a58 Merge "Fix broken Ryu default dir test." 2016-06-23 23:23:32 +00:00
Steve McKay
3ee1ee926d Fix broken Ryu default dir test.
Also, move Matchers to their own file for moar sharing.

Change-Id: Ia621d0efb633159de4c5c700076e2e778583f8bf
2016-06-23 21:44:59 +00:00
Steve McKay
10419c2882 Move event handling code out of DirectoryFragment
Bug:29575607
Change-Id: Ieae3bcee030973bf83551a74f722236a24832730
2016-06-23 20:29:24 +00:00
Ben Lin
693ba32b71 Fix context menu for empty directory/root view.
Since it's not always true that there is a doc/directory given the (x,
y) of the right click, I've changed the signature of right click to take
in a MotionEvent object as a parameter, and make a MotionInputEvent
inside the function as a check whether it's on a file/doc or on
empty/blank pane.

Bug: 29538570
Change-Id: I7ee960c9f556752bf314ab8cc2d94fda28194c0a
(cherry picked from commit 332192dee8cb99bd2e6ef638e78d5b62ab7ecfe6)
2016-06-21 23:44:14 +00:00
Bill Yi
74af5c4488 Import translations. DO NOT MERGE
Change-Id: Ie8d68a06c4943b5e3eb2b80c5ba806ac85e0b5e5
Auto-generated-cl: translation import
2016-06-20 22:37:46 -07:00
Ben Lin
8eafd50a03 Moving Menu-related logic from BaseActivity to MenuManager.
Bug: 29423149
Change-Id: I228e1525cb82d310b16ef0aec8acb4534b7b601d
(cherry picked from commit d896dc7b487771f7d5329feb01ac7c3355fce9ed)
2016-06-20 21:48:17 +00:00
Steve McKay
fc8a346e5a Merge \\\"Make advanced storage option sticky...\\\" into nyc-dev am: 361ccf5eef am: 92e64a65ee
am: 75ea877bc9

Change-Id: I6204de46dd54b2c2a89c9a44edd571179ae1ddab
2016-06-20 21:00:54 +00:00
Steve McKay
06b338fbf0 Merge \"Make advanced storage option sticky...\" into nyc-dev
am: 361ccf5eef

Change-Id: Ibc7ebfa9d5f68014592b4fb8793358be5436efce
2016-06-20 20:54:09 +00:00
Steve McKay
92e64a65ee Merge \"Make advanced storage option sticky...\" into nyc-dev
am: 361ccf5eef

Change-Id: I2369ba044813d2392a73ab369c012f1eb0ef51e8
2016-06-20 20:53:11 +00:00
Steve McKay
dd27444fa8 Make advanced storage option sticky...
...when used from one of the picker modes.

Bug: 29454465
Change-Id: I5f7db04a51023b59121289afd300a13ea071146d
2016-06-20 11:57:19 -07:00
TreeHugger Robot
fbfac58610 Merge "Implementing breadcrumb for tablet devices for navigation in the bar." 2016-06-17 19:01:52 +00:00
Steve McKay
9c4fd7b8e9 Merge \\\"Include cause when reporting errors.\\\" into nyc-dev am: 60585e6c54 am: be8b6e6164
am: 7dfb6fa15e

Change-Id: Iade90d4bfb323bcc1bb7a771fcb2b64656c25d57
2016-06-17 18:33:50 +00:00
Ben Lin
43b62a8eef Implementing breadcrumb for tablet devices for navigation in the bar.
Bug: 29214736
Change-Id: I37de2c39a55c33d7111496e896a0c85e1c7fa553
(cherry picked from commit 6fb1dfcc47b795b7071550a4524667d2f8f4d9a2)
2016-06-17 17:14:54 +00:00
TreeHugger Robot
ff244e6c4c Merge "[multi-part] Eliminate 1k selection limit" 2016-06-17 01:33:49 +00:00
Steve McKay
d81879670b [multi-part] Eliminate 1k selection limit
* Save selection to disk, delete old selections on app startup.
* Do clipper work in background for copy/cut.
* Pull DragShadowBuilder out of DirFragment.
* Reorganize selection handling to avoid creation of large lists of objects.
* Eliminate getAll from selection, make it iterable, remove unused method.
* Avoid creating DocumentInfo instances for full selection when initiating drag and drop.

Next step will be to pass selection tokens to FileOperationService.

Change-Id: Ia3e30a88ebf328e5b045d06b0df15dbd26a01a42
(cherry picked from commit 69b63de63ddae8d1a3ad8fa49a0beb1ff6f921e1)
2016-06-17 00:08:36 +00:00
Ben Lin
dea1aa0cdd Quick fix for Files crashing on start up.
Change-Id: I98df90b6bdf5caacb7565ead7051e507abfff23d
2016-06-16 21:32:02 +00:00
TreeHugger Robot
4a618f5eac Merge "Poll jobs' status to update notifications." 2016-06-16 20:31:24 +00:00
Steve McKay
ba7fc3b35f Merge \"Include cause when reporting errors.\" into nyc-dev
am: 60585e6c54

Change-Id: I014009e3c8e8b167b3d322886cadc20f2d9f6eaf
2016-06-16 19:18:45 +00:00
Steve McKay
be8b6e6164 Merge \"Include cause when reporting errors.\" into nyc-dev
am: 60585e6c54

Change-Id: I9a0ba14d358fedd7287e4bd0c5710953a9f21d27
2016-06-16 19:18:28 +00:00
Garfield, Tan
4a7aba23be Poll jobs' status to update notifications.
Bug: 27249491
Change-Id: I8912c781582af1789c8f76dea06879a3dde75d34
2016-06-16 18:41:30 +00:00
Ben Lin
9a621cbaca Implementation of Right-click context menus for docs/files.
Bug: 24416336
Change-Id: I675baf4abf6308bc1f6c3b4171f7251b0f3fd6e4
(cherry picked from commit be70710de3e1507292381cd14a9e1c1343ff2524)
2016-06-16 18:37:48 +00:00
Steve McKay
56d950c5e6 Include cause when reporting errors.
Bug: 29191892
Change-Id: I5f904da3a8564ec68ca634c28e3eda7f496a5c1c
2016-06-16 10:41:50 -07:00
Garfield, Tan
6f55e3ebcd Remove main looper assertions and attempts to run tests in main thread.
It looks like if we pass timeout_msec 300000 main thread is then
blocked. If we ever post a runnable to it synchronously in test, we'll
get a deadlock.

Change-Id: I7bd4ce2aaa1ffad72b83a343ff3331179896bd78
2016-06-10 22:33:44 +00:00
Felipe Leme
41debd1137 Merge \\\"Fixed check for visible volume.\\\" into nyc-dev am: be0bacda9b am: 2ee81a3211
am: 18ee3e53c8

Change-Id: I4ca401686049e969e6f257b76714e7f3289864c5
2016-06-10 22:04:43 +00:00
Felipe Leme
3ff43c5f0c Merge \"Fixed check for visible volume.\" into nyc-dev
am: be0bacda9b

Change-Id: I5b1aa0be01603cfaa09e3dfaa774182f6a62c188
2016-06-10 21:54:36 +00:00
Felipe Leme
2ee81a3211 Merge \"Fixed check for visible volume.\" into nyc-dev
am: be0bacda9b

Change-Id: I3802f5025e83826f47d674f6d03e78737d8fe8b3
2016-06-10 21:54:31 +00:00
Felipe Leme
9dbeff86c1 Merge \\\"Fixed check for volume name.\\\" into nyc-dev am: cbfc6eed32 am: e54c409a1f
am: a1072465a3

Change-Id: I36b74afea9d609d3fa072985ed8c94b4cf548d3c
2016-06-10 20:35:55 +00:00
Felipe Leme
a1072465a3 Merge \\"Fixed check for volume name.\\" into nyc-dev am: cbfc6eed32
am: e54c409a1f

Change-Id: I3e23c7d37d0e9527f0fccba5bf55b4bf092a1e5c
2016-06-10 20:30:59 +00:00
Felipe Leme
e54c409a1f Merge \"Fixed check for volume name.\" into nyc-dev
am: cbfc6eed32

Change-Id: Ieba9951e1899abca040e1ca456f911dc76412037
2016-06-10 20:25:21 +00:00
Felipe Leme
49843f9a0e Merge \"Fixed check for volume name.\" into nyc-dev
am: cbfc6eed32

Change-Id: Ifb1baa23784ec68566b468647a31479c46ad1ff4
2016-06-10 20:24:44 +00:00
Felipe Leme
24cc2cea74 Fixed check for visible volume.
Previously it was checked if the volume was visible to user, but
transient volumes (such as USB drives) are not marked as such.

Fixes: 29174953
Change-Id: I5dbcc42c5b31c6856e01f73815d73482822785d9
2016-06-10 12:10:16 -07:00
Felipe Leme
60f8f72cd4 Fixed check for volume name.
There are scenarios - like when an SD Card is adopted as internal
storage - where the getBestVolumeDescription() returns null, in which
case we should use the StorageVolume description instead (or a default
value if such description is also null)>

Change-Id: Ia11c3f4069dfbe252c568210ee60b5d8c384d863
Fixes: 29198046
2016-06-10 11:07:35 -07:00
Garfield, Tan
43b9a39cbf Jarjar common dependencies of test apk and app apk to avoid class conflicts.
Also remove android-support-v4 dependency from test apk as there is no
dependency over it in test apk.

Change-Id: I0b459bb831dae6c03adfb4215a8f6a514fc72904
(cherry picked from commit 41f0641ee657215b3efa07c52698c0c4aa2ca1e4)
2016-06-10 17:16:11 +00:00
TreeHugger Robot
cd6edf4df2 Merge "Ensure thumbnail cache test suite is running on main thread." 2016-06-09 19:06:07 +00:00
Ben Lin
151451967a Merge "Isolate Menu/Action management into dedicated manager classes." 2016-06-09 17:26:11 +00:00
Garfield, Tan
553db7241a Ensure thumbnail cache test suite is running on main thread.
Change-Id: I7e54ed76dac22966f4faff34c7653e8a7f0cb380
(cherry picked from commit f17b27a7a5f0872a08801c5edbd33999423d804e)
2016-06-09 16:58:31 +00:00