1962 Commits

Author SHA1 Message Date
Taesu Lee
b40a55ccc9 Use TelephonyManager#isEmergencyNumber() instead
Replace deprecated PhoneNumberUtils#isLocalEmergencyNumber() and
isEmergencyNumber() with TelephonyManager#isEmergencyNumber().

Test: Build
Bug: 132703886

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I232d7f7d23efd963b6d30938f0fa304c90fca8a8
Merged-In: I232d7f7d23efd963b6d30938f0fa304c90fca8a8
2020-10-14 02:31:14 +00:00
Taesu Lee
902b89d936 Use TelephonyManager#isEmergencyNumber() instead
Replace deprecated PhoneNumberUtils#isLocalEmergencyNumber() and
isEmergencyNumber() with TelephonyManager#isEmergencyNumber().

Test: Build
Bug: 132703886

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I232d7f7d23efd963b6d30938f0fa304c90fca8a8
2020-10-13 15:52:20 -07:00
Tyler Gunn
d67a33d6e1 Merge "Add clarification text on getCallerNumberVerificationStatus docs." am: f83bccb02f am: 793b248026 am: 0b22366dc7 am: 49f8fc73bf
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1455218

Change-Id: Icf13ea562dc9dbfd241c28c7938b8bfa50d4631b
2020-10-09 19:01:21 +00:00
Tyler Gunn
49f8fc73bf Merge "Add clarification text on getCallerNumberVerificationStatus docs." am: f83bccb02f am: 793b248026 am: 0b22366dc7
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1455218

Change-Id: I6f93ead176a20d649eb32456288f40b2d8a9d116
2020-10-09 18:34:41 +00:00
Tyler Gunn
f83bccb02f Merge "Add clarification text on getCallerNumberVerificationStatus docs." 2020-10-09 17:07:40 +00:00
Tyler Gunn
9c64249ea2 Add clarification text on getCallerNumberVerificationStatus docs.
Update API docs to make it clear what the verification status means and how
it can be used by CallScreeningService and CallRedirecitonService
implementations.

Test: Build API docs and view offline.
Bug: 150343312
Change-Id: I56f92f5e3ab544e31337a8147134baac33bb4ea9
2020-10-08 13:37:03 -07:00
Jeff Sharkey
f76ffeaff1 Merge changes from topic "oct6"
* changes:
  Upgrade AndroidFrameworkBinderIdentity to fatal.
  Tighten up Binder.clearCallingIdentity() usage.
  Tighten up Binder.clearCallingIdentity() usage.
  Tighten up Binder.clearCallingIdentity() usage.
2020-10-08 18:50:22 +00:00
Treehugger Robot
01aca15537 Merge "CallScreeningService API docs cleanup." am: 834c527a3b am: fcafb9acdf am: c3f4c873df am: 1f4f3591a8
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1453996

Change-Id: I71719dac58f6cda5e94fb62cd68015ce11a097c3
2020-10-08 04:20:36 +00:00
Treehugger Robot
1f4f3591a8 Merge "CallScreeningService API docs cleanup." am: 834c527a3b am: fcafb9acdf am: c3f4c873df
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1453996

Change-Id: I201fb017f2bd7c4e0c808a6053cdf3655669151c
2020-10-08 04:05:46 +00:00
Treehugger Robot
834c527a3b Merge "CallScreeningService API docs cleanup." 2020-10-08 02:49:10 +00:00
Treehugger Robot
7709d39a4d Merge "Clarify API docs for getCannedTextResponses." am: fc1a08a982 am: 9626f7cc42 am: 48b97996fb am: 0108bb9b4b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1451125

Change-Id: Id0185ea220741f93f43ebf7433d9655013f9dae9
2020-10-08 02:36:03 +00:00
Treehugger Robot
0108bb9b4b Merge "Clarify API docs for getCannedTextResponses." am: fc1a08a982 am: 9626f7cc42 am: 48b97996fb
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1451125

Change-Id: Ic9201f0e0a3b48561926023524eb308abd4cde91
2020-10-08 02:14:17 +00:00
Tyler Gunn
467acc47a3 CallScreeningService API docs cleanup.
Cleanups for call screening service APIs and to provide more clarity for
the lifecycle of the service.

Fixes: 170286897
Test: make docs ; preview docs genreated.
Change-Id: I487b438e39abb83cee1bd050889a6bce164247d7
2020-10-07 15:54:43 -07:00
Tyler Gunn
434fc2c524 Clarify API docs for getCannedTextResponses.
The API docs do not clearly indicate the fact that canned text responses
may not be available when a call is first added.  Updating the API docs
to clarify this and reference the listener a developer can use to be
informed of changes to the canned responses.

Test: Docs only change.
Bug: 162843384
Change-Id: I52ced96439b2dfa31c1f2428979ab54466763afa
2020-10-06 14:23:54 -07:00
Jeff Sharkey
2d2e07e2ff Tighten up Binder.clearCallingIdentity() usage.
The recently added AndroidFrameworkBinderIdentity Error Prone checker
examines code to ensure that any cleared identities are restored to
avoid obscure security vulnerabilities.

This change is a purely mechanical refactoring that adds the "final"
keyword to the cleared identity to ensure that it's not accidentally
modified before eventually being cleared.  Here's the exact command
used to generate this CL:

$ find . -name "*.java" -exec sed -Ei \
    's/    (long \w+ = .+?clearCallingIdentity)/    final \1/' \
    {} \;

Bug: 155703208
Test: make
Exempt-From-Owner-Approval: trivial refactoring
Change-Id: I832c9d70c3dfcd8d669cf71939d97837becc973a
2020-10-06 11:18:09 -06:00
Hall Liu
4bb53ec753 Update documentation for phone account sort order
Update documentation to reflect that the sort order extra
should contain integers.

Bug: 169153499
Test: docs only
Change-Id: Ic5269d577f007e01a0c9eaa95cd7e8814ab8f79a
2020-09-29 15:15:24 -07:00
Hall Liu
221f804a00 API tweaks in response to feedback
Update documentation on PhoneAccount#EXTRA_SORT_ORDER to make it more
clear what the sorting order is in edge cases.

Make DisconnectCause#REASON_EMULATING_SINGLE_CALL public, since it might
get propogated up to dialer apps.

Fixes: 169153499
Test: docs only
Change-Id: I7f810f909a8a61b422283c3bafcc97307e4d863b
2020-09-23 16:48:59 -07:00
Hall Liu
e82e9bf01b Merge "Expose Telecom constants for use in Telephony" am: 9fcb2819d0 am: 1bf919f084 am: 5b6beb2fc0 am: 2f8cf2f852 am: 74bb99708b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1427473

Change-Id: Id62c2a0f4add8ce3fccaef64240f9a8efb79aa94
2020-09-16 01:48:21 +00:00
Hall Liu
74bb99708b Merge "Expose Telecom constants for use in Telephony" am: 9fcb2819d0 am: 1bf919f084 am: 5b6beb2fc0 am: 2f8cf2f852
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1427473

Change-Id: Ib461b9a4f7271b9f9263cae8292dc5d0579fc102
2020-09-16 01:25:39 +00:00
Hall Liu
2ef041183d Expose Telecom constants for use in Telephony
Expose Telecom constants that are used in Telephony in preparation for
mainline. Exposure is a combination of public/system -- those which made
sense for 3pty apps to access were made public.

Fixes: 168551099
Test: atest CtsTelecomTestCases
Change-Id: I688f04ba4ddf0498bad3463888fae71cdff2844a
2020-09-14 18:37:44 -07:00
Brad Ebinger
c2d060210a Merge "Modify the TelecomLoaderService to provide LocalServices to Telecom" into rvc-qpr-dev am: ebef1b923b am: 4cead2c3e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12522284

Change-Id: I021763a0d7108b89b09087d115d143ae140bb7a8
2020-09-09 23:41:50 +00:00
Brad Ebinger
4cead2c3e8 Merge "Modify the TelecomLoaderService to provide LocalServices to Telecom" into rvc-qpr-dev am: ebef1b923b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12522284

Change-Id: I3d71331cbc8f01f764cc0b9704416821007feeb5
2020-09-09 17:42:32 +00:00
Brad Ebinger
c4893faddb Merge "Update OWNERS" am: 33082d4490 am: f3670cc3d3 am: ee81b81b29 am: cc0bbcb8d7 am: e11d9e4132
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1418955

Change-Id: Ie5337e21dc29c7e4a51ac3b15fc93bfc78a59fe3
2020-09-08 20:56:55 +00:00
Brad Ebinger
f3670cc3d3 Merge "Update OWNERS" am: 33082d4490
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1418955

Change-Id: Ia358e7f028c9fbbb80aa03e714f652c251a6fd9b
2020-09-08 19:20:53 +00:00
Brad Ebinger
ca201499c6 Update OWNERS
Test: manual
Change-Id: I1c6231bb83f626fcbd3684eb45224abfa610afef
2020-09-03 23:29:16 +00:00
Songchun Fan
c903f6ac26 [telecom] system_server should not call non forUser Settings.Secure.get* methods
BUG: 166312046
Test: builds
Change-Id: I69e91c84ff170abd6e82e0ff322e168c11004daa
2020-09-03 22:59:14 +00:00
Brad Ebinger
cfa3045a5b Modify the TelecomLoaderService to provide LocalServices to Telecom
We need access to the DeviceIdleController, which is not currently
accessible via the PowerWhitelistManager due to restrictions with
components in the same SYSTEM process accessing public APIs (see
context#enforceCallingPermission).

To get around this, we need to wrap services only available as
LocalServices using Binder to pass these services to the Telecom
code. This is all in-process (no IPC allowed), so there should be
little to no impact.

Bug: 160724034
Test: miss call and verify `adb shell cmd deviceidle tempwhitelist` contains
default dialer.
Test: atest TelecomUnitTests; atest CtsTelecomTestCases

Change-Id: I6275b550d19743e576b93f5fcd2bd3aa9ea4e1a8
2020-09-03 22:36:54 +00:00
Xin Li
628590d7ec Merge Android R (rvc-dev-plus-aosp-without-vendor@6692709)
Bug: 166295507
Merged-In: I3d92a6de21a938f6b352ec26dc23420c0fe02b27
Change-Id: Ifdb80563ef042738778ebb8a7581a97c4e3d96e2
2020-08-31 21:21:38 -07:00
Grace Jia
1c997e4ead Merge "Add adhoc conference APIs to RemoteConnection and RemoteConnectionService." am: 329c6ff777 am: e40cfa60de am: 6a55cd1644 am: 300b3cce72 am: f98b0c5eb1
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1388908

Change-Id: I3fc6ba1492996d41530461452e83759a490adc6d
2020-08-13 19:30:59 +00:00
Grace Jia
6a55cd1644 Merge "Add adhoc conference APIs to RemoteConnection and RemoteConnectionService." am: 329c6ff777 am: e40cfa60de
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1388908

Change-Id: I49034d851b111792fa54b3d2f236d56513bb00f9
2020-08-13 18:46:06 +00:00
Grace Jia
329c6ff777 Merge "Add adhoc conference APIs to RemoteConnection and RemoteConnectionService." 2020-08-13 18:06:19 +00:00
Tyler Gunn
560c97bc25 Merge "Improve remote connection logging." 2020-08-12 18:27:36 +00:00
Tyler Gunn
419c0fa22e Merge "Fix createLaunchEmergencyDialerIntent API behavior when Telecom unavailable." 2020-08-12 18:27:18 +00:00
Grace Jia
9a09c67075 Add adhoc conference APIs to RemoteConnection and
RemoteConnectionService.

Plumb through the adhoc conference APIs via these new APIs.

Bug: 159944852
Test: atest CtsTelecomTestCases:RemoteConnectionTest
Change-Id: Icfa27e0616dd35ba350f7a491e5c95337a286b9d
2020-08-11 19:26:33 +00:00
Grace Jia
0128b3c58c Deprecate TelecomManager#getPhoneAccountsForPackage for security.
Bug: 153995334
Test: make
Change-Id: I66d757139f3b7e25481b302e9378327873c7912c
2020-08-07 00:41:29 +00:00
Tyler Gunn
c59fd0cd80 Improve remote connection logging.
This CL improves traceability of calls initiated via a remote connection
service.
For regular incoming/outgoing calls, when initiating a request to create
a remote connection in RemoteConnectionService, we set
EXTRA_REQUESTING_PACKAGE_NAME in the parcelled request to the package name
of the connection manager.  In ConnectionService this serves as an
indicator that the incoming request is via a connection manager and is
used to trigger setting of EXTRA_REMOTE_PHONE_ACCOUNT_HANDLE with the
phone account handle the remote connection service uses to place the call.
For conferences and existing connections, the initial request is from
the remote connection service to the connection manager so we can
just set the EXTRA_REMOTE_PHONE_ACCOUNT handle there directly.

Also cleaned up logging in the telecom session logging to remove the
assumption that the ownerInfo is an incall service.

Test: Manual testing with connection manager to verify logging.
Bug: 154353494
Fixes: 155097158
Merged-In: I916750e0f558db1eb9e581bab7a9fbc71f781709
Change-Id: Iee1b5cfd3334a5de08d7b04022b7c6d5af6a4b04
2020-08-05 13:45:33 -07:00
Tyler Gunn
893a602e61 Fix createLaunchEmergencyDialerIntent API behavior when Telecom unavailable.
The API contract for createLaunchEmergencyDialerIntent indicates that
the return value is @NonNull, however the code clearly can return a null
value if either:
1. Telecom is unavailable.
2. There is a remote exception.

Since the API just returns a new ACTION_EMERGENCY_DIAL intent with the
package name of the emergency dialer (from Telecom string resources), we
can provide a reasonable fallback behavior by just returning a new
ACTION_EMERGENCY_DIAL intent with no targeted package.  The system will
still launch the emergency dialer in this case, but if there is a scenario
where multiple emergency dialers are installed on a device, the AOSP one
may get launched instead.  This is, however, better than there being NO
emergency dialer launched.

Test: Comment out call to Telecom service and verify the AOSP emergency
dialer still launches.
Bug: 152187752
Fixes: 155097434
Merged-In: I1665d456dace8e41cc035e792f319d98dd07219c
Change-Id: I06f8a5bebace5b22822f7bb714e14915126b904f
2020-08-05 13:37:27 -07:00
Tyler Gunn
c5ef3b9cae Merge "Update language to comply with Android's inclusive language guidance" am: a005cb30ed am: 3772a5b3fd
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1377136

Change-Id: I2f838a951cec8f6e7af82a0cd08d99d6045f3952
2020-07-30 21:25:38 +00:00
Tyler Gunn
a005cb30ed Merge "Update language to comply with Android's inclusive language guidance" 2020-07-30 20:42:55 +00:00
Tyler Gunn
460360d6b8 Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Test: Presubmit
Bug: 161896447
Change-Id: I4142f4819f5ed3e2ffddf471b90923985e72523a
2020-07-29 10:23:07 -07:00
Hall Liu
a125ea21f2 Merge "Run CtsTelecomTestCases in presubmit" am: 1b2995ca3f am: 0022d0dc37
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1334115

Change-Id: I3c242b6e16e6176f398f14f4aca58a7be0b42eae
2020-07-28 21:16:18 +00:00
Hall Liu
1b2995ca3f Merge "Run CtsTelecomTestCases in presubmit" 2020-07-28 20:47:36 +00:00
Treehugger Robot
e8a4750ac5 Merge "Expose adhoc conference calling API as public." am: 8ebbe3c038 am: fb8f41f0c2
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1368819

Change-Id: Ia5e17f2dbbfbb539f2415348e1ddb960354d3662
2020-07-28 17:41:13 +00:00
Grace Jia
8587ee5cd5 Expose adhoc conference calling API as public.
Bug: 159944852
Test: make
Change-Id: I2cf39a6fd8a02ca4f2d0c83c484ab12bb13f74c3
2020-07-27 11:18:36 -07:00
Hall Liu
e0f787cc61 Add PROPERTY_DOWNGRADED_CONFERENCE to logging
Bug: 153530054
Test: manual
Change-Id: I37558527ef867b49fc597ae2cdaf1620cfde0ab1
2020-07-08 11:25:56 -07:00
Hall Liu
b5d4decf24 Add telecom command to stop block suppression
Add a Telecom command to stop the number blocking suppression that
happens after an emergency call.

Bug: 158798240
Fixes: 160667708
Test: atest CtsTelecomTestCases
Change-Id: I122de1962fb6aa48a3092c2aa323dcbdcbb8f42e
2020-07-08 11:09:26 -07:00
Hall Liu
de99d04289 Run CtsTelecomTestCases in presubmit
Run Telecom CTS in presubmit, and include a few fixes to prevent
flakiness in said presubmit.

Fixes: 158798240
Test: presubmit
Change-Id: I9b9e2f2604615e93301bc83be7c3545c6f80cb9c
2020-07-01 14:51:59 -07:00
Treehugger Robot
8c5ed53fad Merge "Add telecom command to stop block suppression" am: afe114c2f5 am: 533a19175c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1350781

Change-Id: I4cface851f70245a7efc4063e54c2943f2d0e362
2020-06-26 23:11:08 +00:00
Treehugger Robot
afe114c2f5 Merge "Add telecom command to stop block suppression" 2020-06-26 22:45:32 +00:00
Hall Liu
efe7351c7c Add telecom command to stop block suppression
Add a Telecom command to stop the number blocking suppression that
happens after an emergency call.

Bug: 158798240
Test: atest CtsTelecomTestCases
Change-Id: I122de1962fb6aa48a3092c2aa323dcbdcbb8f42e
2020-06-26 13:38:50 -07:00