2095 Commits

Author SHA1 Message Date
Ben Lin
693ba32b71 Fix context menu for empty directory/root view.
Since it's not always true that there is a doc/directory given the (x,
y) of the right click, I've changed the signature of right click to take
in a MotionEvent object as a parameter, and make a MotionInputEvent
inside the function as a check whether it's on a file/doc or on
empty/blank pane.

Bug: 29538570
Change-Id: I7ee960c9f556752bf314ab8cc2d94fda28194c0a
(cherry picked from commit 332192dee8cb99bd2e6ef638e78d5b62ab7ecfe6)
2016-06-21 23:44:14 +00:00
Bill Yi
74af5c4488 Import translations. DO NOT MERGE
Change-Id: Ie8d68a06c4943b5e3eb2b80c5ba806ac85e0b5e5
Auto-generated-cl: translation import
2016-06-20 22:37:46 -07:00
Ben Lin
8eafd50a03 Moving Menu-related logic from BaseActivity to MenuManager.
Bug: 29423149
Change-Id: I228e1525cb82d310b16ef0aec8acb4534b7b601d
(cherry picked from commit d896dc7b487771f7d5329feb01ac7c3355fce9ed)
2016-06-20 21:48:17 +00:00
Steve McKay
fc8a346e5a Merge \\\"Make advanced storage option sticky...\\\" into nyc-dev am: 361ccf5eef am: 92e64a65ee
am: 75ea877bc9

Change-Id: I6204de46dd54b2c2a89c9a44edd571179ae1ddab
2016-06-20 21:00:54 +00:00
Steve McKay
92e64a65ee Merge \"Make advanced storage option sticky...\" into nyc-dev
am: 361ccf5eef

Change-Id: I2369ba044813d2392a73ab369c012f1eb0ef51e8
2016-06-20 20:53:11 +00:00
Steve McKay
dd27444fa8 Make advanced storage option sticky...
...when used from one of the picker modes.

Bug: 29454465
Change-Id: I5f7db04a51023b59121289afd300a13ea071146d
2016-06-20 11:57:19 -07:00
TreeHugger Robot
fbfac58610 Merge "Implementing breadcrumb for tablet devices for navigation in the bar." 2016-06-17 19:01:52 +00:00
Steve McKay
9c4fd7b8e9 Merge \\\"Include cause when reporting errors.\\\" into nyc-dev am: 60585e6c54 am: be8b6e6164
am: 7dfb6fa15e

Change-Id: Iade90d4bfb323bcc1bb7a771fcb2b64656c25d57
2016-06-17 18:33:50 +00:00
Ben Lin
43b62a8eef Implementing breadcrumb for tablet devices for navigation in the bar.
Bug: 29214736
Change-Id: I37de2c39a55c33d7111496e896a0c85e1c7fa553
(cherry picked from commit 6fb1dfcc47b795b7071550a4524667d2f8f4d9a2)
2016-06-17 17:14:54 +00:00
TreeHugger Robot
ff244e6c4c Merge "[multi-part] Eliminate 1k selection limit" 2016-06-17 01:33:49 +00:00
Steve McKay
d81879670b [multi-part] Eliminate 1k selection limit
* Save selection to disk, delete old selections on app startup.
* Do clipper work in background for copy/cut.
* Pull DragShadowBuilder out of DirFragment.
* Reorganize selection handling to avoid creation of large lists of objects.
* Eliminate getAll from selection, make it iterable, remove unused method.
* Avoid creating DocumentInfo instances for full selection when initiating drag and drop.

Next step will be to pass selection tokens to FileOperationService.

Change-Id: Ia3e30a88ebf328e5b045d06b0df15dbd26a01a42
(cherry picked from commit 69b63de63ddae8d1a3ad8fa49a0beb1ff6f921e1)
2016-06-17 00:08:36 +00:00
Ben Lin
dea1aa0cdd Quick fix for Files crashing on start up.
Change-Id: I98df90b6bdf5caacb7565ead7051e507abfff23d
2016-06-16 21:32:02 +00:00
TreeHugger Robot
4a618f5eac Merge "Poll jobs' status to update notifications." 2016-06-16 20:31:24 +00:00
Steve McKay
be8b6e6164 Merge \"Include cause when reporting errors.\" into nyc-dev
am: 60585e6c54

Change-Id: I9a0ba14d358fedd7287e4bd0c5710953a9f21d27
2016-06-16 19:18:28 +00:00
Garfield, Tan
4a7aba23be Poll jobs' status to update notifications.
Bug: 27249491
Change-Id: I8912c781582af1789c8f76dea06879a3dde75d34
2016-06-16 18:41:30 +00:00
Ben Lin
9a621cbaca Implementation of Right-click context menus for docs/files.
Bug: 24416336
Change-Id: I675baf4abf6308bc1f6c3b4171f7251b0f3fd6e4
(cherry picked from commit be70710de3e1507292381cd14a9e1c1343ff2524)
2016-06-16 18:37:48 +00:00
Steve McKay
56d950c5e6 Include cause when reporting errors.
Bug: 29191892
Change-Id: I5f904da3a8564ec68ca634c28e3eda7f496a5c1c
2016-06-16 10:41:50 -07:00
Garfield, Tan
6f55e3ebcd Remove main looper assertions and attempts to run tests in main thread.
It looks like if we pass timeout_msec 300000 main thread is then
blocked. If we ever post a runnable to it synchronously in test, we'll
get a deadlock.

Change-Id: I7bd4ce2aaa1ffad72b83a343ff3331179896bd78
2016-06-10 22:33:44 +00:00
Felipe Leme
41debd1137 Merge \\\"Fixed check for visible volume.\\\" into nyc-dev am: be0bacda9b am: 2ee81a3211
am: 18ee3e53c8

Change-Id: I4ca401686049e969e6f257b76714e7f3289864c5
2016-06-10 22:04:43 +00:00
Felipe Leme
2ee81a3211 Merge \"Fixed check for visible volume.\" into nyc-dev
am: be0bacda9b

Change-Id: I3802f5025e83826f47d674f6d03e78737d8fe8b3
2016-06-10 21:54:31 +00:00
Felipe Leme
9dbeff86c1 Merge \\\"Fixed check for volume name.\\\" into nyc-dev am: cbfc6eed32 am: e54c409a1f
am: a1072465a3

Change-Id: I36b74afea9d609d3fa072985ed8c94b4cf548d3c
2016-06-10 20:35:55 +00:00
Felipe Leme
a1072465a3 Merge \\"Fixed check for volume name.\\" into nyc-dev am: cbfc6eed32
am: e54c409a1f

Change-Id: I3e23c7d37d0e9527f0fccba5bf55b4bf092a1e5c
2016-06-10 20:30:59 +00:00
Felipe Leme
e54c409a1f Merge \"Fixed check for volume name.\" into nyc-dev
am: cbfc6eed32

Change-Id: Ieba9951e1899abca040e1ca456f911dc76412037
2016-06-10 20:25:21 +00:00
Felipe Leme
49843f9a0e Merge \"Fixed check for volume name.\" into nyc-dev
am: cbfc6eed32

Change-Id: Ifb1baa23784ec68566b468647a31479c46ad1ff4
2016-06-10 20:24:44 +00:00
Felipe Leme
24cc2cea74 Fixed check for visible volume.
Previously it was checked if the volume was visible to user, but
transient volumes (such as USB drives) are not marked as such.

Fixes: 29174953
Change-Id: I5dbcc42c5b31c6856e01f73815d73482822785d9
2016-06-10 12:10:16 -07:00
Felipe Leme
60f8f72cd4 Fixed check for volume name.
There are scenarios - like when an SD Card is adopted as internal
storage - where the getBestVolumeDescription() returns null, in which
case we should use the StorageVolume description instead (or a default
value if such description is also null)>

Change-Id: Ia11c3f4069dfbe252c568210ee60b5d8c384d863
Fixes: 29198046
2016-06-10 11:07:35 -07:00
Garfield, Tan
43b9a39cbf Jarjar common dependencies of test apk and app apk to avoid class conflicts.
Also remove android-support-v4 dependency from test apk as there is no
dependency over it in test apk.

Change-Id: I0b459bb831dae6c03adfb4215a8f6a514fc72904
(cherry picked from commit 41f0641ee657215b3efa07c52698c0c4aa2ca1e4)
2016-06-10 17:16:11 +00:00
TreeHugger Robot
cd6edf4df2 Merge "Ensure thumbnail cache test suite is running on main thread." 2016-06-09 19:06:07 +00:00
Ben Lin
151451967a Merge "Isolate Menu/Action management into dedicated manager classes." 2016-06-09 17:26:11 +00:00
Garfield, Tan
553db7241a Ensure thumbnail cache test suite is running on main thread.
Change-Id: I7e54ed76dac22966f4faff34c7653e8a7f0cb380
(cherry picked from commit f17b27a7a5f0872a08801c5edbd33999423d804e)
2016-06-09 16:58:31 +00:00
Bill Yi
4f7761324c Import translations. DO NOT MERGE
Change-Id: I9d35beab3bc8bc82ee9eb3ce5ddfd1f08f55f9cd
Auto-generated-cl: translation import
2016-06-09 04:03:54 -07:00
Ben Lin
a433c6dc4d Isolate Menu/Action management into dedicated manager classes.
We are now also returning fragmentTuner at the activity level, so that
directoryFragment does not have to do a .pick() logic depending on the
activity type. Rather, the logic lies within the activity itself.

Bug: 24416336
Change-Id: Idb200864f6c9468b9193781f6ac505b557ffbce9
(cherry picked from commit bc330a4bf53c3a766292097d1815b9abd469a945)
2016-06-08 22:45:42 +00:00
Steve McKay
b25f587933 Preserve selection in memory during rotation.
Using onRetainNonConfigurationInstance
Eliminate 1k limit on selections.
Bug: 28194201

Failed cherrypick merge from https://googleplex-android-review.git.corp.google.com/#/c/1105581/

Change-Id: Id986c23867df33f1e53bb2999ba51babde5d535b
2016-06-08 13:14:45 -07:00
TreeHugger Robot
641517546c Merge "Recycle after return to avoid returning an invalid value." 2016-06-08 02:43:55 +00:00
Baligh Uddin
471718a57f Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 29169863
Change-Id: Icab456e7a193fc6099bbd6e7ff207d542e98830e
2016-06-07 17:16:36 -07:00
Garfield, Tan
866858b85a Recycle after return to avoid returning an invalid value.
Also add some main thread assertions.

Change-Id: Id6314d6e92d530ce57a01902b5570381fa20044d
(cherry picked from commit 1a1b9148a2094b4365ff5e65372b1a1eb0282a0a)
2016-06-07 23:30:39 +00:00
Garfield, Tan
3c2bf54e30 Use pool for MotionInputEvents.
Bug: 28987543
Change-Id: I3128320a7d527fdd74ab80165b270be2e5e34476
(cherry picked from commit 2458a15aadca7902744cd7c5f3da8e0779e1e3b8)
2016-06-07 23:30:22 +00:00
TreeHugger Robot
546d5b10a1 Merge "Converge toList and getAll methods." 2016-06-07 21:36:27 +00:00
Steve McKay
f347eef4c7 Converge toList and getAll methods.
Change-Id: I71ba53947f1840a21a9b1f77523dce8675308c99
2016-06-07 12:26:59 -07:00
TreeHugger Robot
3c006b4936 Merge "Import translations. DO NOT MERGE" 2016-06-07 02:28:43 +00:00
Bill Yi
cf3f08d4e8 Import translations. DO NOT MERGE
Change-Id: I98171b651d3e690b0439bb2d205ca615d191c7bd
Auto-generated-cl: translation import
2016-06-06 13:49:28 -07:00
Guang Zhu
dffb037bb8 Merge "migrate documents UI tests to use AndroidJUnitRunner" into nyc-dev am: 56cf05291e
am: 217e152229

* commit '217e152229c51a6d535e6b739ab48c4091d6cd0e':
  migrate documents UI tests to use AndroidJUnitRunner

Change-Id: I9b28c0c844c1d8a88e9869c9a525c32500ebc05b
2016-06-06 19:31:31 +00:00
Guang Zhu
28a6a3f435 Merge "migrate documents UI tests to use AndroidJUnitRunner" into nyc-dev
am: 56cf05291e

* commit '56cf05291e1ffb54025a47ccb046f44c2d05ef14':
  migrate documents UI tests to use AndroidJUnitRunner

Change-Id: Ibc04084e8123a0e0bfe9cbe1c34a1a767dde03ab
2016-06-06 19:27:54 +00:00
Guang Zhu
217e152229 Merge "migrate documents UI tests to use AndroidJUnitRunner" into nyc-dev
am: 56cf05291e

* commit '56cf05291e1ffb54025a47ccb046f44c2d05ef14':
  migrate documents UI tests to use AndroidJUnitRunner

Change-Id: If5e573f0fdb7d9ff8e70f4172fb0adf38c2b552a
2016-06-06 19:27:52 +00:00
Guang Zhu
56cf05291e Merge "migrate documents UI tests to use AndroidJUnitRunner" into nyc-dev 2016-06-06 19:22:32 +00:00
Garfield, Tan
d9ddb3ba5b Suppress auto-closing drawer and add ripple effect on spring load roots.
Bug: 28865182
Change-Id: Ief7967e33b9a0d7e94a667172121d8007f78115b
(cherry picked from commit 17182ca46f7a8f3ae03bb8f5a16116246a5fbd91)
2016-06-06 19:01:51 +00:00
Ben Lin
36c5e5de26 Merge "Adding docsui prefix to access metric tags." into nyc-dev am: de862e1cc8 am: 8454626813
am: f5099d7c16

* commit 'f5099d7c163133ecd415a222cca7f3469378169d':
  Adding docsui prefix to access metric tags.

Change-Id: I4722276266d4a53fbc5a61cbbe05a9613dd0a3b8
2016-06-06 18:17:57 +00:00
Ben Lin
f5099d7c16 Merge "Adding docsui prefix to access metric tags." into nyc-dev am: de862e1cc8
am: 8454626813

* commit '84546268130f2d59d2844c14fb078db36bc61ceb':
  Adding docsui prefix to access metric tags.

Change-Id: I6b1ee9d80c19a475f7b1156f092e72d11bc2c68c
2016-06-06 18:13:39 +00:00
Ben Lin
74190e4a38 Merge "Adding docsui prefix to access metric tags." into nyc-dev
am: de862e1cc8

* commit 'de862e1cc82d96d22394201cb8867b643e4f2e93':
  Adding docsui prefix to access metric tags.

Change-Id: I74cae4f5a7b89411b0e7ebcee348ee05c1cc15f2
2016-06-06 18:08:20 +00:00
Ben Lin
8454626813 Merge "Adding docsui prefix to access metric tags." into nyc-dev
am: de862e1cc8

* commit 'de862e1cc82d96d22394201cb8867b643e4f2e93':
  Adding docsui prefix to access metric tags.

Change-Id: Id3dc690e4f753af51acb406565c643d2fdc01ec1
2016-06-06 18:08:07 +00:00