This reverts commit 4863931934083f806a6627600d1d91bb6edd42cc.
Reason for revert: broke the build due to missing wifi change
Change-Id: I9610a92c1b19aeb0ddab68d10f2abf2f9ed3a205
The two are almost identical, and the target using sources as input
can be deleted.
The diffs that remain are minor and as far as I can tell OK:
- A few constants are removed from the metadata.zip. It looks to
me like metalava was previously including @SystemApi constants in the
public SDK's metadata. This bug is now worked around by only feeding
metalava the public APIs.
- There are some very minor diffs in the docs of a few APIs.
Bug: 186197911
Test: build sdk before/after and diff
Change-Id: Iac7de64f353bc1467fc4b249e531f034ef702d51
This target produces nearly identical contents to the build target
framework-doc-stubs (the only diffs are in whitespace). Using this
module in the SDK zip will allow changing the inputs of
framework-doc-stubs to java sources that don't have all the annotations
(the jar stubs).
Bug: 187397779
Test: m sdk-annotations.zip and diff with framework-doc-stubs zip
Change-Id: Id163473c455f25c5f31c965d907c0c3b0e7755fc
This target produces nearly identical contents to the build target
framework-doc-stubs (the only diffs are in whitespace). Using this
module in the SDK zip will allow changing the inputs of
framework-doc-stubs to java sources that don't have all the annotations
(the jar stubs).
Bug: 187397779
Test: m sdk-annotations.zip and diff with framework-doc-stubs zip
Change-Id: Id163473c455f25c5f31c965d907c0c3b0e7755fc
The framework-doc-stubs target currently takes the module source code
as input. Work is being done to change that over to use module sdk
artifacts, primarily the jar stub source code. Check in a
work-in-progress target that does so, to avoid it breaking and to
simplify iterating on improvements.
Bug: 186197911
Test: m framework-doc-stubs{,-module-stubs}
Change-Id: I1a275b3f44632e6655dc84d711a58fc0c5b3a46a
These two PermissionManager methods are using AttributionSource as
metadata only, and aren't interested in the remote caller enforcing
that the claimed UID matches the caller, since they're not actually
being used for permission enforcement.
Thus we pass the metadata using the AttributionSourceState holder
object and reconstruct on the remote side, entirely avoiding the
enforceCallingUid() check.
Bug: 193842956
Test: atest CtsPermission5TestCases
Change-Id: I576b6feb8cc2b0586b4341268866d8027689293f
Specifing the new property makes soong pass system stub jars for
metalava to process.
Bug: 190665366
Test: m framework-doc-system-stubs
Change-Id: I0da0a0aa79d0128d81a5a6df7f9ce4a190a2b650
A package filter was previously applied to just the jarstubs package,
but not the docstubs. This lead to various internal classes appearing in
the public documentation. Fix that to apply the same filter for both.
This removes the following classes from the docs:
android/telephony/PackageChangeReceiver
com/android/net/module/util/CollectionUtils
com/android/net/module/util/ConnectivityUtils
com/android/net/module/util/NetworkCapabilitiesUtils
com/android/net/module/util/NetworkIdentityUtils
com/google/android/collect/Lists
com/google/android/collect/Maps
com/google/android/collect/Sets
com/google/android/gles_jni/EGLConfigImpl
com/google/android/gles_jni/EGLContextImpl
com/google/android/gles_jni/EGLDisplayImpl
com/google/android/gles_jni/EGLImpl
com/google/android/gles_jni/EGLSurfaceImpl
com/google/android/gles_jni/GLImpl
com/google/android/util/AbstractMessageParser
com/google/android/util/AbstractMessageParser$Acronym
com/google/android/util/AbstractMessageParser$FlickrPhoto
com/google/android/util/AbstractMessageParser$Format
com/google/android/util/AbstractMessageParser$Html
com/google/android/util/AbstractMessageParser$Link
com/google/android/util/AbstractMessageParser$MusicTrack
com/google/android/util/AbstractMessageParser$Part
com/google/android/util/AbstractMessageParser$Photo
com/google/android/util/AbstractMessageParser$Resources
com/google/android/util/AbstractMessageParser$Smiley
com/google/android/util/AbstractMessageParser$Token
com/google/android/util/AbstractMessageParser$Token$Type
com/google/android/util/AbstractMessageParser$TrieNode
com/google/android/util/AbstractMessageParser$Video
com/google/android/util/AbstractMessageParser$YouTubeVideo
com/google/android/util/Procedure
com/google/android/util/SmileyParser
com/google/android/util/SmileyResources
Bug: 187386774
Test: diff framework-doc-stubs/../api-versions.xml before and after
Change-Id: I85b1485b4c5bc1b30a5d537e96d961382f298fb7
This allows soong to infer the package of the given srcs, which in turns
make it able to filter the inputs to metalava to exclude unwanted
packages.
This is part of a larger topic of changes intended to remove undesired
classes from the public documentation.
Bug: 187386774
Test: m
Change-Id: I8196c306b743ce6ca8a6452d212f3d7c0b5b2b82
Like the jar stubs, the doc stubs need modularization to avoid depending
on module sources and instead being assembled by merging the doc stubs
of the constituent modules. This will allow generating e.g. the lint
database, annotation zips, and the documentation itself from prebuilts
(which in turn allows mixing e.g. non-updatable R with the latest
modules).
Move the defaults for the non-updatable jar stubs to the shared bp file
and reuse it for the non-updatable doc stubs, and add two targets for
the public and the system stubs.
Bug: 186197911
Test: m android-non-updatable-doc-stubs{,-system}
Merged-In: Ic2cef748c42c141ea42b8cd7b4afd7ee78a1399d
Change-Id: Ic2cef748c42c141ea42b8cd7b4afd7ee78a1399d
Like the jar stubs, the doc stubs need modularization to avoid depending
on module sources and instead being assembled by merging the doc stubs
of the constituent modules. This will allow generating e.g. the lint
database, annotation zips, and the documentation itself from prebuilts
(which in turn allows mixing e.g. non-updatable R with the latest
modules).
Move the defaults for the non-updatable jar stubs to the shared bp file
and reuse it for the non-updatable doc stubs, and add two targets for
the public and the system stubs.
Bug: 186197911
Test: m android-non-updatable-doc-stubs{,-system}
Change-Id: Ic2cef748c42c141ea42b8cd7b4afd7ee78a1399d
This argument doesn't appear to alter the output.
Bug: 186197911
Test: diff metadata.zip, stubs.srcjar, annotations.zip before and after
Change-Id: I5147cf1f0658c78e5ab24952285c8fc1c036a55d
Inline these sources in the only place it is used.
Test: presubmit
Merged-In: I42e7044471262bf901b8c130a50e1a8a8170c600
Change-Id: I42e7044471262bf901b8c130a50e1a8a8170c600
It was used in the docs stubs generation but it doesn't have its own
(jar) stub generation. Add it to the shared non-updatable sources for
consistency.
The only class in these sources is @hide, so it makes no
immediate difference.
Test: diff android_stubs_current artifact before/after
Change-Id: I33e75623d8d71da362fb16befb78c8c7596fa400
It is being used implicitly at the moment, make it explicit instead.
r.android.com/1305139 added this to the other droidstubs.
Bug: 153703940
Test: diff soong intermediates for framework-doc-stubs before and after
Change-Id: I708cfd02b9096b0245fddbbfb46893d912edd197
We're working on moving the libcore classes away from srcs and into the
classpath, and ignoring classes on the classpath will cause incorrect
API signatures once that happens (several libcore classes appear in
public API signatures).
Keep the docs building in the same way they were before. They will be
addressed in separate CLs.
Bug: 173606718
Test: m checkapi
Change-Id: I471327c3657662d7a093e9baa2fb6e08d640f895
This removes the i18n source from the non-updatable stubs which removes
them from the frameworks/base/core/api files too. The API is still
protected by both the build and Gerrit review as the API is specified
in the external/icu/android_icu4j/api/public/ directory.
The i18n stubs source is used instead of the implementation source for
generating the JavaDoc. That revealed a minor issue with metalava which
is fixed in this topic.
The i18n stubs library was statically included alongside the conscrypt
stubs library so it will still appear in the monolothic android.jar.
Bug: 174344410
Test: m offline-sdk-docs
- check that i18n classes are present
m android_stubs_current android_system_stubs_current android_test_stubs_current
- check that i18n classes are present in each jar
m droid
Change-Id: I744c8bac54a8a5518ca0eca2a7700abbfa0997f4
Uses an output tag to access the doctag_files exposed by the
art.module.public.api java_sdk_library. This ensures that the doctags
will be available from the ART prebuilts as well.
Bug: 168301990
Test: Built offline-sdk-docs with and without the change and
diffed them. The only difference was the timestamp.js
file.
Change-Id: Ibd51899e4aeb9b11727a54644330bbbe8b7e86a7
Bug: 168301990
Test: Built offline-sdk-docs with and without the change and
diffed them. There were some changes other than the timestamp.js
file. With these changes classes that implemented the
Object.equals(Object) method had some extra documentation that
explained that the parameter could be null. The reason for this
change is that the stubs generated with this change includes
android.annotation.Nullable whereas previously they included
androidx.annotation.Nullable. The change is a very minor
improvement over what is currently uploaded to
developer.android.com/reference so not worth backporting.
Diffed api/public/current.txt against
frameworks/base/api/current.txt and made sure that the latter was
a superset of the former and there were no differences in the area
that overlapped.
Change-Id: I3767948b4659b18b813c8eed66258af98ac4a241
This moves the android.media.audio.common, android.media.permission and
android.media.soundtrigger_middleware AIDL files to a their own
separate aidl_interface module for Java.
Previously, because of how the framework JAR is configured, those
files were automatically compiled into it and we had to disable Java
for this target, creating a discrepancy between C++ and Java, which
would require us to similarly diverge any dependent targets if we want
cross-language support.
As part of this change, we also had to switch from using the
FileDescriptor type to ParcelFileDescriptor, as this is the only type
supported outside of the framework JAR and is also the recommended
practice.
Test: Manual verification of basic soundtrigger functionality.
Change-Id: Ib65c19dd7c7f5433cfa527fa74bb61ac677f5cf5
`create_stubs: false` is the default behavior in soong as of
https://r.android.com/1380730
Test: m docs
Bug: 144248501
Bug: 143136634
Change-Id: If13de5c0a4071b032bc460f5c57e27819b33051d
Reason for revert: breaking several builds downstream
Reverted Changes:
Ia5767debc:Enable metalava sandbox in StubLibraries.bp and Ap...
I7256d29f1:Add sandbox property to the javadoc rule.
Ia69440800:Only report a violation when the file exists.
Change-Id: I5651212314fd39b7ba404936dee416f566c682c9
Avoids direct access to the stub sources and instead access them via
tags passed to the java_sdk_library.
Bug: 155164730
Test: m checkapi
Change-Id: I93dfb8bfac60bd7ab628292667c8d7a9d5e8eb82
There were two different filegroups referencing the same last released
APIs. Delete the manually defined one and switch references over to use
the one defined by prebuilt_apis.
Bug: 155197156
Test: m
Change-Id: Ib15d2c08e6400546ca03de6bfd4e5cbcc938c992
Merged-In: Ib15d2c08e6400546ca03de6bfd4e5cbcc938c992
SystemApi no longer has the process parameter. Fixing the last remaining
place where the parameter was still used.
Bug: 155531519
Test: m
Merged-In: I4b1395b3a6e17ff8ce634059f8787c1b6392b1b9
(cherry picked from commit 92514d5b71ab01f4c3ba3882b3acbee768c03671)
Change-Id: I4b1395b3a6e17ff8ce634059f8787c1b6392b1b9
These would cause these actions (and any that depended upon them) to
re-run during every incremental build. These now produce warnings:
ninja: output file missing after successful execution: out/soong/.intermediates/frameworks/base/ds-ref-navtree-docs/android_common/ds-ref-navtree-docs-proofrerad.txt
It turns out that the -proofread argument to doclava is ignored with the
following argument combinations:
* -static -devsite
* -navtreeonly
Test: m docs; m docs (nothing to do)
Change-Id: I21b939951f5a2f33914e9fc9414df8206091d262
Renamed conscrypt-module-public-api-stubs-source to
conscrypt.module.public.api.stubs.source to match the format of the
name created by java_sdk_library.
This is in preparation for switching to use java_sdk_library to
generate conscrypt's public API.
Bug: 153443117
Test: m nothing
Change-Id: I26ad21cf74ad3600de250df8e84deec65b91b3f9
Avoids an extra aggregation step in the creation of the API sources.
Test: m nothing
Bug: 142935992
Change-Id: Ia15c3ceb9fc59e7945687536c60ce265ec95781e
The ds-docs-switched genrule was producing 18947 lines of output,
including a single line with 266986 bytes. Quiet all the tools
used in the genrule.
Test: m ds-docs-switched
Change-Id: I5549c34f6310469e7791b56190d5b7c1f386a5f7
Add compat_config to offline SDK docs for now, to generate the
compatibility changes documentation.
Test: m -j offline-sdk-docs
Bug: 144927670
Change-Id: I856a0972212cb23ff97800243671e9c8280d5287
The new annotation replaces existing two annotations in libcore/ and frameworks/base/. This helps avoid human confusion and allows better and correct tool support.
Bug: 145132366
Test: m
Change-Id: I9078b124ddf0273250c645fe17f27088092c8b18
