Revert "Work around b/70221552"

This reverts commit 159799d7c971777231d17c0aabd60d36044ab331.

Reason for revert: b/70221552 is fixed

Change-Id: Iaae0df6736a3141847376b9ab0115f1c7a31fdb1
This commit is contained in:
Anton Hansson 2019-11-18 13:34:56 +00:00
parent 2cc5a85213
commit d82b2f7e4a
2 changed files with 10 additions and 36 deletions

View File

@ -520,24 +520,22 @@ gensrcs {
name: "framework-javastream-protos",
depfile: true,
tool_files: ["tools/genprotos.sh"],
tools: [
"aprotoc",
"protoc-gen-javastream",
"soong_zip",
],
// TODO This should not be needed. If you set a custom OUT_DIR or OUT_DIR_COMMON_BASE you can
// end up with a command that is extremely long, potentially going passed MAX_ARG_STRLEN due to
// the way sbox rewrites the command. See b/70221552.
cmd: "$(location tools/genprotos.sh) " +
" $(location aprotoc) " +
" $(location protoc-gen-javastream) " +
" $(location soong_zip) " +
" $(genDir) " +
" $(depfile) " +
" $(in) " +
" $(out)",
cmd: "mkdir -p $(genDir)/$(in) " +
"&& $(location aprotoc) " +
" --plugin=$(location protoc-gen-javastream) " +
" --dependency_out=$(depfile) " +
" --javastream_out=$(genDir)/$(in) " +
" -Iexternal/protobuf/src " +
" -I . " +
" $(in) " +
"&& $(location soong_zip) -jar -o $(out) -C $(genDir)/$(in) -D $(genDir)/$(in)",
srcs: [
"core/proto/**/*.proto",
"libs/incident/**/*.proto",

View File

@ -1,24 +0,0 @@
#!/bin/bash
# TODO This should not be needed. If you set a custom OUT_DIR or OUT_DIR_COMMON_BASE you can
# end up with a command that is extremely long, potentially going passed MAX_ARG_STRLEN due to
# the way sbox rewrites the command. See b/70221552.
set -e
location_aprotoc=$1
location_protoc=$2
location_soong_zip=$3
genDir=$4
depfile=$5
in=$6
out=$7
mkdir -p ${genDir}/${in} && \
${location_aprotoc} --plugin=${location_protoc} \
--dependency_out=${depfile} \
--javastream_out=${genDir}/${in} \
-Iexternal/protobuf/src \
-I . \
${in} && \
${location_soong_zip} -jar -o ${out} -C ${genDir}/${in} -D ${genDir}/${in}