From 325fb3e2aac104d7090dd4978356920875c61ee0 Mon Sep 17 00:00:00 2001
From: Cole Faust <colefaust@google.com>
Date: Mon, 29 Aug 2022 15:15:53 -0700
Subject: [PATCH] Fix module-file name collisions

Bazel doesn't allow a module and file with the same name.

Bug: 198619163
Test: m ime, verified it was still installed to out/target/product/emulator64_x86_64/system/bin/ime and not ime.sh
Change-Id: I214e190e159a7aff9149e77146d1a493992e885d
---
 cmds/abx/Android.bp                                        | 7 +++----
 cmds/abx/{abx => abx.sh}                                   | 0
 cmds/abx/{abx2xml => abx2xml.sh}                           | 0
 cmds/abx/{xml2abx => xml2abx.sh}                           | 0
 cmds/bmgr/Android.bp                                       | 2 +-
 cmds/bmgr/{bmgr => bmgr.sh}                                | 0
 cmds/bu/Android.bp                                         | 2 +-
 cmds/bu/{bu => bu.sh}                                      | 0
 cmds/content/Android.bp                                    | 2 +-
 cmds/content/{content => content.sh}                       | 0
 cmds/device_config/Android.bp                              | 2 +-
 cmds/device_config/{device_config => device_config.sh}     | 0
 cmds/dpm/Android.bp                                        | 2 +-
 cmds/dpm/{dpm => dpm.sh}                                   | 0
 cmds/hid/Android.bp                                        | 2 +-
 cmds/hid/{hid => hid.sh}                                   | 0
 cmds/ime/Android.bp                                        | 2 +-
 cmds/ime/{ime => ime.sh}                                   | 0
 cmds/input/Android.bp                                      | 2 +-
 cmds/input/{input => input.sh}                             | 0
 cmds/locksettings/Android.bp                               | 2 +-
 cmds/locksettings/{locksettings => locksettings.sh}        | 0
 cmds/pm/Android.bp                                         | 2 +-
 cmds/pm/{pm => pm.sh}                                      | 0
 cmds/requestsync/Android.bp                                | 2 +-
 cmds/requestsync/{requestsync => requestsync.sh}           | 0
 cmds/settings/Android.bp                                   | 2 +-
 cmds/settings/{settings => settings.sh}                    | 0
 cmds/sm/Android.bp                                         | 2 +-
 cmds/sm/{sm => sm.sh}                                      | 0
 cmds/svc/Android.bp                                        | 2 +-
 cmds/svc/{svc => svc.sh}                                   | 0
 cmds/telecom/Android.bp                                    | 2 +-
 cmds/telecom/{telecom => telecom.sh}                       | 0
 cmds/uiautomator/cmds/uiautomator/Android.bp               | 2 +-
 .../cmds/uiautomator/{uiautomator => uiautomator.sh}       | 0
 cmds/uinput/Android.bp                                     | 7 ++++---
 cmds/uinput/{uinput => uinput.sh}                          | 0
 cmds/vr/Android.bp                                         | 2 +-
 cmds/vr/{vr => vr.sh}                                      | 0
 cmds/wm/Android.bp                                         | 2 +-
 cmds/wm/{wm => wm.sh}                                      | 0
 42 files changed, 25 insertions(+), 25 deletions(-)
 rename cmds/abx/{abx => abx.sh} (100%)
 rename cmds/abx/{abx2xml => abx2xml.sh} (100%)
 rename cmds/abx/{xml2abx => xml2abx.sh} (100%)
 rename cmds/bmgr/{bmgr => bmgr.sh} (100%)
 rename cmds/bu/{bu => bu.sh} (100%)
 rename cmds/content/{content => content.sh} (100%)
 rename cmds/device_config/{device_config => device_config.sh} (100%)
 rename cmds/dpm/{dpm => dpm.sh} (100%)
 rename cmds/hid/{hid => hid.sh} (100%)
 rename cmds/ime/{ime => ime.sh} (100%)
 rename cmds/input/{input => input.sh} (100%)
 rename cmds/locksettings/{locksettings => locksettings.sh} (100%)
 rename cmds/pm/{pm => pm.sh} (100%)
 rename cmds/requestsync/{requestsync => requestsync.sh} (100%)
 rename cmds/settings/{settings => settings.sh} (100%)
 rename cmds/sm/{sm => sm.sh} (100%)
 rename cmds/svc/{svc => svc.sh} (100%)
 rename cmds/telecom/{telecom => telecom.sh} (100%)
 rename cmds/uiautomator/cmds/uiautomator/{uiautomator => uiautomator.sh} (100%)
 rename cmds/uinput/{uinput => uinput.sh} (100%)
 rename cmds/vr/{vr => vr.sh} (100%)
 rename cmds/wm/{wm => wm.sh} (100%)

diff --git a/cmds/abx/Android.bp b/cmds/abx/Android.bp
index 50a0b75b3276..a832dea20673 100644
--- a/cmds/abx/Android.bp
+++ b/cmds/abx/Android.bp
@@ -1,4 +1,3 @@
-
 package {
     default_applicable_licenses: ["frameworks_base_cmds_abx_license"],
 }
@@ -18,7 +17,7 @@ license {
 
 java_binary {
     name: "abx",
-    wrapper: "abx",
+    wrapper: "abx.sh",
     srcs: ["**/*.java"],
     required: [
         "abx2xml",
@@ -28,10 +27,10 @@ java_binary {
 
 sh_binary {
     name: "abx2xml",
-    src: "abx2xml",
+    src: "abx2xml.sh",
 }
 
 sh_binary {
     name: "xml2abx",
-    src: "xml2abx",
+    src: "xml2abx.sh",
 }
diff --git a/cmds/abx/abx b/cmds/abx/abx.sh
similarity index 100%
rename from cmds/abx/abx
rename to cmds/abx/abx.sh
diff --git a/cmds/abx/abx2xml b/cmds/abx/abx2xml.sh
similarity index 100%
rename from cmds/abx/abx2xml
rename to cmds/abx/abx2xml.sh
diff --git a/cmds/abx/xml2abx b/cmds/abx/xml2abx.sh
similarity index 100%
rename from cmds/abx/xml2abx
rename to cmds/abx/xml2abx.sh
diff --git a/cmds/bmgr/Android.bp b/cmds/bmgr/Android.bp
index 14beb5561dba..a85669a20e99 100644
--- a/cmds/bmgr/Android.bp
+++ b/cmds/bmgr/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "bmgr",
-    wrapper: "bmgr",
+    wrapper: "bmgr.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/bmgr/bmgr b/cmds/bmgr/bmgr.sh
similarity index 100%
rename from cmds/bmgr/bmgr
rename to cmds/bmgr/bmgr.sh
diff --git a/cmds/bu/Android.bp b/cmds/bu/Android.bp
index 5b4ec3197cdd..b61a7a6e6429 100644
--- a/cmds/bu/Android.bp
+++ b/cmds/bu/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "bu",
-    wrapper: "bu",
+    wrapper: "bu.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/bu/bu b/cmds/bu/bu.sh
similarity index 100%
rename from cmds/bu/bu
rename to cmds/bu/bu.sh
diff --git a/cmds/content/Android.bp b/cmds/content/Android.bp
index c70d01ec8f0b..0dd0f034e405 100644
--- a/cmds/content/Android.bp
+++ b/cmds/content/Android.bp
@@ -19,6 +19,6 @@ license {
 
 java_binary {
     name: "content",
-    wrapper: "content",
+    wrapper: "content.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/content/content b/cmds/content/content.sh
similarity index 100%
rename from cmds/content/content
rename to cmds/content/content.sh
diff --git a/cmds/device_config/Android.bp b/cmds/device_config/Android.bp
index 69572d8690c4..83b2730c874f 100644
--- a/cmds/device_config/Android.bp
+++ b/cmds/device_config/Android.bp
@@ -14,5 +14,5 @@ package {
 
 sh_binary {
     name: "device_config",
-    src: "device_config",
+    src: "device_config.sh",
 }
diff --git a/cmds/device_config/device_config b/cmds/device_config/device_config.sh
similarity index 100%
rename from cmds/device_config/device_config
rename to cmds/device_config/device_config.sh
diff --git a/cmds/dpm/Android.bp b/cmds/dpm/Android.bp
index 6819d0982d2c..29bee4958be6 100644
--- a/cmds/dpm/Android.bp
+++ b/cmds/dpm/Android.bp
@@ -20,5 +20,5 @@ license {
 
 sh_binary {
     name: "dpm",
-    src: "dpm",
+    src: "dpm.sh",
 }
diff --git a/cmds/dpm/dpm b/cmds/dpm/dpm.sh
similarity index 100%
rename from cmds/dpm/dpm
rename to cmds/dpm/dpm.sh
diff --git a/cmds/hid/Android.bp b/cmds/hid/Android.bp
index 295c71c65368..a6e27698e36c 100644
--- a/cmds/hid/Android.bp
+++ b/cmds/hid/Android.bp
@@ -20,7 +20,7 @@ license {
 
 java_binary {
     name: "hid",
-    wrapper: "hid",
+    wrapper: "hid.sh",
     srcs: ["**/*.java"],
     required: ["libhidcommand_jni"],
 }
diff --git a/cmds/hid/hid b/cmds/hid/hid.sh
similarity index 100%
rename from cmds/hid/hid
rename to cmds/hid/hid.sh
diff --git a/cmds/ime/Android.bp b/cmds/ime/Android.bp
index 6dd3ba1ca7ef..5f54ffacbb00 100644
--- a/cmds/ime/Android.bp
+++ b/cmds/ime/Android.bp
@@ -20,5 +20,5 @@ license {
 
 sh_binary {
     name: "ime",
-    src: "ime",
+    src: "ime.sh",
 }
diff --git a/cmds/ime/ime b/cmds/ime/ime.sh
similarity index 100%
rename from cmds/ime/ime
rename to cmds/ime/ime.sh
diff --git a/cmds/input/Android.bp b/cmds/input/Android.bp
index 2e30176971d7..8f44f3e34ef7 100644
--- a/cmds/input/Android.bp
+++ b/cmds/input/Android.bp
@@ -20,5 +20,5 @@ license {
 
 sh_binary {
     name: "input",
-    src: "input",
+    src: "input.sh",
 }
diff --git a/cmds/input/input b/cmds/input/input.sh
similarity index 100%
rename from cmds/input/input
rename to cmds/input/input.sh
diff --git a/cmds/locksettings/Android.bp b/cmds/locksettings/Android.bp
index 3869c8fcdabc..5ee582450361 100644
--- a/cmds/locksettings/Android.bp
+++ b/cmds/locksettings/Android.bp
@@ -23,6 +23,6 @@ package {
 
 java_binary {
     name: "locksettings",
-    wrapper: "locksettings",
+    wrapper: "locksettings.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/locksettings/locksettings b/cmds/locksettings/locksettings.sh
similarity index 100%
rename from cmds/locksettings/locksettings
rename to cmds/locksettings/locksettings.sh
diff --git a/cmds/pm/Android.bp b/cmds/pm/Android.bp
index 847dbabdf4c0..0e61a9e35d5e 100644
--- a/cmds/pm/Android.bp
+++ b/cmds/pm/Android.bp
@@ -20,5 +20,5 @@ license {
 
 sh_binary {
     name: "pm",
-    src: "pm",
+    src: "pm.sh",
 }
diff --git a/cmds/pm/pm b/cmds/pm/pm.sh
similarity index 100%
rename from cmds/pm/pm
rename to cmds/pm/pm.sh
diff --git a/cmds/requestsync/Android.bp b/cmds/requestsync/Android.bp
index 57e8dd355b26..8718f79c0d70 100644
--- a/cmds/requestsync/Android.bp
+++ b/cmds/requestsync/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "requestsync",
-    wrapper: "requestsync",
+    wrapper: "requestsync.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/requestsync/requestsync b/cmds/requestsync/requestsync.sh
similarity index 100%
rename from cmds/requestsync/requestsync
rename to cmds/requestsync/requestsync.sh
diff --git a/cmds/settings/Android.bp b/cmds/settings/Android.bp
index cc730062f9df..8180fd6cab61 100644
--- a/cmds/settings/Android.bp
+++ b/cmds/settings/Android.bp
@@ -14,5 +14,5 @@ package {
 
 sh_binary {
     name: "settings",
-    src: "settings",
+    src: "settings.sh",
 }
diff --git a/cmds/settings/settings b/cmds/settings/settings.sh
similarity index 100%
rename from cmds/settings/settings
rename to cmds/settings/settings.sh
diff --git a/cmds/sm/Android.bp b/cmds/sm/Android.bp
index ecfacaeecfd9..403022a2d2ae 100644
--- a/cmds/sm/Android.bp
+++ b/cmds/sm/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "sm",
-    wrapper: "sm",
+    wrapper: "sm.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/sm/sm b/cmds/sm/sm.sh
similarity index 100%
rename from cmds/sm/sm
rename to cmds/sm/sm.sh
diff --git a/cmds/svc/Android.bp b/cmds/svc/Android.bp
index 41a3ebd2f514..a2460875f28e 100644
--- a/cmds/svc/Android.bp
+++ b/cmds/svc/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "svc",
-    wrapper: "svc",
+    wrapper: "svc.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/svc/svc b/cmds/svc/svc.sh
similarity index 100%
rename from cmds/svc/svc
rename to cmds/svc/svc.sh
diff --git a/cmds/telecom/Android.bp b/cmds/telecom/Android.bp
index 4da79c54477b..be027105ae98 100644
--- a/cmds/telecom/Android.bp
+++ b/cmds/telecom/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "telecom",
-    wrapper: "telecom",
+    wrapper: "telecom.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/telecom/telecom b/cmds/telecom/telecom.sh
similarity index 100%
rename from cmds/telecom/telecom
rename to cmds/telecom/telecom.sh
diff --git a/cmds/uiautomator/cmds/uiautomator/Android.bp b/cmds/uiautomator/cmds/uiautomator/Android.bp
index 56e2e70958fa..51323860725b 100644
--- a/cmds/uiautomator/cmds/uiautomator/Android.bp
+++ b/cmds/uiautomator/cmds/uiautomator/Android.bp
@@ -25,7 +25,7 @@ package {
 
 java_binary {
     name: "uiautomator",
-    wrapper: "uiautomator",
+    wrapper: "uiautomator.sh",
     srcs: ["src/**/*.java"],
     static_libs: ["uiautomator.core"],
 }
diff --git a/cmds/uiautomator/cmds/uiautomator/uiautomator b/cmds/uiautomator/cmds/uiautomator/uiautomator.sh
similarity index 100%
rename from cmds/uiautomator/cmds/uiautomator/uiautomator
rename to cmds/uiautomator/cmds/uiautomator/uiautomator.sh
diff --git a/cmds/uinput/Android.bp b/cmds/uinput/Android.bp
index 260cfc781ebc..4b08d968ac4a 100644
--- a/cmds/uinput/Android.bp
+++ b/cmds/uinput/Android.bp
@@ -20,9 +20,10 @@ license {
 
 java_binary {
     name: "uinput",
-    wrapper: "uinput",
-    srcs: ["**/*.java",
-           ":uinputcommand_aidl"
+    wrapper: "uinput.sh",
+    srcs: [
+        "**/*.java",
+        ":uinputcommand_aidl",
     ],
     required: ["libuinputcommand_jni"],
 }
diff --git a/cmds/uinput/uinput b/cmds/uinput/uinput.sh
similarity index 100%
rename from cmds/uinput/uinput
rename to cmds/uinput/uinput.sh
diff --git a/cmds/vr/Android.bp b/cmds/vr/Android.bp
index 893649155fd8..61795b4cc052 100644
--- a/cmds/vr/Android.bp
+++ b/cmds/vr/Android.bp
@@ -20,6 +20,6 @@ license {
 
 java_binary {
     name: "vr",
-    wrapper: "vr",
+    wrapper: "vr.sh",
     srcs: ["**/*.java"],
 }
diff --git a/cmds/vr/vr b/cmds/vr/vr.sh
similarity index 100%
rename from cmds/vr/vr
rename to cmds/vr/vr.sh
diff --git a/cmds/wm/Android.bp b/cmds/wm/Android.bp
index cf6b0193fe87..4d00f175211d 100644
--- a/cmds/wm/Android.bp
+++ b/cmds/wm/Android.bp
@@ -20,5 +20,5 @@ license {
 
 sh_binary {
     name: "wm",
-    src: "wm",
+    src: "wm.sh",
 }
diff --git a/cmds/wm/wm b/cmds/wm/wm.sh
similarity index 100%
rename from cmds/wm/wm
rename to cmds/wm/wm.sh