From 51e71dc94633e4b3d6c544215888b1bbd7e43d60 Mon Sep 17 00:00:00 2001
From: Lucas Dupin <dupin@google.com>
Date: Fri, 29 Oct 2021 18:00:28 +0000
Subject: [PATCH] Revert "Do not show side fingerprint sensor overlay when used
 from settings."

This reverts commit 42004250c21623dbfd29a16b7eafcb1ff6b9c650.

Reason for revert: b/204524711

Change-Id: I57ff00e30e72852a4eb894d3302730616a22ae8e
---
 .../biometrics/BiometricOverlayConstants.java        |  5 +----
 .../android/systemui/biometrics/SidefpsController.kt |  2 --
 .../systemui/biometrics/SidefpsControllerTest.kt     | 12 +-----------
 .../biometrics/sensors/AuthenticationClient.java     |  6 ------
 4 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/core/java/android/hardware/biometrics/BiometricOverlayConstants.java b/core/java/android/hardware/biometrics/BiometricOverlayConstants.java
index 065ae64a92ad..603b06ddabaa 100644
--- a/core/java/android/hardware/biometrics/BiometricOverlayConstants.java
+++ b/core/java/android/hardware/biometrics/BiometricOverlayConstants.java
@@ -38,16 +38,13 @@ public interface BiometricOverlayConstants {
     int REASON_AUTH_KEYGUARD = 4;
     /** Non-specific usage (from FingerprintManager). */
     int REASON_AUTH_OTHER = 5;
-    /** Usage from Settings. */
-    int REASON_AUTH_SETTINGS = 6;
 
     @IntDef({REASON_UNKNOWN,
             REASON_ENROLL_FIND_SENSOR,
             REASON_ENROLL_ENROLLING,
             REASON_AUTH_BP,
             REASON_AUTH_KEYGUARD,
-            REASON_AUTH_OTHER,
-            REASON_AUTH_SETTINGS})
+            REASON_AUTH_OTHER})
     @Retention(RetentionPolicy.SOURCE)
     @interface ShowReason {}
 }
diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/SidefpsController.kt b/packages/SystemUI/src/com/android/systemui/biometrics/SidefpsController.kt
index e2a2d07bdf35..b7398d86c16e 100644
--- a/packages/SystemUI/src/com/android/systemui/biometrics/SidefpsController.kt
+++ b/packages/SystemUI/src/com/android/systemui/biometrics/SidefpsController.kt
@@ -22,7 +22,6 @@ import android.graphics.PorterDuffColorFilter
 import android.graphics.Rect
 import android.hardware.biometrics.BiometricOverlayConstants
 import android.hardware.biometrics.BiometricOverlayConstants.REASON_AUTH_KEYGUARD
-import android.hardware.biometrics.BiometricOverlayConstants.REASON_AUTH_SETTINGS
 import android.hardware.display.DisplayManager
 import android.hardware.fingerprint.FingerprintManager
 import android.hardware.fingerprint.FingerprintSensorPropertiesInternal
@@ -182,7 +181,6 @@ class SidefpsController @Inject constructor(
 @BiometricOverlayConstants.ShowReason
 private fun Int.isReasonToShow(): Boolean = when (this) {
     REASON_AUTH_KEYGUARD -> false
-    REASON_AUTH_SETTINGS -> false
     else -> true
 }
 
diff --git a/packages/SystemUI/tests/src/com/android/systemui/biometrics/SidefpsControllerTest.kt b/packages/SystemUI/tests/src/com/android/systemui/biometrics/SidefpsControllerTest.kt
index ca7d506dcc78..5fee7fbf8705 100644
--- a/packages/SystemUI/tests/src/com/android/systemui/biometrics/SidefpsControllerTest.kt
+++ b/packages/SystemUI/tests/src/com/android/systemui/biometrics/SidefpsControllerTest.kt
@@ -18,7 +18,6 @@ package com.android.systemui.biometrics
 
 import android.graphics.Rect
 import android.hardware.biometrics.BiometricOverlayConstants.REASON_AUTH_KEYGUARD
-import android.hardware.biometrics.BiometricOverlayConstants.REASON_AUTH_SETTINGS
 import android.hardware.biometrics.BiometricOverlayConstants.REASON_UNKNOWN
 import android.hardware.biometrics.SensorProperties
 import android.hardware.display.DisplayManager
@@ -183,16 +182,7 @@ class SidefpsControllerTest : SysuiTestCase() {
 
     @Test
     fun testIgnoredForKeyguard() {
-        testIgnoredFor(REASON_AUTH_KEYGUARD)
-    }
-
-    @Test
-    fun testIgnoredForSettings() {
-        testIgnoredFor(REASON_AUTH_SETTINGS)
-    }
-
-    private fun testIgnoredFor(reason: Int) {
-        overlayController.show(SENSOR_ID, reason)
+        overlayController.show(SENSOR_ID, REASON_AUTH_KEYGUARD)
         executor.runAllReady()
 
         verify(windowManager, never()).addView(any(), any())
diff --git a/services/core/java/com/android/server/biometrics/sensors/AuthenticationClient.java b/services/core/java/com/android/server/biometrics/sensors/AuthenticationClient.java
index 61b8ded60db7..031f6eeeca5f 100644
--- a/services/core/java/com/android/server/biometrics/sensors/AuthenticationClient.java
+++ b/services/core/java/com/android/server/biometrics/sensors/AuthenticationClient.java
@@ -168,10 +168,6 @@ public abstract class AuthenticationClient<T> extends AcquisitionClient<T>
         return Utils.isKeyguard(getContext(), getOwnerString());
     }
 
-    private boolean isSettings() {
-        return Utils.isSettings(getContext(), getOwnerString());
-    }
-
     @Override
     protected boolean isCryptoOperation() {
         return mOperationId != 0;
@@ -503,8 +499,6 @@ public abstract class AuthenticationClient<T> extends AcquisitionClient<T>
     protected int getShowOverlayReason() {
         if (isKeyguard()) {
             return BiometricOverlayConstants.REASON_AUTH_KEYGUARD;
-        } else if (isSettings()) {
-            return BiometricOverlayConstants.REASON_AUTH_SETTINGS;
         } else if (isBiometricPrompt()) {
             return BiometricOverlayConstants.REASON_AUTH_BP;
         } else {