drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Prevent modifying mAudioPolicies during iteration"

Browse Source
This commit is contained in:
Treehugger Robot 2022-09-12 21:50:52 +00:00 committed by Gerrit Code Review
commit aded52644c
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
services/core/java/com/android/server/audio/AudioService.java
View File

@ -1517,6 +1517,7 @@ public class AudioService extends IAudioService.Stub
} }
synchronized (mAudioPolicies) { synchronized (mAudioPolicies) {
ArrayList<AudioPolicyProxy> invalidProxies = new ArrayList<>();
for (AudioPolicyProxy policy : mAudioPolicies.values()) { for (AudioPolicyProxy policy : mAudioPolicies.values()) {
final int status = policy.connectMixes(); final int status = policy.connectMixes();
if (status != AudioSystem.SUCCESS) { if (status != AudioSystem.SUCCESS) {
@ -1524,7 +1525,7 @@ public class AudioService extends IAudioService.Stub
Log.e(TAG, "onAudioServerDied: error " Log.e(TAG, "onAudioServerDied: error "
+ AudioSystem.audioSystemErrorToString(status) + AudioSystem.audioSystemErrorToString(status)
+ " when connecting mixes for policy " + policy.toLogFriendlyString()); + " when connecting mixes for policy " + policy.toLogFriendlyString());
policy.release(); invalidProxies.add(policy);
} else { } else {
final int deviceAffinitiesStatus = policy.setupDeviceAffinities(); final int deviceAffinitiesStatus = policy.setupDeviceAffinities();
if (deviceAffinitiesStatus != AudioSystem.SUCCESS) { if (deviceAffinitiesStatus != AudioSystem.SUCCESS) {
@ -1532,10 +1533,12 @@ public class AudioService extends IAudioService.Stub
+ AudioSystem.audioSystemErrorToString(deviceAffinitiesStatus) + AudioSystem.audioSystemErrorToString(deviceAffinitiesStatus)
+ " when connecting device affinities for policy " + " when connecting device affinities for policy "
+ policy.toLogFriendlyString()); + policy.toLogFriendlyString());
policy.release(); invalidProxies.add(policy);
} }
} }
} }
invalidProxies.forEach((policy) -> policy.release());
} }
// Restore capture policies // Restore capture policies