drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Further defer loading widgets until it is absolutely needed.

Browse Source 
Current implementation parses the provider info from all manifests in
every app the first time getInstalledProvidersForProfile is called,
which causes unnecessary delay on the call-site if only a single package
was requested.

This CL ensures widgets loading are deferred further down the line,
until it is absolutely needed to be parsed.

Bug: 202356231
Test: manual
Change-Id: I793bd818781ae956cd5bc590a315c669d01e7ca6
This commit is contained in:
Pinyao Ting 2022-03-21 20:11:58 -07:00
parent 286fd132d6
commit 9c2cb7e257
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java
View File

@ -1617,14 +1617,17 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
final int providerCount = mProviders.size();
for (int i = 0; i < providerCount; i++) {
Provider provider = mProviders.get(i);
AppWidgetProviderInfo info = provider.getInfoLocked(mContext);
final String providerPackageName = provider.id.componentName.getPackageName();
// Ignore an invalid provider, one not matching the filter,
// or one that isn't in the given package, if any.
boolean inPackage = packageName == null
|| providerPackageName.equals(packageName);
if (provider.zombie || (info.widgetCategory & categoryFilter) == 0 || !inPackage) {
// Ignore an invalid provider or one that isn't in the given package, if any.
boolean inPackage = packageName == null || providerPackageName.equals(packageName);
if (provider.zombie || !inPackage) {
continue;
}
// Ignore the ones not matching the filter.
AppWidgetProviderInfo info = provider.getInfoLocked(mContext);
if ((info.widgetCategory & categoryFilter) == 0) {
continue;
}