Don't apply fancy back logic when drawer is not present.
Add test coverage. Booya! Bug: 27078649 Change-Id: Id2ce53009ee212b3af8d143091859d30e2bc76b1
This commit is contained in:
@ -539,7 +539,8 @@ public abstract class BaseActivity extends Activity
|
|||||||
// Do some "do what a I want" drawer fiddling, but don't
|
// Do some "do what a I want" drawer fiddling, but don't
|
||||||
// do it if user already hit back recently and we recently
|
// do it if user already hit back recently and we recently
|
||||||
// did some fiddling.
|
// did some fiddling.
|
||||||
if ((System.currentTimeMillis() - mDrawerLastFiddled) > DRAWER_NO_FIDDLE_DELAY) {
|
if (mDrawer.isPresent()
|
||||||
|
&& (System.currentTimeMillis() - mDrawerLastFiddled) > DRAWER_NO_FIDDLE_DELAY) {
|
||||||
// Close drawer if it is open.
|
// Close drawer if it is open.
|
||||||
if (mDrawer.isOpen()) {
|
if (mDrawer.isOpen()) {
|
||||||
mDrawer.setOpen(false);
|
mDrawer.setOpen(false);
|
||||||
|
@ -16,35 +16,18 @@
|
|||||||
|
|
||||||
package com.android.documentsui;
|
package com.android.documentsui;
|
||||||
|
|
||||||
import static com.android.documentsui.StubProvider.DEFAULT_AUTHORITY;
|
|
||||||
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
||||||
|
|
||||||
import android.app.Instrumentation;
|
|
||||||
import android.content.ContentProviderClient;
|
|
||||||
import android.content.ContentResolver;
|
|
||||||
import android.content.Context;
|
|
||||||
import android.content.Intent;
|
import android.content.Intent;
|
||||||
import android.os.RemoteException;
|
import android.os.RemoteException;
|
||||||
import android.provider.DocumentsContract;
|
import android.provider.DocumentsContract;
|
||||||
import android.support.test.uiautomator.By;
|
import android.support.test.uiautomator.By;
|
||||||
import android.support.test.uiautomator.Configurator;
|
|
||||||
import android.support.test.uiautomator.UiDevice;
|
|
||||||
import android.support.test.uiautomator.Until;
|
import android.support.test.uiautomator.Until;
|
||||||
import android.test.ActivityInstrumentationTestCase2;
|
|
||||||
import android.test.suitebuilder.annotation.LargeTest;
|
import android.test.suitebuilder.annotation.LargeTest;
|
||||||
import android.util.Log;
|
|
||||||
import android.view.MotionEvent;
|
|
||||||
|
|
||||||
import com.android.documentsui.model.RootInfo;
|
|
||||||
|
|
||||||
@LargeTest
|
@LargeTest
|
||||||
public class DownloadsActivityUiTest extends ActivityTest<DownloadsActivity> {
|
public class DownloadsActivityUiTest extends ActivityTest<DownloadsActivity> {
|
||||||
|
|
||||||
private static final int TIMEOUT = 5000;
|
|
||||||
private static final String TAG = "DownloadsActivityUiTest";
|
|
||||||
private static final String TARGET_PKG = "com.android.documentsui";
|
|
||||||
private static final String LAUNCHER_PKG = "com.android.launcher";
|
|
||||||
|
|
||||||
public DownloadsActivityUiTest() {
|
public DownloadsActivityUiTest() {
|
||||||
super(DownloadsActivity.class);
|
super(DownloadsActivity.class);
|
||||||
}
|
}
|
||||||
@ -108,4 +91,11 @@ public class DownloadsActivityUiTest extends ActivityTest<DownloadsActivity> {
|
|||||||
device.waitForIdle();
|
device.waitForIdle();
|
||||||
assertNotNull(bot.menuShare());
|
assertNotNull(bot.menuShare());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public void testClosesOnBack() throws Exception {
|
||||||
|
DownloadsActivity activity = getActivity();
|
||||||
|
device.pressBack();
|
||||||
|
device.wait(Until.gone(By.text(ROOT_0_ID)), TIMEOUT); // wait for the window to go away
|
||||||
|
assertTrue(activity.isDestroyed());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
@ -16,34 +16,15 @@
|
|||||||
|
|
||||||
package com.android.documentsui;
|
package com.android.documentsui;
|
||||||
|
|
||||||
import static com.android.documentsui.StubProvider.DEFAULT_AUTHORITY;
|
|
||||||
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
||||||
import static com.android.documentsui.StubProvider.ROOT_1_ID;
|
import static com.android.documentsui.StubProvider.ROOT_1_ID;
|
||||||
|
|
||||||
import android.app.Instrumentation;
|
|
||||||
import android.content.ContentProviderClient;
|
|
||||||
import android.content.ContentResolver;
|
|
||||||
import android.content.Context;
|
|
||||||
import android.content.Intent;
|
|
||||||
import android.os.RemoteException;
|
import android.os.RemoteException;
|
||||||
import android.support.test.uiautomator.By;
|
|
||||||
import android.support.test.uiautomator.Configurator;
|
|
||||||
import android.support.test.uiautomator.UiDevice;
|
|
||||||
import android.support.test.uiautomator.Until;
|
|
||||||
import android.test.suitebuilder.annotation.LargeTest;
|
import android.test.suitebuilder.annotation.LargeTest;
|
||||||
import android.util.Log;
|
|
||||||
import android.view.MotionEvent;
|
|
||||||
|
|
||||||
import com.android.documentsui.model.RootInfo;
|
|
||||||
|
|
||||||
@LargeTest
|
@LargeTest
|
||||||
public class FilesActivityUiTest extends ActivityTest<FilesActivity> {
|
public class FilesActivityUiTest extends ActivityTest<FilesActivity> {
|
||||||
|
|
||||||
private static final int TIMEOUT = 5000;
|
|
||||||
private static final String TAG = "FilesActivityUiTest";
|
|
||||||
private static final String TARGET_PKG = "com.android.documentsui";
|
|
||||||
private static final String LAUNCHER_PKG = "com.android.launcher";
|
|
||||||
|
|
||||||
public FilesActivityUiTest() {
|
public FilesActivityUiTest() {
|
||||||
super(FilesActivity.class);
|
super(FilesActivity.class);
|
||||||
}
|
}
|
||||||
|
@ -18,9 +18,6 @@ package com.android.documentsui;
|
|||||||
|
|
||||||
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
||||||
|
|
||||||
import android.support.test.uiautomator.UiObject;
|
|
||||||
import android.support.test.uiautomator.UiObjectNotFoundException;
|
|
||||||
import android.test.InstrumentationTestCase;
|
|
||||||
import android.test.suitebuilder.annotation.LargeTest;
|
import android.test.suitebuilder.annotation.LargeTest;
|
||||||
|
|
||||||
@LargeTest
|
@LargeTest
|
||||||
|
@ -19,8 +19,6 @@ package com.android.documentsui;
|
|||||||
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
import static com.android.documentsui.StubProvider.ROOT_0_ID;
|
||||||
import static com.android.documentsui.StubProvider.ROOT_1_ID;
|
import static com.android.documentsui.StubProvider.ROOT_1_ID;
|
||||||
|
|
||||||
import android.support.test.uiautomator.UiObject;
|
|
||||||
import android.test.InstrumentationTestCase;
|
|
||||||
import android.test.suitebuilder.annotation.LargeTest;
|
import android.test.suitebuilder.annotation.LargeTest;
|
||||||
|
|
||||||
@LargeTest
|
@LargeTest
|
||||||
|
@ -21,6 +21,7 @@ import static junit.framework.Assert.assertNotNull;
|
|||||||
import static junit.framework.Assert.assertTrue;
|
import static junit.framework.Assert.assertTrue;
|
||||||
import static junit.framework.Assert.assertFalse;
|
import static junit.framework.Assert.assertFalse;
|
||||||
|
|
||||||
|
import android.app.Activity;
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
import android.support.test.uiautomator.By;
|
import android.support.test.uiautomator.By;
|
||||||
import android.support.test.uiautomator.BySelector;
|
import android.support.test.uiautomator.BySelector;
|
||||||
|
Reference in New Issue
Block a user