drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

am d8d60da6: Merge "Update DownloadManager API to support bulk actions." into gingerbread

Browse Source 
Merge commit 'd8d60da616343b3520b666c385d0005db860be83' into gingerbread-plus-aosp

* commit 'd8d60da616343b3520b666c385d0005db860be83':
  Update DownloadManager API to support bulk actions.
This commit is contained in:
Steve Howard
2010-10-08 14:44:42 -07:00
committed by Android Git Automerger
parent d7d47941a9 d8d60da616
commit 7c08b70c96
2 changed files with 68 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api/current.xml
View File

@ -24561,7 +24561,7 @@
</parameter>
</method>
<method name="remove"
return="void"
return="int"
abstract="false"
native="false"
synchronized="false"
@ -24570,7 +24570,7 @@
deprecated="not deprecated"
visibility="public"
>
<parameter name="id" type="long">
<parameter name="ids" type="long...">
</parameter>
</method>
<field name="ACTION_DOWNLOAD_COMPLETE"
@ -24963,7 +24963,7 @@
deprecated="not deprecated"
visibility="public"
>
<parameter name="id" type="long">
<parameter name="ids" type="long...">
</parameter>
</method>
<method name="setFilterByStatus"

90
core/java/android/app/DownloadManager.java
View File

@ -567,18 +567,18 @@ public class DownloadManager {
*/
public static final int ORDER_DESCENDING = 2;
private Long mId = null;
private long[] mIds = null;
private Integer mStatusFlags = null;
private String mOrderByColumn = Downloads.COLUMN_LAST_MODIFICATION;
private int mOrderDirection = ORDER_DESCENDING;
private boolean mOnlyIncludeVisibleInDownloadsUi = false;
/**
* Include only the download with the given ID.
* Include only the downloads with the given IDs.
* @return this object
*/
public Query setFilterById(long id) {
mId = id;
public Query setFilterById(long... ids) {
mIds = ids;
return this;
}
@ -639,9 +639,11 @@ public class DownloadManager {
Cursor runQuery(ContentResolver resolver, String[] projection, Uri baseUri) {
Uri uri = baseUri;
List<String> selectionParts = new ArrayList<String>();
String[] selectionArgs = null;
if (mId != null) {
uri = ContentUris.withAppendedId(uri, mId);
if (mIds != null) {
selectionParts.add(getWhereClauseForIds(mIds));
selectionArgs = getWhereArgsForIds(mIds);
}
if (mStatusFlags != null) {
@ -676,7 +678,7 @@ public class DownloadManager {
String orderDirection = (mOrderDirection == ORDER_ASCENDING ? "ASC" : "DESC");
String orderBy = mOrderByColumn + " " + orderDirection;
return resolver.query(uri, projection, selection, null, orderBy);
return resolver.query(uri, projection, selection, selectionArgs, orderBy);
}
private String joinStrings(String joiner, Iterable<String> parts) {
@ -738,17 +740,28 @@ public class DownloadManager {
}
/**
* Cancel a download and remove it from the download manager. The download will be stopped if
* Cancel downloads and remove them from the download manager. Each download will be stopped if
* it was running, and it will no longer be accessible through the download manager. If a file
* was already downloaded, it will not be deleted.
* was already downloaded to external storage, it will not be deleted.
*
* @param id the ID of the download
* @param ids the IDs of the downloads to remove
* @return the number of downloads actually removed
*/
public void remove(long id) {
int numDeleted = mResolver.delete(getDownloadUri(id), null, null);
if (numDeleted == 0) {
throw new IllegalArgumentException("Download " + id + " does not exist");
public int remove(long... ids) {
StringBuilder whereClause = new StringBuilder();
String[] whereArgs = new String[ids.length];
whereClause.append(Downloads.Impl._ID + " IN (");
for (int i = 0; i < ids.length; i++) {
if (i > 0) {
whereClause.append(",");
}
whereClause.append("?");
whereArgs[i] = Long.toString(ids[i]);
}
whereClause.append(")");
return mResolver.delete(mBaseUri, whereClause.toString(), whereArgs);
}
/**
@ -776,20 +789,20 @@ public class DownloadManager {
}
/**
* Restart the given download, which must have already completed (successfully or not). This
* Restart the given downloads, which must have already completed (successfully or not). This
* method will only work when called from within the download manager's process.
* @param id the ID of the download
* @param ids the IDs of the downloads
* @hide
*/
public void restartDownload(long id) {
Cursor cursor = query(new Query().setFilterById(id));
public void restartDownload(long... ids) {
Cursor cursor = query(new Query().setFilterById(ids));
try {
if (!cursor.moveToFirst()) {
throw new IllegalArgumentException("No download with id " + id);
}
int status = cursor.getInt(cursor.getColumnIndex(COLUMN_STATUS));
if (status != STATUS_SUCCESSFUL && status != STATUS_FAILED) {
throw new IllegalArgumentException("Cannot restart incomplete download: " + id);
for (cursor.moveToFirst(); !cursor.isAfterLast(); cursor.moveToNext()) {
int status = cursor.getInt(cursor.getColumnIndex(COLUMN_STATUS));
if (status != STATUS_SUCCESSFUL && status != STATUS_FAILED) {
throw new IllegalArgumentException("Cannot restart incomplete download: "
+ cursor.getLong(cursor.getColumnIndex(COLUMN_ID)));
}
}
} finally {
cursor.close();
@ -800,7 +813,7 @@ public class DownloadManager {
values.put(Downloads.Impl.COLUMN_TOTAL_BYTES, -1);
values.putNull(Downloads.Impl._DATA);
values.put(Downloads.Impl.COLUMN_STATUS, Downloads.Impl.STATUS_PENDING);
mResolver.update(getDownloadUri(id), values, null, null);
mResolver.update(mBaseUri, values, getWhereClauseForIds(ids), getWhereArgsForIds(ids));
}
/**
@ -810,6 +823,33 @@ public class DownloadManager {
return ContentUris.withAppendedId(mBaseUri, id);
}
/**
* Get a parameterized SQL WHERE clause to select a bunch of IDs.
*/
static String getWhereClauseForIds(long[] ids) {
StringBuilder whereClause = new StringBuilder();
whereClause.append(Downloads.Impl._ID + " IN (");
for (int i = 0; i < ids.length; i++) {
if (i > 0) {
whereClause.append(",");
}
whereClause.append("?");
}
whereClause.append(")");
return whereClause.toString();
}
/**
* Get the selection args for a clause returned by {@link #getWhereClauseForIds(long[])}.
*/
static String[] getWhereArgsForIds(long[] ids) {
String[] whereArgs = new String[ids.length];
for (int i = 0; i < ids.length; i++) {
whereArgs[i] = Long.toString(ids[i]);
}
return whereArgs;
}
/**
* This class wraps a cursor returned by DownloadProvider -- the "underlying cursor" -- and
* presents a different set of columns, those defined in the DownloadManager.COLUMN_* constants.