Merge "WiFi Calling: Show different operator name string in Data usage dialog." into lmp-mr1-wfc-dev

This commit is contained in:
Pavel Zhamaitsiak
2015-03-27 22:14:29 +00:00
committed by Android (Google) Code Review
5 changed files with 30 additions and 5 deletions

View File

@ -255,6 +255,8 @@
<string-array name="wfcOperatorErrorNotificationMessages" /> <string-array name="wfcOperatorErrorNotificationMessages" />
<!-- Template for showing cellular network operator name while WFC is active --> <!-- Template for showing cellular network operator name while WFC is active -->
<string name="wfcSpnFormat">%s</string> <string name="wfcSpnFormat">%s</string>
<!-- Template for showing operator name for data connection while WFC is active -->
<string name="wfcDataSpnFormat">%s</string>
<!-- WFC, summary for Disabled --> <!-- WFC, summary for Disabled -->
<string name="wifi_calling_off_summary">Off</string> <string name="wifi_calling_off_summary">Off</string>
<!-- WFC, summary for Wi-Fi Preferred --> <!-- WFC, summary for Wi-Fi Preferred -->

View File

@ -750,6 +750,7 @@
<java-symbol type="array" name="wfcOperatorErrorAlertMessages" /> <java-symbol type="array" name="wfcOperatorErrorAlertMessages" />
<java-symbol type="array" name="wfcOperatorErrorNotificationMessages" /> <java-symbol type="array" name="wfcOperatorErrorNotificationMessages" />
<java-symbol type="string" name="wfcSpnFormat" /> <java-symbol type="string" name="wfcSpnFormat" />
<java-symbol type="string" name="wfcDataSpnFormat" />
<java-symbol type="string" name="wifi_calling_off_summary" /> <java-symbol type="string" name="wifi_calling_off_summary" />
<java-symbol type="string" name="wfc_mode_wifi_preferred_summary" /> <java-symbol type="string" name="wfc_mode_wifi_preferred_summary" />
<java-symbol type="string" name="wfc_mode_cellular_preferred_summary" /> <java-symbol type="string" name="wfc_mode_cellular_preferred_summary" />

View File

@ -162,7 +162,7 @@ public class MobileDataControllerImpl implements NetworkController.MobileDataCon
usage.warningLevel = DEFAULT_WARNING_LEVEL; usage.warningLevel = DEFAULT_WARNING_LEVEL;
} }
if (usage != null) { if (usage != null) {
usage.carrier = mNetworkController.getMobileNetworkName(); usage.carrier = mNetworkController.getMobileDataNetworkName();
} }
return usage; return usage;
} catch (RemoteException e) { } catch (RemoteException e) {

View File

@ -277,9 +277,9 @@ public class NetworkControllerImpl extends BroadcastReceiver
return mDefaultSignalController; return mDefaultSignalController;
} }
public String getMobileNetworkName() { public String getMobileDataNetworkName() {
MobileSignalController controller = getDataController(); MobileSignalController controller = getDataController();
return controller != null ? controller.getState().networkName : ""; return controller != null ? controller.getState().networkNameData : "";
} }
public boolean isEmergencyOnly() { public boolean isEmergencyOnly() {
@ -1039,6 +1039,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
mapIconSets(); mapIconSets();
mLastState.networkName = mCurrentState.networkName = mNetworkNameDefault; mLastState.networkName = mCurrentState.networkName = mNetworkNameDefault;
mLastState.networkNameData = mCurrentState.networkNameData = mNetworkNameDefault;
mLastState.enabled = mCurrentState.enabled = hasMobileData; mLastState.enabled = mCurrentState.enabled = hasMobileData;
mLastState.iconGroup = mCurrentState.iconGroup = mDefaultIcons; mLastState.iconGroup = mCurrentState.iconGroup = mDefaultIcons;
// Get initial data sim state. // Get initial data sim state.
@ -1274,6 +1275,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
if (action.equals(TelephonyIntents.SPN_STRINGS_UPDATED_ACTION)) { if (action.equals(TelephonyIntents.SPN_STRINGS_UPDATED_ACTION)) {
updateNetworkName(intent.getBooleanExtra(TelephonyIntents.EXTRA_SHOW_SPN, false), updateNetworkName(intent.getBooleanExtra(TelephonyIntents.EXTRA_SHOW_SPN, false),
intent.getStringExtra(TelephonyIntents.EXTRA_SPN), intent.getStringExtra(TelephonyIntents.EXTRA_SPN),
intent.getStringExtra(TelephonyIntents.EXTRA_DATA_SPN),
intent.getBooleanExtra(TelephonyIntents.EXTRA_SHOW_PLMN, false), intent.getBooleanExtra(TelephonyIntents.EXTRA_SHOW_PLMN, false),
intent.getStringExtra(TelephonyIntents.EXTRA_PLMN)); intent.getStringExtra(TelephonyIntents.EXTRA_PLMN));
notifyListenersIfNecessary(); notifyListenersIfNecessary();
@ -1302,14 +1304,18 @@ public class NetworkControllerImpl extends BroadcastReceiver
/** /**
* Updates the network's name based on incoming spn and plmn. * Updates the network's name based on incoming spn and plmn.
*/ */
void updateNetworkName(boolean showSpn, String spn, boolean showPlmn, String plmn) { void updateNetworkName(boolean showSpn, String spn, String dataSpn,
boolean showPlmn, String plmn) {
if (CHATTY) { if (CHATTY) {
Log.d("CarrierLabel", "updateNetworkName showSpn=" + showSpn + " spn=" + spn Log.d("CarrierLabel", "updateNetworkName showSpn=" + showSpn
+ " spn=" + spn + " dataSpn=" + dataSpn
+ " showPlmn=" + showPlmn + " plmn=" + plmn); + " showPlmn=" + showPlmn + " plmn=" + plmn);
} }
StringBuilder str = new StringBuilder(); StringBuilder str = new StringBuilder();
StringBuilder strData = new StringBuilder();
if (showPlmn && plmn != null) { if (showPlmn && plmn != null) {
str.append(plmn); str.append(plmn);
strData.append(plmn);
} }
if (showSpn && spn != null) { if (showSpn && spn != null) {
if (str.length() != 0) { if (str.length() != 0) {
@ -1322,6 +1328,17 @@ public class NetworkControllerImpl extends BroadcastReceiver
} else { } else {
mCurrentState.networkName = mNetworkNameDefault; mCurrentState.networkName = mNetworkNameDefault;
} }
if (showSpn && dataSpn != null) {
if (strData.length() != 0) {
strData.append(mNetworkNameSeparator);
}
strData.append(dataSpn);
}
if (strData.length() != 0) {
mCurrentState.networkNameData = strData.toString();
} else {
mCurrentState.networkNameData = mNetworkNameDefault;
}
} }
/** /**
@ -1450,6 +1467,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
static class MobileState extends SignalController.State { static class MobileState extends SignalController.State {
String networkName; String networkName;
String networkNameData;
boolean dataSim; boolean dataSim;
boolean dataConnected; boolean dataConnected;
boolean isEmergency; boolean isEmergency;
@ -1462,6 +1480,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
MobileState state = (MobileState) s; MobileState state = (MobileState) s;
dataSim = state.dataSim; dataSim = state.dataSim;
networkName = state.networkName; networkName = state.networkName;
networkNameData = state.networkNameData;
dataConnected = state.dataConnected; dataConnected = state.dataConnected;
inetForNetwork = state.inetForNetwork; inetForNetwork = state.inetForNetwork;
isEmergency = state.isEmergency; isEmergency = state.isEmergency;
@ -1474,6 +1493,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
builder.append(','); builder.append(',');
builder.append("dataSim=").append(dataSim).append(','); builder.append("dataSim=").append(dataSim).append(',');
builder.append("networkName=").append(networkName).append(','); builder.append("networkName=").append(networkName).append(',');
builder.append("networkNameData=").append(networkNameData).append(',');
builder.append("dataConnected=").append(dataConnected).append(','); builder.append("dataConnected=").append(dataConnected).append(',');
builder.append("inetForNetwork=").append(inetForNetwork).append(','); builder.append("inetForNetwork=").append(inetForNetwork).append(',');
builder.append("isEmergency=").append(isEmergency).append(','); builder.append("isEmergency=").append(isEmergency).append(',');
@ -1484,6 +1504,7 @@ public class NetworkControllerImpl extends BroadcastReceiver
public boolean equals(Object o) { public boolean equals(Object o) {
return super.equals(o) return super.equals(o)
&& Objects.equals(((MobileState) o).networkName, networkName) && Objects.equals(((MobileState) o).networkName, networkName)
&& Objects.equals(((MobileState) o).networkNameData, networkNameData)
&& ((MobileState) o).dataSim == dataSim && ((MobileState) o).dataSim == dataSim
&& ((MobileState) o).dataConnected == dataConnected && ((MobileState) o).dataConnected == dataConnected
&& ((MobileState) o).isEmergency == isEmergency && ((MobileState) o).isEmergency == isEmergency

View File

@ -319,6 +319,7 @@ public class TelephonyIntents {
public static final String EXTRA_PLMN = "plmn"; public static final String EXTRA_PLMN = "plmn";
public static final String EXTRA_SHOW_SPN = "showSpn"; public static final String EXTRA_SHOW_SPN = "showSpn";
public static final String EXTRA_SPN = "spn"; public static final String EXTRA_SPN = "spn";
public static final String EXTRA_DATA_SPN = "spnData";
/** /**
* <p>Broadcast Action: It indicates one column of a subinfo record has been changed * <p>Broadcast Action: It indicates one column of a subinfo record has been changed