From 0abd4763ece28033ac863810008a092e99f269c4 Mon Sep 17 00:00:00 2001
From: Miguel <miguelaranda@google.com>
Date: Wed, 13 Jul 2022 09:59:56 +0000
Subject: [PATCH] Fix failing Libcore benchmarks.

JarFilePerfTest was incorrectly submitted and not working yet, and
SignaturePerfTest had a failing test case.

Test: atest SignaturePerfTest
Change-Id: I739a87c02fdb3dd8c82cd63c8187fa9a8bf05ca7
---
 .../libcore/nor_ready/JarFilePerfTest.java    | 61 -------------------
 .../libcore/regression/SignaturePerfTest.java |  1 -
 2 files changed, 62 deletions(-)
 delete mode 100644 apct-tests/perftests/core/src/android/libcore/nor_ready/JarFilePerfTest.java

diff --git a/apct-tests/perftests/core/src/android/libcore/nor_ready/JarFilePerfTest.java b/apct-tests/perftests/core/src/android/libcore/nor_ready/JarFilePerfTest.java
deleted file mode 100644
index 5ad5eea60aae..000000000000
--- a/apct-tests/perftests/core/src/android/libcore/nor_ready/JarFilePerfTest.java
+++ /dev/null
@@ -1,61 +0,0 @@
-/*
- * Copyright (C) 2022 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package android.libcore.regression;
-
-import android.perftests.utils.BenchmarkState;
-import android.perftests.utils.PerfStatusReporter;
-import android.test.suitebuilder.annotation.LargeTest;
-
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameters;
-
-import java.io.File;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.jar.JarFile;
-import java.util.jar.Manifest;
-
-@RunWith(Parameterized.class)
-@LargeTest
-public class JarFilePerfTest {
-    @Rule public PerfStatusReporter mPerfStatusReporter = new PerfStatusReporter();
-
-    @Parameters(name = "mFilename={0}")
-    public static Collection<Object[]> data() {
-        return Arrays.asList(
-                new Object[][] {
-                    {"/system/framework/core-oj.jar"}, {"/system/priv-app/Phonesky/Phonesky.apk"}
-                });
-    }
-
-    @Parameterized.Parameter(0)
-    public String mFilename;
-
-    @Test
-    public void time() throws Exception {
-        File f = new File(mFilename);
-        BenchmarkState state = mPerfStatusReporter.getBenchmarkState();
-        while (state.keepRunning()) {
-            JarFile jf = new JarFile(f);
-            Manifest m = jf.getManifest();
-            jf.close();
-        }
-    }
-}
diff --git a/apct-tests/perftests/core/src/android/libcore/regression/SignaturePerfTest.java b/apct-tests/perftests/core/src/android/libcore/regression/SignaturePerfTest.java
index a1899b92cff7..96e7cb27afef 100644
--- a/apct-tests/perftests/core/src/android/libcore/regression/SignaturePerfTest.java
+++ b/apct-tests/perftests/core/src/android/libcore/regression/SignaturePerfTest.java
@@ -51,7 +51,6 @@ public class SignaturePerfTest {
                     {Algorithm.SHA256WithRSA, Implementation.OpenSSL},
                     {Algorithm.SHA384WithRSA, Implementation.OpenSSL},
                     {Algorithm.SHA512WithRSA, Implementation.OpenSSL},
-                    {Algorithm.SHA1withDSA, Implementation.OpenSSL},
                     {Algorithm.SHA1withDSA, Implementation.BouncyCastle}
                 });
     }